rails-observers 0.1.1 → 0.1.2

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 4ebf1dea2a2c82e54123428320e6685c5765da02
+  data.tar.gz: 52ef78d1ccb52ed81cd43e91d582b18976f18123
+SHA512:
+  metadata.gz: c2465a6f154cd1de2b3439333d2abc2719db0dd0a3294779e09df4caf31f37b66fe61a4ae0622a558011bd6e96a383a243814ee7afee059649aac335cbd24f7f
+  data.tar.gz: ee0dd0aca9d35994d059e92341861319ca4aab3aa00ae104b19e28d94a646798163fb926f00fbe5e5eb177bf1598d331e4e3ceb19eda161323fc0b151c1a4a02

data/.gitignore

@@ -15,3 +15,4 @@ spec/reports
 test/tmp
 test/version_tmp
 tmp
+.ruby-version

data/Gemfile

@@ -3,9 +3,6 @@ source 'https://rubygems.org'
 # Specify your gem's dependencies in active_record-observers.gemspec
 gemspec
 
-gem 'activerecord-deprecated_finders', github: 'rails/activerecord-deprecated_finders'
-gem 'journey', github: 'rails/journey'
-
-gem 'rails', github: 'rails/rails', branch: 'master'
+gem 'activerecord-deprecated_finders'
 
 gem 'mocha', require: false

data/README.md

@@ -1,3 +1,4 @@
+[![Build Status](https://secure.travis-ci.org/rails/rails-observers.png)](https://travis-ci.org/rails/rails-observers)
 # Rails::Observers
 
 Rails Observers (removed from core in Rails 4.0)
@@ -55,6 +56,17 @@ end
 
 This Observer uses logger to log when specific callbacks are triggered.
 
+Please note that observers are called in the order that they are defined. That means that callbacks in an observer
+will always be called *after* callbacks defined in the model itself. Likewise, `has_one` and `has_many`
+use callbacks to enforce `:dependent => :destroy`. Therefore, associated records will be destroyed before
+the observer's `before_destory` is called.
+
+For an observer to be active, it must be registered first. This can be done by adding the following line into the `application.rb`:
+
+    config.active_record.observers = :contact_observer
+
+Obeservers can also be registered on an environment-specific basis by simply using the corresponding environment's configuration file instead of `application.rb`.
+
 ### Action Controller Sweeper
 
 Sweepers are the terminators of the caching world and responsible for expiring caches when model objects change.

data/lib/rails-observers.rb

@@ -1,34 +1,2 @@
-require 'rails'
+require 'rails/observers/railtie' if defined? Rails
 require 'rails/observers/version'
-
-module Rails
-  module Observers
-    class Railtie < ::Rails::Railtie
-      initializer "active_record.observer", :before => "active_record.set_configs" do |app|
-        ActiveSupport.on_load(:active_record) do
-          require "rails/observers/activerecord/active_record"
-
-          if observers = app.config.respond_to?(:active_record) && app.config.active_record.delete(:observers)
-            send :observers=, observers
-          end
-        end
-      end
-
-      initializer "action_controller.caching.sweppers" do
-        ActiveSupport.on_load(:action_controller) do
-          require "rails/observers/action_controller/caching"
-        end
-      end
-
-      config.after_initialize do |app|
-        ActiveSupport.on_load(:active_record) do
-          ActiveRecord::Base.instantiate_observers
-
-          ActionDispatch::Reloader.to_prepare do
-            ActiveRecord::Base.instantiate_observers
-          end
-        end
-      end
-    end
-  end
-end

data/lib/rails/observers/action_controller/caching.rb

@@ -7,6 +7,6 @@ module ActionController #:nodoc:
       autoload :Sweeping, 'rails/observers/action_controller/caching/sweeping'
     end
 
-    include Sweeping if defined?(ActiveRecord)
+    ActionController::Base.extend Sweeping::ClassMethods if defined?(ActiveRecord)
   end
 end

data/lib/rails/observers/action_controller/caching/sweeping.rb

@@ -30,8 +30,6 @@ module ActionController #:nodoc:
     #     cache_sweeper OpenBar::Sweeper, :only => [ :edit, :destroy, :share ]
     #   end
     module Sweeping
-      extend ActiveSupport::Concern
-
       module ClassMethods #:nodoc:
         def cache_sweeper(*sweepers)
           configuration = sweepers.extract_options!

data/lib/rails/observers/active_model.rb

@@ -0,0 +1 @@
+require 'rails/observers/active_model/active_model'

data/lib/rails/observers/railtie.rb

@@ -0,0 +1,33 @@
+require 'rails/railtie'
+
+module Rails
+  module Observers
+    class Railtie < ::Rails::Railtie
+      initializer "active_record.observer", :before => "active_record.set_configs" do |app|
+        ActiveSupport.on_load(:active_record) do
+          require "rails/observers/activerecord/active_record"
+
+          if observers = app.config.respond_to?(:active_record) && app.config.active_record.delete(:observers)
+            send :observers=, observers
+          end
+        end
+      end
+
+      initializer "action_controller.caching.sweepers" do
+        ActiveSupport.on_load(:action_controller) do
+          require "rails/observers/action_controller/caching"
+        end
+      end
+
+      config.after_initialize do |app|
+        ActiveSupport.on_load(:active_record) do
+          ActiveRecord::Base.instantiate_observers
+
+          ActionDispatch::Reloader.to_prepare do
+            ActiveRecord::Base.instantiate_observers
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rails/observers/version.rb

@@ -1,5 +1,5 @@
 module Rails
   module Observers
-    VERSION = "0.1.1"
+    VERSION = "0.1.2"
   end
 end

data/rails-observers.gemspec

@@ -10,17 +10,17 @@ Gem::Specification.new do |s|
   s.homepage    = "https://github.com/rails/rails-observers"
   s.version     = Rails::Observers::VERSION
 
-  s.files         = [".gitignore",".travis.yml","Gemfile","LICENSE","README.md","Rakefile","lib/generators/active_record/observer/observer_generator.rb","lib/generators/active_record/observer/templates/observer.rb","lib/generators/rails/observer/USAGE","lib/generators/rails/observer/observer_generator.rb","lib/generators/test_unit/observer/observer_generator.rb","lib/generators/test_unit/observer/templates/unit_test.rb","lib/rails-observers.rb","lib/rails/observers/action_controller/caching.rb","lib/rails/observers/action_controller/caching/sweeping.rb","lib/rails/observers/active_model/active_model.rb","lib/rails/observers/active_model/observer_array.rb","lib/rails/observers/active_model/observing.rb","lib/rails/observers/activerecord/active_record.rb","lib/rails/observers/activerecord/base.rb","lib/rails/observers/activerecord/observer.rb","lib/rails/observers/version.rb","rails-observers.gemspec","rails-observers.gemspec.erb","test/configuration_test.rb","test/console_test.rb","test/fixtures/developers.yml","test/fixtures/minimalistics.yml","test/fixtures/topics.yml","test/generators/generators_test_helper.rb","test/generators/namespaced_generators_test.rb","test/generators/observer_generator_test.rb","test/helper.rb","test/isolation/abstract_unit.rb","test/lifecycle_test.rb","test/models/observers.rb","test/observer_array_test.rb","test/observing_test.rb","test/rake_test.rb","test/sweeper_test.rb","test/transaction_callbacks_test.rb"]
+  s.files         = [".gitignore",".travis.yml","Gemfile","LICENSE","README.md","Rakefile","lib/generators/active_record/observer/observer_generator.rb","lib/generators/active_record/observer/templates/observer.rb","lib/generators/rails/observer/USAGE","lib/generators/rails/observer/observer_generator.rb","lib/generators/test_unit/observer/observer_generator.rb","lib/generators/test_unit/observer/templates/unit_test.rb","lib/rails-observers.rb","lib/rails/observers/action_controller/caching.rb","lib/rails/observers/action_controller/caching/sweeping.rb","lib/rails/observers/active_model.rb","lib/rails/observers/active_model/active_model.rb","lib/rails/observers/active_model/observer_array.rb","lib/rails/observers/active_model/observing.rb","lib/rails/observers/activerecord/active_record.rb","lib/rails/observers/activerecord/base.rb","lib/rails/observers/activerecord/observer.rb","lib/rails/observers/railtie.rb","lib/rails/observers/version.rb","rails-observers.gemspec","rails-observers.gemspec.erb","test/configuration_test.rb","test/console_test.rb","test/fixtures/developers.yml","test/fixtures/minimalistics.yml","test/fixtures/topics.yml","test/generators/generators_test_helper.rb","test/generators/namespaced_generators_test.rb","test/generators/observer_generator_test.rb","test/helper.rb","test/isolation/abstract_unit.rb","test/lifecycle_test.rb","test/models/observers.rb","test/observer_array_test.rb","test/observing_test.rb","test/rake_test.rb","test/sweeper_test.rb","test/transaction_callbacks_test.rb"]
   s.test_files    = ["test/configuration_test.rb","test/console_test.rb","test/fixtures/developers.yml","test/fixtures/minimalistics.yml","test/fixtures/topics.yml","test/generators/generators_test_helper.rb","test/generators/namespaced_generators_test.rb","test/generators/observer_generator_test.rb","test/helper.rb","test/isolation/abstract_unit.rb","test/lifecycle_test.rb","test/models/observers.rb","test/observer_array_test.rb","test/observing_test.rb","test/rake_test.rb","test/sweeper_test.rb","test/transaction_callbacks_test.rb"]
   s.executables   = []
   s.require_paths = ["lib"]
 
-  s.add_dependency 'railties', '~> 4.0.0.beta'
+  s.add_dependency 'activemodel', '~> 4.0'
 
   s.add_development_dependency 'minitest',     '>= 3'
-  s.add_development_dependency 'activerecord', '~> 4.0.0.beta'
-  s.add_development_dependency 'activemodel', '~> 4.0.0.beta'
-  s.add_development_dependency 'actionmailer', '~> 4.0.0.beta'
-  s.add_development_dependency 'actionpack', '~> 4.0.0.beta'
+  s.add_development_dependency 'railties', '~> 4.0'
+  s.add_development_dependency 'activerecord', '~> 4.0'
+  s.add_development_dependency 'actionmailer', '~> 4.0'
+  s.add_development_dependency 'actionpack', '~> 4.0'
   s.add_development_dependency 'sqlite3',      '~> 1.3'
 end

data/rails-observers.gemspec.erb

@@ -15,12 +15,12 @@ Gem::Specification.new do |s|
   s.executables   = [<%= executables.map(&:inspect).join ',' %>]
   s.require_paths = ["lib"]
 
-  s.add_dependency 'railties', '~> 4.0.0.beta'
+  s.add_dependency 'activemodel', '~> 4.0'
 
   s.add_development_dependency 'minitest',     '>= 3'
-  s.add_development_dependency 'activerecord', '~> 4.0.0.beta'
-  s.add_development_dependency 'activemodel', '~> 4.0.0.beta'
-  s.add_development_dependency 'actionmailer', '~> 4.0.0.beta'
-  s.add_development_dependency 'actionpack', '~> 4.0.0.beta'
+  s.add_development_dependency 'railties', '~> 4.0'
+  s.add_development_dependency 'activerecord', '~> 4.0'
+  s.add_development_dependency 'actionmailer', '~> 4.0'
+  s.add_development_dependency 'actionpack', '~> 4.0'
   s.add_development_dependency 'sqlite3',      '~> 1.3'
 end

data/test/transaction_callbacks_test.rb

@@ -154,9 +154,9 @@ class TransactionCallbacksTest < ActiveRecord::TestCase
   end
 
   def test_call_after_rollback_when_commit_fails
-    @first.connection.class.send(:alias_method, :real_method_commit_db_transaction, :commit_db_transaction)
+    TopicWithCallbacks.connection.class.send(:alias_method, :real_method_commit_db_transaction, :commit_db_transaction)
     begin
-      @first.connection.class.class_eval do
+      TopicWithCallbacks.connection.class.class_eval do
         def commit_db_transaction; raise "boom!"; end
       end
 
@@ -166,8 +166,8 @@ class TransactionCallbacksTest < ActiveRecord::TestCase
       assert !@first.save rescue nil
       assert_equal [:after_rollback], @first.history
     ensure
-      @first.connection.class.send(:remove_method, :commit_db_transaction)
-      @first.connection.class.send(:alias_method, :commit_db_transaction, :real_method_commit_db_transaction)
+      TopicWithCallbacks.connection.class.send(:remove_method, :commit_db_transaction)
+      TopicWithCallbacks.connection.class.send(:alias_method, :commit_db_transaction, :real_method_commit_db_transaction)
     end
   end
 
@@ -244,35 +244,3 @@ class TransactionCallbacksTest < ActiveRecord::TestCase
     assert_equal [:after_rollback], @second.history
   end
 end
-
-
-class SaveFromAfterCommitBlockTest < ActiveRecord::TestCase
-  self.use_transactional_fixtures = false
-
-  class TopicWithSaveInCallback < ActiveRecord::Base
-    self.table_name = :topics
-    after_commit :cache_topic, :on => :create
-    after_commit :call_update, :on => :update
-    attr_accessor :cached, :record_updated
-
-    def call_update
-      self.record_updated = true
-    end
-
-    def cache_topic
-      unless cached
-        self.cached = true
-        self.save
-      else
-        self.cached = false
-      end
-    end
-  end
-
-  def test_after_commit_in_save
-    topic = TopicWithSaveInCallback.new()
-    topic.save
-    assert_equal true, topic.cached
-    assert_equal true, topic.record_updated
-  end
-end

metadata

@@ -1,8 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails-observers
 version: !ruby/object:Gem::Version
-  version: 0.1.1
-  prerelease: 
+  version: 0.1.2
 platform: ruby
 authors:
 - Rafael Mendonça França
@@ -10,108 +9,95 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-11-29 00:00:00.000000000 Z
+date: 2013-07-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: railties
+  name: activemodel
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 4.0.0.beta
+        version: '4.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 4.0.0.beta
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '3'
 - !ruby/object:Gem::Dependency
-  name: activerecord
+  name: railties
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 4.0.0.beta
+        version: '4.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 4.0.0.beta
+        version: '4.0'
 - !ruby/object:Gem::Dependency
-  name: activemodel
+  name: activerecord
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 4.0.0.beta
+        version: '4.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 4.0.0.beta
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: actionmailer
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 4.0.0.beta
+        version: '4.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 4.0.0.beta
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: actionpack
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 4.0.0.beta
+        version: '4.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 4.0.0.beta
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -119,7 +105,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -147,12 +132,14 @@ files:
 - lib/rails-observers.rb
 - lib/rails/observers/action_controller/caching.rb
 - lib/rails/observers/action_controller/caching/sweeping.rb
+- lib/rails/observers/active_model.rb
 - lib/rails/observers/active_model/active_model.rb
 - lib/rails/observers/active_model/observer_array.rb
 - lib/rails/observers/active_model/observing.rb
 - lib/rails/observers/activerecord/active_record.rb
 - lib/rails/observers/activerecord/base.rb
 - lib/rails/observers/activerecord/observer.rb
+- lib/rails/observers/railtie.rb
 - lib/rails/observers/version.rb
 - rails-observers.gemspec
 - rails-observers.gemspec.erb
@@ -175,27 +162,26 @@ files:
 - test/transaction_callbacks_test.rb
 homepage: https://github.com/rails/rails-observers
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.0.2
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: ActiveModel::Observer, ActiveRecord::Observer and ActionController::Caching::Sweeper
   extracted from Rails.
 test_files: