rails-minify 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: debbde5867be2f422c20756ebf3c08185983f80f1f94b1f9be9ffa5f29283989
-  data.tar.gz: d42eca099bc0278d05c81a868ec03eccd844635799e0d826900680324fd56558
+  metadata.gz: bf98d2d12a8005e5ef2755cd6bba97a32122a7dd2514518e9a749d1ba367af00
+  data.tar.gz: 878a2fab37d90963eb4b4d5924d7b3437847672741471d84ea6cefc686cb7ca1
 SHA512:
-  metadata.gz: 835c2eb9c3a2b1210977d40eaaafc28fe399d7755c3681d6c0adaef25b3063c6f43e699f4924015d404deb083ae9e26324e7f524bd51687b937866fc3d10c08b
-  data.tar.gz: 1a04e068acaaa2991c5e8c8f0ea4ec51145acde7d7285ef2c05d422b05754b733f776e269398449b8b6675f8b647aa2d95df9eb077cc55084851d5844045eae3
+  metadata.gz: 2baf13ba8db10c35cfaccfaf86b6c966b11555b9b232c1710da044a37dad166f96dee80cdc2380db98321a845c612e80f3a3648dbc515b31f9402a54bc393599
+  data.tar.gz: b26a83ac5f86fc456c18444e7eba578cb095fa897ee4bac9a508a10047a9164fc8d22197dc0ae6f7f2c7193ca32a437fe1b8fc35c7c9ab873d9091c936be57a0

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## 0.1.2 (2026-10-18)
+
+- `minify:check` also fails on callback chains longer than `callback_limit` (default 5, `ApplicationController`'s callbacks excluded) and on model callbacks that save their own record again; `callback_limit_mode` and `callback_loops` set either to `:warn`. Works without the rest of rails-minify turned on; the manifest check runs only when there is a manifest.
+- Requires activesupport-minimizer 0.1.1.
+
 ## 0.1.1 (2026-10-18)
 
 - `:omniauth` isn't installed when OmniAuth already skips requests that can't be the strategy's (a public `Strategy#passthrough?`, as in the version proposed upstream); its own helper no longer shares that name.

data/README.md

@@ -14,6 +14,19 @@ config.rails_minify.enabled = true
 (`config.ar_minimizer.enums = false`, `config.rails_minify.patches = [:omniauth]`).
 Ruby 3.4+, Rails 8.0, 8.1 and main.
 
+Turn it on in tests too, so a call to a method strict mode removed fails in CI
+rather than in production. In development, strict mode alone is enough: the
+same errors show up while you work, and the compiling parts, which don't
+follow code reloads, stay off.
+
+```ruby
+# config/environments/test.rb
+config.rails_minify.enabled = true
+
+# config/environments/development.rb
+config.ar_minimizer.slim = true # strict mode, without the rest
+```
+
 ## Strict by default
 
 Active Record defines, for every column, a reader, a writer and 19 more
@@ -81,7 +94,26 @@ loaded for wall-clock times to mean much.
 ## Checks
 
 * `bin/rails minify:census`: how much of the app runs compiled, and why the rest doesn't.
-* `bin/rails minify:check`: callbacks naming methods that don't exist (for CI).
+* `bin/rails minify:check` (for CI; works whether or not the rest of
+  rails-minify is on) fails on:
+  * callbacks naming methods that don't exist;
+  * callback chains with more than `callback_limit` (default 5) of the app's
+    own callbacks (Rails' and gems' don't count; controllers per action).
+    Callbacks inherited from `callback_limit_exclude` (default
+    `["ApplicationController"]`: time zone, locale, current user, the
+    per-request basics) don't count either. A base class over the limit is
+    reported once, with the classes that inherit it;
+  * model callbacks that call `save`, `update`, `touch`, ... on the record
+    they run for, which runs the chain again;
+  * an out-of-date manifest.
+
+  ```ruby
+  config.rails_minify.callback_limit = 8
+  config.rails_minify.callback_limit_exclude = ["ApplicationController", "Admin::BaseController"] # [] counts everything
+  config.rails_minify.callback_limit_mode = :warn # report, don't fail
+  config.rails_minify.callback_loops = :warn
+  config.rails_minify.allow_callback_loops = ["Trip#recalculate"] # guarded on purpose
+  ```
 
 ## Things found that are app config, not patches
 

data/lib/rails_minify/railtie.rb

@@ -69,15 +69,39 @@ module RailsMinify
           end
         end
 
-        desc "Fail on what would break at runtime or compile stale: missing callback targets, an out-of-date manifest"
+        desc "Fail on callback problems (missing targets, chains longer than callback_limit, " \
+             "callbacks that save their own record) and an out-of-date manifest"
         task check: :environment do
           app = prepare.call
-          problems = AsMinimizer::Check.callback_targets(routed: AsMinimizer::Check.routed_actions(app.routes))
-          missing = problems.select { it.status == :missing }
-          missing.each { puts "  #{it}" }
-          manifest = ArMinimizer::Census.manifest_state(app.root, ArMinimizer::Index.from_models)
-          puts "callback targets: #{missing.size} missing; manifest: #{manifest}"
-          abort if missing.any? || manifest.start_with?("out of date")
+          options = app.config.rails_minify
+          routed = AsMinimizer::Check.routed_actions(app.routes)
+          failed = false
+          report = lambda do |title, items, mode|
+            next puts("#{title}: none") if items.empty?
+
+            puts "#{title}: #{items.size}#{" (warning)" if mode == :warn}"
+            items.each { puts "  #{it}" }
+            failed ||= mode != :warn
+          end
+
+          missing = AsMinimizer::Check.callback_targets(routed: routed).select { it.status == :missing }
+          report.("callback targets naming no method", missing, :fail)
+
+          limit = options.callback_limit || 5
+          report.("callback chains with more than #{limit} of the app's callbacks",
+            AsMinimizer::Check.long_chains(limit: limit, root: app.root.to_s, routed: routed,
+              exclude: options.callback_limit_exclude.nil? ? ["ApplicationController"] : Array(options.callback_limit_exclude)),
+            (options.callback_limit_mode || :fail).to_sym)
+
+          report.("callbacks saving their own record",
+            AsMinimizer::Check.callback_loops(root: app.root.to_s, allow: Array(options.allow_callback_loops)), (options.callback_loops || :fail).to_sym)
+
+          if defined?(ArMinimizer::Census) && app.root.join("config/ar_minimizer.json").exist?
+            manifest = ArMinimizer::Census.manifest_state(app.root, ArMinimizer::Index.from_models)
+            puts "manifest: #{manifest}"
+            failed ||= manifest.start_with?("out of date")
+          end
+          abort if failed
         end
       end
     end

data/lib/rails_minify/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RailsMinify
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails-minify
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Sampo Kuokkanen
@@ -44,6 +44,9 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.1'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.1.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -51,6 +54,9 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.1'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.1.1
 description: Turns on activerecord-, activesupport- and actionpack-minimizer, and
   patches parts of Rails and common gems that redo work on every request (Action Text
   plain text, Request#host, OmniAuth strategies).