rails-minify 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 32a43a0b86ec6d79152580e59ed32f5468ddd3d1a4e0865716f404bd542b566c
-  data.tar.gz: fa640778b9324a8737ff1e809af7a101ff2e10b910677611de081b033678c983
+  metadata.gz: debbde5867be2f422c20756ebf3c08185983f80f1f94b1f9be9ffa5f29283989
+  data.tar.gz: d42eca099bc0278d05c81a868ec03eccd844635799e0d826900680324fd56558
 SHA512:
-  metadata.gz: d078aaa82950d4407b91e82fcde444264496d72551db08177d629cdb61d5928ff23381462f23388cbf5db91c138cca78d1f79a870f0eeca794d178b0e8427af9
-  data.tar.gz: e6ee0e7f39335eaba0d2adf4718a89dbdf52e8d1a8b993539ddfa3081631714bac16c5fc899b6f8dea5fd3cf12d667875843a1d73ccc524ecc72735c9e42834d
+  metadata.gz: 835c2eb9c3a2b1210977d40eaaafc28fe399d7755c3681d6c0adaef25b3063c6f43e699f4924015d404deb083ae9e26324e7f524bd51687b937866fc3d10c08b
+  data.tar.gz: 1a04e068acaaa2991c5e8c8f0ea4ec51145acde7d7285ef2c05d422b05754b733f776e269398449b8b6675f8b647aa2d95df9eb077cc55084851d5844045eae3

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 0.1.1 (2026-10-18)
+
+- `:omniauth` isn't installed when OmniAuth already skips requests that can't be the strategy's (a public `Strategy#passthrough?`, as in the version proposed upstream); its own helper no longer shares that name.
+
 ## 0.1.0 (2026-10-18)
 
 First release.

data/README.md

@@ -57,7 +57,7 @@ For parts of Rails and common gems that redo work on every request.
   Attachments that are Active Storage blobs, remote images or inline content
   are cached too: a blob without a caption contributes its filename, which a
   hit checks in one query (renamed or deleted: computed again). Other
-  attachables aren't cached. In golf-buddy, 13% of all allocations on its
+  attachables aren't cached. In [Japan Voyage](https://japanvoyage.jp), 13% of all allocations on its
   pages came from it, and guides with images another 4.5%.
 * `:request_host`: `ActionDispatch::Request#host` runs a regexp substitution
   on every call, port or not, and Rails reads it several times per request.
@@ -67,11 +67,13 @@ For parts of Rails and common gems that redo work on every request.
   options on every request before looking at the path. Requests that can't
   be OmniAuth's go straight to the app. Only when that's certain up front:
   a session is present, not in test mode, no `other_phase` or callable
-  paths, and the strategy doesn't override how paths are matched.
+  paths, and the strategy doesn't override how paths are matched. Not
+  installed when OmniAuth already does this itself (it then has a public
+  `Strategy#passthrough?`, as in the version proposed upstream).
 
 ## Numbers
 
-golf-buddy, 132 production pages, with everything on (strict mode after
+Japan Voyage, 132 production pages, with everything on (strict mode after
 rubocop-minify's rewrites, all patches): identical HTML, and
 1,561,283 → 1,224,141 allocations per pass (−21.6%). The machine was too
 loaded for wall-clock times to mean much.

data/lib/rails_minify/patches/action_text_plain_text.rb

@@ -4,9 +4,9 @@ module RailsMinify
   module Patches
     # ActionText::Content#to_plain_text walks the whole HTML tree with
     # Nokogiri on every call, and looks up the record behind every attachment:
-    # in golf-buddy, 13% of all allocations on its pages came from it
-    # (excerpts, meta descriptions, cards). The text is computed once per
-    # distinct HTML and kept, up to MAX_BYTES of HTML.
+    # on Japan Voyage (japanvoyage.jp), 13% of all allocations on its pages
+    # came from it (excerpts, meta descriptions, cards). The text is computed
+    # once per distinct HTML and kept, up to MAX_BYTES of HTML.
     #
     # Without attachments the text depends on the HTML alone. An attachment
     # adds its record's text: for Active Storage blobs "[caption]" (from the

data/lib/rails_minify/patches/omniauth_passthrough.rb

@@ -3,20 +3,29 @@
 module RailsMinify
   module Patches
     # Every OmniAuth strategy is a middleware that, on every request, dups
-    # itself (and its Hashie::Mash options) before looking at the path: in
-    # golf-buddy about 35k allocations per pass over its pages, none of them
-    # on a login path. Requests that can't be OmniAuth's go straight to the
-    # app; anything that might be (or that the strategy decides at runtime:
-    # callable paths, other_phase, overridden path methods, test mode, a
-    # missing session, which OmniAuth reports) runs OmniAuth as before.
+    # itself (and its Hashie::Mash options) before looking at the path: on
+    # Japan Voyage (japanvoyage.jp) about 35k allocations per pass over its
+    # pages, none of them on a login path. Requests that can't be OmniAuth's
+    # go straight to the app; anything that might be (or that the strategy
+    # decides at runtime: callable paths, other_phase, overridden path
+    # methods, test mode, a missing session, which OmniAuth reports) runs
+    # OmniAuth as before.
     module OmniAuthPassthrough
       # What decides whether a request is the strategy's. A strategy that
       # overrides any of these decides for itself: always run it.
       PATH_METHODS = %i[call! on_auth_path? on_request_path? on_callback_path? on_path? request_path
                         callback_path current_path path_prefix script_name].freeze
 
-      def self.install!
-        OmniAuth::Strategy.prepend(self) unless OmniAuth::Strategy < self
+      def self.install!(strategy = OmniAuth::Strategy)
+        return if upstream?(strategy) # OmniAuth does this itself
+
+        strategy.prepend(self) unless strategy < self
+      end
+
+      # The same check in OmniAuth (sampokuokkanen/omniauth@skip-dup-off-auth-paths,
+      # proposed upstream) defines a public Strategy#passthrough?.
+      def self.upstream?(strategy = OmniAuth::Strategy)
+        strategy.public_method_defined?(:passthrough?) && !(strategy < self)
       end
 
       # Per strategy class: are all of PATH_METHODS OmniAuth's own?
@@ -28,14 +37,14 @@ module RailsMinify
       end
 
       def call(env)
-        return super unless passthrough?(env)
+        return super unless minify_passthrough?(env)
 
         @app.call(env)
       end
 
       private
 
-      def passthrough?(env)
+      def minify_passthrough?(env)
         return false if OmniAuth.config.test_mode || !env["rack.session"] || respond_to?(:other_phase)
         return false unless OmniAuthPassthrough.standard_paths?(self.class)
 

data/lib/rails_minify/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RailsMinify
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails-minify
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Sampo Kuokkanen