rails-informant 0.4.3 → 0.4.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: de6c6a1e4797ad9aa7ceb4f44bbe3555030872c05e2fa2d4f5fc3a89c1585add
-  data.tar.gz: d9a7e18f30c905a304e881d4ab0bb39290db5efac899aa0bb6eb54e1b92c55af
+  metadata.gz: 6d0af47e9b626dfed7bcf7a29cb9817ff2fd41ada4700a61a0fab3579c863742
+  data.tar.gz: e130792dad9233646126fed6bcac17c339e50f5aeb566710307661078a0f7772
 SHA512:
-  metadata.gz: 8b96cd324074c8a40e53704d24e2e52e74ef5b9f1f7b00a172fd3fc7c22650bdda50255d6a4f88921b12eaad168bf7ae29feba40eaeee1e003910ea977f4f836
-  data.tar.gz: c6941002dceb643128d7549c0a1862d97d97a26a36b15fad28db592bdd33734b370c13773dfca97c53ec34b06470e774d00c9382514162af7b309132e6132ec3
+  metadata.gz: ab3256ce6ae5de9d3356346d9e5b4c0988f5170439b54a77945051980164a67e2c9e37a6ced0de22e7e68271ac3b5053a1292f4de8cc9f8c5c895e1aad651d0c
+  data.tar.gz: 46530d277944774af55b2b0012d45a76e471c690d35e5324385ade0a2c9cc67704dfcbf0aa545c4172dba8c75f031d00ee591478b8fd6cb2669a54ddeed42295

data/README.md

@@ -100,6 +100,25 @@ Every option can be set via an environment variable. The initializer takes prece
 
 ## Noise Suppression
 
+### Default Ignored Exceptions
+
+Informant ignores only exceptions that are noise in **every** context: `SignalException`
+and `SystemExit` (process control), plus a few client/tamper errors
+(`Rack::Utils::InvalidParameterError`, `Mime::Type::InvalidMimeType`,
+`CGI::Session::CookieStore::TamperedWithCookie`).
+
+It deliberately does **not** ignore Rails' HTTP client errors -- `RecordNotFound`,
+`RoutingError`, `ParameterMissing`, and the rest of the 4xx family. On the request path
+Rails already maps those to responses (404, 422, ...) and never reports them to
+`Rails.error`, so suppressing them again here was redundant. Off the request path -- in a
+**background job**, a rake task, or wrapped as the cause of another error -- those same
+exceptions are real bugs, so Informant records them. A job that dies on an
+`ActiveJob::DeserializationError` caused by a missing record now alerts instead of
+vanishing silently.
+
+Add your own classes with `config.ignored_exceptions`; it still walks the cause chain, so
+ignoring a class also ignores exceptions that wrap it.
+
 ### Silenced Blocks
 
 ```ruby

data/lib/rails_informant/mcp/tools/verify_pending_fixes.rb

@@ -1,9 +1,12 @@
+require "json"
+require "open3"
+
 module RailsInformant
   module Mcp
     module Tools
       class VerifyPendingFixes < BaseTool
         tool_name "verify_pending_fixes"
-        description "Verify fix_pending errors by checking if their fix_sha is an ancestor of the deployed code. Resolves verified fixes. Requires git locally. Results reflect local git state — run git fetch first to ensure accuracy."
+        description "Verify fix_pending errors by checking whether the fix is in the deployed code: first by fix_sha ancestry, then — for squash/rebase merges, where fix_sha is not an ancestor of the deploy — by the fix PR's merge commit. Resolves verified fixes. Requires git locally (and gh for the PR fallback). Results reflect local git state — run git fetch first to ensure accuracy."
         input_schema(
           properties: {
             auto_resolve: { type: "boolean", description: "Resolve verified fixes automatically (default: true)" },
@@ -31,8 +34,7 @@ module RailsInformant
               pending = []
 
               errors.each do |error|
-                fix_sha = error["fix_sha"]
-                if fix_sha && ancestor?(fix_sha, ref)
+                if verified?(error, ref)
                   verified << error
                 else
                   pending << error
@@ -55,10 +57,52 @@ module RailsInformant
 
           private
 
+          def verified?(error, target_ref)
+            fix_sha = error["fix_sha"]
+            return true if fix_sha && ancestor?(fix_sha, target_ref)
+
+            # Squash and rebase merges create a new commit unrelated to fix_sha, so the
+            # recorded SHA is never an ancestor of the deploy. Fall back to the PR's merge
+            # commit, which is in the deployed history regardless of merge strategy.
+            merge_sha = merged_pr_commit error["fix_pr_url"]
+            !merge_sha.nil? && ancestor?(merge_sha, target_ref)
+          end
+
           def ancestor?(fix_sha, target_ref)
             system "git", "merge-base", "--is-ancestor", fix_sha, target_ref, out: File::NULL, err: File::NULL
           end
 
+          # Returns the merge commit SHA of a merged PR, or nil if the PR is unmerged, the
+          # URL is blank, or gh is unavailable. Best-effort fetches the commit so the
+          # subsequent ancestry check can see it. Uses the array form (no shell) so the
+          # PR URL can't be interpreted as a command.
+          def merged_pr_commit(pr_url)
+            return if pr_url.nil? || pr_url.empty?
+            return unless gh_available?
+
+            output, status = Open3.capture2 "gh", "pr", "view", pr_url, "--json", "state,mergeCommit", err: File::NULL
+            return unless status.success? && !output.strip.empty?
+
+            data = JSON.parse output
+            return unless data["state"] == "MERGED"
+
+            merge_sha = data.dig "mergeCommit", "oid"
+            return if merge_sha.nil? || merge_sha.empty?
+
+            fetch_commit merge_sha
+            merge_sha
+          rescue JSON::ParserError
+            nil
+          end
+
+          def fetch_commit(sha)
+            system "git", "fetch", "--quiet", "origin", sha, out: File::NULL, err: File::NULL
+          end
+
+          def gh_available?
+            system "gh", "--version", out: File::NULL, err: File::NULL
+          end
+
           def fetch_all_fix_pending(client)
             errors = []
             page = 1

data/lib/rails_informant.rb

@@ -5,25 +5,17 @@ module RailsInformant
   InvalidParameterError = Class.new(StandardError)
   NotifierError = Class.new(StandardError)
 
+  # Only exceptions that are noise in *every* context. Rails 8.1 maps HTTP
+  # client errors (404s, routing, bad params) via rescue_responses and never
+  # reports them to Rails.error on the request path, so listing them here was
+  # redundant for requests and wrongly suppressed the same exceptions when they
+  # are real bugs in background jobs (e.g. a job's RecordNotFound). Those are
+  # recorded now; what remains is process-control and client/tamper noise.
   IGNORED_EXCEPTIONS_DEFAULT = %w[
-    AbstractController::ActionNotFound
-    ActionController::BadRequest
-    ActionController::InvalidAuthenticityToken
-    ActionController::InvalidCrossOriginRequest
-    ActionController::MethodNotAllowed
-    ActionController::NotImplemented
-    ActionController::ParameterMissing
-    ActionController::RoutingError
     ActionController::UnknownAction
-    ActionController::UnknownFormat
-    ActionController::UnknownHttpMethod
     ActionController::UrlGenerationError
-    ActionDispatch::Http::MimeNegotiation::InvalidType
-    ActiveRecord::RecordNotFound
     CGI::Session::CookieStore::TamperedWithCookie
     Mime::Type::InvalidMimeType
-    Rack::QueryParser::InvalidParameterError
-    Rack::QueryParser::ParameterTypeError
     Rack::Utils::InvalidParameterError
     SignalException
     SystemExit

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails-informant
 version: !ruby/object:Gem::Version
-  version: 0.4.3
+  version: 0.4.5
 platform: ruby
 authors:
 - Daniel López Prat
@@ -195,7 +195,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.6
+rubygems_version: 4.0.10
 specification_version: 4
 summary: Self-hosted error monitoring for Rails with MCP server for agentic workflows
 test_files: []