rails-hidden_autocomplete 0.1.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 714b227121581a2d002269a2255687b039ef2b2e5b18bf1c6e615cae6d3b3aec
-  data.tar.gz: 2f90d31085eceb2b3d0c084b215f2439464c06217bad2f0d22d26f5d9fbfd4e4
+  metadata.gz: 0c7a9e4853b0f4ff53ebb7a25d4b94dc8197b888d264dd1eb5b064241a63ad8e
+  data.tar.gz: 3fea7c3aaafc9c54ea3d0ec5009ace7232b9ee95d1db12c3bfc35f460a90b975
 SHA512:
-  metadata.gz: 3b18e08b4f20d30fb86258c4449c445fcb43518dd20c2962dc3940226e80f0a7ad5ccc720ba45ac40762bc59ed34b216584d044938a4ec8e09496ebd5c3d5c48
-  data.tar.gz: 4bfb358b4018c3ab3919d8d5559735bff7f08d76ac24dde8557371132e41896b2fe04cad5feb915c2545a0a87c75ba2a592b34930669a56a6b25052fb54de7ff
+  metadata.gz: 64929edf453f4f8112694c8b22370a1d71874e1cd93cb35187f5eb5b4ae2f5d3d0cece4bcf69e502f051feb861b1c9baedf58397912cb8146829d1c1009b7d9c
+  data.tar.gz: 2389c9123be817e711678654516d4c53ce30e6a795b4d1c6b4d119557cb7289f32433eb8a7cc271ec53a22cabc9787ab013585da8ef75333fe8a32fbd4f6cde1

data/README.md

@@ -1,8 +1,12 @@
 # rails-hidden_autocomplete
-This is a Rails plugin to add `autocomplete="off"` to all hidden form inputs generated by Rails. This is necessary because Firefox has [a long-running bug](https://bugzilla.mozilla.org/show_bug.cgi?id=520561) where it may populate hidden inputs **without** `autocomplete="off"` with completely random values. Since Rails uses hidden fields extensively for CSRF protection and non-standard HTTP methods, this issue is also tracked in the main Rails tracker here: [add autocomplete="OFF" to firefox-proof automagically added hidden fields like method](https://github.com/rails/rails/issues/42610)
+This is a Rails plugin to add `autocomplete="off"` to all hidden form inputs generated by Rails. This is necessary because Firefox has [a longstanding bug](https://bugzilla.mozilla.org/show_bug.cgi?id=520561) where it may populate hidden inputs **without** `autocomplete="off"` with completely random values. Since Rails uses hidden fields extensively for CSRF protection and non-standard HTTP methods, this issue is also tracked in the main Rails tracker here: [add autocomplete="OFF" to firefox-proof automagically added hidden fields like method](https://github.com/rails/rails/issues/42610)
+
+You can read the announcement blog post here: <https://blog.podqueue.fm/2021/09/19/giving_back_to_rails_with_rails-hidden_autocomplete/>
+
+This work has also been refactored into a Rails PR: <https://github.com/rails/rails/pull/43280>
 
 ## Usage
-Using this plugin from a Rails 6 application should automatically override Rails classes which generate hidden form inputs to add an `autocomplete="off"` attribute.
+Using this plugin from a Rails 6.1 application should automatically override Rails methods which generate hidden form inputs to add an `autocomplete="off"` attribute.
 
 ## Installation
 Add this line to your application's Gemfile:

data/config/initializers/rails-hidden_autocomplete.rb

@@ -1,6 +1,8 @@
-Rails.application.reloader.to_prepare do
+ActiveSupport.on_load(:action_view) do
   ActionView::Helpers::DateTimeSelector.prepend Rails::HiddenAutocomplete::ActionView::Helpers::DateTimeSelector
   ActionView::Helpers::FormTagHelper.prepend Rails::HiddenAutocomplete::ActionView::Helpers::FormTagHelper
-  ActionView::Helpers::Tags.prepend Rails::HiddenAutocomplete::ActionView::Helpers::Tags
+  ActionView::Helpers::Tags::Base.prepend Rails::HiddenAutocomplete::ActionView::Helpers::Tags::Base
+  ActionView::Helpers::Tags::CheckBox.prepend Rails::HiddenAutocomplete::ActionView::Helpers::Tags::CheckBox
+  ActionView::Helpers::Tags::HiddenField.prepend Rails::HiddenAutocomplete::ActionView::Helpers::Tags::HiddenField
   ActionView::Helpers::UrlHelper.prepend Rails::HiddenAutocomplete::ActionView::Helpers::UrlHelper
 end

data/lib/rails/hidden_autocomplete/action_view/helpers/form_tag_helper.rb

@@ -6,6 +6,10 @@ module Rails
           def hidden_field_tag(name, value = nil, options = {})
             super(name, value, options.merge(autocomplete: 'off'))
           end
+
+          def utf8_enforcer_tag
+            '<input name="utf8" type="hidden" value="&#x2713;" autocomplete="off" />'.html_safe
+          end
         end
       end
     end

data/lib/rails/hidden_autocomplete/action_view/helpers/tags/base.rb

@@ -0,0 +1,30 @@
+module Rails
+  module HiddenAutocomplete
+    module ActionView
+      module Helpers
+        module Tags
+          module Base
+            def select_content_tag(option_tags, options, html_options)
+              html_options = html_options.stringify_keys
+              add_default_name_and_id(html_options)
+
+              if placeholder_required?(html_options)
+                raise ArgumentError, "include_blank cannot be false for a required field." if options[:include_blank] == false
+                options[:include_blank] ||= true unless options[:prompt]
+              end
+
+              value = options.fetch(:selected) { value() }
+              select = content_tag("select", add_options(option_tags, options, value), html_options)
+
+              if html_options["multiple"] && options.fetch(:include_hidden, true)
+                tag("input", disabled: html_options["disabled"], name: html_options["name"], type: "hidden", value: "", autocomplete: "off") + select
+              else
+                select
+              end
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rails/hidden_autocomplete/action_view/helpers/tags/check_box.rb

@@ -0,0 +1,16 @@
+module Rails
+  module HiddenAutocomplete
+    module ActionView
+      module Helpers
+        module Tags
+          module CheckBox
+            private
+            def hidden_field_for_checkbox(options)
+              @unchecked_value ? tag("input", options.slice("name", "disabled", "form").merge!("type" => "hidden", "value" => @unchecked_value, "autocomplete" => "off")) : "".html_safe
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rails/hidden_autocomplete/action_view/helpers/{tags.rb → tags/hidden_field.rb}

@@ -3,7 +3,7 @@ module Rails
     module ActionView
       module Helpers
         module Tags
-          class HiddenField
+          module HiddenField
             def render
               @options[:autocomplete] = 'off'
               super

data/lib/rails/hidden_autocomplete/version.rb

@@ -1,5 +1,5 @@
 module Rails
   module HiddenAutocomplete
-    VERSION = '0.1.0'
+    VERSION = '0.4.0'
   end
 end

data/lib/rails/hidden_autocomplete.rb

@@ -1,8 +1,10 @@
 require "rails/hidden_autocomplete/engine"
 require "rails/hidden_autocomplete/action_view/helpers/date_time_selector"
 require "rails/hidden_autocomplete/action_view/helpers/form_tag_helper"
-require "rails/hidden_autocomplete/action_view/helpers/tags"
 require "rails/hidden_autocomplete/action_view/helpers/url_helper"
+require "rails/hidden_autocomplete/action_view/helpers/tags/base"
+require "rails/hidden_autocomplete/action_view/helpers/tags/check_box"
+require "rails/hidden_autocomplete/action_view/helpers/tags/hidden_field"
 
 module Rails
   module HiddenAutocomplete

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails-hidden_autocomplete
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Ryan Baumann
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-09-19 00:00:00.000000000 Z
+date: 2021-09-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -16,22 +16,30 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '6.0'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 6.0.3.2
+        version: '6.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '6.1'
+- !ruby/object:Gem::Dependency
+  name: sqlite3
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 6.0.3.2
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: sqlite3
+  name: gem-release
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -63,7 +71,9 @@ files:
 - lib/rails/hidden_autocomplete.rb
 - lib/rails/hidden_autocomplete/action_view/helpers/date_time_selector.rb
 - lib/rails/hidden_autocomplete/action_view/helpers/form_tag_helper.rb
-- lib/rails/hidden_autocomplete/action_view/helpers/tags.rb
+- lib/rails/hidden_autocomplete/action_view/helpers/tags/base.rb
+- lib/rails/hidden_autocomplete/action_view/helpers/tags/check_box.rb
+- lib/rails/hidden_autocomplete/action_view/helpers/tags/hidden_field.rb
 - lib/rails/hidden_autocomplete/action_view/helpers/url_helper.rb
 - lib/rails/hidden_autocomplete/engine.rb
 - lib/rails/hidden_autocomplete/version.rb
@@ -87,8 +97,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project:
-rubygems_version: 2.7.6.2
+rubygems_version: 3.2.22
 signing_key:
 specification_version: 4
 summary: Adds autocomplete="off" to all hidden inputs generated by Rails