rails-guarddog 0.1.10 → 0.1.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 13a4a099ed1043cb4c5169191304022c1e9f75e8ee28b977fd4a4968a1f458ac
-  data.tar.gz: b62273a1dcaa5d126f19545e8f4c51716decd8e1d7b50ab32aa84d047bf9388b
+  metadata.gz: 97cdcd83511d9b89a1786584d4a21dcf403123b3ea3911e7341a85a3bda88446
+  data.tar.gz: e6634444d93c30e0ddf147cb51db25ee7f04f6f2ee9a17f09d9c1de7b59d7da0
 SHA512:
-  metadata.gz: 3c18887f0434640f5092cc2fe2f13ce706ca10d121f0ffb64a8601f86f673596ad7dd232b62c744e5610cdbd37368a8b2413f95bd8fd0c92a50bc545e703ef03
-  data.tar.gz: 485c37f61a02f85cc9a78710e03441ed7271badb21a3f05818d511e6f3cded152260c9463f05e1fbb427a076d322685122e6dfb76551337ed235c7ffb3246fc0
+  metadata.gz: c1e72af9e429215d30599e42276ced36f320f052002274827beb6b4060adfa29f907c42af0a88da4a13eead365ef84e32cbb079994534084112e60151671a09f
+  data.tar.gz: 2af6a3569f894d95fc2e944ebe14bce13696bc89e0120f13aa5c3cdd9e305e44ecbaba77a6e212dc1911ae1bc2efba267c58093e141bb5c544e59c39979aa3d3

data/README.md

@@ -98,20 +98,30 @@ That's it! Scan your entire Rails app for security vulnerabilities.
 ### Data Protection
 - **CSRF Protection** — Disabled without documented reason
 - **Mass Assignment** — `permit!` vulnerabilities ⭐ IMPROVED in v0.1.8
-- **Hardcoded Secrets** — API keys, tokens, passwords in code (ALWAYS-ON)
+- **Hardcoded Secrets** — API keys, tokens, passwords in code (ALWAYS-ON, false-positive-safe)
 
 ### Resource Management
 - **DoS/ReDoS** — Unbounded queries, dangerous regex patterns ⭐ ENHANCED in v0.1.8
 - **Supply Chain** — Typosquatted gems using Levenshtein distance ⭐ IMPROVED in v0.1.8
 
----
+> **False-positive protection (v0.1.10 - v0.1.12)**
+> - **Secrets**: Patterns use word boundaries — `no_token:` or `reset_password_instructions:` in locale
+>   files will **not** trigger the secrets checker.
+> - **Secrets**: Secret values must be space-free (`[^\s'"]{6,}`) — human-readable sentences like
+>   `"You can't access this page..."` are never flagged.
+> - **Secrets**: `config/locales/` files are skipped entirely — i18n translations are not credentials.
+> - **Secrets**: `spec/` and `test/` trees suppress the secrets checker by default (configurable via
+>   `ignored_checks`).
+> - **DoS**: Smart multiline `.limit()` check detection (v0.1.12) — lookahead up to 3 lines handles chained
+>   `.limit()` calls on subsequent lines or reassignment to the same variable, e.g. `things = Thing.all; things = things.limit(100)` or `.limit(...)` on the next line.
+
 
 ## 📊 Example Output
 
 ### Console Report
 ```
 ============================================================
-          Rails GuardDog Security Report v0.1.8
+          Rails GuardDog Security Report v0.1.12
 ============================================================
 
 [CRITICAL] (5 findings)
@@ -165,25 +175,23 @@ Create `config/initializers/guarddog.rb`:
 
 ```ruby
 Rails.application.config.after_initialize do
-  # Enable only specific checkers
+  # --- Option A: Enable only specific checkers ---
   Rails.application.config.guarddog.enabled_checkers = %w[
     sql_injection xss csrf mass_assignment secrets
     ai_injection idor dos rate_limit supply_chain
   ]
 
+  # --- Option B: Disable only specific checkers (keep everything else) ---
+  # Easier when you want "all but a couple". Takes priority over enabled_checkers.
+  Rails.application.config.guarddog.disabled_checkers = %w[dos rate_limit]
+
   # Directories to skip entirely (all checks silenced).
   # Default: %w[vendor node_modules]
   Rails.application.config.guarddog.excluded_paths = %w[vendor node_modules]
 
   # Suppress specific checkers for files under certain path substrings.
   # Keys are path fragments; values are arrays of checker names.
-  # This is useful to avoid false positives in test/spec trees where
-  # dummy passwords and tokens are intentional.
-  #
-  # Default (built-in):
-  #   { "spec" => %w[secrets], "test" => %w[secrets] }
-  #
-  # Override or extend:
+  # Default: { "spec" => %w[secrets], "test" => %w[secrets] }
   Rails.application.config.guarddog.ignored_checks = {
     "spec"     => %w[secrets],          # no secrets alerts in spec/
     "test"     => %w[secrets],          # no secrets alerts in test/
@@ -198,16 +206,20 @@ Rails.application.config.after_initialize do
 end
 ```
 
+### Disabling specific checkers
 
-### Suppressing checks per directory
-
-If you see false positives like dummy passwords flagged in test/spec files:
+If you want to keep all checkers **except a couple**, use `disabled_checkers`
+instead of maintaining a long `enabled_checkers` list:
 
+```ruby
+# All 12 checkers run, except dos and rate_limit
+Rails.application.config.guarddog.disabled_checkers = %w[dos rate_limit]
 ```
-Secrets — Hardcoded secret detected
-  /app/spec/controllers/api/v1/users_controller_spec.rb:1975
-  Fix: Use ENV variables or Rails credentials
-```
+
+This is the recommended approach when you hit false positives in one checker
+but still want full coverage from all others.
+
+### Suppressing checks per directory
 
 GuardDog already silences `secrets` in `spec/` and `test/` by default. To add
 more suppressions or override the defaults, set `ignored_checks` in your
@@ -215,6 +227,7 @@ initializer (see example above).
 
 ---
 
+
 ## 🔄 CI/CD Integration
 
 ### GitHub Actions
@@ -279,6 +292,6 @@ MIT License - Free to use and modify.
 
 ---
 
-**Rails GuardDog v0.1.8 — Production Ready**
+**Rails GuardDog v0.1.12 — Production Ready**
 
 *Beyond brakeman. Detect what others miss.* 🐕🔒

data/lib/rails/guarddog/checkers/dos_checker.rb

@@ -1,38 +1,107 @@
-module Rails
-  module Guarddog
-    module Checkers
-      class DosChecker < BaseChecker
-        def run
-          glob_files('app/**/*.rb').each do |file|
-            content = File.read(file)
-            content.each_line.with_index do |line, idx|
-              # Check for unbounded queries
-              if line.match?(/\.where\(.*\)\.all/) || line.match?(/\.all\s*$/)
-                add_finding(
-                  severity: :high,
-                  message: "Potential DoS: unbounded database query without limit",
-                  file: file,
-                  line: idx + 1,
-                  snippet: line.strip,
-                  remediation: "Add .limit() to control result size"
-                )
-              end
-              # Check for regex vulnerabilities
-              if line.match?(/\/.+\*\+.*\*\+.+\//) || line.match?(/match\?.*\(.+\*\+/)
-                add_finding(
-                  severity: :high,
-                  message: "Potential ReDoS vulnerability: dangerous regex pattern",
-                  file: file,
-                  line: idx + 1,
-                  snippet: line.strip,
-                  remediation: "Simplify regex or use timeout mechanisms"
-                )
-              end
-            end
-          end
-          findings
-        end
-      end
-    end
-  end
-end
+module Rails
+  module Guarddog
+    module Checkers
+      class DosChecker < BaseChecker
+        # Matches .all only when it is the final call on an ActiveRecord-style
+        # model class (PascalCase constant), e.g.:
+        #   User.all            => flagged
+        #   Post.where(...).all => flagged
+        # But NOT:
+        #   current_user.permissions.track_manage.all => NOT flagged (lowercase receiver)
+        #   collection.all? { }                       => NOT flagged (.all? method)
+        UNBOUNDED_QUERY_PATTERN = /
+          (?:
+            [A-Z][A-Za-z0-9_]*    # PascalCase model class  e.g. User, TrackItem
+            (?:\.[a-z_]+\(.*?\))*  # optional chained scopes e.g. .where(...).order(...)
+          )
+          \.all                    # the .all call
+          (?!\?)                   # not .all? (Enumerable method, not AR query)
+          \s*(?:[,)\]#\n]|$)      # followed by end-of-expression (not .limit etc.)
+        /x.freeze
+
+        # Patterns known to be dangerous nested regex (ReDoS)
+        REDOS_PATTERNS = [
+          /\/.+\*\+.*\*\+.+\//,
+          /match\?.*\(.+\*\+/
+        ].freeze
+
+        # How many lines ahead to search for a .limit() call.
+        # Covers both chained-on-next-line and separate-assignment styles.
+        LOOKAHEAD_LINES = 3
+
+        def run
+          glob_files('app/**/*.rb').each do |file|
+            lines = File.readlines(file) rescue next
+
+            lines.each_with_index do |line, idx|
+              next if line.strip.start_with?('#')
+
+              if line.match?(UNBOUNDED_QUERY_PATTERN) && !limit_applied?(lines, idx, line)
+                add_finding(
+                  severity: :high,
+                  message: "Potential DoS: unbounded database query without limit",
+                  file: file,
+                  line: idx + 1,
+                  snippet: line.strip,
+                  remediation: "Add .limit() to control result size"
+                )
+              end
+
+              if REDOS_PATTERNS.any? { |pat| line.match?(pat) }
+                add_finding(
+                  severity: :high,
+                  message: "Potential ReDoS vulnerability: dangerous regex pattern",
+                  file: file,
+                  line: idx + 1,
+                  snippet: line.strip,
+                  remediation: "Simplify regex or use timeout mechanisms"
+                )
+              end
+            end
+          end
+          findings
+        end
+
+        private
+
+        # Returns true if a .limit() call is found either:
+        #   1. On the same line as .all      (e.g. Thing.all.limit(100))
+        #   2. Chained on the very next line  (e.g. Thing.all\n  .limit(100))
+        #   3. Applied to the assigned variable within LOOKAHEAD_LINES lines
+        #      (e.g. things = Thing.all \n things = things.limit(100))
+        def limit_applied?(lines, current_idx, current_line)
+          # 1. Same-line limit (Thing.all.limit(100)) — already excluded by
+          #    UNBOUNDED_QUERY_PATTERN's end-of-expression anchor, but double-check.
+          return true if current_line.match?(/\.limit\s*\(/)
+
+          # Extract the variable being assigned, supporting local vars, instance
+          # vars (@foo) and class-instance vars (@@foo).
+          assigned_var = current_line.match(/([@]{0,2}\w+)\s*=\s*[A-Z]/)&.[](1)
+
+          lookahead = lines[(current_idx + 1), LOOKAHEAD_LINES] || []
+
+          lookahead.each do |next_line|
+            stripped = next_line.lstrip
+
+            # 2. Chained on next line: the continuation starts with .limit
+            return true if stripped.start_with?('.limit')
+
+            # 3. Assigned variable subsequently limited:
+            #      things   = things.limit(100)   => local var (word boundary ok)
+            #      @things  = @things.limit(100)  => instance var (@ is non-word, use look-behind)
+            #      things.limit(100)
+            if assigned_var
+              # Build an anchor that works for both `@var` and plain `var`:
+              # require that the var is preceded by start-of-line, whitespace or `=`.
+              anchor  = '(?:^|[\s=(])'
+              escaped = Regexp.escape(assigned_var)
+              return true if next_line.match?(/#{anchor}#{escaped}(?:\s*=\s*#{escaped})?\.limit\s*\(/)
+            end
+          end
+
+          false
+        end
+      end
+    end
+  end
+end

data/lib/rails/guarddog/configuration.rb

@@ -2,11 +2,16 @@ module Rails
   module Guarddog
     class Configuration
       attr_writer :root
-      attr_accessor :enabled_checkers, :excluded_paths, :output_format, :ignored_checks
+      attr_accessor :enabled_checkers, :disabled_checkers, :excluded_paths, :output_format, :ignored_checks
 
       def initialize
         @root = nil
         @enabled_checkers = all_checkers
+        # Checkers to turn off without having to list every other checker in
+        # enabled_checkers. Takes priority over enabled_checkers.
+        # Example: disable just dos and rate_limit:
+        #   config.disabled_checkers = %w[dos rate_limit]
+        @disabled_checkers = []
         @excluded_paths = %w[vendor node_modules]
         # Per-directory checker suppression: keys are path substrings, values are
         # arrays of checker names (same format as enabled_checkers).
@@ -19,6 +24,12 @@ module Rails
         @output_format = :console
       end
 
+      # The final resolved list of checkers to run:
+      # enabled_checkers minus anything in disabled_checkers.
+      def active_checkers
+        enabled_checkers - Array(@disabled_checkers).map(&:to_s)
+      end
+
       def root
         @root || Rails.root.to_s
       end

data/lib/rails/guarddog/scanner.rb

@@ -20,20 +20,21 @@ module Rails
       private
 
       def load_checkers
-        [
-          Checkers::SqlInjectionChecker,
-          Checkers::XssChecker,
-          Checkers::CsrfChecker,
-          Checkers::MassAssignmentChecker,
-          Checkers::OpenRedirectChecker,
-          Checkers::SecretsChecker,
-          Checkers::DosChecker,
-          Checkers::IdorChecker,
-          Checkers::AiInjectionChecker,
-          Checkers::RateLimitChecker,
-          Checkers::DependencyChecker,
-          Checkers::GraphqlChecker
-        ]
+        checker_map = {
+          'sql_injection'  => Checkers::SqlInjectionChecker,
+          'xss'            => Checkers::XssChecker,
+          'csrf'           => Checkers::CsrfChecker,
+          'mass_assignment'=> Checkers::MassAssignmentChecker,
+          'open_redirect'  => Checkers::OpenRedirectChecker,
+          'secrets'        => Checkers::SecretsChecker,
+          'dos'            => Checkers::DosChecker,
+          'idor'           => Checkers::IdorChecker,
+          'ai_injection'   => Checkers::AiInjectionChecker,
+          'rate_limit'     => Checkers::RateLimitChecker,
+          'dependency'     => Checkers::DependencyChecker,
+          'graphql'        => Checkers::GraphqlChecker
+        }
+        @configuration.active_checkers.filter_map { |name| checker_map[name] }
       end
 
       def severity_order(severity)

data/lib/rails/guarddog/version.rb

@@ -1,5 +1,5 @@
 module Rails
   module Guarddog
-    VERSION = "0.1.10"
+    VERSION = "0.1.12"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails-guarddog
 version: !ruby/object:Gem::Version
-  version: 0.1.10
+  version: 0.1.12
 platform: ruby
 authors:
 - Security Team
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-07-12 00:00:00.000000000 Z
+date: 2026-07-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties