rails-graphql 1.0.2 → 1.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3e7d0465d49d0e8eef8d0672cc60cbf8f15e5ee8cb11bf765a2a944b4d5aab33
-  data.tar.gz: 6ada22cc356373aa92a4986029092fb63b16532e8a5df16798b15f17c4d8221a
+  metadata.gz: 5e7e0b35058deec4afd328520ed24fcd24fe4b0f8765b064b0ff0005398e9e7a
+  data.tar.gz: 0ef41b6819bbbe8057fa203ff6f008812e385030d3c171b401ac051a5890d756
 SHA512:
-  metadata.gz: a62b2abf73592f82b4b5b2b290dde535b32054903d6a330808c03137369df0d1962576eaf4658ef42e08803ba82fed36963d75dd72101d0ec1e3362ae2d9ceb1
-  data.tar.gz: d5f8e3b75c6458623e9af9a493113ac230855fadd7bdb93b4bc2f3165a3bf0ed6a7cd6697a05199749a69c3b55412cd849fbc92cd25edbbc331493f5c5989df5
+  metadata.gz: 14d030f7f42f0096d30d0fe9eab85baf3b52526ad5432620a16fa2288e6cfc5e0c123b8f433c78d1155a1dc0869ce5c7567bcdd3b6ff6eef5eca3de1d13ab399
+  data.tar.gz: 933ce0bcb53a39d436a1ff60056882d187bdcf4ec6a76b883f91724b550cdb81164a16e2bc91642db8e2093a76f3c20138ea8fa2ae92772e626352d3807f1adb

data/lib/rails/graphql/config.rb

@@ -2,6 +2,8 @@
 
 module Rails
   module GraphQL
+    AR710 = (ActiveRecord.gem_version >= Gem::Version.new('7.1.0'))
+
     configure do |config|
       # This helps to keep track of when things were cached and registered. Cached
       # objects with mismatching versions need to be upgraded or simply reloaded.

data/lib/rails/graphql/field/output_field.rb

@@ -41,6 +41,10 @@ module Rails
           super || field.has_argument?(name)
         end
 
+        def has_arguments?
+          super || field.has_arguments?
+        end
+
         def arguments?
           super || field.arguments?
         end

data/lib/rails/graphql/helpers/attribute_delegator.rb

@@ -5,13 +5,20 @@ module Rails
     module Helpers
       # This is an extra magic on top of the delegator class from the standard
       # lib that allows fetching a specific property of the delegated object
-      class AttributeDelegator < ActiveSupport::ProxyObject
+      class AttributeDelegator < ::BasicObject
+        undef_method :==
+        undef_method :equal?
+
         def initialize(obj = nil, attribute = nil, cache: true, &block)
           @delegate_sd_attr = attribute
           @delegate_sd_obj = block.presence || obj
           @delegate_cache = cache
         end
 
+        def raise(*args)
+          ::Object.send(:raise, *args)
+        end
+
         private
 
           def respond_to_missing?(method_name, include_private = false)

data/lib/rails/graphql/helpers/with_arguments.rb

@@ -100,6 +100,11 @@ module Rails
           defined?(@arguments) && @arguments.key?(name)
         end
 
+        # Check if any argument has been defined at all
+        def has_arguments?
+          defined?(@arguments) && !@arguments.empty?
+        end
+
         # Validate all the arguments to make sure the definition is valid
         def validate!(*)
           super if defined? super

data/lib/rails/graphql/railtie.rb

@@ -29,13 +29,9 @@ module Rails
       # Ensure a valid logger
       initializer 'graphql.logger' do |app|
         ActiveSupport.on_load(:graphql) do
-          return if config.logger.present?
-
-          logger = ::Rails.logger
-          if logger.respond_to?(:tagged)
-            config.logger = logger
-          else
-            config.logger = ActiveSupport::TaggedLogging.new(logger)
+          config.logger ||= begin
+            logger = ::Rails.logger
+            logger.respond_to?(:tagged) ? logger : ActiveSupport::TaggedLogging.new(logger)
           end
         end
       end

data/lib/rails/graphql/railties/log_subscriber.rb

@@ -98,7 +98,8 @@ module Rails
           parts = ['  GraphQL', suffix.presence, event.payload[:name]]
           parts << "(#{duration}ms)" unless duration.zero?
 
-          color(parts.compact.join(' '), MAGENTA, true)
+          style = AR710 ? { bold: true } : true
+          color(parts.compact.join(' '), MAGENTA, style)
         end
 
         def debug_variables(vars)

data/lib/rails/graphql/request/backtrace.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require 'active_support/parameter_filter'
+
 module Rails
   module GraphQL
     class Request
@@ -130,7 +132,8 @@ module Rails
             return '{}' if value.blank?
 
             request.cache(:backtrace_arguments_filter) do
-              ActiveSupport::ParameterFilter.new(GraphQL.config.filter_parameters)
+              filters = GraphQL.config.filter_parameters || EMPTY_ARRAY
+              ActiveSupport::ParameterFilter.new(filters)
             end.filter(value)
           end
 

data/lib/rails/graphql/request/component/field.rb

@@ -16,7 +16,7 @@ module Rails
         delegate :decorate, to: :type_klass
         delegate :operation, :variables, :request, to: :parent
         delegate :method_name, :resolver, :performer, :type_klass, :leaf_type?,
-          :dynamic_resolver?, :mutation?, to: :field
+          :dynamic_resolver?, :has_arguments?, :mutation?, to: :field
 
         attr_reader :name, :alias_name, :parent, :field, :arguments, :current_object
 

data/lib/rails/graphql/request/steps/organizable.rb

@@ -118,9 +118,9 @@ module Rails
           # Helper parser for arguments that also collect necessary variables
           # Default values forces this method to run even without nodes
           def parse_arguments(nodes)
-            return @arguments = EMPTY_HASH if nodes.blank?
+            return @arguments = EMPTY_HASH if nodes.blank? && !self.has_arguments?
 
-            args = nodes.each.with_object({}) do |(name, value, var_name), hash|
+            args = nodes&.each_with_object({}) do |(name, value, var_name), hash|
               hash[name.to_s] = var_name.nil? ? value : var_name
             end
 

data/lib/rails/graphql/source/base.rb

@@ -41,7 +41,9 @@ module Rails
           # to the +::GraphQL+ namespace with the addition of any namespace of
           # the current class
           def object
-            @object ||= create_type(superclass: object_class, gql_name: object_name)
+            @object ||= create_type(superclass: object_class, gql_name: object_name).tap do |t|
+              t.include(const_get(:ObjectMethods)) if const_defined?(:ObjectMethods, false)
+            end
           end
 
           # Return the GraphQL input type associated with the source. It will
@@ -49,7 +51,9 @@ module Rails
           # to the +::GraphQL+ namespace with the addition of any namespace of
           # the current class
           def input
-            @input ||= create_type(superclass: input_class, gql_name: input_name)
+            @input ||= create_type(superclass: input_class, gql_name: input_name).tap do |t|
+              t.include(const_get(:InputMethods)) if const_defined?(:InputMethods, false)
+            end
           end
 
           protected
@@ -77,6 +81,30 @@ module Rails
               GraphQL::Type.create!(self, name, superclass, **xargs, &block)
             end
 
+            # Allow setting methods on the source object via a proper module
+            def object_methods(&block)
+              type_extend_with_module(:object, &block)
+            end
+
+            # Allow setting methods on the source input via a proper module
+            def input_methods(&block)
+              type_extend_with_module(:input, &block)
+            end
+
+          private
+
+            # Allows adding methods to a type by properly providing a module
+            # and adding it to the type
+            def type_extend_with_module(type, &block)
+              mod_name = :"#{type.to_s.classify}Methods"
+              mod = const_get(mod_name) if const_defined?(mod_name, false)
+              mod ||= const_set(mod_name, Module.new).tap do |m|
+                instance_variable_get("@#{type}")&.include(m)
+              end
+
+              mod.module_eval(&block)
+            end
+
         end
       end
     end

data/lib/rails/graphql/uri.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require 'uri/generic'
+
 module URI
   # URI::GLQ encodes objects from a GraphQL server as an URI.
   # It has the components:

data/lib/rails/graphql/version.rb

@@ -14,7 +14,7 @@ module Rails
     module VERSION
       MAJOR = 1
       MINOR = 0
-      TINY  = 2
+      TINY  = 5
       PRE   = nil
 
       STRING = [MAJOR, MINOR, TINY, PRE].compact.join('.')

data/lib/rails/graphql.rb

@@ -2,6 +2,7 @@
 
 require 'i18n'
 require 'zlib'
+require 'ostruct'
 require 'active_model'
 require 'active_support'
 

data/test/assets/sqlite.gql

@@ -171,6 +171,8 @@ input LiteFactionInput {
   
   basesAttributes: [LiteBaseInput!]
   
+  greeting: String
+  
   name: String
   
   shipsAttributes: [LiteShipInput!]
@@ -206,6 +208,8 @@ type LiteFaction {
   
   bases: [LiteBase!]!
   
+  greeting: String
+  
   name: String
   
   ships: [LiteShip!]!

data/test/config.rb

@@ -13,6 +13,7 @@ SimpleCov.start do
   add_group 'Source', ['/graphql/adapters', '/graphql/source']
 end
 
+require 'logger'
 require 'minitest/autorun'
 require 'minitest/reporters'
 require 'active_record'

data/test/graphql/source_test.rb

@@ -129,6 +129,9 @@ class GraphQL_SourceTest < GraphQL::TestCase
   end
 
   def test_disable
+    # class_attribute changed and the stub does not work as expected
+    return skip if rails8?
+
     described_class.stub(:hook_names, Set[:start]) do
       assert_includes(described_class.hook_names, :start)
       described_class.send(:disable, 'starts')
@@ -137,6 +140,9 @@ class GraphQL_SourceTest < GraphQL::TestCase
   end
 
   def test_enable
+    # class_attribute changed and the stub does not work as expected
+    return skip if rails8?
+
     described_class.stub(:hook_names, Set[]) do
       refute_includes(described_class.hook_names, :start)
       described_class.send(:enable, 'starts')
@@ -157,4 +163,8 @@ class GraphQL_SourceTest < GraphQL::TestCase
     def source_const
       Rails::GraphQL::Source
     end
+
+    def rails8?
+      ActiveSupport.gem_version >= Gem::Version.new('8')
+    end
 end

data/test/integration/alternative_test.rb

@@ -71,7 +71,7 @@ class Integration_AlternativeTest < GraphQL::IntegrationTestCase
   end
 
   class SCHEMA < GraphQL::Schema
-    namespace :authorization
+    namespace :alternatives
 
     configure do |config|
       config.enable_string_collector = false

data/test/integration/memory/star_wars_query_test.rb

@@ -132,6 +132,20 @@ class Integration_Memory_StarWarsQueryTest < GraphQL::IntegrationTestCase
     GQL
   end
 
+  def test_query_with_field_argument_and_default_value
+    argument = SCHEMA.find_type('Human')[:greeting].arguments[:name]
+    argument.stub_ivar(:@default, 'You') do
+      assert(argument.inspect, "name: String! = 'You'")
+
+      vader = { name: 'Han Solo', greeting: 'Hello You!' }
+      assert_result({ data: { human: vader } }, <<~GQL)
+        query WithFieldArgument {
+          human(id: "1002") { name greeting }
+        }
+      GQL
+    end
+  end
+
   def test_query_with_fragment
     luke = { name: 'Luke Skywalker', homePlanet: 'Tatooine' }
     leia = { name: 'Leia Organa', homePlanet: 'Alderaan' }

data/test/integration/memory/star_wars_validation_test.rb

@@ -27,8 +27,21 @@ class Integration_Memory_StarWarsValidationTest < GraphQL::IntegrationTestCase
       locations: [{ line: 2, column: 1 }],
     }]
 
-    assert_result(errors, <<~GQL, dig: 'errors')
+    assert_result(errors, <<~QUERY, dig: 'errors')
       query DroidFieldInFragment { hero { name ... on Droid { primaryFunction
+    QUERY
+  end
+
+  def test_fields_with_required_arguments
+    errors = [{
+      message: 'Invalid arguments for human field: the "id" argument can not be null.',
+      locations: [{ line: 1, column: 19 }, { line: 1, column: 33 }],
+      path: %w[HumanName human],
+      extensions: { stage: 'organize', exception: 'Rails::GraphQL::ArgumentsError' },
+    }]
+
+    assert_result(errors, <<~GQL, dig: 'errors')
+      query HumanName { human { name } }
     GQL
   end
 

data/test/integration/schemas/mysql.rb

@@ -6,7 +6,7 @@ class MySQLRecord < ActiveRecord::Base
   establish_connection(
     name: 'mysql',
     adapter: 'mysql2',
-    host: ENV.fetch('GQL_MYSQL_HOST', 'localhost'),
+    host: ENV.fetch('GQL_MYSQL_HOST', '127.0.0.1'),
     database: ENV.fetch('GQL_MYSQL_DATABASE', 'starwars'),
     username: ENV.fetch('GQL_MYSQL_USERNAME', 'root'),
     password: ENV['GQL_MYSQL_PASSWORD'],

data/test/integration/schemas/sqlite.rb

@@ -14,6 +14,7 @@ end
 SQLiteRecord.connection.instance_eval do
   create_table 'lite_factions', force: :cascade do |t|
     t.string 'name'
+    t.string 'greeting'
   end
 
   create_table 'lite_bases', force: :cascade do |t|
@@ -35,8 +36,8 @@ class LiteFaction < SQLiteRecord
   accepts_nested_attributes_for :bases
   accepts_nested_attributes_for :ships
 
-  REBELS = create!(name: 'Alliance to Restore the Republic')
-  EMPIRE = create!(name: 'Galactic Empire')
+  REBELS = create!(name: 'Alliance to Restore the Republic', greeting: 'Hello %s!')
+  EMPIRE = create!(name: 'Galactic Empire', greeting: 'Hi %s!')
 end
 
 class LiteBase < SQLiteRecord
@@ -79,6 +80,12 @@ class StartWarsSqliteSchema < GraphQL::Schema
     with_options on: 'liteFactions' do
       scoped_argument(:order) { |o| order(name: o) }
     end
+
+    object_methods do
+      def greeting
+        format(current.greeting, 'you')
+      end
+    end
   end
 
   source LiteBase do

data/test/integration/sqlite/star_wars_query_test.rb

@@ -81,4 +81,11 @@ class Integration_SQLite_StarWarsQueryTest < GraphQL::IntegrationTestCase
       query AllBases($order: String!) { liteBases(order: $order) { name } }
     GQL
   end
+
+  def test_query_methods_precedence
+    faction = { greeting: 'Hi you!' }
+    assert_result({ data: { liteFaction: faction } }, <<~GQL)
+      query EmpireFleet { liteFaction(id: "2") { greeting } }
+    GQL
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails-graphql
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.5
 platform: ruby
 authors:
 - Carlos Silva
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-02-03 00:00:00.000000000 Z
+date: 2025-07-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -421,7 +421,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.26
+rubygems_version: 3.4.19
 signing_key:
 specification_version: 4
 summary: GraphQL meets RoR with the most Ruby-like DSL