rails-graphql 1.0.0.rc2 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3c29232c14870c44aeab62fba29beda42f8f99a8047bf83f717149e6fc2e5d7c
-  data.tar.gz: 196468f3151958620774998650fe7a5f70e0b3204fdb5a028b31c634d21a9cb0
+  metadata.gz: d610a5ff87d748320cba5705f819c0832146a28be41ffdfe9ebd8d13772b7326
+  data.tar.gz: 390b994294e6f7ee5f51feadb8dc0102d4d79816d90615b25ca46994bb62e66a
 SHA512:
-  metadata.gz: a17d0f98a0473afd6d221d98b967068ae9d97da363e44e92817729e23a204510768c72bed50a858816e9d7eeda8b0fcdefe83c56d9782e8abe06d71bea6e0f75
-  data.tar.gz: c4258dfce30c7aedba8a3f2c1a9a6c20b0eca30ae520888efac8dfeb3f5267654d74e2992b9794bdb892a2f84d8f1be68d6d71e637ebaa48ee780d3b019ccf25
+  metadata.gz: 738aab60ab153f08f180909a89577cc802c9171b1199763a540094aaf16ebe3169a0a75a49a5de0124383b555ab40d39448201031e71d0caa8ea52b1bc132229
+  data.tar.gz: 4f41e879a2501cbca1c1826c0c5e620e3506f156a4bcc4529d342dc9383109efdd33a25201b4959382967a73b6af29db29328db2ea30c31aa0d411c2c446c5c5

data/Rakefile

@@ -2,7 +2,7 @@
 # Rake tasks for development purposes
 
 begin
-  require 'bundler/setup'
+  require 'bundler/setup' unless ENV.key?('CI_COMPILE')
 rescue LoadError
   puts 'You must `gem install bundler` and `bundle install` to run rake tasks'
 end

data/lib/generators/graphql/templates/config.rb

@@ -37,6 +37,11 @@ Rails::GraphQL.configure do |config|
   # different suffix, change this value to it.
   # config.auto_suffix_input_objects = 'Input'
 
+  # Set if the server should allow strings be used as input for ENUM inputs.
+  # It means that operations will support quotes for ENUM values embedded in
+  # the documents (heredoc won't be accepted).
+  # config.allow_string_as_enum_input = false
+
   # Introspection is enabled by default. It is recommended to only use
   # introspection during development and tests, never in production.
   # This can also be set per schema level.

data/lib/rails/graphql/config.rb

@@ -61,6 +61,11 @@ module Rails
       # different suffix, change this value to it.
       config.auto_suffix_input_objects = 'Input'
 
+      # Set if the server should allow strings be used as input for ENUM inputs.
+      # It means that operations will support quotes for ENUM values embedded in
+      # the documents (heredoc won't be accepted).
+      config.allow_string_as_enum_input = false
+
       # Introspection is enabled by default. It is recommended to only use
       # introspection during development and tests, never in production.
       # This can also be set per schema level.

data/lib/rails/graphql/request/component/operation.rb

@@ -19,6 +19,8 @@ module Rails
           # Helper method to initialize an operation given the node
           def build(request, node)
             request.build(const_get(node.type.to_s.classify, false), request, node)
+          rescue ::NameError
+            raise NameError, +%[Unable to initialize "#{node.type}" operation.]
           end
 
           # Rewrite the kind to always return +:operation+

data/lib/rails/graphql/type/enum.rb

@@ -39,7 +39,9 @@ module Rails
           # Check if a given value is a valid non-deserialized input
           def valid_input?(value)
             (valid_token?(value, :enum) && all_values.include?(value.to_s)) ||
-              (value.is_a?(String) && all_values.include?(value))
+              (value.is_a?(String) && all_values.include?(value)) ||
+              (allow_string_input? && valid_token?(value, :string) &&
+                all_values.include?(value.to_s[1..-2]))
           end
 
           # Check if a given value is a valid non-serialized output
@@ -62,7 +64,13 @@ module Rails
 
           # Turn a user input of this given type into an ruby object
           def deserialize(value)
-            new(value.is_a?(::GQLParser::Token) ? value.to_s : value) if valid_input?(value)
+            if valid_token?(value, :enum)
+              new(value.to_s)
+            elsif allow_string_input? && valid_token?(value, :string)
+              new(value[1..-2])
+            elsif valid_input?(value)
+              new(value)
+            end
           end
 
           # Use the instance as decorator
@@ -142,6 +150,12 @@ module Rails
               #{inspect_directives}
             INFO
           end
+
+          private
+
+            def allow_string_input?
+              GraphQL.config.allow_string_as_enum_input
+            end
         end
 
         attr_reader :value

data/lib/rails/graphql/version.rb

@@ -14,8 +14,8 @@ module Rails
     module VERSION
       MAJOR = 1
       MINOR = 0
-      TINY  = 0
-      PRE   = 'rc2'
+      TINY  = 1
+      PRE   = nil
 
       STRING = [MAJOR, MINOR, TINY, PRE].compact.join('.')
     end

data/test/graphql/request/component/operation_test.rb

@@ -0,0 +1,21 @@
+require 'config'
+
+class GraphQL_Request_Component_OperationTest < GraphQL::TestCase
+  def test_build
+    request = Object.new
+    request.define_singleton_method(:build) { |klass, *| klass }
+
+    assert_equal(klass::Query, klass.build(request, new_token('', :query)))
+    assert_equal(klass::Mutation, klass.build(request, new_token('', :mutation)))
+    assert_equal(klass::Subscription, klass.build(request, new_token('', :subscription)))
+
+    assert_raises(Rails::GraphQL::NameError) { klass.build(request, new_token('', '')) }
+    assert_raises(Rails::GraphQL::NameError) { klass.build(request, new_token('', :field)) }
+  end
+
+  private
+
+  def klass
+    Rails::GraphQL::Request::Component::Operation
+  end
+end

data/test/graphql/type/enum_test.rb

@@ -17,6 +17,13 @@ class GraphQL_Type_EnumTest < GraphQL::TestCase
     refute(DESCRIBED_CLASS.valid_input?(1))
     refute(DESCRIBED_CLASS.valid_input?(nil))
     refute(DESCRIBED_CLASS.valid_input?('abc'))
+
+    str_token = new_token('"A"', :string)
+    refute(DESCRIBED_CLASS.valid_input?(str_token))
+
+    stubbed_config(:allow_string_as_enum_input, true) do
+      assert(DESCRIBED_CLASS.valid_input?(str_token))
+    end
   end
 
   def test_valid_output_ask
@@ -58,6 +65,14 @@ class GraphQL_Type_EnumTest < GraphQL::TestCase
     test_value = DESCRIBED_CLASS.deserialize('A')
     assert_instance_of(DESCRIBED_CLASS, test_value)
     assert_equal('A', test_value.value)
+
+    str_token = new_token('"A"', :string)
+    assert_nil(DESCRIBED_CLASS.deserialize(str_token))
+    stubbed_config(:allow_string_as_enum_input, true) do
+      test_value = DESCRIBED_CLASS.deserialize(str_token)
+      assert_instance_of(DESCRIBED_CLASS, test_value)
+      assert_equal('A', test_value.value)
+    end
   end
 
   def test_decorate

data/test/integration/schemas/mysql.rb

@@ -10,6 +10,7 @@ class MySQLRecord < ActiveRecord::Base
     database: ENV.fetch('GQL_MYSQL_DATABASE', 'starwars'),
     username: ENV.fetch('GQL_MYSQL_USERNAME', 'root'),
     password: ENV['GQL_MYSQL_PASSWORD'],
+    port: ENV['GQL_MYSQL_PORT'],
   )
 end
 

data/test/test_ext.rb

@@ -1,6 +1,12 @@
 # Core ext methods
 
 class Object < BasicObject
+  def new_token(value, type)
+    GQLParser::Token.new(value).tap do |token|
+      token.instance_variable_set(:@type, type)
+    end
+  end
+
   def stub_ivar(name, value = nil)
     instance_variable_set(name, value)
     yield

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails-graphql
 version: !ruby/object:Gem::Version
-  version: 1.0.0.rc2
+  version: 1.0.1
 platform: ruby
 authors:
 - Carlos Silva
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-02-28 00:00:00.000000000 Z
+date: 2024-01-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -349,6 +349,7 @@ files:
 - test/assets/sqlite.gql
 - test/assets/translate.gql
 - test/config.rb
+- test/graphql/request/component/operation_test.rb
 - test/graphql/request/context_test.rb
 - test/graphql/schema_test.rb
 - test/graphql/source_test.rb
@@ -414,9 +415,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 2.6.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubygems_version: 3.3.26
 signing_key:
@@ -433,6 +434,7 @@ test_files:
 - test/assets/sqlite.gql
 - test/assets/translate.gql
 - test/config.rb
+- test/graphql/request/component/operation_test.rb
 - test/graphql/request/context_test.rb
 - test/graphql/schema_test.rb
 - test/graphql/source_test.rb