rails-geocoder 0.8.8 → 0.8.9

data/CHANGELOG.rdoc

@@ -2,6 +2,11 @@
 
 Per-release changes to Geocoder.
 
+== 0.8.9 (2010 Feb 11)
+
+* Add Rails 3 compatibility.
+* Avoid querying Google when query would be an empty string.
+
 == 0.8.8 (2009 Dec 7)
 
 * Automatically select a less accurate but compatible distance algorithm when SQLite database detected (fixes SQLite incompatibility).

data/LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2009 Alex Reisner
+Copyright (c) 2009-10 Alex Reisner
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/README.rdoc

@@ -4,6 +4,8 @@ Geocoder adds object geocoding and database-agnostic distance calculations to Ru
 
 Geocoder does not rely on proprietary database functions so finding geocoded objects in a given area is easily done using out-of-the-box MySQL or even SQLite.
 
+<b>Geocoder is currently compatible with Rails 2.x and Rails 3.</b>
+
 
 == 1. Install
 
@@ -122,7 +124,9 @@ Because Geocoder needs to provide this functionality as a named scope, we must g
 
 == To-do List
 
+* prevent NameError when GOOGLE_MAPS_API_KEY is missing: show nice msg
 * <tt>install.rb</tt> should do some setup when installed as a plugin
+  * create initializer with GOOGLE_MAPS_API_KEY?
 
 
-Copyright (c) 2009 Alex Reisner, released under the MIT license
+Copyright (c) 2009-10 Alex Reisner, released under the MIT license

data/Rakefile

@@ -8,7 +8,7 @@ begin
     gem.summary     = %Q{Add geocoding functionality to Rails models.}
     gem.description = %Q{Geocoder adds object geocoding and database-agnostic distance calculations to Ruby on Rails. It does not rely on proprietary database functions so finding geocoded objects in a given area is easily done using out-of-the-box MySQL or even SQLite.}
     gem.email       = "alex@alexreisner.com"
-    gem.homepage    = "http://code.alexreisner.com/code/geocoder.html"
+    gem.homepage    = "http://github.com/alexreisner/geocoder"
     gem.authors     = ["Alex Reisner"]
     # gem is a Gem::Specification... see http://www.rubygems.org/read/chapter/20 for additional settings
   end

data/VERSION

@@ -1 +1 @@
-0.8.8
+0.8.9

data/lib/geocoder.rb

@@ -213,6 +213,7 @@ module Geocoder
   # Returns array [lat,lon] if found, nil if not found or if network error.
   #
   def self.fetch_coordinates(query)
+    return nil if query.blank?
     return nil unless doc = self.search(query)
     
     # make sure search found a result

data/rails-geocoder.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{rails-geocoder}
-  s.version = "0.8.8"
+  s.version = "0.8.9"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Alex Reisner"]
-  s.date = %q{2009-12-07}
+  s.date = %q{2010-02-11}
   s.description = %q{Geocoder adds object geocoding and database-agnostic distance calculations to Ruby on Rails. It does not rely on proprietary database functions so finding geocoded objects in a given area is easily done using out-of-the-box MySQL or even SQLite.}
   s.email = %q{alex@alexreisner.com}
   s.extra_rdoc_files = [
@@ -26,13 +26,13 @@ Gem::Specification.new do |s|
      "VERSION",
      "init.rb",
      "lib/geocoder.rb",
+     "lib/tasks/geocoder_tasks.rake",
      "rails-geocoder.gemspec",
-     "tasks/geocoder_tasks.rake",
      "test/fixtures/madison_square_garden.xml",
      "test/geocoder_test.rb",
      "test/test_helper.rb"
   ]
-  s.homepage = %q{http://code.alexreisner.com/code/geocoder.html}
+  s.homepage = %q{http://github.com/alexreisner/geocoder}
   s.rdoc_options = ["--charset=UTF-8"]
   s.require_paths = ["lib"]
   s.rubygems_version = %q{1.3.5}

data/test/test_helper.rb

@@ -1,6 +1,6 @@
 require 'rubygems'
 require 'test/unit'
-require 'activesupport'
+require 'active_support/core_ext'
 
 $LOAD_PATH.unshift(File.dirname(__FILE__))
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
@@ -16,16 +16,15 @@ module ActiveRecord
     end
     
     def read_attribute(attr_name)
-      @attributes[attr_name.to_s]
+      @attributes[attr_name.to_sym]
     end
     
     def write_attribute(attr_name, value)
-      attr_name = attr_name.to_s
-      @attributes[attr_name] = value
+      @attributes[attr_name.to_sym] = value
     end
     
     def update_attribute(attr_name, value)
-      write_attribute(attr_name, value)
+      write_attribute(attr_name.to_sym, value)
     end
     
     def self.named_scope(*args); end
@@ -51,18 +50,18 @@ end
 class Venue < ActiveRecord::Base
   geocoded_by :address
   
-  attr_accessor :name, :address
-  
   def initialize(name, address)
     super()
     write_attribute :name, name
     write_attribute :address, address
   end
   
-  # could implement these with method_missing
-  # to simulate custom lat/lon methods
-  def latitude; read_attribute(:latitude); end
-  def longitude; read_attribute(:longitude); end
+  ##
+  # If method not found, assume it's an ActiveRecord attribute reader.
+  #
+  def method_missing(name, *args, &block)
+    @attributes[name]
+  end
 end
 
 class Test::Unit::TestCase

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: rails-geocoder
 version: !ruby/object:Gem::Version 
-  version: 0.8.8
+  version: 0.8.9
 platform: ruby
 authors: 
 - Alex Reisner
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-12-07 00:00:00 -05:00
+date: 2010-02-11 00:00:00 -05:00
 default_executable: 
 dependencies: []
 
@@ -32,13 +32,13 @@ files:
 - VERSION
 - init.rb
 - lib/geocoder.rb
+- lib/tasks/geocoder_tasks.rake
 - rails-geocoder.gemspec
-- tasks/geocoder_tasks.rake
 - test/fixtures/madison_square_garden.xml
 - test/geocoder_test.rb
 - test/test_helper.rb
 has_rdoc: true
-homepage: http://code.alexreisner.com/code/geocoder.html
+homepage: http://github.com/alexreisner/geocoder
 licenses: []
 
 post_install_message: