rails-footnotes 4.1.6 → 4.1.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c57242b5f541d4d6722be87fcb7aaee885065388
-  data.tar.gz: 804664dc9f668fe41bf3cd4c0a3e05a72cf4bb2d
+  metadata.gz: 5e2343ef7d62b4ef197387788f0ff7dd42e86441
+  data.tar.gz: 72282e6373b9b1519d1cd6ba2eedea85aaf39d60
 SHA512:
-  metadata.gz: 4f6e3da7e078c14fd7d4115d250a871c74e75319a4aa47373ebae0cbc3e0094770c24fac5b7ddac183df83eb5a73bcddd93037c09af387a91cc5d4403a1f5b32
-  data.tar.gz: cc4644cb39a8336493649916a3d412f03eb42ff8f8b703f88e29bbd2f6720f0e9a75e6df292a20ce5bddecd4b09a4c7b1a833b4dda4f864b57c5c8e906632510
+  metadata.gz: bb376b0a2f6ee0414db7c4923bd0d9d81813852241cccee6f5a0861c6f92d99f5f19b69eb2a25812694245c62048a4f75dadc46406963e4dc714bc7e1c4dbc60
+  data.tar.gz: c202eef9eb88ba4327a00c046763e5572269b863ac528bb6a58644f2bda6f29ee99902cff4102daf1da9f3fecdc052e79fc0d36aa68807fda0a91b48820f8c42

data/CHANGELOG

@@ -1,5 +1,7 @@
+== Footnotes v4.1.7 ==
+  * Fix notes not collapsing when clicking on them again (#130)*
 == Footnotes v4.1.6 ==
-  * Fix incorrect handler link to css/js files (#217)*
+  * Fix incorrect handler link to css/js files (#127)*
 == Footnotes v4.1.5 ==
   * Remove use of non-existing note in initializer introduced in v4, impacting new installations *
 == Footnotes v4.1.4 ==

data/Rakefile

@@ -9,7 +9,7 @@ task :default => :spec
 desc 'Run tests for Footnotes.'
 RSpec::Core::RakeTask.new(:spec) do |t|
   t.pattern = 'spec/**/*_spec.rb'
-  t.rcov = false
+  # t.rcov = false
 end
 
 desc 'Generate documentation for Footnotes.'

data/lib/rails-footnotes.rb

@@ -50,9 +50,13 @@ module Footnotes
     @@after_hooks << block
   end
 
-  def self.enabled?
+  def self.enabled?(controller)
     if @@enabled.is_a? Proc
-      @@enabled.call
+      if @@enabled.arity == 1
+        @@enabled.call(controller)
+      else
+        @@enabled.call
+      end
     else
       !!@@enabled
     end

data/lib/rails-footnotes/extension.rb

@@ -11,13 +11,13 @@ module Footnotes
     end
 
     def rails_footnotes_before_filter
-      if Footnotes.enabled?
+      if Footnotes.enabled?(self)
         Footnotes::Filter.start!(self)
       end
     end
 
     def rails_footnotes_after_filter
-      if Footnotes.enabled?
+      if Footnotes.enabled?(self)
         filter = Footnotes::Filter.new(self)
         filter.add_footnotes!
         filter.close!(self)

data/lib/rails-footnotes/filter.rb

@@ -207,14 +207,22 @@ module Footnotes
               }
 
               function hideAllAndToggle(id) {
+                var n = note(id);
+                var display = n.style.display;
                 hideAll();
+                // Restore original display to allow toggling
+                n.style.display = display;
                 toggle(id)
 
                 location.href = '#footnotes_debug';
               }
 
+              function note(id) {
+                return (document.getElementById(id));
+              }
+
               function toggle(id){
-                var el = document.getElementById(id);
+                var el = note(id);
                 if (el.style.display == 'none') {
                   Footnotes.show(el);
                 } else {

data/lib/rails-footnotes/notes/view_note.rb

@@ -1,31 +1,39 @@
 module Footnotes
   module Notes
     class ViewNote < AbstractNote
+      cattr_accessor :template
+
+      def self.start!(controller)
+        @subscriber ||= ActiveSupport::Notifications.subscribe('render_template.action_view') do |*args|
+          event = ActiveSupport::Notifications::Event.new *args
+          self.template = {:file => event.payload[:identifier], :duration => event.duration}
+        end
+      end
+
       def initialize(controller)
         @controller = controller
-        @template = controller.instance_variable_get(:@template)
       end
 
       def row
         :edit
       end
 
+      def title
+        "View (#{"%.3f" % self.template[:duration]}ms)"
+      end
+
       def link
         escape(Footnotes::Filter.prefix(filename, 1, 1))
       end
 
       def valid?
-        prefix? && first_render?
+        prefix? && filename && File.exists?(filename)
       end
 
       protected
 
-        def first_render?
-          @template.instance_variable_get(:@_first_render)
-        end
-
         def filename
-          @filename ||= @template.instance_variable_get(:@_first_render).filename
+          @filename ||= self.class.template[:file]
         end
 
     end

data/lib/rails-footnotes/version.rb

@@ -1,3 +1,3 @@
 module Footnotes
-  VERSION = "4.1.6"
+  VERSION = "4.1.7"
 end

data/rails-footnotes.gemspec

@@ -16,7 +16,7 @@ Gem::Specification.new do |s|
 
   s.add_dependency "rails", ">= 3.2"
 
-  s.add_development_dependency "rspec-rails", '~> 2.14.0'
+  s.add_development_dependency "rspec-rails", '~> 3.2.1'
   s.add_development_dependency "test-unit"
   s.add_development_dependency "capybara"
 

data/spec/abstract_note_spec.rb

@@ -11,17 +11,21 @@ describe Footnotes::Notes::AbstractNote do
     Footnotes::Filter.notes = @notes
   end
 
-  it {described_class.should respond_to :start!}
-  it {described_class.should respond_to :close!}
-  it {described_class.should respond_to :title}
+  it {expect(described_class).to respond_to :start!}
+  it {expect(described_class).to respond_to :close!}
+  it {expect(described_class).to respond_to :title}
 
   it {should respond_to :to_sym}
-  its(:to_sym) {should eql :abstract}
 
-  it { described_class.should be_included }
+  describe '#to_sym' do
+    subject { super().to_sym }
+    it {should eql :abstract}
+  end
+
+  it { expect(described_class).to be_included }
   specify do
     Footnotes::Filter.notes = []
-    described_class.should_not be_included
+    expect(described_class).not_to be_included
   end
 
   it { should respond_to :row }
@@ -45,12 +49,12 @@ describe Footnotes::Notes::AbstractNote do
 
   #TODO should be moved to builder
   #helpers
-  specify { subject.escape('<').should eql '&lt;' }
-  specify { subject.escape('&').should eql '&amp;' }
-  specify { subject.escape('>').should eql '&gt;' }
+  specify { expect(subject.escape('<')).to eql '&lt;' }
+  specify { expect(subject.escape('&')).to eql '&amp;' }
+  specify { expect(subject.escape('>')).to eql '&gt;' }
 
-  specify { subject.mount_table([]).should be_blank }
-  specify { subject.mount_table([['h1', 'h2', 'h3']], :class => 'table').should be_blank }
+  specify { expect(subject.mount_table([])).to be_blank }
+  specify { expect(subject.mount_table([['h1', 'h2', 'h3']], :class => 'table')).to be_blank }
 
   specify {
     tab = <<-TABLE
@@ -60,7 +64,7 @@ describe Footnotes::Notes::AbstractNote do
           </table>
           TABLE
 
-    subject.mount_table([['h1'],['r1c1']], :class => 'table').should eql tab
+    expect(subject.mount_table([['h1'],['r1c1']], :class => 'table')).to eql tab
   }
 
   specify {
@@ -70,7 +74,7 @@ describe Footnotes::Notes::AbstractNote do
             <tbody><tr><td>r1c1</td><td>r1c2</td><td>r1c3</td></tr></tbody>
           </table>
           TABLE
-    subject.mount_table([['h1', 'h2', 'h3'],['r1c1', 'r1c2', 'r1c3']]).should eql tab
+    expect(subject.mount_table([['h1', 'h2', 'h3'],['r1c1', 'r1c2', 'r1c3']])).to eql tab
   }
 
   specify {

data/spec/controllers/files_note_controller_spec.rb

@@ -6,14 +6,8 @@ class FilesController < ApplicationController
     end
   end
 
-describe FilesController do
-
+describe FilesController, type: :controller do
   render_views
-  include Capybara::DSL
-
-  def page
-    Capybara::Node::Simple.new(response.body)
-  end
 
   before :all do
     Footnotes.enabled = true

data/spec/controllers/footnotes_controller_spec.rb

@@ -20,28 +20,24 @@ class FootnotesController < ActionController::Base
 
 end
 
-describe FootnotesController do
-
-  def page
-    Capybara::Node::Simple.new(response.body)
-  end
+describe FootnotesController, type: :controller do
 
   shared_examples 'has_footnotes' do
     it 'includes footnotes' do
       get :foo
-      response.body.should have_selector('#footnotes_debug')
+      expect(response.body).to have_selector('#footnotes_debug')
     end
   end
 
   shared_examples 'has_no_footnotes' do
     it 'does not include footnotes' do
-      response.body.should_not have_selector('#footnotes_debug')
+      expect(response.body).not_to have_selector('#footnotes_debug')
     end
   end
 
   it 'does not alter the page by default' do
     get :foo
-    response.body.should == HTML_DOCUMENT
+    expect(response.body).to eq(HTML_DOCUMENT)
   end
 
   context 'with footnotes' do
@@ -62,17 +58,17 @@ describe FootnotesController do
       end
 
       it 'includes footnotes in the last div in body' do
-        all('body > :last-child')[0][:id].should == 'footnotes_debug'
+        expect(all('body > :last-child')[0][:id]).to eq('footnotes_debug')
       end
 
       it 'includes footnotes in the footnoted_holder div if present' do
         get :foo_holder
-        response.body.should have_selector('#footnotes_holder > #footnotes_debug')
+        expect(response.body).to have_selector('#footnotes_holder > #footnotes_debug')
       end
 
       it 'does not alter a html file download' do
         get :foo_download
-        response.body.should == File.open(Rails.root.join('fixtures', 'html_download.html')).read
+        expect(response.body).to eq(File.open(Rails.root.join('fixtures', 'html_download.html')).read)
       end
     end
 
@@ -90,6 +86,43 @@ describe FootnotesController do
       end
     end
 
+    describe 'when footnotes is disabled' do
+      include_context 'has_no_footnotes'
+      before do
+        Footnotes.enabled = false
+        get :foo
+      end
+    end
+
+    describe 'with a proc' do
+
+      it 'yields the controller' do
+        c = nil
+        Footnotes.enabled = lambda { |controller| c = controller}
+        get :foo
+        expect(c).to be_kind_of(ActionController::Base)
+      end
+
+      context 'returning true' do
+        include_context 'has_footnotes'
+
+        before do
+          Footnotes.enabled = lambda { true }
+          get :foo
+        end
+      end
+
+      context 'returning false' do
+        include_context 'has_no_footnotes'
+
+        before do
+          Footnotes.enabled = lambda { false }
+          get :foo
+        end
+      end
+
+    end
+
   end
 
 end

data/spec/controllers/log_note_controller_spec.rb

@@ -1,11 +1,7 @@
 require 'spec_helper'
 require 'stringio'
 
-describe 'log note' do
-
-  def page
-    Capybara::Node::Simple.new(response.body)
-  end
+describe 'log note', type: :controller do
 
   class ApplicationController < ActionController::Base
   end
@@ -29,8 +25,8 @@ describe 'log note' do
   it 'Includes the log in the response' do
     get :index
     log_debug = first('fieldset#log_debug_info div', :visible => false)
-    log_debug.should have_content('foo')
-    log_debug.should have_content('bar')
+    expect(log_debug).to have_content('foo')
+    expect(log_debug).to have_content('bar')
   end
 
 end

data/spec/controllers/partials_note_controller_spec.rb

@@ -7,7 +7,7 @@ class PartialsController < ActionController::Base
 
 end
 
-describe PartialsController do
+describe PartialsController, type: :controller do
 
   render_views
 
@@ -21,7 +21,7 @@ describe PartialsController do
 
   it 'lists the rendered partials' do
     get :index
-    response.body.should have_selector('#footnotes_debug #partials_debug_info table tr', :visible => false, :count => 2)
+    expect(response.body).to have_selector('#footnotes_debug #partials_debug_info table tr', :visible => false, :count => 2)
   end
 
 

data/spec/footnotes_spec.rb

@@ -42,7 +42,7 @@ describe "Footnotes" do
 
   it "footnotes_controller" do
     index = @controller.response.body.index(/This is the HTML page/)
-    index.should eql 334
+    expect(index).to eql 334
   end
 
   context "response_body is file" do
@@ -66,62 +66,62 @@ describe "Footnotes" do
 
   it "foonotes_included" do
     footnotes_perform!
-    @controller.response_body.should_not == HTML_DOCUMENT
+    expect(@controller.response_body).not_to eq(HTML_DOCUMENT)
   end
 
   it "should escape links with special chars" do
     note_with_link = Footnotes::Notes::FileURINote.new
     link = Footnotes::Filter.prefix(note_with_link.link, 1, 1, 1)
-    link.should eql "txmt://open?url=file:///example/local%20file%20path/with-special-chars/%C3%B6%C3%A4%C3%BC/file&line=1&column=1"
+    expect(link).to eql "txmt://open?url=file:///example/local%20file%20path/with-special-chars/%C3%B6%C3%A4%C3%BC/file&line=1&column=1"
   end
 
   specify "footnotes_not_included_when_request_is_xhr" do
     @controller.request.env['HTTP_X_REQUESTED_WITH'] = 'XMLHttpRequest'
     @controller.request.env['HTTP_ACCEPT'] = 'text/javascript, text/html, application/xml, text/xml, */*'
     footnotes_perform!
-    @controller.response.body.should eql HTML_DOCUMENT
+    expect(@controller.response.body).to eql HTML_DOCUMENT
   end
 
   specify "footnotes_not_included_when_content_type_is_javascript" do
     @controller.response.content_type = 'text/javascript'
     footnotes_perform!
-    @controller.response.body.should eql HTML_DOCUMENT
+    expect(@controller.response.body).to eql HTML_DOCUMENT
   end
 
   specify "footnotes_included_when_content_type_is_html" do
     @controller.response.content_type = 'text/html'
     footnotes_perform!
-    @controller.response.body.should_not eql HTML_DOCUMENT
+    expect(@controller.response.body).not_to eql HTML_DOCUMENT
   end
 
   specify "footnotes_included_when_content_type_is_nil" do
     footnotes_perform!
-    @controller.response.body.should_not eql HTML_DOCUMENT
+    expect(@controller.response.body).not_to eql HTML_DOCUMENT
   end
 
   specify "not_included_when_body_is_not_a_string" do
-    @controller.response.stub(:body).and_return(Time.now)# = Proc.new { Time.now }
-    Footnotes::Filter.new(@controller).send(:valid?).should_not be
-    @controller.response.body.should_not =~ /<!-- Footnotes/
+    allow(@controller.response).to receive(:body).and_return(Time.now)# = Proc.new { Time.now }
+    expect(Footnotes::Filter.new(@controller).send(:valid?)).not_to be
+    expect(@controller.response.body).not_to match(/<!-- Footnotes/)
   end
 
   specify "notes_are_initialized" do
     footnotes_perform!
     test_note = @footnotes.instance_variable_get('@notes').first
-    test_note.class.name.should eql 'Footnotes::Notes::TestNote'
-    test_note.to_sym.should eql :test
+    expect(test_note.class.name).to eql 'Footnotes::Notes::TestNote'
+    expect(test_note.to_sym).to eql :test
   end
 
   specify "notes_links" do
     note = Footnotes::Notes::TestNote.new
-    note.should_receive(:row).twice
+    expect(note).to receive(:row).twice
     @footnotes.instance_variable_set(:@notes, [note])
     footnotes_perform!
   end
 
   specify "notes_fieldset" do
     note = Footnotes::Notes::TestNote.new
-    note.should_receive(:has_fieldset?).exactly(3).times
+    expect(note).to receive(:has_fieldset?).exactly(3).times
     @footnotes.instance_variable_set(:@notes, [note])
     footnotes_perform!
   end
@@ -129,70 +129,70 @@ describe "Footnotes" do
   specify "multiple_notes" do
     Footnotes::Filter.multiple_notes = true
     note = Footnotes::Notes::TestNote.new
-    note.should_receive(:has_fieldset?).twice
+    expect(note).to receive(:has_fieldset?).twice
     @footnotes.instance_variable_set(:@notes, [note])
     footnotes_perform!
   end
 
   specify "notes_are_reset" do
     note = Footnotes::Notes::TestNote.new
-    note.class.should_receive(:close!)
+    expect(note.class).to receive(:close!)
     @footnotes.instance_variable_set(:@notes, [note])
     @footnotes.send(:close!, @controller)
   end
 
   specify "links_helper" do
     note = Footnotes::Notes::TestNote.new
-    @footnotes.send(:link_helper, note).should eql '<a href="#" onclick="">Test</a>'
+    expect(@footnotes.send(:link_helper, note)).to eql '<a href="#" onclick="">Test</a>'
 
-    note.should_receive(:link).once.and_return(:link)
-    @footnotes.send(:link_helper, note).should eql '<a href="link" onclick="">Test</a>'
+    expect(note).to receive(:link).once.and_return(:link)
+    expect(@footnotes.send(:link_helper, note)).to eql '<a href="link" onclick="">Test</a>'
   end
 
   specify "links_helper_has_fieldset?" do
     note = Footnotes::Notes::TestNote.new
-    note.should_receive(:has_fieldset?).once.and_return(true)
-    @footnotes.send(:link_helper, note).should eql '<a href="#" onclick="Footnotes.hideAllAndToggle(\'test_debug_info\');return false;">Test</a>'
+    expect(note).to receive(:has_fieldset?).once.and_return(true)
+    expect(@footnotes.send(:link_helper, note)).to eql '<a href="#" onclick="Footnotes.hideAllAndToggle(\'test_debug_info\');return false;">Test</a>'
   end
 
   specify "links_helper_onclick" do
     note = Footnotes::Notes::TestNote.new
-    note.should_receive(:onclick).twice.and_return(:onclick)
-    @footnotes.send(:link_helper, note).should eql '<a href="#" onclick="onclick">Test</a>'
+    expect(note).to receive(:onclick).twice.and_return(:onclick)
+    expect(@footnotes.send(:link_helper, note)).to eql '<a href="#" onclick="onclick">Test</a>'
 
-    note.should_receive(:has_fieldset?).once.and_return(true)
-    @footnotes.send(:link_helper, note).should eql '<a href="#" onclick="onclick">Test</a>'
+    expect(note).to receive(:has_fieldset?).once.and_return(true)
+    expect(@footnotes.send(:link_helper, note)).to eql '<a href="#" onclick="onclick">Test</a>'
   end
 
   specify "insert_style" do
     @controller.response.body = "<head></head><split><body></body>"
     @footnotes = Footnotes::Filter.new(@controller)
     footnotes_perform!
-    @controller.response.body.split('<split>').first.include?('<!-- Footnotes Style -->').should be
+    expect(@controller.response.body.split('<split>').first.include?('<!-- Footnotes Style -->')).to be
   end
 
   specify "insert_footnotes_inside_body" do
     @controller.response.body = "<head></head><split><body></body>"
     @footnotes = Footnotes::Filter.new(@controller)
     footnotes_perform!
-    @controller.response.body.split('<split>').last.include?('<!-- End Footnotes -->').should be
+    expect(@controller.response.body.split('<split>').last.include?('<!-- End Footnotes -->')).to be
   end
 
   specify "insert_footnotes_inside_holder" do
     @controller.response.body = "<head></head><split><div id='footnotes_holder'></div>"
     @footnotes = Footnotes::Filter.new(@controller)
     footnotes_perform!
-    @controller.response.body.split('<split>').last.include?('<!-- End Footnotes -->').should be
+    expect(@controller.response.body.split('<split>').last.include?('<!-- End Footnotes -->')).to be
   end
 
   specify "insert_text" do
     @footnotes.send(:insert_text, :after, /<head>/, "Graffiti")
     after = "    <head>Graffiti"
-    @controller.response.body.split("\n")[2].should eql after
+    expect(@controller.response.body.split("\n")[2]).to eql after
 
     @footnotes.send(:insert_text, :before, /<\/body>/, "Notes")
     after = "    Notes</body>"
-    @controller.response.body.split("\n")[12].should eql after
+    expect(@controller.response.body.split("\n")[12]).to eql after
   end
 
   describe 'Hooks' do
@@ -201,14 +201,14 @@ describe "Footnotes" do
       specify do
         Footnotes.setup {|config| config.before {|controller, filter| filter.notes -= [:note_y] }}
         Footnotes::Filter.start!(@controller)
-        Footnotes::Filter.notes.should eql [:note_x, :note_z]
+        expect(Footnotes::Filter.notes).to eql [:note_x, :note_z]
       end
     end
     context "after" do
       specify do
         Footnotes.setup {|config| config.after {|controller, filter| filter.notes -= [:note_y] }}
         Footnotes::Filter.start!(@controller)
-        Footnotes::Filter.notes.should eql [:note_x, :note_z]
+        expect(Footnotes::Filter.notes).to eql [:note_x, :note_z]
       end
     end
   end
@@ -224,9 +224,9 @@ describe "Footnotes" do
 
   def template_expects(format)
     if @controller.template.respond_to?(:template_format)
-      @controller.template.stub(:template_format).and_return(format)
+      allow(@controller.template).to receive(:template_format).and_return(format)
     else
-      @controller.template.stub(:format).and_return(format)
+      allow(@controller.template).to receive(:format).and_return(format)
     end
   end
 

data/spec/notes/assigns_note_spec.rb

@@ -5,7 +5,7 @@ require "rails-footnotes/notes/assigns_note"
 describe Footnotes::Notes::AssignsNote do
   let(:note) do
     @controller = double
-    @controller.stub(:instance_variables).and_return([:@action_has_layout, :@status])
+    allow(@controller).to receive(:instance_variables).and_return([:@action_has_layout, :@status])
     @controller.instance_variable_set(:@action_has_layout, true)
     @controller.instance_variable_set(:@status, 200)
     Footnotes::Notes::AssignsNote.new(@controller)
@@ -15,10 +15,14 @@ describe Footnotes::Notes::AssignsNote do
   before(:each) {Footnotes::Notes::AssignsNote.ignored_assigns = []}
 
   it {should be_valid}
-  its(:title) {should eql 'Assigns (2)'}
 
-  specify {note.send(:assigns).should eql [:@action_has_layout, :@status]}
-  specify {note.send(:to_table).should eql [
+  describe '#title' do
+    subject { super().title }
+    it {should eql 'Assigns (2)'}
+  end
+
+  specify {expect(note.send(:assigns)).to eql [:@action_has_layout, :@status]}
+  specify {expect(note.send(:to_table)).to eql [
     ["Name", "Value"],
     ["<strong>@action_has_layout</strong><br /><em>TrueClass</em>", "true"],
     ["<strong>@status</strong><br /><em>Fixnum</em>", "200"]
@@ -26,16 +30,16 @@ describe Footnotes::Notes::AssignsNote do
 
   describe "Ignored Assigns" do
     before(:each) {Footnotes::Notes::AssignsNote.ignored_assigns = [:@status]}
-    it {note.send(:assigns).should_not include :@status}
+    it {expect(note.send(:assigns)).not_to include :@status}
   end
 
   describe "Ignored Assigns by regexp" do
     before(:each) {Footnotes::Notes::AssignsNote.ignored_assigns_pattern = /^@status$/}
-    it {note.send(:assigns).should_not include :@status}
+    it {expect(note.send(:assigns)).not_to include :@status}
   end
 
   it "should call #mount_table method with correct params" do
-    note.should_receive(:mount_table).with(
+    expect(note).to receive(:mount_table).with(
       [
         ["Name", "Value"],
         ["<strong>@action_has_layout</strong><br /><em>TrueClass</em>", "true"],

data/spec/notes/controller_note_spec.rb

@@ -5,8 +5,8 @@ describe Footnotes::Notes::ControllerNote do
   # Issue #60
   it "should not be valid if conftroller file not exist" do
     note = Footnotes::Notes::ControllerNote.new(double)
-    note.stub(:controller_filename).and_return(nil)
+    allow(note).to receive(:controller_filename).and_return(nil)
 
-    note.should_not be_valid
+    expect(note).not_to be_valid
   end
 end

data/spec/notes/files_note_spec.rb

@@ -11,6 +11,10 @@ describe Footnotes::Notes::FilesNote do
   subject { note }
 
   it { should be_valid }
-  its(:row) { should eql :edit }
+
+  describe '#row' do
+    subject { super().row }
+    it { should eql :edit }
+  end
 
 end

data/spec/notes/javascripts_note_spec.rb

@@ -8,7 +8,7 @@ describe Footnotes::Notes::JavascriptsNote do
   it {should be_valid}
 
   it "should return js links from html after #scan_text mehtod call" do
-    subject.send(:scan_text, HTML_WITH_JS).should eql ['/javascripts/all.js', '/javascripts/jquery.js']
+    expect(subject.send(:scan_text, HTML_WITH_JS)).to eql ['/javascripts/all.js', '/javascripts/jquery.js']
   end
 end
 

data/spec/notes/stylesheets_note_spec.rb

@@ -9,7 +9,7 @@ describe Footnotes::Notes::StylesheetsNote do
   it {should be_valid}
 
   it "should return css link from html text after #scan_text call" do
-    subject.send(:scan_text, HTML_WITH_CSS).should eql ['/stylesheets/compiled/print.css', '/stylesheets/compiled/print.css']
+    expect(subject.send(:scan_text, HTML_WITH_CSS)).to eql ['/stylesheets/compiled/print.css', '/stylesheets/compiled/print.css']
   end
 end
 

data/spec/notes/view_note_spec.rb

@@ -0,0 +1,12 @@
+require "spec_helper"
+require "rails-footnotes/notes/view_note"
+
+describe Footnotes::Notes::ViewNote do
+
+  it "should not be valid if view file not exist" do
+    note = Footnotes::Notes::ViewNote.new(double)
+    allow(note).to receive(:filename).and_return(nil)
+
+    expect(note).not_to be_valid
+  end
+end

data/spec/spec_helper.rb

@@ -6,6 +6,7 @@ end
 ENV["RAILS_ENV"] ||= 'test'
 require "sprockets/railtie"
 require "rails-footnotes"
+require 'capybara/rspec'
 
 module FooBar
   class Application < Rails::Application
@@ -22,10 +23,19 @@ end
 class ApplicationController < ActionController::Base
 end
 
+module Helpers
+  def page
+    Capybara::Node::Simple.new(response.body)
+  end
+end
+
 RSpec.configure do |config|
 
   Rails.application.initialize!
 
+  config.include Capybara::DSL
+  config.include Helpers
+
   Rails.application.routes.draw do
     get 'footnotes/foo'
     get 'footnotes/foo_holder'
@@ -34,9 +44,7 @@ RSpec.configure do |config|
     get 'partials/index'
     get 'files/index'
   end
-
 end
 
 require 'rspec/rails'
-require 'capybara/rspec'
 require 'capybara/rails'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails-footnotes
 version: !ruby/object:Gem::Version
-  version: 4.1.6
+  version: 4.1.7
 platform: ruby
 authors:
 - Roman V. Babenko
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-02 00:00:00.000000000 Z
+date: 2015-05-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -34,14 +34,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.14.0
+        version: 3.2.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.14.0
+        version: 3.2.1
 - !ruby/object:Gem::Dependency
   name: test-unit
   requirement: !ruby/object:Gem::Requirement
@@ -137,6 +137,7 @@ files:
 - spec/notes/files_note_spec.rb
 - spec/notes/javascripts_note_spec.rb
 - spec/notes/stylesheets_note_spec.rb
+- spec/notes/view_note_spec.rb
 - spec/spec_helper.rb
 homepage: http://github.com/josevalim/rails-footnotes
 licenses: []
@@ -157,7 +158,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: rails-footnotes
-rubygems_version: 2.4.5
+rubygems_version: 2.4.6
 signing_key: 
 specification_version: 4
 summary: Every Rails page has footnotes that gives information about your application
@@ -182,4 +183,5 @@ test_files:
 - spec/notes/files_note_spec.rb
 - spec/notes/javascripts_note_spec.rb
 - spec/notes/stylesheets_note_spec.rb
+- spec/notes/view_note_spec.rb
 - spec/spec_helper.rb