rails-footnotes 4.1.5 → 5.0.0

data/spec/notes/assigns_note_spec.rb

@@ -5,7 +5,7 @@ require "rails-footnotes/notes/assigns_note"
 describe Footnotes::Notes::AssignsNote do
   let(:note) do
     @controller = double
-    @controller.stub(:instance_variables).and_return([:@action_has_layout, :@status])
+    allow(@controller).to receive(:instance_variables).and_return([:@action_has_layout, :@status])
     @controller.instance_variable_set(:@action_has_layout, true)
     @controller.instance_variable_set(:@status, 200)
     Footnotes::Notes::AssignsNote.new(@controller)
@@ -15,31 +15,35 @@ describe Footnotes::Notes::AssignsNote do
   before(:each) {Footnotes::Notes::AssignsNote.ignored_assigns = []}
 
   it {should be_valid}
-  its(:title) {should eql 'Assigns (2)'}
 
-  specify {note.send(:assigns).should eql [:@action_has_layout, :@status]}
-  specify {note.send(:to_table).should eql [
+  describe '#title' do
+    subject { super().title }
+    it {should eql 'Assigns (2)'}
+  end
+
+  specify {expect(note.send(:assigns)).to eql [:@action_has_layout, :@status]}
+  specify {expect(note.send(:to_table)).to eql [
     ["Name", "Value"],
     ["<strong>@action_has_layout</strong><br /><em>TrueClass</em>", "true"],
-    ["<strong>@status</strong><br /><em>Fixnum</em>", "200"]
+    ["<strong>@status</strong><br /><em>Integer</em>", "200"]
   ]}
 
   describe "Ignored Assigns" do
     before(:each) {Footnotes::Notes::AssignsNote.ignored_assigns = [:@status]}
-    it {note.send(:assigns).should_not include :@status}
+    it {expect(note.send(:assigns)).not_to include :@status}
   end
 
   describe "Ignored Assigns by regexp" do
     before(:each) {Footnotes::Notes::AssignsNote.ignored_assigns_pattern = /^@status$/}
-    it {note.send(:assigns).should_not include :@status}
+    it {expect(note.send(:assigns)).not_to include :@status}
   end
 
   it "should call #mount_table method with correct params" do
-    note.should_receive(:mount_table).with(
+    expect(note).to receive(:mount_table).with(
       [
         ["Name", "Value"],
         ["<strong>@action_has_layout</strong><br /><em>TrueClass</em>", "true"],
-        ["<strong>@status</strong><br /><em>Fixnum</em>", "200"]
+        ["<strong>@status</strong><br /><em>Integer</em>", "200"]
       ], {:summary=>"Debug information for Assigns (2)"})
     note.content
   end

data/spec/notes/controller_note_spec.rb

@@ -5,8 +5,8 @@ describe Footnotes::Notes::ControllerNote do
   # Issue #60
   it "should not be valid if conftroller file not exist" do
     note = Footnotes::Notes::ControllerNote.new(double)
-    note.stub(:controller_filename).and_return(nil)
+    allow(note).to receive(:controller_filename).and_return(nil)
 
-    note.should_not be_valid
+    expect(note).not_to be_valid
   end
 end

data/spec/notes/files_note_spec.rb

@@ -2,16 +2,25 @@ require 'spec_helper'
 require 'action_controller'
 require "rails-footnotes/notes/files_note"
 
+class ConcreteFilesNote < Footnotes::Notes::FilesNote
+  def scan_text(text)
+    []
+  end
+end
+
 describe Footnotes::Notes::FilesNote do
 
   let(:note) do
-    Rails.stub(:version).and_return('3.0.12');
-    Footnotes::Notes::FilesNote.new(double('controller', :response => double('', :body => '')))
+    ConcreteFilesNote.new(double('controller', :response => double('', :body => '')))
   end
 
   subject { note }
 
   it { should be_valid }
-  its(:row) { should eql :edit }
+
+  describe '#row' do
+    subject { super().row }
+    it { should eql :edit }
+  end
 
 end

data/spec/notes/javascripts_note_spec.rb

@@ -8,7 +8,7 @@ describe Footnotes::Notes::JavascriptsNote do
   it {should be_valid}
 
   it "should return js links from html after #scan_text mehtod call" do
-    subject.send(:scan_text, HTML_WITH_JS).should eql ['/javascripts/all.js', '/javascripts/jquery.js']
+    expect(subject.send(:scan_text, HTML_WITH_JS)).to eql ['/javascripts/all.js', '/javascripts/jquery.js']
   end
 end
 

data/spec/notes/stylesheets_note_spec.rb

@@ -9,7 +9,7 @@ describe Footnotes::Notes::StylesheetsNote do
   it {should be_valid}
 
   it "should return css link from html text after #scan_text call" do
-    subject.send(:scan_text, HTML_WITH_CSS).should eql ['/stylesheets/compiled/print.css', '/stylesheets/compiled/print.css']
+    expect(subject.send(:scan_text, HTML_WITH_CSS)).to eql ['/stylesheets/compiled/print.css', '/stylesheets/compiled/print.css']
   end
 end
 

data/spec/notes/view_note_spec.rb

@@ -0,0 +1,18 @@
+require "spec_helper"
+require "rails-footnotes/notes/view_note"
+
+describe Footnotes::Notes::ViewNote do
+  it "should not be valid if view file not exist" do
+    note = Footnotes::Notes::ViewNote.new(double)
+    allow(note).to receive(:filename).and_return(nil)
+
+    expect(note).not_to be_valid
+  end
+
+  it "should not explode if template is nil" do
+    Footnotes::Notes::ViewNote.template = nil
+
+    note = Footnotes::Notes::ViewNote.new(double)
+    expect(note).to_not be_valid
+  end
+end

data/spec/spec_helper.rb

@@ -4,12 +4,15 @@ begin
 rescue LoadError
 end
 ENV["RAILS_ENV"] ||= 'test'
+require "sprockets/railtie"
 require "rails-footnotes"
+require 'capybara/rspec'
 
 module FooBar
   class Application < Rails::Application
     config.secret_key_base = 'foobar'
-    config.root = Dir.new('.')
+    config.root = Dir.new('./spec')
+    config.eager_load = false
   end
 end
 
@@ -17,20 +20,49 @@ ActionController::Base.class_eval do
   include Rails.application.routes.url_helpers
 end
 
+class ApplicationController < ActionController::Base
+end
+
+module Helpers
+  def page
+    Capybara::Node::Simple.new(response.body)
+  end
+end
+
 RSpec.configure do |config|
 
   Rails.application.initialize!
 
+  config.include Capybara::DSL
+  config.include Helpers
+  config.example_status_persistence_file_path = ".rspec_results"
+
   Rails.application.routes.draw do
     get 'footnotes/foo'
     get 'footnotes/foo_holder'
     get 'footnotes/foo_js'
     get 'footnotes/foo_download'
     get 'partials/index'
+    get 'files/index'
   end
-
 end
 
 require 'rspec/rails'
-require 'capybara/rspec'
 require 'capybara/rails'
+
+HTML_DOCUMENT = <<EOF
+<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
+<html>
+    <head>
+        <title>HTML to XHTML Example: HTML page</title>
+        <link rel="Stylesheet" href="htmltohxhtml.css" type="text/css" media="screen">
+        <meta http-equiv="Content-Type" content="text/html;charset=UTF-8">
+    </head>
+    <body>
+        <p>This is the HTML page. It works and is encoded just like any HTML page you
+         have previously done. View <a href="htmltoxhtml2.htm">the XHTML version</a> of
+         this page to view the difference between HTML and XHTML.</p>
+        <p>You will be glad to know that no changes need to be made to any of your CSS files.</p>
+    </body>
+</html>
+EOF

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails-footnotes
 version: !ruby/object:Gem::Version
-  version: 4.1.5
+  version: 5.0.0
 platform: ruby
 authors:
 - Roman V. Babenko
@@ -9,70 +9,46 @@ authors:
 - Keenan Brock
 - Duane Johnson
 - Adrien Siami
-autorequire: 
+- André Arko
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2015-02-04 00:00:00.000000000 Z
+date: 2021-08-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '3.2'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '3.2'
-- !ruby/object:Gem::Dependency
-  name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.14.0
-  type: :development
+        version: '6.0'
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.14.0
-- !ruby/object:Gem::Dependency
-  name: capybara
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
+        version: '6.0'
 description: Every Rails page has footnotes that gives information about your application
   and links back to your editor.
 email:
-- romanvbabenko@gmail.com
+- andre@arko.net
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/ci.yml"
 - ".gitignore"
 - ".rspec.example"
-- ".travis.yml"
 - CHANGELOG
 - Gemfile
+- Gemfile.lock
 - MIT-LICENSE
 - README.rdoc
 - Rakefile
-- gemfiles/Gemfile.rails-3.2.x
+- bin/rake
+- bin/rspec
+- gemfiles/Gemfile.rails-3.2.22
 - gemfiles/Gemfile.rails-4.0.x
 - gemfiles/Gemfile.rails-4.1.x
 - gemfiles/Gemfile.rails-4.2.x
@@ -103,8 +79,17 @@ files:
 - lib/rails-footnotes/notes/stylesheets_note.rb
 - lib/rails-footnotes/notes/view_note.rb
 - lib/rails-footnotes/version.rb
+- lib/rails6-footnotes.rb
 - rails-footnotes.gemspec
 - spec/abstract_note_spec.rb
+- spec/app/assets/config/manifest.js
+- spec/app/assets/javascripts/foobar.js
+- spec/app/assets/stylesheets/foobar.css
+- spec/app/views/files/index.html.erb
+- spec/app/views/layouts/application.html.erb
+- spec/app/views/partials/_foo.html.erb
+- spec/app/views/partials/index.html.erb
+- spec/controllers/files_note_controller_spec.rb
 - spec/controllers/footnotes_controller_spec.rb
 - spec/controllers/log_note_controller_spec.rb
 - spec/controllers/partials_note_controller_spec.rb
@@ -116,35 +101,41 @@ files:
 - spec/notes/files_note_spec.rb
 - spec/notes/javascripts_note_spec.rb
 - spec/notes/stylesheets_note_spec.rb
+- spec/notes/view_note_spec.rb
 - spec/spec_helper.rb
-- spec/views/partials/_foo.html.erb
-- spec/views/partials/index.html.erb
-homepage: http://github.com/josevalim/rails-footnotes
+homepage: http://github.com/indirect/rails-footnotes
 licenses: []
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - "~>"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '3.0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: rails-footnotes
-rubygems_version: 2.4.5
-signing_key: 
+rubygems_version: 3.2.23
+signing_key:
 specification_version: 4
 summary: Every Rails page has footnotes that gives information about your application
   and links back to your editor.
 test_files:
 - spec/abstract_note_spec.rb
+- spec/app/assets/config/manifest.js
+- spec/app/assets/javascripts/foobar.js
+- spec/app/assets/stylesheets/foobar.css
+- spec/app/views/files/index.html.erb
+- spec/app/views/layouts/application.html.erb
+- spec/app/views/partials/_foo.html.erb
+- spec/app/views/partials/index.html.erb
+- spec/controllers/files_note_controller_spec.rb
 - spec/controllers/footnotes_controller_spec.rb
 - spec/controllers/log_note_controller_spec.rb
 - spec/controllers/partials_note_controller_spec.rb
@@ -156,6 +147,5 @@ test_files:
 - spec/notes/files_note_spec.rb
 - spec/notes/javascripts_note_spec.rb
 - spec/notes/stylesheets_note_spec.rb
+- spec/notes/view_note_spec.rb
 - spec/spec_helper.rb
-- spec/views/partials/_foo.html.erb
-- spec/views/partials/index.html.erb

data/.travis.yml

@@ -1,14 +0,0 @@
-script: "bundle exec rake spec"
-rvm:
-  - 1.9.3
-  - 2.0.0
-  - 2.1.1
-gemfile:
-  - gemfiles/Gemfile.rails-3.2.x
-  - gemfiles/Gemfile.rails-4.0.x
-  - gemfiles/Gemfile.rails-4.1.x
-  - gemfiles/Gemfile.rails-4.2.x
-  - gemfiles/Gemfile.rails-edge
-matrix:
-  allow_failures:
-    - gemfile: gemfiles/Gemfile.rails-edge