rails-footnotes 4.1.3 → 4.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 30f78c7266a4f4e1ec31ead76bdfa0df95f83759
-  data.tar.gz: 87c90a35321e12cb18fcc551450038d2e2c83de2
+  metadata.gz: 803d3d85a6d449ddde04bfe4d17245c7dfb7a2e5
+  data.tar.gz: 40c0a64bf8f12a66a2354c13d887d72e5299e6ec
 SHA512:
-  metadata.gz: 676ba9d1a928b9abc18a5eba12d3fd58aba70793120659944b39e3fc10db6cb88749a8b0e2eb85d10c736c5b8ccdb646ebae26d844b1e9c77627d35d39ae377c
-  data.tar.gz: 8d88e8d16638d10a8610adcd5e40d3e647664be877cbc0745da8f9b752a330d1ef1e39b62453d175a452e346d355fb765f316accb074948c04d45e898e3ab268
+  metadata.gz: d12c0a1fbf3126730c738ecd3da4cc4051c8af71c6da82b78523d55f7ddab3680e80ec54dc48a62b8642cf1322e16b575543e7210929f23dfc69623a4c871027
+  data.tar.gz: 6e791ef289186ce48faaa7f4d4c821c2dbb0f766ae1cfb12862cc04d0f38cd9c82cd00b949ee92db0f0ed39d4c9e725edadf5b13d35fc0134430b0ab00694adb

data/CHANGELOG

@@ -1,3 +1,5 @@
+== Footnotes v4.1.4 ==
+  * Allow to click on links if filenames contain special chars
 == Footnotes v4.1.3 ==
   * Improve fix done in 4.1.2 that broke support with rails 3 (thanks kirikiriyamama)
 == Footnotes v4.1.2 ==

data/lib/rails-footnotes/filter.rb

@@ -47,6 +47,8 @@ module Footnotes
         if args.empty?
           @@prefix
         else
+          args.map! { |arg| URI.escape(arg.to_s) }
+
           if @@prefix.respond_to? :call
             @@prefix.call *args
           else

data/lib/rails-footnotes/version.rb

@@ -1,3 +1,3 @@
 module Footnotes
-  VERSION = "4.1.3"
+  VERSION = "4.1.4"
 end

data/spec/footnotes_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require "spec_helper"
 require 'action_controller'
 require 'action_controller/test_case'
@@ -16,6 +18,12 @@ module Footnotes::Notes
   class NoteXNote < TestNote; end
   class NoteYNote < TestNote; end
   class NoteZNote < TestNote; end
+
+  class FileURINote < TestNote
+    def link
+      "/example/local file path/with-special-chars/öäü/file"
+    end
+  end
 end
 
 describe "Footnotes" do
@@ -61,6 +69,12 @@ describe "Footnotes" do
     @controller.response_body.should_not == HTML_DOCUMENT
   end
 
+  it "should escape links with special chars" do
+    note_with_link = Footnotes::Notes::FileURINote.new
+    link = Footnotes::Filter.prefix(note_with_link.link, 1, 1, 1)
+    link.should eql "txmt://open?url=file:///example/local%20file%20path/with-special-chars/%C3%B6%C3%A4%C3%BC/file&amp;line=1&amp;column=1"
+  end
+
   specify "footnotes_not_included_when_request_is_xhr" do
     @controller.request.env['HTTP_X_REQUESTED_WITH'] = 'XMLHttpRequest'
     @controller.request.env['HTTP_ACCEPT'] = 'text/javascript, text/html, application/xml, text/xml, */*'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails-footnotes
 version: !ruby/object:Gem::Version
-  version: 4.1.3
+  version: 4.1.4
 platform: ruby
 authors:
 - Roman V. Babenko
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-06 00:00:00.000000000 Z
+date: 2014-11-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails