rails-footnotes 3.7.5.rc4 → 3.7.5

data/Gemfile

@@ -1,12 +1,14 @@
 source "http://rubygems.org"
 
-# Specify your gem's dependencies in mcutter.gemspec
 gemspec
 
 # gem "rails", ">= 3.0.5"
-#
-if RUBY_PLATFORM =~ /darwin/
-  group :test do
-    gem 'simplecov', '>= 0.4.0', :require => false
+
+group :test do
+  if RUBY_VERSION > "1.9.0"
+    # gem 'simplecov', '>= 0.4.0', :require => false
+  else
+    # gem "rcov"
+    gem "ruby-debug"
   end
 end

data/README.rdoc

@@ -17,11 +17,11 @@ Install Rails Footnotes is very easy.
 
 === Rails 3.x
 
-   gem 'rails-footnotes', '>= 3.7', :group => :development
+   gem 'rails-footnotes', '>= 3.7.5.rc4', :group => :development
 
 After you install RailsFootnotes and add it to your Gemfile, you need to run the generator:
 
-  rails generate rails_footnotese:install
+  rails generate rails_footnotes:install
 
 === Rails 2.x
 

data/lib/rails-footnotes/abstract_note.rb

@@ -145,7 +145,6 @@ module Footnotes
           return '' if array.empty?
 
           header = header.collect{|i| escape(i.to_s.humanize) }
-#          array = array.collect { |a| a.collect { |b| c = b.to_s; escape(c) unless c == ""}}
           rows = array.collect{|i| "<tr><td>#{i.join('</td><td>')}</td></tr>" }
 
           <<-TABLE

data/lib/rails-footnotes/notes/assigns_note.rb

@@ -26,28 +26,20 @@ module Footnotes
       end
 
       def valid?
-        assigns
+        assigns.present?
       end
 
       def content
-        rows = []
-        assigns.each do |key|
-          rows << [ key, escape(assigned_value(key)) ]
-        end
-        mount_table(rows.unshift(['Name', 'Value']), :class => 'name_values', :summary => "Debug information for #{title}")
+        mount_table(to_table, :summary => "Debug information for #{title}")
       end
 
       protected
+        def to_table
+          @to_table ||= assigns.inject([]) {|rr, var| rr << [var, escape(assigned_value(var))]}.unshift(['Name', 'Value'])
+        end
 
         def assigns
-          assign = []
-          ignored = @@ignored_assigns
-
-          @controller.instance_variables.each {|x| assign << x.intern }
-          @controller.protected_instance_variables.each {|x| ignored << x.intern } if @controller.respond_to? :protected_instance_variables
-
-          assign -= ignored
-          return assign
+          @assigns ||= @controller.instance_variables.map {|v| v.to_sym} - ignored_assigns
         end
 
         def assigned_value(key)

data/lib/rails-footnotes/version.rb

@@ -1,3 +1,3 @@
 module Footnotes
-  VERSION = "3.7.5.rc4"
+  VERSION = "3.7.5"
 end

data/spec/footnotes_spec.rb

@@ -23,7 +23,7 @@ describe "Footnotes" do
     @controller.template = Object.new
     @controller.request = ActionController::TestRequest.new
     @controller.response = ActionController::TestResponse.new
-    @controller.response_body = $html.dup
+    @controller.response_body = HTML.dup
     @controller.params = {}
 
     Footnotes::Filter.notes = [ :test ]
@@ -36,33 +36,36 @@ describe "Footnotes" do
     index.should eql 334
   end
 
-  it "foonotes_included" do
-    footnotes_perform!
-    @controller.response_body.should_not eql $html
+  #TODO doe's not pased with 1.8.7
+  if RUBY_VERSION >= '1.9.0'
+    it "foonotes_included" do
+      footnotes_perform!
+      @controller.response_body.should_not == HTML
+    end
   end
 
   specify "footnotes_not_included_when_request_is_xhr" do
     @controller.request.env['HTTP_X_REQUESTED_WITH'] = 'XMLHttpRequest'
     @controller.request.env['HTTP_ACCEPT'] = 'text/javascript, text/html, application/xml, text/xml, */*'
     footnotes_perform!
-    @controller.response.body.should eql $html
+    @controller.response.body.should eql HTML
   end
 
   specify "footnotes_not_included_when_content_type_is_javascript" do
     @controller.response.headers['Content-Type'] = 'text/javascript'
     footnotes_perform!
-    @controller.response.body.should eql $html
+    @controller.response.body.should eql HTML
   end
 
   specify "footnotes_included_when_content_type_is_html" do
     @controller.response.headers['Content-Type'] = 'text/html'
     footnotes_perform!
-    @controller.response.body.should_not eql $html
+    @controller.response.body.should_not eql HTML
   end
 
   specify "footnotes_included_when_content_type_is_nil" do
     footnotes_perform!
-    @controller.response.body.should_not eql $html
+    @controller.response.body.should_not eql HTML
   end
 
   specify "not_included_when_body_is_not_a_string" do
@@ -195,7 +198,7 @@ describe "Footnotes" do
     end
   end
 
-$html = <<HTML
+HTML = <<EOF
 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
 <html>
     <head>
@@ -210,6 +213,6 @@ $html = <<HTML
         <p>You will be glad to know that no changes need to be made to any of your CSS files.</p>
     </body>
 </html>
-HTML
+EOF
 
 end

data/spec/notes/assigns_note_spec.rb

@@ -2,23 +2,32 @@ require "spec_helper"
 require 'action_controller'
 require "rails-footnotes/notes/assigns_note"
 
-class FootnotesController < ActionController::Base
-end
-
 describe Footnotes::Notes::AssignsNote do
   let(:note) do
-    @controller = FootnotesController.new
+    @controller = mock
+    @controller.stub(:instance_variables).and_return([:@action_has_layout, :@_status])
+    @controller.instance_variable_set(:@action_has_layout, true)
+    @controller.instance_variable_set(:@_status, 200)
     Footnotes::Notes::AssignsNote.new(@controller)
   end
   subject {note}
 
   before(:each) {Footnotes::Notes::AssignsNote.ignored_assigns = []}
+
   it {should be_valid}
-  its(:title) {should eql 'Assigns (3)'}
-  specify {note.send(:assigns).should eql [:@action_has_layout, :@view_context_class, :@_status] }
+  its(:title) {should eql 'Assigns (2)'}
+
+  specify {note.send(:assigns).should eql [:@action_has_layout, :@_status]}
+  specify {note.send(:to_table).should eql [['Name', 'Value'], [:@action_has_layout, "true"], [:@_status, "200"]]}
 
   describe "Ignored Assigns" do
     before(:each) {Footnotes::Notes::AssignsNote.ignored_assigns = [:@_status]}
     it {note.send(:assigns).should_not include :@_status}
   end
+
+  it "should call #mount_table method with correct params" do
+    note.should_receive(:mount_table).with(
+      [['Name', 'Value'], [:@action_has_layout, "true"], [:@_status, "200"]], {:summary=>"Debug information for Assigns (2)"})
+    note.content
+  end
 end

data/spec/notes/files_note_spec.rb

@@ -0,0 +1,11 @@
+require 'spec_helper'
+require 'action_controller'
+require "rails-footnotes/notes/files_note"
+
+describe Footnotes::Notes::FilesNote do
+  let(:note) {Footnotes::Notes::FilesNote.new(mock('controller', :response => mock('', :body => '')))}
+  subject {note}
+
+  it {should be_valid}
+  its(:row) {should eql :edit}
+end

data/spec/notes/javascripts_note_spec.rb

@@ -2,5 +2,17 @@ require 'spec_helper'
 require "rails-footnotes/notes/javascripts_note"
 
 describe Footnotes::Notes::JavascriptsNote do
-  pending
+  let(:note) {described_class.new(mock('controller', :response => mock('body', :body => '')))}
+  subject {note}
+
+  it {should be_valid}
+
+  it "should return js links from html after #scan_text mehtod call" do
+    subject.send(:scan_text, HTML_WITH_JS).should eql ['/javascripts/all.js', '/javascripts/jquery.js']
+  end
 end
+
+HTML_WITH_JS = <<-EOF
+  <script cache="false" src="/javascripts/all.js?1315913920" type="text/javascript"></script>
+  <script cache="false" src="/javascripts/jquery.js?1315913920" type="text/javascript"></script>
+EOF

data/spec/notes/partials_notes_spec.rb

@@ -2,5 +2,8 @@ require "spec_helper"
 require "rails-footnotes/notes/partials_note"
 
 describe Footnotes::Notes::PartialsNote do
-  pending
+  let(:note) {described_class.new(mock())}
+  subject {note}
+
+  it {should be_valid}
 end

data/spec/notes/stylesheets_note_spec.rb

@@ -2,5 +2,18 @@ require 'spec_helper'
 require "rails-footnotes/notes/stylesheets_note"
 
 describe Footnotes::Notes::StylesheetsNote do
-  pending
+
+  let(:note) {described_class.new(mock('controller', :response => mock('body', :body => '')))}
+  subject {note}
+
+  it {should be_valid}
+
+  it "should return css link from html text after #scan_text call" do
+    subject.send(:scan_text, HTML_WITH_CSS).should eql ['/stylesheets/compiled/print.css', '/stylesheets/compiled/print.css']
+  end
 end
+
+HTML_WITH_CSS = <<-EOF
+  <link href="/stylesheets/compiled/print.css?1315913920" media="print" rel="stylesheet" type="text/css" />'
+  '<link href="/stylesheets/compiled/print.css?1315913920" media="print" rel="stylesheet" type="text/css" />'
+EOF

data/spec/spec_helper.rb

@@ -1,5 +1,8 @@
-require 'simplecov'
-SimpleCov.start
+begin
+  require 'simplecov'
+  SimpleCov.start
+rescue LoadError
+end
 
 require 'rubygems'
 

metadata

@@ -1,68 +1,92 @@
---- !ruby/object:Gem::Specification
+--- !ruby/object:Gem::Specification 
 name: rails-footnotes
-version: !ruby/object:Gem::Version
-  version: 3.7.5.rc4
-  prerelease: 6
+version: !ruby/object:Gem::Version 
+  hash: 17
+  prerelease: 
+  segments: 
+  - 3
+  - 7
+  - 5
+  version: 3.7.5
 platform: ruby
-authors:
+authors: 
 - Keenan Brock
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-09-10 00:00:00.000000000Z
-dependencies:
-- !ruby/object:Gem::Dependency
+
+date: 2011-09-30 00:00:00 Z
+dependencies: 
+- !ruby/object:Gem::Dependency 
   name: rails
-  requirement: &2157023740 !ruby/object:Gem::Requirement
+  prerelease: false
+  requirement: &id001 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 7
+        segments: 
+        - 3
+        - 0
+        - 0
         version: 3.0.0
   type: :runtime
-  prerelease: false
-  version_requirements: *2157023740
-- !ruby/object:Gem::Dependency
+  version_requirements: *id001
+- !ruby/object:Gem::Dependency 
   name: rails
-  requirement: &2157023120 !ruby/object:Gem::Requirement
+  prerelease: false
+  requirement: &id002 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 7
+        segments: 
+        - 3
+        - 0
+        - 0
         version: 3.0.0
   type: :development
-  prerelease: false
-  version_requirements: *2157023120
-- !ruby/object:Gem::Dependency
+  version_requirements: *id002
+- !ruby/object:Gem::Dependency 
   name: rspec
-  requirement: &2157022740 !ruby/object:Gem::Requirement
+  prerelease: false
+  requirement: &id003 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
   type: :development
-  prerelease: false
-  version_requirements: *2157022740
-- !ruby/object:Gem::Dependency
+  version_requirements: *id003
+- !ruby/object:Gem::Dependency 
   name: watchr
-  requirement: &2157022180 !ruby/object:Gem::Requirement
+  prerelease: false
+  requirement: &id004 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
   type: :development
-  prerelease: false
-  version_requirements: *2157022180
-description: Every Rails page has footnotes that gives information about your application
-  and links back to your editor.
-email:
+  version_requirements: *id004
+description: Every Rails page has footnotes that gives information about your application and links back to your editor.
+email: 
 - keenan@thebrocks.net
 executables: []
+
 extensions: []
+
 extra_rdoc_files: []
-files:
+
+files: 
 - .gitignore
 - .rspec.example
 - .watchr.example
@@ -102,39 +126,49 @@ files:
 - spec/abstract_note_spec.rb
 - spec/footnotes_spec.rb
 - spec/notes/assigns_note_spec.rb
+- spec/notes/files_note_spec.rb
 - spec/notes/javascripts_note_spec.rb
 - spec/notes/partials_notes_spec.rb
 - spec/notes/stylesheets_note_spec.rb
 - spec/spec_helper.rb
 homepage: http://github.com/josevalim/rails-footnotes
 licenses: []
+
 post_install_message: 
 rdoc_options: []
-require_paths:
+
+require_paths: 
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement
+required_ruby_version: !ruby/object:Gem::Requirement 
   none: false
-  requirements:
-  - - ! '>='
-    - !ruby/object:Gem::Version
-      version: '0'
-required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
+      - 0
+      version: "0"
+required_rubygems_version: !ruby/object:Gem::Requirement 
   none: false
-  requirements:
-  - - ! '>'
-    - !ruby/object:Gem::Version
-      version: 1.3.1
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
+      - 0
+      version: "0"
 requirements: []
+
 rubyforge_project: rails-footnotes
-rubygems_version: 1.8.5
+rubygems_version: 1.8.10
 signing_key: 
 specification_version: 3
-summary: Every Rails page has footnotes that gives information about your application
-  and links back to your editor.
-test_files:
+summary: Every Rails page has footnotes that gives information about your application and links back to your editor.
+test_files: 
 - spec/abstract_note_spec.rb
 - spec/footnotes_spec.rb
 - spec/notes/assigns_note_spec.rb
+- spec/notes/files_note_spec.rb
 - spec/notes/javascripts_note_spec.rb
 - spec/notes/partials_notes_spec.rb
 - spec/notes/stylesheets_note_spec.rb