rails-dom-testing 1.0.5 → 1.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6a29feb41b5ab1bec20c3f358c1ff848f66db985
-  data.tar.gz: beaf92796b4e2d31e4e4b58515f48e8ba400344a
+  metadata.gz: 724b5c435bae94b76380a61fac570c5092c3d81f
+  data.tar.gz: 540c6659e6b2589084adedba5b712c94de84ac4e
 SHA512:
-  metadata.gz: 823c8ce6237dd7a47600be8275a615243a887aa2e5d20bcfe5d527d189467fadb274783907645f49426132cce513f6e945c0b2bd38f386ffcd570851f75d7b70
-  data.tar.gz: ca1f844b515eb7de1d6201bf0341abe212b5a1502adf02d13c0051d44da5821302e920f8d8ce25f5c77ec047dc1c9f1b5c75bf7d6d51a370c1354ac47c0a48fd
+  metadata.gz: fc1af6fd6f6b348867bed35bd3f01644085880958de07eb73964db9f4ce36ec2868a6e68602724db40893fac95f516f8dda7d07b82be8f6cc02761e54e47e46a
+  data.tar.gz: e4d7320a4af4d767149ecb4e0f29753c913fe92fa0fd30253dfb0212b5968b5417062a2ffa682aae8da3745ab2ee37bfd89ef085747e2e3562378a6f245a0d28

data/README.md

@@ -6,6 +6,15 @@ Doms are compared via `assert_dom_equal` and `assert_dom_not_equal`.
 Elements are asserted via `assert_select`, `assert_select_encoded`, `assert_select_email` and a subset of the dom can be selected with `css_select`.
 The gem is developed for Rails 4.2 and above, and will not work on previous versions.
 
+## Deprecation warnings when upgrading to Rails 4.2:
+
+Nokogiri is slightly more strict about the format of css selectors than the previous implementation. That's why you have warnings like:
+
+```
+DEPRECATION WARNING: The assertion was not run because of an invalid css selector.
+```
+
+Check the 4.2 release notes [section on `assert_select`](http://edgeguides.rubyonrails.org/4_2_release_notes.html#assert-select) for help.
 
 ## Installation
 

data/lib/rails/dom/testing/assertions/selector_assertions/substitution_context.rb

@@ -1,27 +1,21 @@
 class SubstitutionContext
   def initialize
     @substitute = '?'
-    @regexes = []
   end
 
   def substitute!(selector, values)
     while !values.empty? && substitutable?(values.first) && selector.index(@substitute)
-      selector.sub! @substitute, substitution_id_for(values.shift)
+      selector.sub! @substitute, matcher_for(values.shift)
     end
   end
 
-  def match(matches, attribute, substitution_id)
-    matches.find_all { |node| node[attribute] =~ @regexes[substitution_id] }
+  def match(matches, attribute, matcher)
+    matches.find_all { |node| node[attribute] =~ Regexp.new(matcher) }
   end
 
   private
-    def substitution_id_for(value)
-      if value.is_a?(Regexp)
-        @regexes << value
-        @regexes.size - 1
-      else
-        value
-      end.inspect # Nokogiri doesn't like arbitrary values without quotes, hence inspect.
+    def matcher_for(value)
+      value.to_s.inspect # Nokogiri doesn't like arbitrary values without quotes, hence inspect.
     end
 
     def substitutable?(value)

data/lib/rails/dom/testing/version.rb

@@ -1,7 +1,7 @@
 module Rails
   module Dom
     module Testing
-      VERSION = "1.0.5"
+      VERSION = "1.0.6"
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails-dom-testing
 version: !ruby/object:Gem::Version
-  version: 1.0.5
+  version: 1.0.6
 platform: ruby
 authors:
 - Rafael Mendonça França
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-25 00:00:00.000000000 Z
+date: 2015-03-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -101,7 +101,8 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: " Dom and Selector assertions for Rails applications "
+description: " This gem can compare doms and assert certain elements exists in doms
+  using Nokogiri. "
 email:
 - rafaelmfranca@gmail.com
 - kaspth@gmail.com
@@ -124,7 +125,7 @@ files:
 - test/selector_assertions_test.rb
 - test/tag_assertions_test.rb
 - test/test_helper.rb
-homepage: https://github.com/kaspth/rails-dom-testing
+homepage: https://github.com/rails/rails-dom-testing
 licenses:
 - MIT
 metadata: {}
@@ -144,11 +145,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
-summary: This gem can compare doms and assert certain elements exists in doms using
-  Nokogiri.
+summary: Dom and Selector assertions for Rails applications
 test_files:
 - test/dom_assertions_test.rb
 - test/selector_assertions_test.rb