rails-contact 0.1.1 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3f8cf546cda0f081e8da876f17377f8d71f384c41c868cfda1d19af009c6fd63
-  data.tar.gz: 307ce9285a133f372d09aa503235620ab669a6ef94a60cbdd132486dc3086cc5
+  metadata.gz: 96bbf7fb23c7f016bf4ca07ef9713a0f2412f1236efeb11b20d978f3e8c809cc
+  data.tar.gz: c16b7c6f1258b827468f1f816b67bfe6bb77ad7e7fc2ceafb36a5197b5923bfe
 SHA512:
-  metadata.gz: 721d2f5d8a7b111d6139069bd9af461278e385dca6080fbed28521fc582ba9ad8a4ecee3f1d4b6f5f9bae241ce94f22a18f61757b16aa290ec9c1bd6e495dec1
-  data.tar.gz: 15b1587cd03cdc1b5d090b7f972c2c2d84e9313d7f7ae07e070d86bf14bbcd630ed4fb1e390d2a92cc164a5564663edbc59e4a296616195478053b53bb14047d
+  metadata.gz: c97455fedc7043f89e3a3ffcb5ebcc38a80d68ef597df76b2c4a25fb506c76d2c6e1dd577ffb071b4c4cd6df5de3f5c773b7ce5fad8bdcb51b9b72468293c4de
+  data.tar.gz: a16a9da2acbccebe3aaeac7371c5023f511278b6c8f88a2f5b629b8d2aada0336b5e68b2f327bd53c0f8844d99b5a22fb05f6cb754e46d9fe8fc1f188df17db0

data/.github/workflows/ci.yml

@@ -61,5 +61,5 @@ jobs:
           bundler-cache: true
 
       - name: Run tests
-        run: bundle exec ruby -Itest -e 'Dir["test/**/*_test.rb"].sort.each { |f| require File.expand_path(f) }'
+        run: bundle exec rspec --format progress
 

data/.rspec

@@ -0,0 +1,2 @@
+--require spec_helper
+--format documentation

data/CHANGELOG.md

@@ -1,5 +1,19 @@
 # Changelog
 
+## 0.1.3
+
+- Flatten view partial paths under `app/views/rails/contact` and remove legacy `contacts/` partial nesting.
+- Add `.gitignore` to keep generated artifacts (including `coverage/`) out of release commits.
+- Update packaging/docs metadata for smoother RubyGems release workflow.
+
+## 0.1.2
+
+- Breaking parity-focused rewrite foundation for richer Google-like contacts.
+- Added label, website, event, merge, and bulk-delete capabilities.
+- Added dynamic nested field add/remove behavior for multi-value rows.
+- Introduced RSpec suite with SimpleCov gates (100% line/branch in tracked critical files).
+- Added parity matrix, roadmap, and migration documentation.
+
 ## 0.1.1
 
 - Fix mounted route shape to avoid `/contacts/contacts` duplication.

data/Gemfile

@@ -11,6 +11,9 @@ gem "minitest-reporters"
 gem "mocha"
 gem "webmock"
 gem "parallel", "~> 1.26.0"
+gem "rspec-rails", "~> 8.0"
+gem "factory_bot"
+gem "simplecov", require: false
 
 # Omakase Ruby styling [https://github.com/rails/rubocop-rails-omakase/]
 gem "rubocop-rails-omakase", require: false

data/README.md

@@ -1,70 +1,113 @@
 # rails-contact
 
-`rails-contact` is a mountable Rails engine to manage contacts in your app, with optional Elasticsearch search and Google Contacts sync.
+`rails-contact` is a mountable Rails engine for Google-Contacts-style contact management.
 
-## What you get
+It provides:
 
-- Contact CRUD screens and controller
-- Local contact schema (emails, phones, addresses)
-- CSV importer
-- Elasticsearch search backend (with DB fallback)
-- Google sync service scaffolding
-- Install, migration, view, and controller generators
+- rich contact profile fields
+- multi-value contact methods (emails/phones/addresses/websites/events)
+- labels/tags
+- dynamic add/remove nested rows
+- Elasticsearch-backed search with DB fallback
+- CSV import and Google sync scaffolding
+- merge and bulk-delete operations
+- Devise-style override generators
 
-## 1) Install the gem
+---
+
+## Quickstart
+
+### 1) Add gem
 
 ```ruby
-gem "rails-contact"
+gem "rails-contact", "~> 0.1.3"
 ```
 
 ```bash
 bundle install
 ```
 
-## 2) Run generators
+### 2) Install and generate schema
 
 ```bash
 rails generate rails:contact:install
 rails generate rails:contact:contact Contact
+rails db:migrate
+```
+
+### 3) Mount engine routes
+
+```ruby
+rails_contact_for :contacts
+```
+
+or explicit mount:
+
+```ruby
+mount Rails::Contact::Engine => "/contacts", as: "rails_contact"
 ```
 
-Optional override generators (Devise-style customization):
+`rails_contact_for :contact` is auto-normalized to `/contacts`.
+
+### 4) Visit UI
+
+- `/contacts`
+- `/contacts/new`
+- `/contacts/:id`
+
+---
+
+## Generators
 
 ```bash
+rails generate rails:contact:install
+rails generate rails:contact:contact Contact
 rails generate rails:contact:views
 rails generate rails:contact:controllers
 ```
 
-Then migrate:
+- `views` copies templates so host apps can customize UI.
+- `controllers` copies an override-ready contacts controller.
 
-```bash
-rails db:migrate
-```
+---
 
-## 3) Mount routes (clean paths)
+## Feature map
 
-Use either:
+### Core profile fields
 
-```ruby
-mount Rails::Contact::Engine => "/contacts", as: "rails_contact"
-```
+- Prefix, first, middle, last, suffix, nickname
+- Company, job title, department
+- Labels (comma-separated input)
+- Notes and metadata
+- Starred flag
+- Photo URL
 
-or:
+### Multi-value sections (dynamic)
 
-```ruby
-rails_contact_for :contacts
-```
+- Emails
+- Phones
+- Addresses
+- Websites
+- Events (birthday/custom)
 
-With this setup, paths are:
-- `/contacts` (index)
-- `/contacts/new`
-- `/contacts/:id`
+Rows can be added/removed dynamically in form UI.
+
+### List/search
 
-No `/contacts/contacts` duplication.
+- Search by name/email/phone/company/job title/labels
+- Filter by city/region/sync/starred
+- Sort by recent updates
 
-## 4) Configure
+### Actions
 
-Generated initializer: `config/initializers/rails_contact.rb`
+- Bulk delete selected contacts
+- Merge source contact into target contact
+
+---
+
+## Configuration
+
+Initializer: `config/initializers/rails_contact.rb`
 
 ```ruby
 Rails::Contact.configure do |config|
@@ -73,26 +116,38 @@ Rails::Contact.configure do |config|
   config.google_sync_enabled = false
   config.google_max_contacts = 25_000
   config.rolling_window_sort = :updated_at
+  config.default_per_page = 25
 end
 ```
 
-## CSV import
+---
+
+## Rake tasks
 
 ```bash
+rake rails_contact:reindex
+rake rails_contact:sync_google
 rake rails_contact:import_csv CSV_PATH=/absolute/path/to/eq.csv
 ```
 
-## Utility tasks
+---
 
-- `rake rails_contact:reindex`
-- `rake rails_contact:sync_google`
+## Testing and coverage
 
-## Test
+RSpec is the primary framework.
 
 ```bash
-bundle exec ruby -Itest -e 'Dir["test/**/*_test.rb"].sort.each { |f| require File.expand_path(f) }'
+bundle exec rspec
 ```
 
+Coverage is enforced with SimpleCov:
+
+- 100% line coverage target
+- 100% branch coverage target
+- CI fails below thresholds
+
+---
+
 ## Release
 
 ```bash
@@ -100,4 +155,13 @@ bundle exec rake build
 bundle exec rake release
 ```
 
-RubyGems MFA is required.
+RubyGems MFA is required for push.
+
+---
+
+## Extended docs
+
+- `docs/parity_matrix.md`
+- `docs/product_decisions.md`
+- `docs/roadmap.md`
+- `docs/migration_guide.md`

data/app/assets/javascripts/rails/contact/application.js

@@ -0,0 +1 @@
+//= require rails/contact/nested_fields

data/app/assets/javascripts/rails/contact/nested_fields.js

@@ -0,0 +1,46 @@
+(() => {
+  function addRow(event) {
+    const button = event.target.closest("[data-add-nested]");
+    if (!button) return;
+
+    const wrapper = button.closest("[data-nested-wrapper]");
+    const targetSelector = button.dataset.target;
+    const templateSelector = button.dataset.template;
+    if (!wrapper || !targetSelector || !templateSelector) return;
+
+    const container = wrapper.querySelector(targetSelector);
+    const template = wrapper.querySelector(templateSelector);
+    if (!container || !template) return;
+
+    const uniqueId = String(Date.now() + Math.floor(Math.random() * 1000));
+    const html = template.innerHTML.replace(/NEW_RECORD/g, uniqueId);
+    container.insertAdjacentHTML("beforeend", html);
+  }
+
+  function removeRow(event) {
+    const button = event.target.closest("[data-action='nested-fields#remove']");
+    if (!button) return;
+    const row = button.closest("[data-nested-fields-target='row']");
+    if (!row) return;
+
+    const destroyField = row.querySelector("[data-nested-fields-target='destroyField']");
+    if (destroyField) {
+      destroyField.value = "1";
+      row.style.display = "none";
+    } else {
+      row.remove();
+    }
+  }
+
+  document.addEventListener("click", (event) => {
+    if (event.target.closest("[data-add-nested]")) {
+      event.preventDefault();
+      addRow(event);
+      return;
+    }
+    if (event.target.closest("[data-action='nested-fields#remove']")) {
+      event.preventDefault();
+      removeRow(event);
+    }
+  });
+})();

data/app/controllers/concerns/rails/contact/filterable.rb

@@ -0,0 +1,11 @@
+module Rails
+  module Contact
+    module Filterable
+      private
+
+      def normalized_filters(params)
+        params.to_h.compact_blank
+      end
+    end
+  end
+end

data/app/controllers/rails/contact/contacts_controller.rb

@@ -1,38 +1,51 @@
 module Rails
   module Contact
     class ContactsController < ApplicationController
+      include Rails::Contact::Filterable
+      METADATA_KEYS = %w[
+        prefix middle_name suffix nickname company job_title department website birthday notes
+      ].freeze
+
       before_action :set_contact, only: [ :show, :edit, :update, :destroy ]
 
       def index
         @query = params[:q].to_s.strip
-        @contacts = Search::Query.new(@query, filters: filter_params).call
+        @contacts = Search::Query.new(@query, filters: normalized_filters(filter_params)).call
+        render "rails/contact/index"
       end
 
-      def show; end
+      def show
+        render "rails/contact/show"
+      end
 
       def new
         @contact = Contact.new
         build_default_associations
+        render "rails/contact/new"
       end
 
-      def edit; end
+      def edit
+        render "rails/contact/edit"
+      end
 
       def create
         @contact = Contact.new(contact_params)
+        assign_labels(@contact)
         if @contact.save
           enqueue_index(@contact.id)
           redirect_to contact_path(@contact), notice: "Contact created."
         else
-          render :new, status: :unprocessable_entity
+          render "rails/contact/new", status: :unprocessable_entity
         end
       end
 
       def update
+        assign_labels(@contact)
         if @contact.update(contact_params)
           enqueue_index(@contact.id)
           redirect_to contact_path(@contact), notice: "Contact updated."
         else
-          render :edit, status: :unprocessable_entity
+          render "rails/contact/edit", status: :unprocessable_entity
         end
       end
 
@@ -43,6 +56,21 @@ module Rails
         redirect_to contacts_path, notice: "Contact deleted."
       end
 
+      def bulk_destroy
+        ids = params[:ids].to_s.split(",").map(&:to_i).reject(&:zero?).uniq
+        Contact.where(id: ids).find_each(&:destroy!)
+        redirect_to contacts_path, notice: "#{ids.size} contact(s) deleted."
+      end
+
+      def merge
+        source_id = params[:source_id]
+        target_id = params[:target_id]
+        MergeContactsService.new(source_id: source_id, target_id: target_id).call
+        redirect_to contact_path(target_id), notice: "Contacts merged."
+      rescue StandardError => e
+        redirect_to contacts_path, alert: "Merge failed: #{e.message}"
+      end
+
       private
 
       def set_contact
@@ -51,16 +79,24 @@ module Rails
       end
 
       def contact_params
-        params.require(:contact).permit(
-          :given_name, :family_name, :current_city, :departure_city, :region_name, :biography, :sync_eligible,
+        permitted = params.require(:contact).permit(
+          :given_name, :family_name, :current_city, :departure_city, :region_name, :biography, :sync_eligible, :starred, :photo_url,
+          :labels_csv,
+          metadata: {},
           emails_attributes: [ :id, :value, :label, :primary, :_destroy ],
           phones_attributes: [ :id, :value, :label, :primary, :_destroy ],
-          addresses_attributes: [ :id, :city, :departure_city, :formatted_value, :label, :_destroy ]
+          addresses_attributes: [ :id, :city, :departure_city, :formatted_value, :label, :_destroy ],
+          websites_attributes: [ :id, :url, :label, :_destroy ],
+          events_attributes: [ :id, :event_type, :event_date, :label, :_destroy ]
         )
+
+        metadata = permitted[:metadata].is_a?(ActionController::Parameters) ? permitted[:metadata].to_h : {}
+        permitted[:metadata] = metadata.slice(*METADATA_KEYS)
+        permitted
       end
 
       def filter_params
-        params.permit(:city, :region, :sync_eligible)
+        params.permit(:city, :region, :sync_eligible, :starred)
       end
 
       def enqueue_index(contact_id)
@@ -68,9 +104,17 @@ module Rails
       end
 
       def build_default_associations
-        @contact.emails.build if @contact.emails.empty?
-        @contact.phones.build if @contact.phones.empty?
+        @contact.emails.build(label: "work") while @contact.emails.size < 2
+        @contact.phones.build(label: "mobile") while @contact.phones.size < 2
         @contact.addresses.build if @contact.addresses.empty?
+        @contact.websites.build(label: "profile") if @contact.websites.empty?
+        @contact.events.build(event_type: "birthday") if @contact.events.empty?
+      end
+
+      def assign_labels(contact)
+        return unless params.dig(:contact, :labels_csv).present?
+
+        contact.set_labels_from_csv!(params.dig(:contact, :labels_csv))
       end
     end
   end

data/app/helpers/rails/contact/application_helper.rb

@@ -1,6 +1,13 @@
 module Rails
   module Contact
     module ApplicationHelper
+      def contact_initials(contact)
+        [ contact.given_name, contact.family_name ].map { |part| part.to_s.first.to_s.upcase }.join
+      end
+
+      def contact_chip(value)
+        value.presence || "-"
+      end
     end
   end
 end

data/app/models/rails/contact/contact.rb

@@ -1,13 +1,20 @@
+require "json"
+
 module Rails
   module Contact
     class Contact < ApplicationRecord
       self.table_name = "rails_contact_contacts"
+      attr_accessor :labels_csv
 
       has_many :emails, class_name: "Rails::Contact::ContactEmail", dependent: :destroy, inverse_of: :contact
       has_many :phones, class_name: "Rails::Contact::ContactPhone", dependent: :destroy, inverse_of: :contact
       has_many :addresses, class_name: "Rails::Contact::ContactAddress", dependent: :destroy, inverse_of: :contact
+      has_many :websites, class_name: "Rails::Contact::ContactWebsite", dependent: :destroy, inverse_of: :contact
+      has_many :events, class_name: "Rails::Contact::ContactEvent", dependent: :destroy, inverse_of: :contact
+      has_many :contact_labels, class_name: "Rails::Contact::ContactLabel", dependent: :destroy, inverse_of: :contact
+      has_many :labels, through: :contact_labels, source: :label
 
-      accepts_nested_attributes_for :emails, :phones, :addresses, allow_destroy: true
+      accepts_nested_attributes_for :emails, :phones, :addresses, :websites, :events, allow_destroy: true
 
       validates :given_name, presence: true
 
@@ -27,6 +34,30 @@ module Rails
       def primary_phone
         phones.find(&:primary?) || phones.first
       end
+
+      def meta(key)
+        metadata_hash[key.to_s]
+      end
+
+      def set_labels_from_csv!(csv_string)
+        names = csv_string.to_s.split(",").map(&:strip).reject(&:empty?).uniq
+        self.labels = names.map { |name| Rails::Contact::Label.find_or_create_by!(name: name) }
+      end
+
+      def labels_csv
+        labels.pluck(:name).sort.join(", ")
+      end
+
+      def metadata_hash
+        value = metadata
+        return value if value.is_a?(Hash)
+        return {} if value.blank?
+
+        parsed = JSON.parse(value)
+        parsed.is_a?(Hash) ? parsed : {}
+      rescue JSON::ParserError
+        {}
+      end
     end
   end
 end

data/app/models/rails/contact/contact_event.rb

@@ -0,0 +1,11 @@
+module Rails
+  module Contact
+    class ContactEvent < ApplicationRecord
+      self.table_name = "rails_contact_contact_events"
+
+      belongs_to :contact, class_name: "Rails::Contact::Contact", inverse_of: :events
+
+      validates :event_type, presence: true
+    end
+  end
+end

data/app/models/rails/contact/contact_label.rb

@@ -0,0 +1,12 @@
+module Rails
+  module Contact
+    class ContactLabel < ApplicationRecord
+      self.table_name = "rails_contact_contact_labels"
+
+      belongs_to :contact, class_name: "Rails::Contact::Contact", inverse_of: :contact_labels
+      belongs_to :label, class_name: "Rails::Contact::Label", inverse_of: :contact_labels
+
+      validates :label_id, uniqueness: { scope: :contact_id }
+    end
+  end
+end

data/app/models/rails/contact/contact_website.rb

@@ -0,0 +1,11 @@
+module Rails
+  module Contact
+    class ContactWebsite < ApplicationRecord
+      self.table_name = "rails_contact_contact_websites"
+
+      belongs_to :contact, class_name: "Rails::Contact::Contact", inverse_of: :websites
+
+      validates :url, presence: true
+    end
+  end
+end

data/app/models/rails/contact/label.rb

@@ -0,0 +1,20 @@
+module Rails
+  module Contact
+    class Label < ApplicationRecord
+      self.table_name = "rails_contact_labels"
+
+      has_many :contact_labels, class_name: "Rails::Contact::ContactLabel", dependent: :destroy, inverse_of: :label
+      has_many :contacts, through: :contact_labels, source: :contact
+
+      validates :name, presence: true, uniqueness: { case_sensitive: false }
+
+      before_validation :normalize_name
+
+      private
+
+      def normalize_name
+        self.name = name.to_s.strip
+      end
+    end
+  end
+end

data/app/views/layouts/rails/contact/application.html.erb

@@ -8,6 +8,7 @@
   <%= yield :head %>
 
   <%= stylesheet_link_tag    "rails/contact/application", media: "all" %>
+  <%= javascript_include_tag "rails/contact/application", defer: true %>
 </head>
 <body>
 

data/app/views/rails/contact/_address_fields.html.erb

@@ -0,0 +1,18 @@
+<div class="grid grid-cols-1 gap-3 md:grid-cols-4" data-nested-fields-target="row">
+  <%= address_fields.hidden_field :_destroy, value: 0, data: { nested_fields_target: "destroyField" } %>
+  <div>
+    <%= address_fields.label :city, "Current City", class: "mb-1 block text-sm font-medium text-gray-700" %>
+    <%= address_fields.text_field :city, class: "w-full rounded-md border border-gray-300 px-3 py-2 text-sm" %>
+  </div>
+  <div>
+    <%= address_fields.label :departure_city, "Departure City", class: "mb-1 block text-sm font-medium text-gray-700" %>
+    <%= address_fields.text_field :departure_city, class: "w-full rounded-md border border-gray-300 px-3 py-2 text-sm" %>
+  </div>
+  <div>
+    <%= address_fields.label :label, "Label", class: "mb-1 block text-sm font-medium text-gray-700" %>
+    <%= address_fields.text_field :label, class: "w-full rounded-md border border-gray-300 px-3 py-2 text-sm" %>
+  </div>
+  <div class="flex items-end">
+    <button type="button" class="rounded-md border border-gray-300 px-2 py-1 text-xs text-gray-700" data-action="nested-fields#remove">Remove</button>
+  </div>
+</div>

data/app/views/rails/contact/_email_fields.html.erb

@@ -0,0 +1,18 @@
+<div class="grid grid-cols-1 gap-3 md:grid-cols-5" data-nested-fields-target="row">
+  <%= email_fields.hidden_field :_destroy, value: 0, data: { nested_fields_target: "destroyField" } %>
+  <div class="md:col-span-3">
+    <%= email_fields.label :value, "Email", class: "mb-1 block text-sm font-medium text-gray-700" %>
+    <%= email_fields.email_field :value, class: "w-full rounded-md border border-gray-300 px-3 py-2 text-sm" %>
+  </div>
+  <div>
+    <%= email_fields.label :label, "Label", class: "mb-1 block text-sm font-medium text-gray-700" %>
+    <%= email_fields.text_field :label, class: "w-full rounded-md border border-gray-300 px-3 py-2 text-sm" %>
+  </div>
+  <div class="flex items-end gap-2">
+    <label class="inline-flex items-center gap-2 text-sm text-gray-700">
+      <%= email_fields.check_box :primary, class: "h-4 w-4 rounded border-gray-300 text-blue-600" %>
+      Primary
+    </label>
+    <button type="button" class="rounded-md border border-gray-300 px-2 py-1 text-xs text-gray-700" data-action="nested-fields#remove">Remove</button>
+  </div>
+</div>

data/app/views/rails/contact/_event_fields.html.erb

@@ -0,0 +1,18 @@
+<div class="grid grid-cols-1 gap-3 md:grid-cols-4" data-nested-fields-target="row">
+  <%= event_fields.hidden_field :_destroy, value: 0, data: { nested_fields_target: "destroyField" } %>
+  <div>
+    <%= event_fields.label :event_type, "Event Type", class: "mb-1 block text-sm font-medium text-gray-700" %>
+    <%= event_fields.text_field :event_type, class: "w-full rounded-md border border-gray-300 px-3 py-2 text-sm" %>
+  </div>
+  <div>
+    <%= event_fields.label :event_date, "Date", class: "mb-1 block text-sm font-medium text-gray-700" %>
+    <%= event_fields.date_field :event_date, class: "w-full rounded-md border border-gray-300 px-3 py-2 text-sm" %>
+  </div>
+  <div>
+    <%= event_fields.label :label, "Label", class: "mb-1 block text-sm font-medium text-gray-700" %>
+    <%= event_fields.text_field :label, class: "w-full rounded-md border border-gray-300 px-3 py-2 text-sm" %>
+  </div>
+  <div class="flex items-end">
+    <button type="button" class="rounded-md border border-gray-300 px-2 py-1 text-xs text-gray-700" data-action="nested-fields#remove">Remove</button>
+  </div>
+</div>