rails-cloud-tasks 0.0.3 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5059f50ae4598ee23d9abec5ddac5eb2e1c8d4a2023ff794b08461b8611d6d73
-  data.tar.gz: 15cb24ec98ffde490596bbdb0a1dff7145e98dcf15aadfb4a5c12093dd8dbfba
+  metadata.gz: 04d8c81b125d6c5a31fc5058b0a363615a39a5c96ae091df89a383055938b294
+  data.tar.gz: 40d5e7c7dea249786c94a3933e8d77e4baf29364bdceb3a2f4c30e652544e05e
 SHA512:
-  metadata.gz: c9076b550dfbdbb3909633ee5f262613df39efc844d06d4a6c6e9153863b18480dc70405c728999465298a7b3950a29454db4f7c5bef926b5d2330cefc7e840d
-  data.tar.gz: cab15a28e2083170c65643b7ae58bd83ac2a359b767a3bfa138d6ffc32021767c526dafe4fbf1edc3f0a53b4714ffde19d4128b95081563a70c705e7ac6bd813
+  metadata.gz: a851899a7195a2280ab19b5b9276c993c143782b7756362b48f04731dcca769db99c765f889c5c255f33c87e15255e4263de285a6c45ec4fafb02759b6037db0
+  data.tar.gz: fba16fe2a21f0466216fd1eabb901ef657e53356f33ec8e1fc005533a875ac45e1280926fa2090d2f69e03c1ab71bebbf0bd90739fa324dc70f9a257c8f705e7

data/.github/workflows/main.yaml

@@ -23,7 +23,7 @@ jobs:
         run: gem install bundler
 
       - name: Cache dependencies
-        uses: actions/cache@v1
+        uses: actions/cache@v2
         with:
           path: vendor/bundle
           key: ${{ runner.os }}-gem-${{ hashFiles('**/rails-cloud-tasks.gemspec') }}
@@ -48,7 +48,7 @@ jobs:
         run: gem install bundler
 
       - name: Cache dependencies
-        uses: actions/cache@v1
+        uses: actions/cache@v2
         with:
           path: vendor/bundle
           key: ${{ runner.os }}-gem-${{ hashFiles('**/rails-cloud-tasks.gemspec') }}
@@ -73,7 +73,7 @@ jobs:
         run: gem install bundler
 
       - name: Cache dependencies
-        uses: actions/cache@v1
+        uses: actions/cache@v2
         with:
           path: vendor/bundle
           key: ${{ runner.os }}-gem-${{ hashFiles('**/rails-cloud-tasks.gemspec') }}

data/.github/workflows/release.yml

@@ -25,7 +25,7 @@ jobs:
         run: gem install bundler
 
       - name: Cache dependencies
-        uses: actions/cache@v1
+        uses: actions/cache@v2
         with:
           path: vendor/bundle
           key: ${{ runner.os }}-gem-${{ hashFiles('**/rails-cloud-tasks.gemspec') }}-2.7
@@ -67,7 +67,7 @@ jobs:
         run: gem install bundler
 
       - name: Cache dependencies
-        uses: actions/cache@v1
+        uses: actions/cache@v2
         with:
           path: vendor/bundle
           key: ${{ runner.os }}-gem-${{ hashFiles('**/rails-cloud-tasks.gemspec') }}-2.7

data/README.md

@@ -105,23 +105,29 @@ We have support to Google Cloud Schedule. It's based on Cloud tasks, the jobs ar
 Check out the follow sample of config file:
 ```yaml
 # config/scheduler.yml
-- name: Users::SyncJob
+- name: UsersSyncJob
   schedule: 0 8 * * *
   description: Sync user data
   time_zone: "America/Los_Angeles"
+  class_name: Users::SyncJob
   args:
-    arg1: 100
-    arg2: 200
+    - this_first: argument
+      is_a: hash
+    - - this second argument
+      - is an array
+    - this third argument is a string
 ```
 
-| attribute   	| description                                                    	| required 	|
-|-------------	|----------------------------------------------------------------	|----------	|
-| name        	| The Job class namespace                                        	| ✓        	|
-| schedule    	| The frequency to run your job. It should be a unix-cron format 	| ✓        	|
-| description 	| What this job does                                             	| ✓        	|
-| time_zone   	| Choose which one timezone your job must run                    	| ✓        	|
-| args        	| What are the job's arguments                                   	| ✓        	|
+| attribute   	| description                                                    	                                                   | required 	|
+|-------------	|----------------------------------------------------------------------------------                                  |----------	|
+| name        	| Any descriptive name, following [Tasks naming restrictions][1]                                                     | ✓        	|
+| schedule    	| The frequency to run your job. It should be a unix-cron format 	                                                   | ✓        	|
+| description 	| What this job does                                             	                                                   | ✓        	|
+| time_zone   	| Choose which one timezone your job must run                    	                                                   | ✓        	|
+| args        	| Arguments to the job execution. Important: if present, this must be an array of items. Check out the example above | 𐄂          |
+| class_name    | The Job class name (including namespace)                                                                           | ✓        	|
 
+[1]: https://cloud.google.com/tasks/docs/reference/rpc/google.cloud.tasks.v2
 
 
 

data/lib/rails_cloud_tasks/rack/jobs.rb

@@ -14,13 +14,12 @@ module RailsCloudTasks
 
           request = ::Rack::Request.new(env)
           job_args = extract_args(request)
-          job_class.perform_now(job_args)
+
+          job_class.perform_now(*job_args)
 
           response(200, {})
         rescue Rack::InvalidPayloadError => e
           response(422, { error: e.message })
-        rescue StandardError => e
-          response(500, { error: e.message })
         end
 
         private
@@ -32,7 +31,7 @@ module RailsCloudTasks
 
         def extract_args(request)
           body = request.body.read
-          JSON.parse(body)
+          JSON.parse(body) || []
         rescue JSON::ParserError, KeyError
           raise Rack::InvalidPayloadError
         end

data/lib/rails_cloud_tasks/rack/tasks.rb

@@ -17,8 +17,6 @@ module RailsCloudTasks
           response(200, {})
         rescue Rack::InvalidPayloadError => e
           response(400, { error: e.cause.message })
-        rescue StandardError => e
-          response(500, { error: e.message })
         end
 
         private

data/lib/rails_cloud_tasks/scheduler.rb

@@ -23,15 +23,7 @@ module RailsCloudTasks
     def upsert
       result = { success: [], failure: [] }
       scheduler_jobs.each do |job|
-        success = true
-        begin
-          client.create_job parent: location_path, job: job
-        rescue Google::Cloud::AlreadyExistsError
-          client.update_job job: job
-        rescue StandardError
-          success = false
-        end
-        success ? (result[:success] << job[:name]) : (result[:failure] << job[:name])
+        upsert_job(job) ? (result[:success] << job[:name]) : (result[:failure] << job[:name])
       end
       log_output(result)
     end
@@ -53,7 +45,7 @@ module RailsCloudTasks
         description: job[:description],
         time_zone:   job[:time_zone],
         http_target: {
-          uri:         "#{host}#{tasks_path}/#{job[:name]}",
+          uri:         "#{host}#{tasks_path}/#{job[:class_name]}",
           http_method: 'POST',
           body:        job[:args].to_json
         }.merge(auth)
@@ -84,5 +76,20 @@ module RailsCloudTasks
       logger.info(desc)
       logger.info(prefix + tasks.join("\n #{prefix}"))
     end
+
+    private
+
+    def upsert_job(job)
+      success = true
+      begin
+        client.create_job parent: location_path, job: job
+      rescue Google::Cloud::AlreadyExistsError
+        client.update_job job: job
+      rescue StandardError => e
+        logger.error(e)
+        success = false
+      end
+      success
+    end
   end
 end

data/lib/rails_cloud_tasks/version.rb

@@ -1,3 +1,3 @@
 module RailsCloudTasks
-  VERSION = '0.0.3'.freeze
+  VERSION = '0.0.6'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails-cloud-tasks
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.6
 platform: ruby
 authors:
 - Guilherme Araújo
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-03-05 00:00:00.000000000 Z
+date: 2021-03-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport