railpack 1.2.3 → 1.2.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 269e75f35771ec905394623faa61366d3c7208ea4f21cb867c8a10dc733ff9cc
-  data.tar.gz: 925c4070f7f2888cc7e260cab0ff3617d1ac0151dfc190c6b9ccd1d7a4baf9bf
+  metadata.gz: b13af1329c7192e2a8fd5c83eb0cc9ff07a0edec87b7311dedae0f26b4710975
+  data.tar.gz: 757f2eedf1421e59d9ae165f13a353918cdad3bad8cee83cdf0bc60078ede4d1
 SHA512:
-  metadata.gz: fa4ef98d5320a341ef6fb6c0d103ef83aee393b2efd346c132299c842046f17b885f1ea5da84e549dc91fc0de5d83fac00a20c3155000f6f0b4cbb9da9b018a6
-  data.tar.gz: bd4178182819778bbd1d7716a660030904099eee0af4c3f127d906afa1a0c4cd49590903ab7ca9690042c1addfa190943452a79e01395d828294f194d3794ef8
+  metadata.gz: f14bb9cb2f37592089c517a4c8dcd16185bf9fa6d5029344031c58e9f54baa1cea24a0542bb8059f96acc59d54d0aec00b3c783f787ba5188743553b63864777
+  data.tar.gz: 17748f4d280fbfebefec259db9525daf4609285886a98a0027cd29a53a1c5a8aa0ff3007e05ffed4c96802a048d58cceae3ec2d056ab50f9c953f7d3e276ad40

data/CHANGELOG.md

@@ -1,5 +1,30 @@
 ## [Unreleased]
 
+## [1.2.5] - 2026-01-26
+
+- Add test_config_yaml_file_loading test for YAML config file loading
+- Test that Railpack correctly reads config/railpack.yml from Rails.root
+- Test bundler selection, environment overrides, and config merging
+- All 19 tests passing with 72 assertions
+
+## [1.2.4] - 2026-01-26
+
+- Add comprehensive test suite (19 tests, 72 assertions)
+- Test config system including YAML file loading from Rails.root
+- Test bundler implementations, manager features, event hooks
+- Test error handling, asset manifest generation, bundle size calculation
+- Test Rails integration and environment overrides
+- Add default logger with Logger.new($stdout)
+- Fix logger nil issues in manager
+
+## [1.2.3] - 2026-01-26
+
+- Add install scaffold generator (`rails railpack:install`)
+- Create default `config/railpack.yml` with sensible Rails defaults
+- Add `rails railpack:install:force` for overwriting existing config
+- Update README with install instructions
+- Similar to jsbundling install experience
+
 ## [1.2.2] - 2026-01-26
 
 - Fix asset manifest generation for Propshaft compatibility

data/lib/railpack/version.rb

@@ -1,3 +1,3 @@
 module Railpack
-  VERSION = "1.2.3"
+  VERSION = "1.2.5"
 end

data/lib/railpack.rb

@@ -1,4 +1,5 @@
 # Railpack - Multi-bundler asset pipeline for Rails
+require 'logger'
 require_relative "railpack/version"
 require_relative "railpack/bundler"
 require_relative "railpack/bundlers/bun_bundler"
@@ -12,7 +13,11 @@ module Railpack
   class Error < StandardError; end
 
   class << self
-    attr_accessor :logger
+    attr_writer :logger
+
+    def logger
+      @logger ||= Logger.new($stdout)
+    end
 
     def config
       @config ||= Config.new

data/test/railpack_test.rb

@@ -1,18 +1,40 @@
 # frozen_string_literal: true
 
 require 'minitest/autorun'
+require 'tempfile'
+require 'fileutils'
+require 'pathname'
+require 'json'
 require 'railpack'
 
 class RailpackTest < Minitest::Test
+  def setup
+    # Create a temporary directory for testing
+    @temp_dir = Dir.mktmpdir
+    @original_rails_root = nil
+    if defined?(Rails) && Rails.respond_to?(:root)
+      @original_rails_root = Rails.singleton_class.instance_method(:root)
+    end
+  end
+
+  def teardown
+    FileUtils.remove_entry(@temp_dir) if @temp_dir && Dir.exist?(@temp_dir)
+    # Restore original Rails.root method if it was overridden
+    if @original_rails_root && defined?(Rails)
+      Rails.singleton_class.define_method(:root, @original_rails_root)
+    end
+  end
+
   def test_version
     refute_nil ::Railpack::VERSION
+    assert_match(/\d+\.\d+\.\d+/, ::Railpack::VERSION)
   end
 
-  def test_config
+  def test_config_instance
     assert_instance_of Railpack::Config, Railpack.config
   end
 
-  def test_manager
+  def test_manager_instance
     assert_instance_of Railpack::Manager, Railpack.manager
   end
 
@@ -26,4 +48,230 @@ class RailpackTest < Minitest::Test
     assert_equal Railpack::RollupBundler, Railpack::Manager::BUNDLERS['rollup']
     assert_equal Railpack::WebpackBundler, Railpack::Manager::BUNDLERS['webpack']
   end
+
+  def test_config_loading_without_rails
+    # Test config loading without Rails.root
+    config = Railpack::Config.new
+    assert_equal 'bun', config.bundler
+    assert_equal './app/javascript/application.js', config.entrypoint
+  end
+
+  def test_config_yaml_file_loading
+    # Test that Railpack can load config from a YAML file
+    config_dir = File.join(@temp_dir, 'config')
+    FileUtils.mkdir_p(config_dir)
+    config_file = File.join(config_dir, 'railpack.yml')
+
+    File.write(config_file, <<~YAML)
+      default:
+        bundler: rollup
+        target: node
+        format: cjs
+        entrypoint: "./server.js"
+        outdir: "dist"
+        minify: false
+      development:
+        sourcemap: true
+      production:
+        minify: true
+        sourcemap: false
+    YAML
+
+    # Verify the file was created
+    assert File.exist?(config_file), "Config file should exist at #{config_file}"
+
+    # Mock Rails.root to point to our temp directory
+    mock_rails_root(@temp_dir)
+
+    # Create a fresh config instance to test file loading
+    config = Railpack::Config.new
+
+
+
+    # Test that the YAML file was loaded correctly
+    assert_equal 'rollup', config.bundler
+    assert_equal './server.js', config.entrypoint
+    assert_equal 'dist', config.outdir
+    assert_equal 'node', config.target
+    assert_equal 'cjs', config.format
+    assert_equal false, config.minify
+
+    # Test environment overrides
+    dev_config = config.for_environment('development')
+    prod_config = config.for_environment('production')
+
+    assert_equal true, dev_config['sourcemap']
+    assert_equal true, prod_config['minify']
+    assert_equal false, prod_config['sourcemap']
+  end
+
+  def test_config_environment_overrides
+    # Test environment override logic with default config
+    config = Railpack::Config.new
+    dev_config = config.for_environment('development')
+    prod_config = config.for_environment('production')
+
+    # Development should have sourcemap enabled by default
+    assert_equal true, dev_config['sourcemap']
+    # Production should have minify enabled by default
+    assert_equal true, prod_config['minify']
+  end
+
+  def test_config_build_flags
+    # Test build flags generation with default config
+    config = Railpack::Config.new
+    flags = config.build_flags
+
+    assert_includes flags, '--target=browser'
+    assert_includes flags, '--format=esm'
+  end
+
+  def test_config_build_args
+    # Test build args generation with default config
+    config = Railpack::Config.new
+    args = config.build_args
+
+    assert_includes args, './app/javascript/application.js'
+    assert_includes args, '--outdir=app/assets/builds'
+    assert_includes args, '--target=browser'
+    assert_includes args, '--format=esm'
+  end
+
+  def test_manager_bundle_size_calculation
+    # Create test output directory with fake assets
+    outdir = File.join(@temp_dir, 'builds')
+    FileUtils.mkdir_p(outdir)
+
+    # Create fake JS and CSS files
+    File.write(File.join(outdir, 'app.js'), 'console.log("test");')
+    File.write(File.join(outdir, 'app.css'), 'body { color: red; }')
+    File.write(File.join(outdir, 'app.js.map'), '{"version":3}')
+
+    config = { 'outdir' => outdir }
+    manager = Railpack::Manager.new
+
+    size = manager.send(:calculate_bundle_size, config)
+    assert size.is_a?(Float)
+    assert size > 0
+  end
+
+  def test_manager_asset_manifest_generation
+    outdir = File.join(@temp_dir, 'builds')
+    FileUtils.mkdir_p(outdir)
+
+    # Create fake built assets
+    File.write(File.join(outdir, 'application.js'), 'console.log("app");')
+    File.write(File.join(outdir, 'application.css'), 'body { color: blue; }')
+
+    config = { 'outdir' => outdir }
+    manager = Railpack::Manager.new
+
+    manager.send(:generate_asset_manifest, config)
+
+    manifest_path = File.join(outdir, '.manifest.json')
+    assert File.exist?(manifest_path)
+
+    manifest = JSON.parse(File.read(manifest_path))
+    assert manifest.key?('application.js')
+    assert manifest.key?('application.css')
+    assert manifest['application.js']['logical_path'] == 'application.js'
+  end
+
+  def test_bundler_base_class
+    bundler = Railpack::Bundler.new({})
+
+    assert_respond_to bundler, :build!
+    assert_respond_to bundler, :watch
+    assert_respond_to bundler, :install!
+    assert_respond_to bundler, :name
+    assert_respond_to bundler, :commands
+  end
+
+  def test_bun_bundler_commands
+    bundler = Railpack::BunBundler.new({})
+    commands = bundler.send(:commands)
+
+    assert_equal 'bun run build', commands[:build]
+    assert_equal 'bun run watch', commands[:watch]
+    assert_equal 'bun install', commands[:install]
+  end
+
+  def test_esbuild_bundler_commands
+    bundler = Railpack::EsbuildBundler.new({})
+    commands = bundler.send(:commands)
+
+    assert_equal 'esbuild', commands[:build]
+    assert_equal 'esbuild --watch', commands[:watch]
+    assert_equal 'npm install', commands[:install]
+  end
+
+  def test_rollup_bundler_commands
+    bundler = Railpack::RollupBundler.new({})
+    commands = bundler.send(:commands)
+
+    assert_equal 'rollup', commands[:build]
+    assert_equal 'rollup --watch', commands[:watch]
+    assert_equal 'npm install', commands[:install]
+  end
+
+  def test_webpack_bundler_commands
+    bundler = Railpack::WebpackBundler.new({})
+    commands = bundler.send(:commands)
+
+    assert_equal 'webpack', commands[:build]
+    assert_equal 'webpack --watch', commands[:watch]
+    assert_equal 'npm install', commands[:install]
+  end
+
+  def test_event_hooks
+    events = []
+    Railpack.on_build_start { |config| events << [:start, config] }
+    Railpack.on_build_complete { |result| events << [:complete, result] }
+
+    # Trigger build to test hooks
+    manager = Railpack::Manager.new
+    config = Railpack.config.for_environment
+
+    # Mock a simple build that doesn't actually execute
+    manager.instance_variable_set(:@bundler, Minitest::Mock.new)
+    manager.instance_variable_get(:@bundler).expect(:build!, true, [[]])
+
+    Railpack.trigger_build_start(config)
+    Railpack.trigger_build_complete({ success: true })
+
+    assert_equal 2, events.size
+    assert_equal [:start, config], events[0]
+    assert_equal [:complete, { success: true }], events[1]
+  end
+
+  def test_error_handling
+    error = nil
+    Railpack.on_error { |err| error = err }
+
+    begin
+      raise StandardError.new("Test error")
+    rescue => e
+      Railpack.trigger_error(e)
+    end
+
+    assert_equal "Test error", error.message
+  end
+
+  def test_logger_integration
+    # Test that logger methods exist
+    assert_respond_to Railpack, :logger
+    assert_respond_to Railpack, :logger=
+  end
+
+  private
+
+  def mock_rails_root(path)
+    rails_module = if defined?(Rails)
+                     Rails
+                   else
+                     Object.const_set(:Rails, Module.new)
+                   end
+
+    rails_module.define_singleton_method(:root) { Pathname.new(path) }
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: railpack
 version: !ruby/object:Gem::Version
-  version: 1.2.3
+  version: 1.2.5
 platform: ruby
 authors:
 - 21tycoons LLC