rage-iodine 5.8.0 → 5.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7e2925f48b74a97ff3431fc421ebd451c1f8d4befd701ac454ceb0bb8ed2ae82
-  data.tar.gz: 6c101cf70146f67794adc91ca9eee8cfade412b27bbed04d2c9937e378f25fa8
+  metadata.gz: b9b70a5de57c61bdbbd996b844305eb1c0f05f7ca489df818df57147f77bcdd4
+  data.tar.gz: '095e078c74ab42347353278e6cb2fd82ca3b5fe582b2d37a835673b06575f386'
 SHA512:
-  metadata.gz: bcfba0ed6461dad2478e3f35b1dc2246046d872b6159bac5f93651f7ce3fa74ef2ee86e90727e930bb48514a7266844d9eb616af253f2aef30d92646b65fe06b
-  data.tar.gz: 2c1fa87406f4f249551addeb72d59231684552bdc5fde2ed55539851afe9b14349497f7cc8e0dfa1969f71668e24b93d1cc591cc5a2e3d560e2b4abd67e56c7b
+  metadata.gz: 18dbb21c7678eff317996415f0f1d51e511a5c54c4184cab6a39f85c0f708d99f471daa0c3702ddf850c3273e7588eaee4847e317c6a25d3a8d72fd2cfad47a2
+  data.tar.gz: 2e0ec6b84cca4ae1ae0db795eb509082129483b896fbd5caed4ffc8887bb99451c91a49013b56f4cf45a213c720e34b09cef258812900003ea5381eab7658637

data/CHANGELOG.md

@@ -6,6 +6,10 @@ Please notice that this change log contains changes for upcoming releases as wel
 
 ## Changes:
 
+#### Change log v.5.9.0 (2026-10-15)
+
+**Fix**: Prevent process hang on exit caused by a use-after-free in pub/sub teardown (`fio_cluster_at_exit` read a channel freed by `fio_unsubscribe` of its last subscription; it now performs a bounded best-effort cleanup instead). See #21.
+
 #### Change log v.5.8.0 (2026-10-09)
 
 **Update**: Encode parameters as UTF-8

data/ext/iodine/fio.c

@@ -7644,6 +7644,25 @@ static inline void fio_cluster_inform_root_about_channel(channel_s *ch,
 /* *****************************************************************************
  * Initialization
  **************************************************************************** */
+/* best-effort teardown without fio_unsubscribe: it may free `ch` (and remove
+ * it from the set) while this loop still uses it (#21) */
+FIO_FUNC void fio_pubsub_at_exit_clear(fio_ch_set_s *channels) {
+  while (fio_ch_set_count(channels)) {
+    channel_s *ch = fio_ch_set_last(channels);
+    while (fio_ls_embd_any(&ch->subscriptions)) {
+      subscription_s *sub =
+          FIO_LS_EMBD_OBJ(subscription_s, node, ch->subscriptions.next);
+      fio_ls_embd_remove(&sub->node);
+      sub->unsubscribed = 1;
+      sub->on_message = NULL;
+      sub->on_unsubscribe = NULL;
+      fio_subscription_free(sub);
+    }
+    fio_ch_set_pop(channels);
+  }
+  fio_ch_set_free(channels);
+}
+
 #ifndef __MINGW32__
 static void fio_accept_after_fork(void *ignore) {
   /* prevent `accept` backlog in parent */
@@ -7657,38 +7676,9 @@ static void fio_cluster_at_exit(void *ignore) {
   /* unlock all */
   fio_pubsub_on_fork();
   /* clear subscriptions of all types */
-  while (fio_ch_set_count(&fio_postoffice.patterns.channels)) {
-    channel_s *ch = fio_ch_set_last(&fio_postoffice.patterns.channels);
-    while (fio_ls_embd_any(&ch->subscriptions)) {
-      subscription_s *sub =
-          FIO_LS_EMBD_OBJ(subscription_s, node, ch->subscriptions.next);
-      fio_unsubscribe(sub);
-    }
-    fio_ch_set_pop(&fio_postoffice.patterns.channels);
-  }
-
-  while (fio_ch_set_count(&fio_postoffice.pubsub.channels)) {
-    channel_s *ch = fio_ch_set_last(&fio_postoffice.pubsub.channels);
-    while (fio_ls_embd_any(&ch->subscriptions)) {
-      subscription_s *sub =
-          FIO_LS_EMBD_OBJ(subscription_s, node, ch->subscriptions.next);
-      fio_unsubscribe(sub);
-    }
-    fio_ch_set_pop(&fio_postoffice.pubsub.channels);
-  }
-
-  while (fio_ch_set_count(&fio_postoffice.filters.channels)) {
-    channel_s *ch = fio_ch_set_last(&fio_postoffice.filters.channels);
-    while (fio_ls_embd_any(&ch->subscriptions)) {
-      subscription_s *sub =
-          FIO_LS_EMBD_OBJ(subscription_s, node, ch->subscriptions.next);
-      fio_unsubscribe(sub);
-    }
-    fio_ch_set_pop(&fio_postoffice.filters.channels);
-  }
-  fio_ch_set_free(&fio_postoffice.filters.channels);
-  fio_ch_set_free(&fio_postoffice.patterns.channels);
-  fio_ch_set_free(&fio_postoffice.pubsub.channels);
+  fio_pubsub_at_exit_clear(&fio_postoffice.patterns.channels);
+  fio_pubsub_at_exit_clear(&fio_postoffice.pubsub.channels);
+  fio_pubsub_at_exit_clear(&fio_postoffice.filters.channels);
 
   /* clear engines */
   FIO_PUBSUB_DEFAULT = FIO_PUBSUB_CLUSTER;
@@ -12092,6 +12082,23 @@ FIO_FUNC void fio_pubsub_test(void) {
   ++expect;
   fio_defer_perform();
   FIO_ASSERT(counter == expect, "unsubscribe wasn't called for named channel!");
+
+  /* Regression #21: at-exit cleanup must terminate and empty the set, even
+   * with several subscriptions per channel or an already-marked one. */
+  fio_subscribe(.channel = {0, 9, "hang-test"}, .udata1 = &counter,
+                .on_message = fio_pubsub_test_on_message,
+                .on_unsubscribe = fio_pubsub_test_on_unsubscribe);
+  s = fio_subscribe(.channel = {0, 9, "hang-test"}, .udata1 = &counter,
+                    .on_message = fio_pubsub_test_on_message,
+                    .on_unsubscribe = fio_pubsub_test_on_unsubscribe);
+  FIO_ASSERT(s, "fio_subscribe FAILED for hang-test channel.");
+  fio_trylock(&s->unsubscribed);
+  fio_pubsub_at_exit_clear(&fio_postoffice.pubsub.channels);
+  FIO_ASSERT(!fio_ch_set_count(&fio_postoffice.pubsub.channels),
+             "at-exit cleanup left channels behind (#21)");
+  fio_defer_perform();
+  FIO_ASSERT(counter == expect, "at-exit cleanup shouldn't call callbacks!");
+
   fio_data->is_worker = 0;
   fio_data->active = 0;
   fio_data->workers = 0;

data/lib/iodine/version.rb

@@ -1,3 +1,3 @@
 module Iodine
-  VERSION = '5.8.0'.freeze
+  VERSION = '5.9.0'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rage-iodine
 version: !ruby/object:Gem::Version
-  version: 5.8.0
+  version: 5.9.0
 platform: ruby
 authors:
 - Boaz Segev