rage-iodine 5.7.0 → 5.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e296131738e4dd072f1708da46957d66d78634792bd92f7162bdf3e49b222421
-  data.tar.gz: cbe8892dad5781565df04fce249acdcda2a050d3ccbb30218c41202704deee9a
+  metadata.gz: b9b70a5de57c61bdbbd996b844305eb1c0f05f7ca489df818df57147f77bcdd4
+  data.tar.gz: '095e078c74ab42347353278e6cb2fd82ca3b5fe582b2d37a835673b06575f386'
 SHA512:
-  metadata.gz: bcdc806d2ef25fd4ed32d12cf6348220de5a242d26f69e3b97375e2dd988397d348c1e0ca8f86328fec0eac065081d880f9842b56a9c5e7f4086cb07af69b2b6
-  data.tar.gz: 65c3066177011062277f25a685644063e416b84ebba6f8d90080ac37be01eda37ade06a1a20721b2293e950253052bdac8e49e5484932857a2265c9c80293d37
+  metadata.gz: 18dbb21c7678eff317996415f0f1d51e511a5c54c4184cab6a39f85c0f708d99f471daa0c3702ddf850c3273e7588eaee4847e317c6a25d3a8d72fd2cfad47a2
+  data.tar.gz: 2e0ec6b84cca4ae1ae0db795eb509082129483b896fbd5caed4ffc8887bb99451c91a49013b56f4cf45a213c720e34b09cef258812900003ea5381eab7658637

data/CHANGELOG.md

@@ -6,6 +6,14 @@ Please notice that this change log contains changes for upcoming releases as wel
 
 ## Changes:
 
+#### Change log v.5.9.0 (2026-10-15)
+
+**Fix**: Prevent process hang on exit caused by a use-after-free in pub/sub teardown (`fio_cluster_at_exit` read a channel freed by `fio_unsubscribe` of its last subscription; it now performs a bounded best-effort cleanup instead). See #21.
+
+#### Change log v.5.8.0 (2026-10-09)
+
+**Update**: Encode parameters as UTF-8
+
 #### Change log v.5.7.0 (2026-10-04)
 
 **Update**: Refactor parameters parsing

data/ext/iodine/fio.c

@@ -7644,6 +7644,25 @@ static inline void fio_cluster_inform_root_about_channel(channel_s *ch,
 /* *****************************************************************************
  * Initialization
  **************************************************************************** */
+/* best-effort teardown without fio_unsubscribe: it may free `ch` (and remove
+ * it from the set) while this loop still uses it (#21) */
+FIO_FUNC void fio_pubsub_at_exit_clear(fio_ch_set_s *channels) {
+  while (fio_ch_set_count(channels)) {
+    channel_s *ch = fio_ch_set_last(channels);
+    while (fio_ls_embd_any(&ch->subscriptions)) {
+      subscription_s *sub =
+          FIO_LS_EMBD_OBJ(subscription_s, node, ch->subscriptions.next);
+      fio_ls_embd_remove(&sub->node);
+      sub->unsubscribed = 1;
+      sub->on_message = NULL;
+      sub->on_unsubscribe = NULL;
+      fio_subscription_free(sub);
+    }
+    fio_ch_set_pop(channels);
+  }
+  fio_ch_set_free(channels);
+}
+
 #ifndef __MINGW32__
 static void fio_accept_after_fork(void *ignore) {
   /* prevent `accept` backlog in parent */
@@ -7657,38 +7676,9 @@ static void fio_cluster_at_exit(void *ignore) {
   /* unlock all */
   fio_pubsub_on_fork();
   /* clear subscriptions of all types */
-  while (fio_ch_set_count(&fio_postoffice.patterns.channels)) {
-    channel_s *ch = fio_ch_set_last(&fio_postoffice.patterns.channels);
-    while (fio_ls_embd_any(&ch->subscriptions)) {
-      subscription_s *sub =
-          FIO_LS_EMBD_OBJ(subscription_s, node, ch->subscriptions.next);
-      fio_unsubscribe(sub);
-    }
-    fio_ch_set_pop(&fio_postoffice.patterns.channels);
-  }
-
-  while (fio_ch_set_count(&fio_postoffice.pubsub.channels)) {
-    channel_s *ch = fio_ch_set_last(&fio_postoffice.pubsub.channels);
-    while (fio_ls_embd_any(&ch->subscriptions)) {
-      subscription_s *sub =
-          FIO_LS_EMBD_OBJ(subscription_s, node, ch->subscriptions.next);
-      fio_unsubscribe(sub);
-    }
-    fio_ch_set_pop(&fio_postoffice.pubsub.channels);
-  }
-
-  while (fio_ch_set_count(&fio_postoffice.filters.channels)) {
-    channel_s *ch = fio_ch_set_last(&fio_postoffice.filters.channels);
-    while (fio_ls_embd_any(&ch->subscriptions)) {
-      subscription_s *sub =
-          FIO_LS_EMBD_OBJ(subscription_s, node, ch->subscriptions.next);
-      fio_unsubscribe(sub);
-    }
-    fio_ch_set_pop(&fio_postoffice.filters.channels);
-  }
-  fio_ch_set_free(&fio_postoffice.filters.channels);
-  fio_ch_set_free(&fio_postoffice.patterns.channels);
-  fio_ch_set_free(&fio_postoffice.pubsub.channels);
+  fio_pubsub_at_exit_clear(&fio_postoffice.patterns.channels);
+  fio_pubsub_at_exit_clear(&fio_postoffice.pubsub.channels);
+  fio_pubsub_at_exit_clear(&fio_postoffice.filters.channels);
 
   /* clear engines */
   FIO_PUBSUB_DEFAULT = FIO_PUBSUB_CLUSTER;
@@ -12092,6 +12082,23 @@ FIO_FUNC void fio_pubsub_test(void) {
   ++expect;
   fio_defer_perform();
   FIO_ASSERT(counter == expect, "unsubscribe wasn't called for named channel!");
+
+  /* Regression #21: at-exit cleanup must terminate and empty the set, even
+   * with several subscriptions per channel or an already-marked one. */
+  fio_subscribe(.channel = {0, 9, "hang-test"}, .udata1 = &counter,
+                .on_message = fio_pubsub_test_on_message,
+                .on_unsubscribe = fio_pubsub_test_on_unsubscribe);
+  s = fio_subscribe(.channel = {0, 9, "hang-test"}, .udata1 = &counter,
+                    .on_message = fio_pubsub_test_on_message,
+                    .on_unsubscribe = fio_pubsub_test_on_unsubscribe);
+  FIO_ASSERT(s, "fio_subscribe FAILED for hang-test channel.");
+  fio_trylock(&s->unsubscribed);
+  fio_pubsub_at_exit_clear(&fio_postoffice.pubsub.channels);
+  FIO_ASSERT(!fio_ch_set_count(&fio_postoffice.pubsub.channels),
+             "at-exit cleanup left channels behind (#21)");
+  fio_defer_perform();
+  FIO_ASSERT(counter == expect, "at-exit cleanup shouldn't call callbacks!");
+
   fio_data->is_worker = 0;
   fio_data->active = 0;
   fio_data->workers = 0;

data/ext/iodine/http.c

@@ -68,6 +68,7 @@ static VALUE cUploadedFile;
 static ID create_id;
 static ID path_id;
 static rb_encoding *IodineBinaryEncoding;
+static rb_encoding *IodineUTF8Encoding;
 
 /* *****************************************************************************
 Small Helpers
@@ -2010,7 +2011,7 @@ static void http_mime_parser_on_data(http_mime_parser_s *parser, void *name,
                                      size_t value_len) {
   // for regular values - just add them to params
   if (!filename_len) {
-    VALUE r_value = rb_enc_str_new(value, value_len, IodineBinaryEncoding);
+    VALUE r_value = rb_enc_str_new(value, value_len, IodineUTF8Encoding);
     http_add_to_params(http_mime_parser2fio(parser)->params, name, name_len, r_value);
     return;
   }
@@ -2085,7 +2086,7 @@ static void http_mime_parser_on_partial_end(http_mime_parser_s *parser) {
 
   FIOBJ slice = fiobj_data_slice(fio_parser->h->body, fio_parser->partial_offset, fio_parser->partial_length);
   fio_str_info_s s_slice = fiobj_obj2cstr(slice);
-  VALUE r_value = rb_enc_str_new(s_slice.data, s_slice.len, IodineBinaryEncoding);
+  VALUE r_value = rb_enc_str_new(s_slice.data, s_slice.len, IodineUTF8Encoding);
   http_add_to_params(fio_parser->params, RSTRING_PTR(fio_parser->partial_name), RSTRING_LEN(fio_parser->partial_name), r_value);
 
   fio_parser->partial_name = Qnil;
@@ -2701,6 +2702,7 @@ void http_init(void) {
   path_id = rb_intern("path");
 
   IodineBinaryEncoding = rb_enc_find("binary");
+  IodineUTF8Encoding = rb_enc_find("UTF-8");
 }
 
 /* *****************************************************************************

data/ext/iodine/iodine_helpers.c

@@ -242,7 +242,7 @@ Convert query string into a Ruby object without recursion.
 */
 static VALUE build_query_component(char *str, size_t len,
                                     uint8_t should_decode) {
-  VALUE result = rb_str_new(str, len);
+  VALUE result = rb_enc_str_new(str, len, IodineUTF8Encoding);
   if (should_decode) {
     url_decode_inplace(Qnil, result);
   }
@@ -290,7 +290,7 @@ static VALUE parse_nested_query_internal(char *str, size_t len) {
                                      pair_end - separator - 1,
                                      value_should_decode);
     } else if (key_len > 1 && memchr(key_data + 1, '[', key_len - 1)) {
-      value = rb_str_new(NULL, 0);
+      value = rb_enc_str_new(NULL, 0, IodineUTF8Encoding);
     } else {
       value = Qnil;
     }

data/lib/iodine/version.rb

@@ -1,3 +1,3 @@
 module Iodine
-  VERSION = '5.7.0'.freeze
+  VERSION = '5.9.0'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rage-iodine
 version: !ruby/object:Gem::Version
-  version: 5.7.0
+  version: 5.9.0
 platform: ruby
 authors:
 - Boaz Segev