radius-spec 0.7.0 → 0.8.0

data/benchmarks/unfreeze_string.rb

@@ -5,7 +5,6 @@ require_relative 'bm_setup'
 
 display_benchmark_header
 
-# rubocop:disable Performance/UnfreezeString
 section "Unfreezing empty string" do |bench|
   bench.report("String.new") do
     String.new
@@ -34,7 +33,6 @@ section "Unfreezing string" do |bench|
     STRING.dup
   end
 end
-# rubocop:enable Performance/UnfreezeString
 
 __END__
 

data/common_rubocop.yml

@@ -1,5 +1,11 @@
 AllCops:
   TargetRubyVersion: 2.7.0
+  # We choose to opt-in to new checks by default. This allows us to update
+  # version by version without having to worry about adding an entry for each
+  # new "enabled by default" check. If we want to jump multiple versions and
+  # wish to be notified of all the enw check, then we'll need to change
+  # `NewCops` to `pending.
+  NewCops: enable
   Exclude:
     # Exclude generated binstubs
     - 'bin/bundle'
@@ -56,7 +62,7 @@ Layout/AccessModifierIndentation:
 # SupportedHashRocketStyles: key, separator, table
 # SupportedColonStyles: key, separator, table
 # SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
-Layout/AlignHash:
+Layout/HashAlignment:
   Enabled: true
   EnforcedHashRocketStyle: key
   EnforcedColonStyle: key
@@ -82,7 +88,7 @@ Layout/BlockAlignment:
 #
 # TODO: At some point this is split into both Layout/FirstArgumentIndentation
 # and Layout/FirstParameterIndentation
-Layout/IndentFirstArgument:
+Layout/FirstArgumentIndentation:
   Enabled: false
 
 # This project only uses newer Ruby versions which all support the "squiggly"
@@ -91,9 +97,44 @@ Layout/IndentFirstArgument:
 #
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: auto_detection, squiggly, active_support, powerpack, unindent
-Layout/IndentHeredoc:
+Layout/HeredocIndentation:
   EnforcedStyle: squiggly
 
+# We generally prefer to use the default line length of 80. Though sometimes
+# we just need a little extra space because it makes it easier to read.
+#
+# The only way to disable Rubocop for a single line is either to wrap the line
+# with two comments or append the disable comment to the end of the line. For
+# guard clauses, we tend to prefer trailing comments to avoid adding two lines
+# just to disable a cop on one line.
+#
+# Sometimes comments include ASCII diagrams, flow charts, etc. These cannot
+# always be reformatted to fit within the 80 column limit. Also, we write most
+# comments in markdown format. Rubocop isn't very good at understanding when
+# the line is long because of a URL in a markdown link. Instead of requiring
+# additional comments to turn this cop off for comments we ignore any long
+# lines which are only comments.
+#
+# There are also cases where for one valid reason or another we have a trailing
+# comment that extends a little too far. We'd like to be able to ignore those
+# as well. This _attempts_ to do that, however, as this uses simple regular
+# expressions we can only attempt to match so much. We probably should change
+# this for a node pattern matcher in the future.
+#
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes,
+#                           IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Layout/LineLength:
+  IgnoreCopDirectives: true
+  IgnoredPatterns:
+    # Leading comments
+    - '\A\s*#'
+    # Attempt at trailing comments
+    - '\A.{1,78}\s#\s.*\z'
+  Max: 100
+  Exclude:
+    - '**/*.gemspec'
+
 # We tend to indent multi-line operation statements. I think this is because it
 # tends to be the default style auto-formatted by VIM (which many of us use).
 # It also helps show the continuation of the statement instead of it
@@ -186,41 +227,6 @@ Metrics/BlockLength:
     - 'RSpec.configure'
     - 'VCR.configure'
 
-# We generally prefer to use the default line length of 80. Though sometimes
-# we just need a little extra space because it makes it easier to read.
-#
-# The only way to disable Rubocop for a single line is either to wrap the line
-# with two comments or append the disable comment to the end of the line. For
-# guard clauses, we tend to prefer trailing comments to avoid adding two lines
-# just to disable a cop on one line.
-#
-# Sometimes comments include ASCII diagrams, flow charts, etc. These cannot
-# always be reformatted to fit within the 80 column limit. Also, we write most
-# comments in markdown format. Rubocop isn't very good at understanding when
-# the line is long because of a URL in a markdown link. Instead of requiring
-# additional comments to turn this cop off for comments we ignore any long
-# lines which are only comments.
-#
-# There are also cases where for one valid reason or another we have a trailing
-# comment that extends a little too far. We'd like to be able to ignore those
-# as well. This _attempts_ to do that, however, as this uses simple regular
-# expressions we can only attempt to match so much. We probably should change
-# this for a node pattern matcher in the future.
-#
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes,
-#                           IgnoreCopDirectives, IgnoredPatterns.
-# URISchemes: http, https
-Metrics/LineLength:
-  IgnoreCopDirectives: true
-  IgnoredPatterns:
-    # Leading comments
-    - '\A\s*#'
-    # Attempt at trailing comments
-    - '\A.{1,78}\s#\s.*\z'
-  Max: 100
-  Exclude:
-    - '**/*.gemspec'
-
 # TODO: Remove this when we get to 0.89.0 as the new default max is 8
 #
 # Configuration parameters: IgnoredMethods, Max
@@ -248,14 +254,14 @@ Naming/FileName:
 # `EOF` is a common terminal abbreviate indicating end-of-file. We allow this
 # for those heredocs which represent "file" text.
 #
-# Configuration parameters: Blacklist.
-# Blacklist: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$))
+# Configuration parameters: ForbiddenDelimiters.
+# ForbiddenDelimiters: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$))
 Naming/HeredocDelimiterNaming:
   Details: |
 
     Use meaningful delimiter names to provide context to the text. The only
     allowed `EO*` variant if `EOF` which has specific meaning for file content.
-  Blacklist:
+  ForbiddenDelimiters:
     - !ruby/regexp '/(^|\s)(EO[A-EG-Z]{1}|END)(\s|$)/'
 
 # It is generally a good idea to match the instance variable names with their
@@ -454,6 +460,13 @@ Style/EmptyCaseCondition:
 Style/EmptyMethod:
   EnforcedStyle: expanded
 
+# Always require the pragma comment to be true
+#
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: always, always_true, never
+Style/FrozenStringLiteralComment:
+  EnforcedStyle: always_true
+
 # Prefer symbol keys using the 1.9 hash syntax. However, when keys are mixed
 # use a consistent mapping style; which generally means using hash rockets:
 #

data/common_rubocop_rails.yml

@@ -20,26 +20,26 @@ AllCops:
     - 'db/migrate/**/*'
 
 # Rails project's are not concerned with API docs normally
-Documentation:
+Style/Documentation:
   Enabled: false
 
-Metrics/BlockLength:
-  Exclude:
-    - 'bin/setup'
-    - 'bin/update'
-    - 'config/routes.rb'
-    - 'spec/rails_helper.rb'
-
 # Rails foreign keys and indexes can get long. We want to ignore our annotation
 # comments which are for these entries.
 #
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https
-Metrics/LineLength:
+Layout/LineLength:
   IgnoredPatterns:
     - '\A#  fk_rails_'
     - '\A#  index_'
 
+Metrics/BlockLength:
+  Exclude:
+    - 'bin/setup'
+    - 'bin/update'
+    - 'config/routes.rb'
+    - 'spec/rails_helper.rb'
+
 # For our Rails apps several of them use the `respond_to` with `format` blocks
 # to handle various mime types (mostly HTML and JSON). Given our `do` / `end`
 # block style for non-functional blocks (which includes both `respond_to` and
@@ -150,6 +150,30 @@ Rails/HasAndBelongsToMany:
 Rails/IgnoredSkipActionFilterOption:
   Enabled: false
 
+# We do not care about this check due to its lack of configuration.
+#
+# Some of the team finds the naming of this method is more confusing than using
+# `each_with_object`. We all agree the other examples are bad and should not be
+# used:
+#
+#     # OK for us
+#     [1, 2, 3].each_with_object({}) { |el, h| h[foo(el)] = el }
+#
+#     # Bad
+#     [1, 2, 3].to_h { |el| [foo(el), el] }
+#     [1, 2, 3].map { |el| [foo(el), el] }.to_h
+#     Hash[[1, 2, 3].collect { |el| [foo(el), el] }]
+#
+# If this check supports configuration in the future so that we can allow
+# `each_with_object` then we'll turn it back on.
+Rails/IndexBy:
+  Enabled: false
+
+# We find the name of this method to be very confusing. We'd prefer this method
+# is never used.
+Rails/IndexWith:
+  Enabled: false
+
 # The ActiveSupport monkey patches for `present?` are nearly all defined as:
 #
 #     !blank?

data/lib/radius/spec/model_factory.rb

@@ -482,10 +482,8 @@ module Radius
 end
 
 # Try to load the factories defined for the specs
-# rubocop:disable Lint/HandleExceptions
 begin
   require 'support/model_factories'
 rescue LoadError
   # Ignore as this is an optional convenience feature
 end
-# rubocop:enable Lint/HandleExceptions

data/lib/radius/spec/vcr.rb

@@ -91,10 +91,8 @@ RSpec.configure do |config|
 end
 
 # Try to any custom VCR config for the app
-# rubocop:disable Lint/HandleExceptions
 begin
   require 'support/vcr'
 rescue LoadError
   # Ignore as this is an optional convenience feature
 end
-# rubocop:enable Lint/HandleExceptions

data/lib/radius/spec/version.rb

@@ -2,6 +2,6 @@
 
 module Radius
   module Spec
-    VERSION = "0.7.0"
+    VERSION = "0.8.0"
   end
 end

data/radius-spec.gemspec

@@ -12,7 +12,7 @@ Gem::Specification.new do |spec|
 
   spec.metadata      = {
     "bug_tracker_uri" => "https://github.com/RadiusNetworks/radius-spec/issues",
-    "changelog_uri"   => "https://github.com/RadiusNetworks/radius-spec/blob/v#{Radius::Spec::VERSION}/CHANGELOG.md",
+    "changelog_uri" => "https://github.com/RadiusNetworks/radius-spec/blob/v#{Radius::Spec::VERSION}/CHANGELOG.md",
     "source_code_uri" => "https://github.com/RadiusNetworks/radius-spec/tree/v#{Radius::Spec::VERSION}",
   }
   spec.summary       = "Radius Networks RSpec setup and plug-ins"
@@ -21,18 +21,18 @@ Gem::Specification.new do |spec|
   spec.homepage      = "https://github.com/RadiusNetworks/radius-spec"
   spec.license       = "Apache-2.0"
 
-  spec.files         = `git ls-files -z`.split("\x0").reject do |f|
+  spec.files         = `git ls-files -z`.split("\x0").reject { |f|
     f.match(%r{^(test|spec|features)/})
-  end
+  }
   spec.bindir        = "exe"
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.required_ruby_version = ">= 2.5"
+  spec.required_ruby_version = ">= 2.5" # rubocop:disable Gemspec/RequiredRubyVersion
 
   spec.add_runtime_dependency "rspec", "~> 3.7"
-  spec.add_runtime_dependency "rubocop", "~> 0.73.0"
-  spec.add_runtime_dependency "rubocop-rails", "~> 2.2.1"
+  spec.add_runtime_dependency "rubocop", "~> 0.82.0"
+  spec.add_runtime_dependency "rubocop-rails", "~> 2.5.2"
 
   spec.add_development_dependency "bundler", ">= 2.2.10"
   spec.add_development_dependency "rake", ">= 12.0", "< 14.0"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: radius-spec
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.8.0
 platform: ruby
 authors:
 - Radius Networks
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-07-23 00:00:00.000000000 Z
+date: 2021-08-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -31,28 +31,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.73.0
+        version: 0.82.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.73.0
+        version: 0.82.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.2.1
+        version: 2.5.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.2.1
+        version: 2.5.2
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -94,10 +94,11 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/ci.yml"
+- ".github/workflows/reviewdog.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
-- ".travis.yml"
 - ".yardopts"
 - CHANGELOG.md
 - CODE_OF_CONDUCT.md
@@ -116,14 +117,15 @@ files:
 - benchmarks/format_string.rb
 - benchmarks/format_string_token.rb
 - benchmarks/gsub_vs_tr.rb
+- benchmarks/hash_each.rb
 - benchmarks/hash_merge.rb
+- benchmarks/hash_transform.rb
 - benchmarks/kwargs.rb
 - benchmarks/max_ternary.rb
 - benchmarks/max_ternary_micro.rb
 - benchmarks/unfreeze_string.rb
 - benchmarks/unpack_first.rb
 - bin/ci
-- bin/ci-code-review
 - bin/console
 - bin/pry
 - bin/rake
@@ -147,8 +149,8 @@ licenses:
 - Apache-2.0
 metadata:
   bug_tracker_uri: https://github.com/RadiusNetworks/radius-spec/issues
-  changelog_uri: https://github.com/RadiusNetworks/radius-spec/blob/v0.7.0/CHANGELOG.md
-  source_code_uri: https://github.com/RadiusNetworks/radius-spec/tree/v0.7.0
+  changelog_uri: https://github.com/RadiusNetworks/radius-spec/blob/v0.8.0/CHANGELOG.md
+  source_code_uri: https://github.com/RadiusNetworks/radius-spec/tree/v0.8.0
 post_install_message:
 rdoc_options: []
 require_paths:

data/.travis.yml

@@ -1,15 +0,0 @@
-language: ruby
-cache: bundler
-bundler_args: --jobs=3 --retry=3 --without documentation debug
-before_script:
-  - "bin/ci-code-review"
-script: bin/ci
-rvm:
-  - 2.7
-  - 2.6
-  - 2.5
-  - ruby-head
-jobs:
-  allow_failures:
-    - rvm: ruby-head
-  fast_finish: true

data/bin/ci-code-review

@@ -1,28 +0,0 @@
-#!/bin/bash
-
-# See:
-#   - https://docs.travis-ci.com/user/environment-variables/#Convenience-Variables
-#   - https://docs.travis-ci.com/user/environment-variables/#Default-Environment-Variables
-#   - https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
-if [[ "$TRAVIS_PULL_REQUEST" = "false" ]] || [[ "$TRAVIS_BRANCH" = "production" ]]; then
-  exit
-fi
-
-set -e
-cd "$(dirname "$0")/.."
-
-REVIEWDOG_VERSION="0.9.9"
-
-if ! [ "$(./bin/reviewdog -version)" = "$REVIEWDOG_VERSION" ]; then
-  echo "Installing reviewdog version ${REVIEWDOG_VERSION}..."
-  curl -fsSL https://github.com/haya14busa/reviewdog/releases/download/$REVIEWDOG_VERSION/reviewdog_linux_amd64 \
-    -o ./bin/reviewdog
-  chmod +x ./bin/reviewdog
-fi
-
-echo Rubocop Version: $(./bin/rubocop --version)
-echo Review Dog Version: $(./bin/reviewdog -version)
-
-# Add `-diff="git diff master"` to reviewdog args when running locally
-./bin/rubocop --config .rubocop.yml --extra-details --display-style-guide --rails | \
-  ./bin/reviewdog -f=rubocop -reporter=github-pr-check