radius-spec 0.7.0 → 0.11.0

data/common_rubocop.yml

@@ -1,5 +1,11 @@
 AllCops:
   TargetRubyVersion: 2.7.0
+  # We choose to opt-in to new checks by default. This allows us to update
+  # version by version without having to worry about adding an entry for each
+  # new "enabled by default" check. If we want to jump multiple versions and
+  # wish to be notified of all the enw check, then we'll need to change
+  # `NewCops` to `pending`.
+  NewCops: enable
   Exclude:
     # Exclude generated binstubs
     - 'bin/bundle'
@@ -18,6 +24,11 @@ AllCops:
     # Exclude vendored content
     - 'vendor/**/*'
 
+# We would like to disallow http for bundler sources and enforce https
+# as it is more secure.
+Bundler/InsecureProtocolSource:
+  AllowHttpProtocol: false
+
 # We prefer outdented access modifiers as we feel they provide demarcation of
 # the class similar to `rescue` and `ensure` in a method.
 #
@@ -30,6 +41,18 @@ Layout/AccessModifierIndentation:
     similar to `rescue` and `ensure` in a method.
   EnforcedStyle: outdent
 
+# This cop checks whether the end keyword of begin is aligned properly.
+#
+# Two modes are supported through the EnforcedStyleAlignWith configuration parameter. If it’s set to
+# begin, the end shall be aligned with the begin keyword. We chose this to be consistent with our if
+# statement styles, if you want the end to be aligned with the start of the line just put the begin
+# on the next line.
+#
+# Configuration parameters: EnforcedStyleAlignWith
+# SupportedStyles: start_of_line, begin
+Layout/BeginEndAlignment:
+  EnforcedStyleAlignWith: begin
+
 # Rubocop 0.60.0 changed how it handled value alignments in this cop. This
 # breaks our preference for wanting keys to be aligned, but allowing values to
 # either use the `key` or `table` style:
@@ -56,7 +79,7 @@ Layout/AccessModifierIndentation:
 # SupportedHashRocketStyles: key, separator, table
 # SupportedColonStyles: key, separator, table
 # SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
-Layout/AlignHash:
+Layout/HashAlignment:
   Enabled: true
   EnforcedHashRocketStyle: key
   EnforcedColonStyle: key
@@ -82,17 +105,43 @@ Layout/BlockAlignment:
 #
 # TODO: At some point this is split into both Layout/FirstArgumentIndentation
 # and Layout/FirstParameterIndentation
-Layout/IndentFirstArgument:
+Layout/FirstArgumentIndentation:
   Enabled: false
 
-# This project only uses newer Ruby versions which all support the "squiggly"
-# style. We prefer to use pure Ruby calls when possible instead of relying on
-# alternatives; even for Rails app.
+# We generally prefer to use the default line length of 80. Though sometimes
+# we just need a little extra space because it makes it easier to read.
 #
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: auto_detection, squiggly, active_support, powerpack, unindent
-Layout/IndentHeredoc:
-  EnforcedStyle: squiggly
+# The only way to disable Rubocop for a single line is either to wrap the line
+# with two comments or append the disable comment to the end of the line. For
+# guard clauses, we tend to prefer trailing comments to avoid adding two lines
+# just to disable a cop on one line.
+#
+# Sometimes comments include ASCII diagrams, flow charts, etc. These cannot
+# always be reformatted to fit within the 80 column limit. Also, we write most
+# comments in markdown format. Rubocop isn't very good at understanding when
+# the line is long because of a URL in a markdown link. Instead of requiring
+# additional comments to turn this cop off for comments we ignore any long
+# lines which are only comments.
+#
+# There are also cases where for one valid reason or another we have a trailing
+# comment that extends a little too far. We'd like to be able to ignore those
+# as well. This _attempts_ to do that, however, as this uses simple regular
+# expressions we can only attempt to match so much. We probably should change
+# this for a node pattern matcher in the future.
+#
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes,
+#                           IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Layout/LineLength:
+  IgnoreCopDirectives: true
+  IgnoredPatterns:
+    # Leading comments
+    - '\A\s*#'
+    # Attempt at trailing comments
+    - '\A.{1,78}\s#\s.*\z'
+  Max: 100
+  Exclude:
+    - '**/*.gemspec'
 
 # We tend to indent multi-line operation statements. I think this is because it
 # tends to be the default style auto-formatted by VIM (which many of us use).
@@ -123,6 +172,18 @@ Layout/MultilineOperationIndentation:
 #     }.to change {
 #       object.state
 #     }
+#
+# WARNING TO FUTURE READERS (future being after 2021-12-10):
+# We tried to allowlist certain methods using the IgnoredMethods option (introduced 1.13.0),
+# and Rubocop successfully ignored `change` and `not_change` constructions, but it flag false
+# positives against code like
+#
+# expect { something }
+#   .to enqueue_job(SomeJobClass)
+#   .with { custom expectations about the enqueued payload }
+#
+# no matter what combination of `enqueue_job` and `with` we tried to add to the IgnoredMethods
+# array. We suspect the AST matching is somewhat half-baked.
 Lint/AmbiguousBlockAssociation:
   Exclude:
     - 'spec/**/*_spec.rb'
@@ -152,6 +213,10 @@ Lint/HeredocMethodCallPosition:
 Lint/InheritException:
   EnforcedStyle: standard_error
 
+# Make developers explain themselves in a comment if they want their rescue block to do nothing.
+Lint/SuppressedException:
+  AllowNil: false
+
 # Often with benchmarking we don't explicitly "use" a variable or return value.
 # We simply need to perform the operation which generates said value for the
 # benchmark.
@@ -162,70 +227,54 @@ Lint/Void:
     - 'benchmarks/**/*'
 
 Metrics/AbcSize:
-  # TODO: When we are able to upgrade to Rubocop 1.5.0 we want to enable the
-  # following `CountRepeatedAttributes` option. We often find the
-  # multi-references to the same object to be necessary for reability and that
-  # for our team it does not increase complexity.
-  #
-  # CountRepeatedAttributes: false
+  CountRepeatedAttributes: false
   Max: 17
 
-# Configuration parameters: CountComments, ExcludedMethods, Max.
-# ExcludedMethods: refine
+# Configuration parameters: CountComments, IgnoredMethods, Max.
+# IgnoredMethods: refine
 Metrics/BlockLength:
+  CountAsOne:
+    - 'array'
+    - 'hash'
+    - 'heredoc'
   Exclude:
     - '**/Rakefile'
     - '**/*.rake'
     - 'spec/spec_helper.rb'
     - 'spec/**/*_spec.rb'
     - 'spec/support/model_factories.rb'
-  ExcludedMethods:
+  IgnoredMethods:
     - 'chdir'
+    - 'describe'
     - 'refine'
+    - 'shared_context'
+    - 'shared_examples'
     - 'Capybara.register_driver'
     - 'RSpec.configure'
+    - 'RSpec.describe'
+    - 'RSpec.shared_context'
+    - 'RSpec.shared_examples'
     - 'VCR.configure'
 
-# We generally prefer to use the default line length of 80. Though sometimes
-# we just need a little extra space because it makes it easier to read.
-#
-# The only way to disable Rubocop for a single line is either to wrap the line
-# with two comments or append the disable comment to the end of the line. For
-# guard clauses, we tend to prefer trailing comments to avoid adding two lines
-# just to disable a cop on one line.
-#
-# Sometimes comments include ASCII diagrams, flow charts, etc. These cannot
-# always be reformatted to fit within the 80 column limit. Also, we write most
-# comments in markdown format. Rubocop isn't very good at understanding when
-# the line is long because of a URL in a markdown link. Instead of requiring
-# additional comments to turn this cop off for comments we ignore any long
-# lines which are only comments.
-#
-# There are also cases where for one valid reason or another we have a trailing
-# comment that extends a little too far. We'd like to be able to ignore those
-# as well. This _attempts_ to do that, however, as this uses simple regular
-# expressions we can only attempt to match so much. We probably should change
-# this for a node pattern matcher in the future.
-#
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes,
-#                           IgnoreCopDirectives, IgnoredPatterns.
-# URISchemes: http, https
-Metrics/LineLength:
-  IgnoreCopDirectives: true
-  IgnoredPatterns:
-    # Leading comments
-    - '\A\s*#'
-    # Attempt at trailing comments
-    - '\A.{1,78}\s#\s.*\z'
-  Max: 100
-  Exclude:
-    - '**/*.gemspec'
-
-# TODO: Remove this when we get to 0.89.0 as the new default max is 8
-#
-# Configuration parameters: IgnoredMethods, Max
-Metrics/PerceivedComplexity:
-  Max: 8
+# We want length related code metrics to count Hashs, Arrays, and
+# Heredocs as one "line"
+Metrics/ClassLength:
+  CountAsOne:
+    - 'array'
+    - 'hash'
+    - 'heredoc'
+
+Metrics/ModuleLength:
+  CountAsOne:
+    - 'array'
+    - 'hash'
+    - 'heredoc'
+
+Metrics/MethodLength:
+    CountAsOne:
+    - 'array'
+    - 'hash'
+    - 'heredoc'
 
 # This is overly pedantic (only allowing `other` as the parameter name). Ruby
 # core doesn't follow this consistently either. Looking at several classes
@@ -235,6 +284,21 @@ Metrics/PerceivedComplexity:
 Naming/BinaryOperatorParameterName:
   Enabled: false
 
+# We don't need this configured just yet, because we dont have any applications on
+# Ruby 3.1, but pre-emptively, we want to configure this to prefer the explicit style.
+# 
+# bad
+# def foo(&)
+#   bar(&)
+# end
+
+# good
+# def foo(&block)
+#   bar(&block)
+# end
+Naming/BlockForwarding:
+  EnforcedStyle: explicit
+
 # Configuration parameters: ExpectMatchingDefinition, Regex, IgnoreExecutableScripts, AllowedAcronyms.
 # AllowedAcronyms: CLI, DSL, ACL, API, ASCII, CPU, CSS, DNS, EOF, GUID, HTML, HTTP, HTTPS, ID, IP, JSON, LHS, QPS, RAM, RHS, RPC, SLA, SMTP, SQL, SSH, TCP, TLS, TTL, UDP, UI, UID, UUID, URI, URL, UTF8, VM, XML, XMPP, XSRF, XSS
 Naming/FileName:
@@ -248,14 +312,14 @@ Naming/FileName:
 # `EOF` is a common terminal abbreviate indicating end-of-file. We allow this
 # for those heredocs which represent "file" text.
 #
-# Configuration parameters: Blacklist.
-# Blacklist: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$))
+# Configuration parameters: ForbiddenDelimiters.
+# ForbiddenDelimiters: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$))
 Naming/HeredocDelimiterNaming:
   Details: |
 
     Use meaningful delimiter names to provide context to the text. The only
     allowed `EO*` variant if `EOF` which has specific meaning for file content.
-  Blacklist:
+  ForbiddenDelimiters:
     - !ruby/regexp '/(^|\s)(EO[A-EG-Z]{1}|END)(\s|$)/'
 
 # It is generally a good idea to match the instance variable names with their
@@ -324,6 +388,9 @@ Style/AndOr:
 # These days most people have editors which support unicode and other
 # non-ASCII characters.
 #
+# In version 1.21.0, this is disabled by default. We've chosen to leave
+# it in the config, in case it changes in future versions.
+#
 # Configuration parameters: AllowedChars.
 Style/AsciiComments:
   Enabled: false
@@ -380,6 +447,15 @@ Style/BlockDelimiters:
     - proc
     - it
 
+# As a team we prefer the more explicit `def self.method_name` style. We find
+# the explicitness easier to read and grep for on the CLI.
+#
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: def_self, self_class
+Style/ClassMethodsDefinitions:
+  Enabled: true
+  EnforcedStyle: def_self
+
 # Prefer `Time` over `DateTime`.
 #
 # While these are not necessarily interchangeable we prefer `Time`. According
@@ -454,6 +530,13 @@ Style/EmptyCaseCondition:
 Style/EmptyMethod:
   EnforcedStyle: expanded
 
+# Always require the pragma comment to be true
+#
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: always, always_true, never
+Style/FrozenStringLiteralComment:
+  EnforcedStyle: always_true
+
 # Prefer symbol keys using the 1.9 hash syntax. However, when keys are mixed
 # use a consistent mapping style; which generally means using hash rockets:
 #
@@ -474,6 +557,7 @@ Style/HashSyntax:
     Prefer symbol keys using the 1.9 hash syntax. However, when keys are mixed
     use a consistent mapping style; which generally means using hash rockets.
   EnforcedStyle: ruby19_no_mixed_keys
+  EnforcedShorthandSyntax: either
 
 # As part of our semantic style we generally use the literal `-> { }` format to
 # indicate this is a function with a return value we care about. As this cop
@@ -504,6 +588,11 @@ Style/MethodCalledOnDoEndBlock:
 Style/MultilineBlockChain:
   Enabled: false
 
+# Disallowing numbered parameter usage because we dont prefer this style.
+# We would rather name the paramaters to clearly communicate intent.
+Style/NumberedParameters:
+  EnforcedStyle: disallow
+
 # Context for this cop is too dependent.
 #
 # Often using the numeric comparison is faster. Also, depending on the context
@@ -520,6 +609,12 @@ Style/MultilineBlockChain:
 Style/NumericPredicate:
   Enabled: false
 
+# As a general rule, we want to be explicit here instead of requiring readers
+# of our code to know what the default arguments to methods like `#join` and
+# and `#split` so we disable this cop here.
+Style/RedundantArgument:
+  Enabled: false
+
 # In Ruby every method returns a value. Implicitly this is the value of the
 # last line of the method. This means using `return` is often redundant.
 # However, there isn't anything inherently wrong about doing so. In fact, in
@@ -627,6 +722,20 @@ Style/RescueStandardError:
     Avoid rescuing `Exception` as this may hide system errors.
   EnforcedStyle: implicit
 
+# We don't really care which style we use here and would prefer rubocop not
+# complain about this.
+Style/SlicingWithRange:
+  Enabled: false
+
+# We want to turn this cop on so that rubocop can yell at us instead of Aaron
+# yelling at us.
+Style/StaticClass:
+  Enabled: true
+
+# Enable Style/StringChars
+Style/StringChars:
+  Enabled: true
+
 # We generally prefer double quotes but many generators use single quotes. We
 # don't view the performance difference to be all that much so we don't care
 # if the style is mixed or double quotes are used for static strings.
@@ -657,6 +766,13 @@ Style/StringLiteralsInInterpolation:
 Style/SymbolArray:
   MinSize: 3
 
+# Allow either
+#   something.do_something(foo, &:bar)
+# or
+#   something.do_something(foo) { |s| s.bar }
+Style/SymbolProc:
+  AllowMethodsWithArguments: true
+
 # When ternaries become complex they can be difficult to read due to increased
 # cognitive load parsing the expression. Cognitive load can increase further
 # when assignment is involved.
@@ -719,6 +835,11 @@ Style/TrailingCommaInHashLiteral:
     simplifies adding, removing, and re-arranging the elements.
   EnforcedStyleForMultiline: consistent_comma
 
+# Don't combine && & || inside the same `unless` guard clause.
+Style/UnlessLogicalOperators:
+  Enabled: true
+  EnforcedStyle: forbid_mixed_logical_operators
+
 # We don't feel too strongly about percent vs bracket array style. We tend to
 # use the percent style, which also happens to be Rubocop's default. So for
 # pedantic consistency we'll enforce this.
@@ -738,3 +859,7 @@ Style/WordArray:
 # SupportedStyles: all_comparison_operators, equality_operators_only
 Style/YodaCondition:
   Enabled: false
+
+# Disabled in 1.21.0. Radius Networks has chosen to enable it.
+Naming/InclusiveLanguage:
+  Enabled: true

data/common_rubocop_rails.yml

@@ -20,26 +20,26 @@ AllCops:
     - 'db/migrate/**/*'
 
 # Rails project's are not concerned with API docs normally
-Documentation:
+Style/Documentation:
   Enabled: false
 
-Metrics/BlockLength:
-  Exclude:
-    - 'bin/setup'
-    - 'bin/update'
-    - 'config/routes.rb'
-    - 'spec/rails_helper.rb'
-
 # Rails foreign keys and indexes can get long. We want to ignore our annotation
 # comments which are for these entries.
 #
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https
-Metrics/LineLength:
+Layout/LineLength:
   IgnoredPatterns:
     - '\A#  fk_rails_'
     - '\A#  index_'
 
+Metrics/BlockLength:
+  Exclude:
+    - 'bin/setup'
+    - 'bin/update'
+    - 'config/routes.rb'
+    - 'spec/rails_helper.rb'
+
 # For our Rails apps several of them use the `respond_to` with `format` blocks
 # to handle various mime types (mostly HTML and JSON). Given our `do` / `end`
 # block style for non-functional blocks (which includes both `respond_to` and
@@ -106,19 +106,39 @@ Rails/ApplicationRecord:
 Rails/CreateTableWithTimestamps:
   Enabled: false
 
+# This cop looks for uses of default_scope because named scopes are preferred:
+# https://rails.rubystyle.guide/#named-scopes
+Rails/DefaultScope:
+  Enabled: true
+
+# We were originally going to disable this, but after much discussion agreed that enabling
+# this cop with AllowReads: true should be relatively painless.
+Rails/EnvironmentVariableAccess:
+  Enabled: true
+  AllowReads: true
+
 # Usage of `find_by` is more expressive of intent than `where.first`. We should
 # check all app code, not just the models to improve intent expression.
 #
 # Since rake tasks often live in `lib` we also check all of lib as well.
 #
+# We are also disabling the default IgnoreWhereFirst that was added in version
+# 2.11
+#
 # Configuration parameters: Include.
 # Include: app/models/**/*.rb
 Rails/FindBy:
   Enabled: true
+  IgnoreWhereFirst: false
   Include:
     - 'app/**/*.rb'
     - 'lib/**/*.rb'
 
+# This cop enforces that ActiveRecord#find is used instead of where.take!, find_by!, and find_by_id!
+# to retrieve a single record by primary key when you expect it to be found.
+Rails/FindById:
+  Enabled: true
+
 # Usage of `each` for large datasets can be a performance issue; specially a
 # drain on system memory. When possible it's better to use `find_each` so that
 # chunks of data are evaluated at a time.
@@ -150,6 +170,45 @@ Rails/HasAndBelongsToMany:
 Rails/IgnoredSkipActionFilterOption:
   Enabled: false
 
+# We do not care about this check due to its lack of configuration.
+#
+# Some of the team finds the naming of this method is more confusing than using
+# `each_with_object`. We all agree the other examples are bad and should not be
+# used:
+#
+#     # OK for us
+#     [1, 2, 3].each_with_object({}) { |el, h| h[foo(el)] = el }
+#
+#     # Bad
+#     [1, 2, 3].to_h { |el| [foo(el), el] }
+#     [1, 2, 3].map { |el| [foo(el), el] }.to_h
+#     Hash[[1, 2, 3].collect { |el| [foo(el), el] }]
+#
+# If this check supports configuration in the future so that we can allow
+# `each_with_object` then we'll turn it back on.
+Rails/IndexBy:
+  Enabled: false
+
+# We find the name of this method to be very confusing. We'd prefer this method
+# is never used.
+Rails/IndexWith:
+  Enabled: false
+
+# This cop enforces the use of ids over pluck(:id) and pluck(primary_key).
+# https://rails.rubystyle.guide/#ids
+Rails/PluckId:
+  Enabled: true
+
+# This cop identifies places where pluck is used in where query methods and can be replaced with
+# select. Since pluck is an eager method and hits the database immediately, using select helps to
+# avoid additional database queries.
+#
+# When the EnforcedStyle is aggressive then all calls to pluck in the where is used as offenses.
+# This may lead to false positives as the cop cannot replace to select between calls to pluck on an
+# ActiveRecord::Relation instance vs a call to pluck on an Array instance.
+Rails/PluckInWhere:
+  EnforcedStyle: aggressive
+
 # The ActiveSupport monkey patches for `present?` are nearly all defined as:
 #
 #     !blank?
@@ -179,6 +238,10 @@ Rails/Present:
 Rails/ReadWriteAttribute:
   Enabled: false
 
+# Enabling this because it is disabled by default and we want it.
+Rails/ReversibleMigrationMethodDefinition:
+  Enabled: true
+
 # This ensures we do not ignore potential validation issues in the code. Doing
 # so can lead to strange and surprising bugs where records are expected to
 # be created, or be modified, but are not.
@@ -210,6 +273,13 @@ Rails/ReadWriteAttribute:
 Rails/SaveBang:
   Enabled: true
 
+# This cop enforces that short forms of I18n methods are used: t instead of translate and l instead
+# of localize. We want this because it's a pain to use the full method names over and over in view
+# code. When the EnforcedStyle is aggressive then all translate and localize calls without a
+# receiver are added as offenses.
+Rails/ShortI18n:
+  EnforcedStyle: aggressive
+
 # According to the Rails docs while the following methods skip validations they
 # only update the specified (single) attribute reducing risks. We'd rather not
 # warn for those cases:
@@ -227,14 +297,19 @@ Rails/SaveBang:
 #   - http://api.rubyonrails.org/classes/ActiveRecord/Persistence.html
 #   - http://api.rubyonrails.org/classes/ActiveRecord/Relation.html
 #
-# Configuration parameters: Blacklist, Whitelist.
-# Blacklist: decrement!, decrement_counter, increment!, increment_counter, toggle!, touch, update_all, update_attribute, update_column, update_columns, update_counters
+# Configuration parameters: ForbiddenMethods, AllowedMethods.
+# ForbiddenMethods: decrement!, decrement_counter, increment!, increment_counter, toggle!, touch, update_all, update_attribute, update_column, update_columns, update_counters
 Rails/SkipsModelValidations:
-  Whitelist:
+  AllowedMethods:
     - 'decrement!'
     - 'increment!'
     - 'touch'
 
+# We don't want to be forced to use squish in SQL or JSON heredocs (especially
+# in specs).
+Rails/SquishedSQLHeredocs:
+  Enabled: false
+
 # Rails uses compact style by default so we're disabling this with a :hammer:
 # for things likely to be generated by Rails (i.e. most things in app).
 #

data/lib/radius/spec/model_factory.rb

@@ -109,7 +109,14 @@ module Radius
       # factory {Radius::Spec::ModelFactory.catalog}.
       class TemplateNotFound < KeyError; end
 
-      class << self
+      class << self # rubocop:disable Style/ClassMethodsDefinitions
+        # Style Note: We are using this class method style because we need to
+        # call `alias_method` within this module's singleton class context.
+        # Ruby did not introduce access to `singleton_class` until 2.7. Once we
+        # drop support for Ruby < 2.7 we can switch styles and use:
+        #
+        #     singleton_class.alias_method :factory, :define_factory
+
         # Suggested method for defining multiple factory templates at once.
         #
         # Most projects end up having many domain models which need factories
@@ -482,10 +489,8 @@ module Radius
 end
 
 # Try to load the factories defined for the specs
-# rubocop:disable Lint/HandleExceptions
 begin
   require 'support/model_factories'
 rescue LoadError
   # Ignore as this is an optional convenience feature
 end
-# rubocop:enable Lint/HandleExceptions

data/lib/radius/spec/rspec.rb

@@ -22,6 +22,10 @@ RSpec.configure do |config|
     # ...rather than:
     #     # => "be bigger than 2"
     expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+
+    # The default is to warn, but this normally just gets ignored by
+    # developers. It's best to fix the problem then live with the warning.
+    expectations.on_potential_false_positives = :raise
   end
 
   # rspec-mocks config goes here. You can use an alternate test double
@@ -101,6 +105,11 @@ RSpec.configure do |config|
   # as the one that triggered the failure.
   Kernel.srand config.seed
 
+  # Common shared_example / shared_context inclusion alias for behavior driven
+  # development
+  config.alias_it_should_behave_like_to :has_behavior
+  config.alias_it_should_behave_like_to :it_has_behavior, 'has behavior:'
+
   config.when_first_matching_example_defined(
     :model_factory,
     :model_factories,
@@ -124,6 +133,11 @@ RSpec.configure do |config|
     config.include Radius::Spec::ModelFactory, type: :feature
   end
 
+  config.when_first_matching_example_defined(type: :helper) do
+    require 'radius/spec/model_factory'
+    config.include Radius::Spec::ModelFactory, type: :helper
+  end
+
   config.when_first_matching_example_defined(type: :job) do
     require 'radius/spec/model_factory'
     config.include Radius::Spec::ModelFactory, type: :job

data/lib/radius/spec/vcr.rb

@@ -10,15 +10,15 @@ VCR.configure do |config|
   config.ignore_localhost = true
 
   record_mode = case
+                when ENV['CI']
+                  # Never let CI record
+                  :none
                 when RSpec.configuration.files_to_run.one?
                   # When developing new features we often run new specs in
                   # isolation as we write the code. This is the time to allow
                   # creating the cassettes.
                   :once
-                when ENV['CI']
-                  # Never let CI record
-                  :none
-                else
+                else # rubocop:disable Lint/DuplicateBranch
                   # Default to blocking new requests to catch issues
                   :none
                 end
@@ -91,10 +91,8 @@ RSpec.configure do |config|
 end
 
 # Try to any custom VCR config for the app
-# rubocop:disable Lint/HandleExceptions
 begin
   require 'support/vcr'
 rescue LoadError
   # Ignore as this is an optional convenience feature
 end
-# rubocop:enable Lint/HandleExceptions

data/lib/radius/spec/version.rb

@@ -2,6 +2,6 @@
 
 module Radius
   module Spec
-    VERSION = "0.7.0"
+    VERSION = "0.11.0"
   end
 end