radius-spec 0.5.0 → 0.9.0

data/common_rubocop_rails.yml

@@ -1,3 +1,5 @@
+require: rubocop-rails
+
 inherit_mode:
   merge:
     - Exclude
@@ -5,10 +7,6 @@ inherit_mode:
 
 inherit_from: common_rubocop.yml
 
-# Enable additional Rails cops
-Rails:
-  Enabled: true
-
 AllCops:
   Exclude:
     - 'bin/puma'
@@ -22,24 +20,26 @@ AllCops:
     - 'db/migrate/**/*'
 
 # Rails project's are not concerned with API docs normally
-Documentation:
+Style/Documentation:
   Enabled: false
 
-Metrics/BlockLength:
-  Exclude:
-    - 'config/routes.rb'
-    - 'spec/rails_helper.rb'
-
 # Rails foreign keys and indexes can get long. We want to ignore our annotation
 # comments which are for these entries.
 #
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https
-Metrics/LineLength:
+Layout/LineLength:
   IgnoredPatterns:
     - '\A#  fk_rails_'
     - '\A#  index_'
 
+Metrics/BlockLength:
+  Exclude:
+    - 'bin/setup'
+    - 'bin/update'
+    - 'config/routes.rb'
+    - 'spec/rails_helper.rb'
+
 # For our Rails apps several of them use the `respond_to` with `format` blocks
 # to handle various mime types (mostly HTML and JSON). Given our `do` / `end`
 # block style for non-functional blocks (which includes both `respond_to` and
@@ -143,6 +143,37 @@ Rails/FindEach:
 Rails/HasAndBelongsToMany:
   Enabled: false
 
+# We find the combo `:only` and `:if` readable. While the `:except` and `:if`
+# combo is easier to read as a combined proc. As a team we are fine with
+# handling this in PR reviews, until such time which Rubocop provides an option
+# for us to configure this.
+Rails/IgnoredSkipActionFilterOption:
+  Enabled: false
+
+# We do not care about this check due to its lack of configuration.
+#
+# Some of the team finds the naming of this method is more confusing than using
+# `each_with_object`. We all agree the other examples are bad and should not be
+# used:
+#
+#     # OK for us
+#     [1, 2, 3].each_with_object({}) { |el, h| h[foo(el)] = el }
+#
+#     # Bad
+#     [1, 2, 3].to_h { |el| [foo(el), el] }
+#     [1, 2, 3].map { |el| [foo(el), el] }.to_h
+#     Hash[[1, 2, 3].collect { |el| [foo(el), el] }]
+#
+# If this check supports configuration in the future so that we can allow
+# `each_with_object` then we'll turn it back on.
+Rails/IndexBy:
+  Enabled: false
+
+# We find the name of this method to be very confusing. We'd prefer this method
+# is never used.
+Rails/IndexWith:
+  Enabled: false
+
 # The ActiveSupport monkey patches for `present?` are nearly all defined as:
 #
 #     !blank?
@@ -220,17 +251,13 @@ Rails/SaveBang:
 #   - http://api.rubyonrails.org/classes/ActiveRecord/Persistence.html
 #   - http://api.rubyonrails.org/classes/ActiveRecord/Relation.html
 #
+# Configuration parameters: Blacklist, Whitelist.
 # Blacklist: decrement!, decrement_counter, increment!, increment_counter, toggle!, touch, update_all, update_attribute, update_column, update_columns, update_counters
 Rails/SkipsModelValidations:
-  Blacklist:
-    - 'decrement_counter'
-    - 'increment_counter'
-    - 'toggle!'
-    - 'update_all'
-    - 'update_attribute'
-    - 'update_column'
-    - 'update_columns'
-    - 'update_counters'
+  Whitelist:
+    - 'decrement!'
+    - 'increment!'
+    - 'touch'
 
 # Rails uses compact style by default so we're disabling this with a :hammer:
 # for things likely to be generated by Rails (i.e. most things in app).

data/lib/radius/spec/model_factory.rb

@@ -482,10 +482,8 @@ module Radius
 end
 
 # Try to load the factories defined for the specs
-# rubocop:disable Lint/HandleExceptions
 begin
   require 'support/model_factories'
 rescue LoadError
   # Ignore as this is an optional convenience feature
 end
-# rubocop:enable Lint/HandleExceptions

data/lib/radius/spec/rspec.rb

@@ -22,6 +22,10 @@ RSpec.configure do |config|
     # ...rather than:
     #     # => "be bigger than 2"
     expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+
+    # The default is to warn, but this normally just gets ignored by
+    # developers. It's best to fix the problem then live with the warning.
+    expectations.on_potential_false_positives = :raise
   end
 
   # rspec-mocks config goes here. You can use an alternate test double
@@ -101,6 +105,11 @@ RSpec.configure do |config|
   # as the one that triggered the failure.
   Kernel.srand config.seed
 
+  # Common shared_example / shared_context inclusion alias for behavior driven
+  # development
+  config.alias_it_should_behave_like_to :has_behavior
+  config.alias_it_should_behave_like_to :it_has_behavior, 'has behavior:'
+
   config.when_first_matching_example_defined(
     :model_factory,
     :model_factories,

data/lib/radius/spec/vcr.rb

@@ -91,10 +91,8 @@ RSpec.configure do |config|
 end
 
 # Try to any custom VCR config for the app
-# rubocop:disable Lint/HandleExceptions
 begin
   require 'support/vcr'
 rescue LoadError
   # Ignore as this is an optional convenience feature
 end
-# rubocop:enable Lint/HandleExceptions

data/lib/radius/spec/version.rb

@@ -2,6 +2,6 @@
 
 module Radius
   module Spec
-    VERSION = "0.5.0"
+    VERSION = "0.9.0"
   end
 end

data/radius-spec.gemspec

@@ -12,7 +12,7 @@ Gem::Specification.new do |spec|
 
   spec.metadata      = {
     "bug_tracker_uri" => "https://github.com/RadiusNetworks/radius-spec/issues",
-    "changelog_uri"   => "https://github.com/RadiusNetworks/radius-spec/blob/v#{Radius::Spec::VERSION}/CHANGELOG.md",
+    "changelog_uri" => "https://github.com/RadiusNetworks/radius-spec/blob/v#{Radius::Spec::VERSION}/CHANGELOG.md",
     "source_code_uri" => "https://github.com/RadiusNetworks/radius-spec/tree/v#{Radius::Spec::VERSION}",
   }
   spec.summary       = "Radius Networks RSpec setup and plug-ins"
@@ -21,18 +21,19 @@ Gem::Specification.new do |spec|
   spec.homepage      = "https://github.com/RadiusNetworks/radius-spec"
   spec.license       = "Apache-2.0"
 
-  spec.files         = `git ls-files -z`.split("\x0").reject do |f|
+  spec.files         = `git ls-files -z`.split("\x0").reject { |f|
     f.match(%r{^(test|spec|features)/})
-  end
+  }
   spec.bindir        = "exe"
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.required_ruby_version = ">= 2.5"
+  spec.required_ruby_version = ">= 2.5" # rubocop:disable Gemspec/RequiredRubyVersion
 
   spec.add_runtime_dependency "rspec", "~> 3.7"
-  spec.add_runtime_dependency "rubocop", "~> 0.59.1"
+  spec.add_runtime_dependency "rubocop", "~> 0.89.0"
+  spec.add_runtime_dependency "rubocop-rails", "~> 2.6.0"
 
-  spec.add_development_dependency "bundler", "~> 1.16"
-  spec.add_development_dependency "rake", "~> 12.0"
+  spec.add_development_dependency "bundler", ">= 2.2.10"
+  spec.add_development_dependency "rake", ">= 12.0", "< 14.0"
 end

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: radius-spec
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.9.0
 platform: ruby
 authors:
 - Radius Networks
 - Aaron Kromer
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2018-09-26 00:00:00.000000000 Z
+date: 2021-09-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -31,42 +31,62 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.59.1
+        version: 0.89.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.59.1
+        version: 0.89.0
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.16'
-  type: :development
+        version: 2.6.0
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.16'
+        version: 2.6.0
+- !ruby/object:Gem::Dependency
+  name: bundler
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 2.2.10
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 2.2.10
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '12.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '14.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '12.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '14.0'
 description: Standard RSpec setup and a collection of plug-ins to help improve specs.
 email:
 - support@radiusnetworks.com
@@ -74,10 +94,11 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/ci.yml"
+- ".github/workflows/reviewdog.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
-- ".travis.yml"
 - ".yardopts"
 - CHANGELOG.md
 - CODE_OF_CONDUCT.md
@@ -88,6 +109,7 @@ files:
 - benchmarks/bm_setup.rb
 - benchmarks/call_vs_yield.rb
 - benchmarks/case_equality_vs_class_check.rb
+- benchmarks/casecmp_vs_downcase.rb
 - benchmarks/cover_vs_include.rb
 - benchmarks/delete_vs_tr.rb
 - benchmarks/double_negation.rb
@@ -95,14 +117,16 @@ files:
 - benchmarks/format_string.rb
 - benchmarks/format_string_token.rb
 - benchmarks/gsub_vs_tr.rb
+- benchmarks/hash_each.rb
 - benchmarks/hash_merge.rb
+- benchmarks/hash_transform.rb
 - benchmarks/kwargs.rb
 - benchmarks/max_ternary.rb
 - benchmarks/max_ternary_micro.rb
+- benchmarks/style_hash_like_case.rb
 - benchmarks/unfreeze_string.rb
 - benchmarks/unpack_first.rb
 - bin/ci
-- bin/ci-code-review
 - bin/console
 - bin/pry
 - bin/rake
@@ -126,9 +150,9 @@ licenses:
 - Apache-2.0
 metadata:
   bug_tracker_uri: https://github.com/RadiusNetworks/radius-spec/issues
-  changelog_uri: https://github.com/RadiusNetworks/radius-spec/blob/v0.5.0/CHANGELOG.md
-  source_code_uri: https://github.com/RadiusNetworks/radius-spec/tree/v0.5.0
-post_install_message: 
+  changelog_uri: https://github.com/RadiusNetworks/radius-spec/blob/v0.9.0/CHANGELOG.md
+  source_code_uri: https://github.com/RadiusNetworks/radius-spec/tree/v0.9.0
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -143,9 +167,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
-signing_key: 
+rubygems_version: 3.1.2
+signing_key:
 specification_version: 4
 summary: Radius Networks RSpec setup and plug-ins
 test_files: []

data/.travis.yml

@@ -1,17 +0,0 @@
-sudo: false
-language: ruby
-cache: bundler
-before_install:
-  - gem update --system
-  - gem install bundler
-bundler_args: --jobs=3 --retry=3 --without documentation debug
-before_script:
-  - "bin/ci-code-review"
-script: bin/ci
-rvm:
-  - 2.5
-  - ruby-head
-matrix:
-  allow_failures:
-    - rvm: ruby-head
-  fast_finish: true

data/bin/ci-code-review

@@ -1,28 +0,0 @@
-#!/bin/bash
-
-# See:
-#   - https://docs.travis-ci.com/user/environment-variables/#Convenience-Variables
-#   - https://docs.travis-ci.com/user/environment-variables/#Default-Environment-Variables
-#   - https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
-if [[ "$TRAVIS_PULL_REQUEST" = "false" ]] || [[ "$TRAVIS_BRANCH" = "production" ]]; then
-  exit
-fi
-
-set -e
-cd "$(dirname "$0")/.."
-
-REVIEWDOG_VERSION="0.9.9"
-
-if ! [ "$(./bin/reviewdog -version)" = "$REVIEWDOG_VERSION" ]; then
-  echo "Installing reviewdog version ${REVIEWDOG_VERSION}..."
-  curl -fsSL https://github.com/haya14busa/reviewdog/releases/download/$REVIEWDOG_VERSION/reviewdog_linux_amd64 \
-    -o ./bin/reviewdog
-  chmod +x ./bin/reviewdog
-fi
-
-echo Rubocop Version: $(./bin/rubocop --version)
-echo Review Dog Version: $(./bin/reviewdog -version)
-
-# Add `-diff="git diff master"` to reviewdog args when running locally
-./bin/rubocop --config .rubocop.yml --extra-details --display-style-guide --rails | \
-  ./bin/reviewdog -f=rubocop -reporter=github-pr-check