radius-spec 0.14.0 → 0.15.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c8d597edb6ceafbec64f128f6916a669bb632dd47a7f30005a74c708cc650157
-  data.tar.gz: 2742aed45c3a37ffb4ae489128b525987e79de39d6a405f768391c20e2204f7d
+  metadata.gz: 11d5afd163004c770b391ddaa8b133e30382f138dd3dd84305110da2e12cec9d
+  data.tar.gz: 40f4a119924a39691ebf6536859d25c070ece461f2e076414f4a9e36023ccc09
 SHA512:
-  metadata.gz: 6c2fbdfd8c2d2cb6022240184cf4e321a610efb5402d2e332668ef5b3d0a471d689cee73f41e4aa9b12f97416cd7f18870587b85d9d0cd727d7db63cda8cdab7
-  data.tar.gz: 4aa93da9405ef5a2cd35e54b5c219772ba987dd25c42c6143b4180b54aec6a3a158990acb88c54c536df573749769f29dfca900498de457ebc5805003fc7b9d6
+  metadata.gz: 139670b6368055942aabd6c739c98d4fa9156db3311713df9b91dfc7442b18bc11b8e732f752a5929fa793dca5e8e9f0fd8bd7919a6e15a4b671f6382bee498f
+  data.tar.gz: 5ae9482c86f52ca6e8b7be513403211ab63b524ec1e99031461fd0347e6ba75d3098a8268127f26861342ea3d6169f09f8527236c36dff9a58f50480aba3cf57

data/.github/workflows/ci.yml

@@ -15,7 +15,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        ruby-version: ['2.7', '3.0']
+        ruby-version: ['3.1', '3.2']
 
     steps:
     - uses: actions/checkout@v2

data/.github/workflows/reviewdog.yml

@@ -9,7 +9,7 @@ jobs:
         uses: actions/checkout@v1
       - uses: ruby/setup-ruby@v1 # ruby-version pulled .ruby-version file automatically
         with:
-          ruby-version: '2.7'
+          ruby-version: '3.1'
           bundler-cache: true
       - name: rubocop
         uses: reviewdog/action-rubocop@v1

data/.gitignore

@@ -32,6 +32,7 @@
 Gemfile.lock
 .ruby-version
 .ruby-gemset
+.tool-versions
 
 # unless supporting rvm < 1.11.0 or doing something fancy, ignore this:
 .rvmrc

data/Gemfile

@@ -7,6 +7,11 @@ git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 # Specify your gem's dependencies in radius-spec.gemspec
 gemspec
 
+group :development do
+  gem "bundler", ">= 2.2.10"
+  gem "rake", ">= 12.0", "< 14.0"
+end
+
 group :benchmark, optional: true do
   gem 'activesupport', require: false
   gem 'benchmark-ips', require: false

data/README.md

@@ -781,11 +781,18 @@ After checking out the repo, run `bin/setup` to install dependencies. Then, run
 `rake spec` to run the tests. You can also run `bin/console` for an interactive
 prompt that will allow you to experiment.
 
-To install this gem onto your local machine, run `bundle exec rake install`. To
-release a new version, update the version number in `version.rb`, and then run
-`bundle exec rake release`, which will create a git tag for the version, push
-git commits and tags, and push the `.gem` file to
-[rubygems.org](https://rubygems.org).
+To install this gem onto your local machine, run `bundle exec rake install`.
+
+To release a new version:
+- Update the CHANGELOG file with auto-generated release notes from Github (create
+the next tag in Github releases)
+- Update the version number in `version.rb`
+- Commit these changes and push up a branch. Get it approved.
+- From the updated `main` branch, run `bundle exec rake release`, which will
+  create a git tag for the version, push git commits and tags, and push
+  the `.gem` file to [rubygems.org](https://rubygems.org).
+- Create a Github release using the tag you created in the first step, and mark
+  it as the latest.
 
 ## Contributing
 

data/common_rubocop.yml

@@ -818,27 +818,28 @@ Style/TrailingCommaInArguments:
 # by cutting down on noise when commas are appended.
 #
 # Configuration parameters: EnforcedStyleForMultiline.
-# SupportedStylesForMultiline: comma, consistent_comma, no_comma
+# SupportedStylesForMultiline: comma, consistent_comma, no_comma, diff_comma
 Style/TrailingCommaInArrayLiteral:
   Details: |
 
-    Always use trailing commas for multiline arrays. This makes git diffs
-    easier to read by cutting down on noise when commas are appended. It also
-    simplifies adding, removing, and re-arranging the elements.
-  EnforcedStyleForMultiline: consistent_comma
+    Always use trailing commas for multiline arrays, but allow no trailing comma
+    for single line arrays. This makes git diffs easier to read by cutting down on
+    noise when commas are appended. It also simplifies adding, removing, and
+    re-arranging the elements.
+  EnforcedStyleForMultiline: diff_comma
 
 # Always use trailing commas for multiline. This makes git diffs easier to read
 # by cutting down on noise when commas are appended.
 #
 # Configuration parameters: EnforcedStyleForMultiline.
-# SupportedStylesForMultiline: comma, consistent_comma, no_comma
+# SupportedStylesForMultiline: comma, consistent_comma, no_comma, diff_comma
 Style/TrailingCommaInHashLiteral:
   Details: |
 
-    Always use trailing commas for multiline hashes. This makes git diffs
-    easier to read by cutting down on noise when commas are appended. It also
-    simplifies adding, removing, and re-arranging the elements.
-  EnforcedStyleForMultiline: consistent_comma
+    Always use trailing commas for multiline hashes, but allows no trailing commas for
+    single line hashes. This makes git diffs easier to read by cutting down on noise
+    when commas are appended. It also simplifies adding, removing, and re-arranging the elements.
+  EnforcedStyleForMultiline: diff_comma
 
 # Don't combine && & || inside the same `unless` guard clause.
 Style/UnlessLogicalOperators:

data/common_rubocop_rails.yml

@@ -1,4 +1,7 @@
-require: rubocop-rails
+plugins:
+- rubocop-rails
+- rubocop-rspec
+- rubocop-rspec_rails
 
 inherit_mode:
   merge:
@@ -23,6 +26,15 @@ AllCops:
 Style/Documentation:
   Enabled: false
 
+RSpecRails:
+  Enabled: false
+
+RSpec:
+  Enabled: false
+
+RSpec/Focus:
+  Enabled: true
+
 # Rails foreign keys and indexes can get long. We want to ignore our annotation
 # comments which are for these entries.
 #
@@ -75,14 +87,21 @@ Metrics/BlockLength:
 # We do believe that the default size of 10, which is what we explicitly
 # configure below so there's no confusion, is a good general limit to help
 # encourage a balance between terseness and procedural code. Thus we do not
-# want to raise the limit, instead we just want to exclude these controllers.
+# want to raise the limit, instead we just want to exclude these controllers. (@cupakromer 2019)
+#
+# We have since raised this limit to 20. We found that too often this cop was being
+# imposed on methods that eked above 10 lines, and the resulting refactoring created
+# code that was less readable overall. Some of us felt the method should be removed
+# entirely, or made significantly larger (trusting devs to self-regulate),
+# but we compromised by doubling it to 20 instead. Devs should still be encouraged to
+# be pragmatic about this, and to see this as a guardrail and not an absolute limit. (@armahillo 2026)
 #
 # At this time there is no way for us to exclude just the common controller
-# actions / *_params methods so we exclude the entire file.
+# actions / *_params methods so we exclude the entire file. (@cupakromer 2019)
 #
 # Configuration parameters: CountComments.
 Metrics/MethodLength:
-  Max: 10
+  Max: 20
   Exclude:
     - 'app/controllers/**/*_controller.rb'
 
@@ -111,6 +130,11 @@ Rails/CreateTableWithTimestamps:
 Rails/DefaultScope:
   Enabled: true
 
+# This cop checks for usage of Rails.env.foo? and prefers it to be replaced with Feature Flags. Since our team
+# uses Rails.env.foo rarely in configuration files, this isn't a problem we need to have a cop in place for.
+Rails/Env:
+  Enabled: false
+
 # We were originally going to disable this, but after much discussion agreed that enabling
 # this cop with AllowReads: true should be relatively painless.
 Rails/EnvironmentVariableAccess:
@@ -198,6 +222,12 @@ Rails/IndexWith:
 Rails/I18nLocaleTexts:
   Enabled: false
 
+# This cop enforced a style that helps prevent ambigous calls, which we already use throughout the codebase.
+# The cop doesn't however, account for complex  calls like `.order('site_id NULLS FIRST', :description)`.
+# Team decided to disable.
+Rails/OrderArguments:
+  Enabled: false
+
 # This cop enforces the use of ids over pluck(:id) and pluck(primary_key).
 # https://rails.rubystyle.guide/#ids
 Rails/PluckId:

data/lib/radius/spec/version.rb

@@ -2,6 +2,6 @@
 
 module Radius
   module Spec
-    VERSION = "0.14.0"
+    VERSION = "0.15.1"
   end
 end

data/radius-spec.gemspec

@@ -29,12 +29,10 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.required_ruby_version = ">= 2.5" # rubocop:disable Gemspec/RequiredRubyVersion
+  spec.required_ruby_version = ">= 3.1" # rubocop:disable Gemspec/RequiredRubyVersion
 
-  spec.add_runtime_dependency "rspec", "~> 3.7"
-  spec.add_runtime_dependency "rubocop", ">= 1.25", "< 1.62"
-  spec.add_runtime_dependency "rubocop-rails", ">= 2.13", "< 2.22"
-
-  spec.add_development_dependency "bundler", ">= 2.2.10"
-  spec.add_development_dependency "rake", ">= 12.0", "< 14.0"
+  spec.add_dependency "rspec", "~> 3.7"
+  spec.add_dependency "rubocop", ">= 1.25", "< 1.83"
+  spec.add_dependency "rubocop-rails", ">= 2.13", "< 2.35"
+  spec.add_dependency "rubocop-rspec_rails", "~> 2.31"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: radius-spec
 version: !ruby/object:Gem::Version
-  version: 0.14.0
+  version: 0.15.1
 platform: ruby
 authors:
 - Radius Networks
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-05-23 00:00:00.000000000 Z
+date: 2026-03-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -34,7 +34,7 @@ dependencies:
         version: '1.25'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '1.62'
+        version: '1.83'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -44,7 +44,7 @@ dependencies:
         version: '1.25'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '1.62'
+        version: '1.83'
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
@@ -54,7 +54,7 @@ dependencies:
         version: '2.13'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '2.22'
+        version: '2.35'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -64,41 +64,21 @@ dependencies:
         version: '2.13'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '2.22'
+        version: '2.35'
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: rubocop-rspec_rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 2.2.10
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 2.2.10
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '12.0'
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '14.0'
-  type: :development
+        version: '2.31'
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '12.0'
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '14.0'
+        version: '2.31'
 description: Standard RSpec setup and a collection of plug-ins to help improve specs.
 email:
 - support@radiusnetworks.com
@@ -164,8 +144,8 @@ licenses:
 - Apache-2.0
 metadata:
   bug_tracker_uri: https://github.com/RadiusNetworks/radius-spec/issues
-  changelog_uri: https://github.com/RadiusNetworks/radius-spec/blob/v0.14.0/CHANGELOG.md
-  source_code_uri: https://github.com/RadiusNetworks/radius-spec/tree/v0.14.0
+  changelog_uri: https://github.com/RadiusNetworks/radius-spec/blob/v0.15.1/CHANGELOG.md
+  source_code_uri: https://github.com/RadiusNetworks/radius-spec/tree/v0.15.1
   rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options: []
@@ -175,14 +155,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.5'
+      version: '3.1'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.26
+rubygems_version: 3.3.27
 signing_key:
 specification_version: 4
 summary: Radius Networks RSpec setup and plug-ins