radius-spec 0.11.0 → 0.12.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8866a2f90557e85b2974af975e2461737ee1393031ffa7ab5aeacfcd9b2b2c46
-  data.tar.gz: 5f04fb6044c683d90c7cd331423c069fd97b6bd1e2de54a6251051a52b86c23c
+  metadata.gz: 546fb33c439cbca96fc9807190531ce04602dcc57d47092210453bce377f5caf
+  data.tar.gz: 10b9a8e011aeefa54947f20c4ad09802cfe1139611fcc749f3b097a83df4f75c
 SHA512:
-  metadata.gz: ee3d463a37fee11380d6700ed966068fdf20ac19d1636a9e577959c633bdde2d04657dca074b6e6c53a24f536d637f254340c7c775853a20214691698218f0fd
-  data.tar.gz: 014b79fb72b9ef1ecb07e8d6ec01e660755eef2dc484d807e525a62d975e624392ab92f990f2ee80acbaa6b8b3bcd6020a8b27613e0d7a6c67bca94bf6a1476f
+  metadata.gz: 8e86cdfe23e2f82994484e43d8c9c11b751931c869f04e5d3df86085ebdab97cca75804c9d5befc62eca73c53faa570f411aa55d2eb582fb441c581261e5d31f
+  data.tar.gz: 9c959caac8ffcd3a630586671c1cfafdc3d11347e36b0aee4210dc5e2fdfff61f76022a9d449acc2ecdcc2e3ebd4bd79f1ed32b568791fe23e954a11465a0099

data/.github/dependabot.yml

@@ -0,0 +1,10 @@
+version: 2
+updates:
+- package-ecosystem: bundler
+  directory: "/"
+  schedule:
+    interval: daily
+    time: "11:00"
+  open-pull-requests-limit: 10
+#  allow:
+#  - dependency-type: direct

data/.rubocop.yml

@@ -1,11 +1,11 @@
 inherit_mode:
   merge:
     - Exclude
-    - IgnoredPatterns
+    - AllowedPatterns
 
 inherit_from: common_rubocop_rails.yml
 
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns.
 # URISchemes: http, https
 Layout/LineLength:
   Exclude:

data/CHANGELOG.md

@@ -1,3 +1,36 @@
+## Development
+
+[Full Changelog](https://github.com/RadiusNetworks/radius-spec/compare/v0.12.0...main)
+
+### Enhancements
+
+- TODO
+
+### Bug Fixes
+
+- TODO
+
+## 0.12.0 (August 3, 2022)
+
+[Full Changelog](https://github.com/RadiusNetworks/radius-spec/compare/v0.11.0...v0.12.0)
+
+### Enhancements
+
+- Upgrade `rubocop` (1.0 Edition 🎉 ) by @jnebeker in https://github.com/RadiusNetworks/radius-spec/pull/33
+- Rubocop rails upgrades by @benreyn in https://github.com/RadiusNetworks/radius-spec/pull/36
+- Upgrade rubocop to Latest by @alexstone in https://github.com/RadiusNetworks/radius-spec/pull/37
+- Upgrade rubocop and rubcop-rails dependecies by @benreyn in https://github.com/RadiusNetworks/radius-spec/pull/39
+- Include model factories in helpers specs by default by @benreyn in https://github.com/RadiusNetworks/radius-spec/pull/40
+- Adds Dependabot to Radius-Spec by @alexstone in https://github.com/RadiusNetworks/radius-spec/pull/42
+- Update vcr requirement from ~> 4.0 to ~> 6.0 by @dependabot in https://github.com/RadiusNetworks/radius-spec/pull/44
+- Update rubocop-rails requirement from ~> 2.13.0 to >= 2.13, < 2.15 by @dependabot in https://github.com/RadiusNetworks/radius-spec/pull/46
+- Update rubocop requirement from ~> 1.25.0 to >= 1.25, < 1.29 by @dependabot in https://github.com/RadiusNetworks/radius-spec/pull/48
+- Update rubocop-rails requirement from >= 2.13, < 2.15 to >= 2.13, < 2.16 by @dependabot in https://github.com/RadiusNetworks/radius-spec/pull/50
+- Update rubocop requirement from >= 1.25, < 1.29 to >= 1.25, < 1.31 by @dependabot in https://github.com/RadiusNetworks/radius-spec/pull/49
+
+### Bug Fixes
+
+None
 ## 0.11.0 (January 21, 2022)
 
 [Full Changelog](https://github.com/RadiusNetworks/radius-spec/compare/v0.10.0...0.11.0)

data/Gemfile

@@ -23,6 +23,6 @@ group :documentation do
 end
 
 group :plugins do
-  gem "vcr", "~> 4.0", require: false
+  gem "vcr", "~> 6.0", require: false
   gem "webmock", "~> 3.3", require: false
 end

data/README.md

@@ -3,6 +3,8 @@
 [![Maintainability](https://api.codeclimate.com/v1/badges/701295df43d53e25eafe/maintainability)](https://codeclimate.com/github/RadiusNetworks/radius-spec/maintainability)
 [![Gem Version](https://badge.fury.io/rb/radius-spec.svg)](https://badge.fury.io/rb/radius-spec)
 
+[Cop Docs](https://docs.rubocop.org/rubocop/1.42/cops_bundler.html)
+
 Basic RSpec setup and plug-ins for use with Radius Networks Ruby / Rails
 projects.
 
@@ -94,7 +96,7 @@ end
 Projects can inherit from the [base Rubocop config](.rubocop.yml). This can be
 accomplished by using either the remote raw URL or dependency gem formats. With
 either method we also strongly suggest setting the `inherit_mode` to `merge`
-for both `Exclude` and `IgnoredPatterns`. This way you can append additional
+for both `Exclude` and `AllowedPatterns`. This way you can append additional
 exceptions without overwriting the defaults.
 
 #### Inherit from Gem (Recommended Method)
@@ -103,7 +105,7 @@ exceptions without overwriting the defaults.
 inherit_mode:
   merge:
     - Exclude
-    - IgnoredPatterns
+    - AllowedPatterns
 
 inherit_gem:
   radius-spec:
@@ -118,7 +120,7 @@ inherit_gem:
 inherit_mode:
   merge:
     - Exclude
-    - IgnoredPatterns
+    - AllowedPatterns
 
 # Available for projects which cannot include this gem (i.e. Ruby < 2.5)
 inherit_from:
@@ -154,7 +156,7 @@ inherit_from: .rubocop_todo.yml
 inherit_mode:
   merge:
     - Exclude
-    - IgnoredPatterns
+    - AllowedPatterns
 
 Style/For:
   inherit_mode:

data/benchmarks/bm_setup.rb

@@ -67,4 +67,4 @@ def display_benchmark_header
   puts "### Test Cases"
 end
 
-GC_DISABLED = as_boolean(ENV['GC_DISABLED'], default: false)
+GC_DISABLED = as_boolean(ENV.fetch('GC_DISABLED', nil), default: false)

data/benchmarks/hash_transform.rb

@@ -18,7 +18,7 @@ end
 
 # Bad per Rubocop
 def hash_transform_key_map_to_h(hash)
-  hash.map { |k, v| [k + 100, v] }.to_h
+  hash.map { |k, v| [k + 100, v] }.to_h # rubocop:disable Style/MapToHash
 end
 
 # Bad per Rubocop
@@ -78,7 +78,7 @@ end
 
 # Bad per Rubocop
 def hash_transform_value_map_to_h(hash)
-  hash.map { |k, v| [k, v + 100] }.to_h
+  hash.map { |k, v| [k, v + 100] }.to_h # rubocop:disable Style/MapToHash
 end
 
 # Bad per Rubocop

data/common_rubocop.yml

@@ -130,16 +130,16 @@ Layout/FirstArgumentIndentation:
 # this for a node pattern matcher in the future.
 #
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes,
-#                           IgnoreCopDirectives, IgnoredPatterns.
+#                           IgnoreCopDirectives, AllowedPatterns.
 # URISchemes: http, https
 Layout/LineLength:
   IgnoreCopDirectives: true
-  IgnoredPatterns:
+  AllowedPatterns:
     # Leading comments
     - '\A\s*#'
     # Attempt at trailing comments
     - '\A.{1,78}\s#\s.*\z'
-  Max: 100
+  Max: 120
   Exclude:
     - '**/*.gemspec'
 
@@ -243,7 +243,7 @@ Metrics/BlockLength:
     - 'spec/spec_helper.rb'
     - 'spec/**/*_spec.rb'
     - 'spec/support/model_factories.rb'
-  IgnoredMethods:
+  AllowedMethods:
     - 'chdir'
     - 'describe'
     - 'refine'
@@ -286,7 +286,7 @@ Naming/BinaryOperatorParameterName:
 
 # We don't need this configured just yet, because we dont have any applications on
 # Ruby 3.1, but pre-emptively, we want to configure this to prefer the explicit style.
-# 
+#
 # bad
 # def foo(&)
 #   bar(&)
@@ -442,7 +442,7 @@ Style/BlockDelimiters:
     - subject
     - tap
     - watch
-  IgnoredMethods:
+  AllowedMethods:
     - lambda
     - proc
     - it
@@ -537,6 +537,11 @@ Style/EmptyMethod:
 Style/FrozenStringLiteralComment:
   EnforcedStyle: always_true
 
+# If we're using consecutive conditionals we probably know what we're doing. The good thing is this
+# cop will still flag consecutive conditionals that are identical.
+Style/GuardClause:
+  AllowConsecutiveConditionals: true
+
 # Prefer symbol keys using the 1.9 hash syntax. However, when keys are mixed
 # use a consistent mapping style; which generally means using hash rockets:
 #

data/common_rubocop_rails.yml

@@ -3,7 +3,7 @@ require: rubocop-rails
 inherit_mode:
   merge:
     - Exclude
-    - IgnoredPatterns
+    - AllowedPatterns
 
 inherit_from: common_rubocop.yml
 
@@ -26,10 +26,10 @@ Style/Documentation:
 # Rails foreign keys and indexes can get long. We want to ignore our annotation
 # comments which are for these entries.
 #
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns.
 # URISchemes: http, https
 Layout/LineLength:
-  IgnoredPatterns:
+  AllowedPatterns:
     - '\A#  fk_rails_'
     - '\A#  index_'
 
@@ -194,6 +194,10 @@ Rails/IndexBy:
 Rails/IndexWith:
   Enabled: false
 
+# This would be extremely hard to implement with our app
+Rails/I18nLocaleTexts:
+  Enabled: false
+
 # This cop enforces the use of ids over pluck(:id) and pluck(primary_key).
 # https://rails.rubystyle.guide/#ids
 Rails/PluckId:

data/lib/radius/spec/rails.rb

@@ -7,7 +7,7 @@ require 'rspec/rails'
 
 RSpec.configure do |config|
   # Remove this line if you're not using ActiveRecord or ActiveRecord fixtures
-  config.fixture_path = ::Rails.root.join("spec", "fixtures").to_path
+  config.fixture_path = Rails.root.join("spec/fixtures").to_path
 
   # If you're not using ActiveRecord, or you'd prefer not to run each of your
   # examples within a transaction, remove the following line or assign false

data/lib/radius/spec/vcr.rb

@@ -10,7 +10,7 @@ VCR.configure do |config|
   config.ignore_localhost = true
 
   record_mode = case
-                when ENV['CI']
+                when ENV.fetch('CI', false)
                   # Never let CI record
                   :none
                 when RSpec.configuration.files_to_run.one?
@@ -42,14 +42,17 @@ VCR.configure do |config|
     RADIUS_OAUTH_PROVIDER_APP_SECRET
     RADIUS_OAUTH_PROVIDER_URL
   ].each do |secret|
-    config.filter_sensitive_data("<#{secret}>") { ENV[secret] }
+    # WARNING: It may seem tempting, but don't try to extract ENV[secret] to a local variable
+    # here. `filter_sensitive_data` calls its block instead of exec-ing it, so a local variable
+    # set outside the blocks won't be accessible inside them.
+    config.filter_sensitive_data("<#{secret}>") { ENV.fetch(secret, nil) }
 
     config.filter_sensitive_data("<#{secret}_FORM>") {
-      URI.encode_www_form_component(ENV[secret]) if ENV[secret]
+      URI.encode_www_form_component(ENV.fetch(secret, nil)) if ENV[secret]
     }
 
     config.filter_sensitive_data("<#{secret}_URI>") {
-      ERB::Util.url_encode(ENV[secret]) if ENV[secret]
+      ERB::Util.url_encode(ENV.fetch(secret, nil)) if ENV[secret]
     }
 
     config.filter_sensitive_data('<AUTHORIZATION_HEADER>') { |interaction|

data/lib/radius/spec/version.rb

@@ -2,6 +2,6 @@
 
 module Radius
   module Spec
-    VERSION = "0.11.0"
+    VERSION = "0.12.1"
   end
 end

data/radius-spec.gemspec

@@ -32,8 +32,8 @@ Gem::Specification.new do |spec|
   spec.required_ruby_version = ">= 2.5" # rubocop:disable Gemspec/RequiredRubyVersion
 
   spec.add_runtime_dependency "rspec", "~> 3.7"
-  spec.add_runtime_dependency "rubocop", "~> 1.25.0"
-  spec.add_runtime_dependency "rubocop-rails", "~> 2.13.0"
+  spec.add_runtime_dependency "rubocop", ">= 1.25", "< 1.43"
+  spec.add_runtime_dependency "rubocop-rails", ">= 2.13", "< 2.18"
 
   spec.add_development_dependency "bundler", ">= 2.2.10"
   spec.add_development_dependency "rake", ">= 12.0", "< 14.0"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: radius-spec
 version: !ruby/object:Gem::Version
-  version: 0.11.0
+  version: 0.12.1
 platform: ruby
 authors:
 - Radius Networks
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-01-21 00:00:00.000000000 Z
+date: 2023-05-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -29,30 +29,42 @@ dependencies:
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '1.25'
+    - - "<"
       - !ruby/object:Gem::Version
-        version: 1.25.0
+        version: '1.43'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '1.25'
+    - - "<"
       - !ruby/object:Gem::Version
-        version: 1.25.0
+        version: '1.43'
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '2.13'
+    - - "<"
       - !ruby/object:Gem::Version
-        version: 2.13.0
+        version: '2.18'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '2.13'
+    - - "<"
       - !ruby/object:Gem::Version
-        version: 2.13.0
+        version: '2.18'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -94,6 +106,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/dependabot.yml"
 - ".github/workflows/ci.yml"
 - ".github/workflows/reviewdog.yml"
 - ".gitignore"
@@ -151,8 +164,8 @@ licenses:
 - Apache-2.0
 metadata:
   bug_tracker_uri: https://github.com/RadiusNetworks/radius-spec/issues
-  changelog_uri: https://github.com/RadiusNetworks/radius-spec/blob/v0.11.0/CHANGELOG.md
-  source_code_uri: https://github.com/RadiusNetworks/radius-spec/tree/v0.11.0
+  changelog_uri: https://github.com/RadiusNetworks/radius-spec/blob/v0.12.1/CHANGELOG.md
+  source_code_uri: https://github.com/RadiusNetworks/radius-spec/tree/v0.12.1
   rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options: []
@@ -169,7 +182,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.1.6
 signing_key:
 specification_version: 4
 summary: Radius Networks RSpec setup and plug-ins