radiator 0.4.0pre4 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0fa87cf414d03f44944ae568a7c96b6c7e268d7c
-  data.tar.gz: 14b86e6768d73cc4842497c8b91547e6cd2add46
+  metadata.gz: 20a5af6853cd421c70122a70ff48cc4822e7c58c
+  data.tar.gz: 2f303245c66ce3f4ee7d7ad7a1050bd18221c0b1
 SHA512:
-  metadata.gz: 577386edefce45ef60a51476db9b1f76a44a096ac149cdb61fc992af391420a2c35a40fe797921fb9ddc1a6765895e9eff5d636ad378555d0f550e058dd608c9
-  data.tar.gz: 40432819def16218dbc7fa51099791138c4afb1282e7e6c5eb066cee5b0bf4d16245f2e411d4aa5b3de8be73e4a2dedf35343c606d0b3642eb633a566310d0b6
+  metadata.gz: a42aa75fa026a2ea1e0e6dfb25d22c1769eab3672e28616762df741ea523135389980b1299c863ca6886ddd643b72f146f97569f47f0b332c9e2d6565593fa4d
+  data.tar.gz: ba2fa368c835473f96519c909818a645e8d416e4061ea28b34c5b1d5a575b3188acaa7601aa1dd2ae6d4d12086950b73501d2215271dd70924dbd15e18806be1

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    radiator (0.4.0pre4)
+    radiator (0.4.0)
       awesome_print (~> 1.7, >= 1.7.0)
       bitcoin-ruby (~> 0.0, >= 0.0.11)
       ffi (~> 1.9, >= 1.9.18)
@@ -32,7 +32,7 @@ GEM
       multi_json (~> 1.10)
     method_source (0.9.0)
     minitest (5.11.3)
-    minitest-line (0.6.4)
+    minitest-line (0.6.5)
       minitest (~> 5.0)
     minitest-proveit (1.0.0)
       minitest (> 5, < 7)
@@ -51,7 +51,7 @@ GEM
       simplecov-html (~> 0.10.0)
     simplecov-html (0.10.2)
     vcr (3.0.3)
-    webmock (3.3.0)
+    webmock (3.4.1)
       addressable (>= 2.3.6)
       crack (>= 0.3.2)
       hashdiff

data/README.md

@@ -13,7 +13,7 @@ Radiator is an API Client for interaction with the STEEM network using Ruby.
 #### Changes in v0.4.0
 
 * Gem updates
-* AppBase Support
+* **AppBase Support**
   * Defaulting to `condenser_api.*` in `Radiator::Api` (see below)
   * Handle/recover from new `AppBase` errors.
 * `Radiator::Stream` now detects if it's stalled and takes action if it has to wait too long for a new block.
@@ -425,24 +425,6 @@ tx.operations << transfer
 tx.process(true)
 ```
 
-#### Golos
-
-Radiator also supports Golos.  To use the Golos blockchain, provide a node and chain_id:
-
-```ruby
-tx = Radiator::Transaction.new(wif: 'Your Wif Here', chain: :golos, url: 'https://ws.golos.io')
-vote = {
-  type: :vote,
-  voter: 'xeroc',
-  author: 'xeroc',
-  permlink: 'piston',
-  weight: 10000
-}
-
-tx.operations << vote
-tx.process(true)
-```
-
 There's a complete list of operations known to Radiator in [`broadcast_operations.json`](https://github.com/inertia186/radiator/blob/master/lib/radiator/broadcast_operations.json).
 
 ## Failover
@@ -451,10 +433,10 @@ Radiator supports failover for situations where a node has, for example, become
 
 ```ruby
 options = {
-  ur: 'https://api.steemit.com',
+  url: 'https://api.steemit.com',
   failover_urls: [
     'https://api.steemitstage.com',
-    'https://gtg.steem.house:8090'
+    'https://api.steem.house'
   ]
 }
 
@@ -475,6 +457,22 @@ There is another rare scenario involving `::Transaction` broadcasts that's handl
 tx = Radiator::Transaction.new(wif: wif, recover_transactions_on_error: false)
 ```
 
+### Golos Failover Examples
+
+Typically, you only need to pass `chain: :golos` to enable Golos.  Failover is enabled by default.  If you want to provide your own full nodes, use this format:
+
+```ruby
+options = {
+  chain: :golos,
+  url: 'https://ws.golos.io',
+  failover_urls: [
+    'https://api.golos.cf'
+  ]
+}
+
+api = Radiator::Api.new(options)
+```
+
 ## Debugging
 
 To enable debugging, set environment `LOG=DEBUG` before launching your app.  E.g.:
@@ -519,6 +517,34 @@ If you have excluded system resources as the root cause, then you should take a
 
 Verify your code is not doing too much between blocks.
 
+## Problem: I'm getting an endless loop: `#<OpenSSL::SSL::SSLError: SSL_connect SYSCALL returned=5 errno=0 state=error: certificate verify failed>`
+
+## Solution:
+
+You're probably creating too many threads or you don't have enough resources for what you're doing.  One option for you is to avoid persistent HTTP by passing `persist: false`.
+
+Doing this will impact performance because each API call will be a separate socket call.  All of the constructors accept `persist: false`., e.g.:
+
+```ruby
+api = Radiator::Api.new(persist: false)
+```
+
+... or ...
+
+```ruby
+stream = Radiator::Stream.new(persist: false)
+```
+
+... or ...
+
+```ruby
+tx = Radiator::Transaction.new(options.merge(persist: false, wif: wif))
+```
+
+Also see troubleshooting discussion about this situation:
+
+https://github.com/inertia186/radiator/issues/12
+
 ## Tests
 
 * Clone the client repository into a directory of your choice:
@@ -531,15 +557,13 @@ Verify your code is not doing too much between blocks.
   * `HELL_ENABLED=true rake`
 * To run a stream test on the live STEEM blockchain with debug logging enabled:
   * `LOG=DEBUG rake test_live_stream`
-* To run a stream test on the live GOLOS blockchain with debug logging enabled:
-  * `LOG=DEBUG rake test_live_stream[golos]`
 ---
 
 <center>
   <img src="http://www.steemimg.com/images/2016/08/19/RadiatorCoolingFan-54in-Webfdcb1.png" />
 </center>
 
-See my previous Ruby How To posts in: [#radiator](https://steemit.com/created/radiator) [#ruby](https://steemit.com/created/ruby)
+See my previous Ruby How To posts in: [/f/ruby](https://chainbb.com/f/ruby)
 
 ## Get in touch!
 

data/Rakefile

@@ -3,7 +3,6 @@ require 'rake/testtask'
 require 'yard'
 require 'radiator'
 require 'awesome_print'
-require 'pry'
 
 Rake::TestTask.new(:test) do |t|
   t.libs << 'test'
@@ -85,7 +84,7 @@ task :test_live_stream, [:chain, :persist] do |t, args|
       api.get_ops_in_block(n, true) do |vops, error|
         if !!error
           puts "Error on get_ops_in_block for block #{n}"
-          ap error
+          ap error if defined? ap
         end
         
         puts "Problem: vops is nil!" if vops.nil?

data/lib/radiator/api.rb

@@ -136,13 +136,10 @@ module Radiator
     
     DEFAULT_STEEM_URL = 'https://api.steemit.com'
     
-    DEFAULT_GOLOS_URL = 'https://ws.golos.io'
-    
     DEFAULT_STEEM_FAILOVER_URLS = [
       DEFAULT_STEEM_URL,
       'https://api.steemitstage.com',
       'https://appbasetest.timcliff.com',
-      'https://gtg.steem.house:8090',
       'https://api.steem.house',
       'https://seed.bitcoiner.me',
       'https://steemd.minnowsupportproject.org',
@@ -155,16 +152,6 @@ module Radiator
       'https://steemd.steemgigs.org'
     ]
     
-    DEFAULT_GOLOS_FAILOVER_URLS = [
-      DEFAULT_GOLOS_URL,
-      'https://api.golos.cf',
-      # not recommended, not all plug-ins enabled:
-      # 'https://ws.goldvoice.club',
-      # 'http://golos-seed.arcange.eu',
-      # not recommended, requires option ssl_verify_mode: OpenSSL::SSL::VERIFY_NONE
-      # 'https://golos-seed.arcange.eu',
-    ]
-    
     # @private
     POST_HEADERS = {
       'Content-Type' => 'application/json',
@@ -177,7 +164,6 @@ module Radiator
     def self.default_url(chain)
       case chain.to_sym
       when :steem then DEFAULT_STEEM_URL
-      when :golos then DEFAULT_GOLOS_URL
       else; raise ApiError, "Unsupported chain: #{chain}"
       end
     end
@@ -185,7 +171,6 @@ module Radiator
     def self.default_failover_urls(chain)
       case chain.to_sym
       when :steem then DEFAULT_STEEM_FAILOVER_URLS
-      when :golos then DEFAULT_GOLOS_FAILOVER_URLS
       else; raise ApiError, "Unsupported chain: #{chain}"
       end
     end
@@ -204,6 +189,7 @@ module Radiator
     # @option options [Integer] :max_requests Maximum number of requests on a connection before it is considered expired and automatically closed.
     # @option options [Integer] :pool_size Maximum number of connections allowed.
     # @option options [Boolean] :reuse_ssl_sessions Reuse a previously opened SSL session for a new connection.  There's a slight performance improvement by enabling this, but at the expense of reliability during long execution.  Default false.
+    # @option options [Boolean] :persist Enable or disable Persistent HTTP.  Using Persistent HTTP keeps the connection alive between API calls.  Default: `true`
     def initialize(options = {})
       @user = options[:user]
       @password = options[:password]
@@ -400,6 +386,10 @@ module Radiator
       loop do
         tries += 1
         
+        if tries > 5 && flappy? && !check_file_open?
+          raise ApiError, 'PANIC: Out of file resources'
+        end
+        
         begin
           if tries > 1 && @recover_transactions_on_error && api_name == :network_broadcast_api
             signatures, exp = extract_signatures(options)
@@ -435,7 +425,7 @@ module Radiator
                     warning "Unexpected rpc_id (expected: #{options[:id]}, got: #{response['id']}), retrying ...", method_name, true
                   else
                     # The node has broken the jsonrpc spec.
-                    warning "Node did not provide jsonrpc id (expected: #{options[:id]}, got: nothing, retrying ...", method_name, true
+                    warning "Node did not provide jsonrpc id (expected: #{options[:id]}, got: nothing), retrying ...", method_name, true
                   end
                   
                   if response.keys.include?('error')
@@ -675,7 +665,6 @@ module Radiator
       
       api.get_blocks(block_range) do |block, block_num|
         unless defined? block.transaction_ids
-          # Happens on Golos, see: https://github.com/GolosChain/golos/issues/281
           error "Blockchain does not provide transaction ids in blocks, giving up."
           return nil
         end
@@ -683,6 +672,16 @@ module Radiator
         count += 1
         raise ApiError, "Race condition detected on remote node at: #{block_num}" if block.nil?
         
+        # TODO Some blockchains (like Golos) do not have transaction_ids.  In
+        # the future, it would be better to decode the operation and signature
+        # into the transaction id.
+        # See: https://github.com/steemit/steem/issues/187
+        # See: https://github.com/GolosChain/golos/issues/281
+        unless defined? block.transaction_ids
+          @recover_transactions_on_error = false
+          return
+        end
+        
         timestamp = Time.parse(block.timestamp + 'Z')
         break if timestamp < after
         
@@ -867,5 +866,17 @@ module Radiator
         @backoff_sleep = nil
       end
     end
+    
+    def self.finalize(logger, hashie_logger)
+      proc {
+        if !!logger && defined?(logger.close) && !logger.closed?
+          logger.close
+        end
+        
+        if !!hashie_logger && defined?(hashie_logger.close) && !hashie_logger.closed?
+          hashie_logger.close
+        end
+      }
+    end
   end
 end

data/lib/radiator/chain.rb

@@ -291,7 +291,6 @@ module Radiator
     def default_debt_asset
       case chain
       when :steem then ChainConfig::NETWORKS_STEEM_DEBT_ASSET
-      when :golos then ChainConfig::NETWORKS_GOLOS_DEBT_ASSET
       when :test then ChainConfig::NETWORKS_TEST_DEBT_ASSET
       else; raise ChainError, "Unknown chain: #{chain}"
       end

data/lib/radiator/chain_config.rb

@@ -10,13 +10,6 @@ module Radiator
     NETWORKS_STEEM_VEST_ASSET = 'VESTS'
     NETWORKS_STEEM_DEFAULT_NODE = 'https://api.steemit.com'
     
-    NETWORKS_GOLOS_CHAIN_ID = '782a3039b478c839e4cb0c941ff4eaeb7df40bdd68bd441afd444b9da763de12'
-    NETWORKS_GOLOS_ADDRESS_PREFIX = 'GLS'
-    NETWORKS_GOLOS_CORE_ASSET = 'GOLOS'
-    NETWORKS_GOLOS_DEBT_ASSET = 'GBG'
-    NETWORKS_GOLOS_VEST_ASSET = 'GESTS'
-    NETWORKS_GOLOS_DEFAULT_NODE = 'https://ws.golos.io'
-    
     NETWORKS_TEST_CHAIN_ID = '18dcf0a285365fc58b71f18b3d3fec954aa0c141c44e4e5cb4cf777b9eab274e'
     NETWORKS_TEST_ADDRESS_PREFIX = 'TST'
     NETWORKS_TEST_CORE_ASSET = 'CORE'
@@ -24,6 +17,6 @@ module Radiator
     NETWORKS_TEST_VEST_ASSET = 'CESTS'
     NETWORKS_TEST_DEFAULT_NODE = 'https://test.steem.ws'
     
-    NETWORK_CHAIN_IDS = [NETWORKS_STEEM_CHAIN_ID, NETWORKS_GOLOS_CHAIN_ID, NETWORKS_TEST_CHAIN_ID]
+    NETWORK_CHAIN_IDS = [NETWORKS_STEEM_CHAIN_ID, NETWORKS_TEST_CHAIN_ID]
   end
 end

data/lib/radiator/error_parser.rb

@@ -1,5 +1,3 @@
-require 'awesome_print'
-
 module Radiator
   class ErrorParser
     include Utils
@@ -154,10 +152,12 @@ module Radiator
           @can_reprepare = false
         end
       rescue => e
-        if ENV['DEBUG'] == 'true'
-          ap error_parser_exception: e, original_response: response, backtrace: e.backtrace
-        else
-          ap error_parser_exception: e, original_response: response
+        if defined? ap
+          if ENV['DEBUG'] == 'true'
+            ap error_parser_exception: e, original_response: response, backtrace: e.backtrace
+          else
+            ap error_parser_exception: e, original_response: response
+          end
         end
         
         @expiry = false

data/lib/radiator/transaction.rb

@@ -75,7 +75,6 @@ module Radiator
 
       case chain.to_s.downcase.to_sym
       when :steem then NETWORKS_STEEM_CHAIN_ID
-      when :golos then NETWORKS_GOLOS_CHAIN_ID
       when :test then NETWORKS_TEST_CHAIN_ID
       end
     end
@@ -83,7 +82,6 @@ module Radiator
     def url
       case chain.to_s.downcase.to_sym
       when :steem then NETWORKS_STEEM_DEFAULT_NODE
-      when :golos then NETWORKS_GOLOS_DEFAULT_NODE
       when :test then NETWORKS_TEST_DEFAULT_NODE
       end
     end
@@ -172,7 +170,7 @@ module Radiator
 
         @api.get_block(block_number) do |block, error|
           if !!error
-            ap error if ENV['DEBUG'] == 'true'
+            ap error if defined?(ap) && ENV['DEBUG'] == 'true'
             raise TransactionError, "Unable to prepare transaction: #{error.message || 'Unknown cause.'}"
           end
 

data/lib/radiator/type/amount.rb

@@ -23,9 +23,6 @@ module Radiator
           when 'STEEM' then 3
           when 'VESTS' then 6
           when 'SBD' then 3
-          when 'GOLOS' then 3
-          when 'GESTS' then 6
-          when 'GBG' then 3
           when 'CORE' then 3
           when 'CESTS' then 6
           when 'TEST' then 3

data/lib/radiator/utils.rb

@@ -39,10 +39,18 @@ module Radiator
           puts "#{level}: #{log_message}"
         end
       else
-        if !!prefix
-          @logger.ap log_level: level, prefix => obj
+        if defined? @logger.ap
+          if !!prefix
+            @logger.ap log_level: level, prefix => obj
+          else
+            @logger.ap obj, level
+          end
         else
-          @logger.ap obj, level
+          if !!prefix
+            @logger.send level, ({prefix => obj}).inspect
+          else
+            @logger.send level, obj.inspect
+          end
         end
       end
       

data/lib/radiator/version.rb

@@ -1,4 +1,4 @@
 module Radiator
-  VERSION = '0.4.0pre4'
+  VERSION = '0.4.0'
   AGENT_ID = "radiator/#{VERSION}"
 end

data/lib/radiator.rb

@@ -1,5 +1,6 @@
 require 'radiator/version'
 require 'json'
+require 'awesome_print' if ENV['USE_AWESOME_PRINT'] == 'true'
 
 module Radiator
   require 'radiator/utils'
@@ -38,6 +39,5 @@ module Radiator
   require 'radiator/mixins/acts_as_wallet'
   require 'radiator/chain'
   require 'steem'
-  require 'golos'
   extend self
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: radiator
 version: !ruby/object:Gem::Version
-  version: 0.4.0pre4
+  version: 0.4.0
 platform: ruby
 authors:
 - Anthony Martin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-04-28 00:00:00.000000000 Z
+date: 2018-05-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -345,7 +345,6 @@ files:
 - images/Anthony Martin.png
 - images/Marvin Hofmann.jpg
 - images/Marvin Hofmann.png
-- lib/golos.rb
 - lib/radiator.rb
 - lib/radiator/account_by_key_api.rb
 - lib/radiator/account_history_api.rb
@@ -402,9 +401,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.6.14

data/lib/golos.rb

@@ -1,11 +0,0 @@
-# Golos chain client for broadcasting common operations.
-# 
-# @see Radiator::Chain
-class Golos < Radiator::Chain
-  def initialize(options = {})
-    super(options.merge(chain: :golos))
-  end
-  
-  alias golos_per_mgest base_per_mvest
-  alias golos_per_gbg base_per_debt
-end