radiator 0.4.0pre3 → 0.4.0pre4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b3f2fba4fb406179bfcb988e1d1669615b392569
-  data.tar.gz: b721efe6e8751fef45eb40a31e1799c3c695378f
+  metadata.gz: 0fa87cf414d03f44944ae568a7c96b6c7e268d7c
+  data.tar.gz: 14b86e6768d73cc4842497c8b91547e6cd2add46
 SHA512:
-  metadata.gz: 439ff52f2860e63571e6be0cdd53431f80ceaf4e8671c6754ab5db47a41a4cf87447a6b23ae8ce69209990e5064651619bdb897e27d75c507e9b107ae8123f98
-  data.tar.gz: c62becd00245e1478d287bd4a62b013608f0138078626969225947ab4f2322daec363ed54af443d1c5f7b652775e1833bf6a02871af36f269fb8bd3ef9089c54
+  metadata.gz: 577386edefce45ef60a51476db9b1f76a44a096ac149cdb61fc992af391420a2c35a40fe797921fb9ddc1a6765895e9eff5d636ad378555d0f550e058dd608c9
+  data.tar.gz: 40432819def16218dbc7fa51099791138c4afb1282e7e6c5eb066cee5b0bf4d16245f2e411d4aa5b3de8be73e4a2dedf35343c606d0b3642eb633a566310d0b6

data/.travis.yml

@@ -1,9 +1,11 @@
 language: ruby
 rvm:
+  # You can enable more than one ruby version target at the same time, but doing
+  # so will disable code coverage reporting.
   # - "2.0.0"
   # - "2.1.5"
   # - "2.2.1"
-  - "2.3.0"
+  # - "2.3.0"
   - "2.4.2"
   # - "2.5.0" # dev
 env:

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    radiator (0.4.0pre3)
+    radiator (0.4.0pre4)
       awesome_print (~> 1.7, >= 1.7.0)
       bitcoin-ruby (~> 0.0, >= 0.0.11)
       ffi (~> 1.9, >= 1.9.18)

data/README.md

@@ -10,6 +10,60 @@
 
 Radiator is an API Client for interaction with the STEEM network using Ruby.
 
+#### Changes in v0.4.0
+
+* Gem updates
+* AppBase Support
+  * Defaulting to `condenser_api.*` in `Radiator::Api` (see below)
+  * Handle/recover from new `AppBase` errors.
+* `Radiator::Stream` now detects if it's stalled and takes action if it has to wait too long for a new block.
+  1. Exponential back-off for stalls so that the node doesn't get slammed.
+  2. Short delays (3 times block production) only result in a warning.
+  3. Long delays (6 times block production) may try to switch to an alternate node.
+* Fixed internal logging bug that would open too many files.
+  * This fix also mitigates issues like `SSL Verify` problems (similar to [#12](https://github.com/inertia186/radiator/issues/12))
+* Dropped GOLOS support.
+
+**Appbase is now supported.**
+
+If you were already using `Radiator::Api` then there is nothing to change.  But if you made use of other API classes, like `Radiator::FollowApi`, then the method signatures have changed.
+
+**Pre-AppBase:**
+
+```ruby
+api = Radiator::FollowApi.new
+
+api.get_followers('inertia', 0, 'blog', 10)
+```
+
+**New Signature:**
+
+```ruby
+api = Radiator::FollowApi.new
+
+api.get_followers(account: 'inertia', start: 0, type: 'blog', limit: 10)
+```
+
+*-- or --*
+
+**Switch to Condenser API:**
+
+The other strategy for using this version of Radiator is to just switch away from classes like `Radiator::FollowApi` over to `Radiator::Api` (also known as `Radiator::CondenserApi`) instead.  Then you don't have to update individual method calls.
+
+```ruby
+api = Radiator::Api.new
+
+api.get_followers('inertia', 0, 'blog', 10)
+```
+
+**Note about GOLOS**
+
+GOLOS is no longer supported in Radiator.  If you want to continue to use GOLOS, you'll need to branch from v0.3.15 (pre-appbase) and add WebSockets support because GOLOS completely dropped JSON-RPC over HTTP clients support for some reason 
+
+Radiator has never and will never use WebSockets due to its server scalability requirements.
+
+From a client perspective, WebSockets is *great*.  **I have nothing against WebSockets.**  So I might get around to it at some point, but GOLOS won't be part of Radiator anymore mainly because GOLOS has no plans to implement AppBase.
+
 #### Changes in v0.3.0
 
 * Gem updates

data/Rakefile

@@ -34,7 +34,9 @@ task :test_live_broadcast, [:account, :wif, :chain] do |t, args|
   account_name = args[:account] || 'social'
   posting_wif = args[:wif] || '5JrvPrQeBBvCRdjv29iDvkwn3EQYZ9jqfAHzrCyUvfbEbRkrYFC'
   chain = args[:chain] || 'steem'
-  options = {chain: chain, wif: posting_wif}
+  # url = 'https://testnet.steemitdev.com/' # use testnet
+  url = nil # use default
+  options = {chain: chain, wif: posting_wif, url: url}
   tx = Radiator::Transaction.new(options)
   tx.operations << {
     type: :claim_reward_balance,
@@ -60,7 +62,9 @@ task :test_live_stream, [:chain, :persist] do |t, args|
   chain = args[:chain] || 'steem'
   persist = (args[:persist] || 'true') == 'true'
   last_block_number = 0
-  options = {chain: chain, persist: persist}
+  # url = 'https://testnet.steemitdev.com/'
+  url = nil # use default
+  options = {chain: chain, persist: persist, url: url}
   total_ops = 0.0
   total_vops = 0.0
   elapsed = 0
@@ -84,11 +88,13 @@ task :test_live_stream, [:chain, :persist] do |t, args|
           ap error
         end
         
-        vop_size = if vops.nil?
-          0
-        else
-          vops.size
-        end
+        puts "Problem: vops is nil!" if vops.nil?
+        
+        # Did we reach this point with an unhandled error that wasn't retried?
+        # If so, vops might be nil and we might need this error to get handled
+        # instead of checking for vops.nil?.
+        
+        vop_size = vops.size
         total_vops += vop_size
         
         vop_ratio = if total_vops > 0

data/lib/radiator/api.rb

@@ -429,12 +429,15 @@ module Radiator
                 response = JSON[body]
                 
                 if response['id'] != options[:id]
+                  debug_payload(options, body) if ENV['DEBUG'] == 'true'
+                  
                   if !!response['id']
                     warning "Unexpected rpc_id (expected: #{options[:id]}, got: #{response['id']}), retrying ...", method_name, true
                   else
                     # The node has broken the jsonrpc spec.
                     warning "Node did not provide jsonrpc id (expected: #{options[:id]}, got: nothing, retrying ...", method_name, true
                   end
+                  
                   if response.keys.include?('error')
                     handle_error(response, options, method_name, tries)
                   end
@@ -835,6 +838,20 @@ module Radiator
       end
     end
     
+    def debug_payload(request, response)
+      request = JSON.pretty_generate(request)
+      response = JSON.parse(response) rescue response
+      response = JSON.pretty_generate(response) rescue response
+      
+      puts '=' * 80
+      puts "Request:"
+      puts request
+      puts '=' * 80
+      puts "Response:"
+      puts response
+      puts '=' * 80
+    end
+    
     def backoff
       shutdown
       bump_failover if flappy? || !healthy?(uri)

data/lib/radiator/error_parser.rb

@@ -87,14 +87,20 @@ module Radiator
             @api_name = data_call_method['call.params']
           end
         else
-          @error_code = ['code']
-          @error_message = ['message']
+          @error_code = @error['code']
+          @error_message = @error['message']
           @expiry = false
           @can_retry = false
           @can_reprepare = false
         end
         
         case @error_code
+        when -32603
+          if error_match?('Internal Error')
+            @expiry = false
+            @can_retry = true
+            @can_reprepare = true
+          end
         when -32003
           if error_match?('Unable to acquire database lock')
             @expiry = false
@@ -148,7 +154,11 @@ module Radiator
           @can_reprepare = false
         end
       rescue => e
-        ap error_parser_exception: e, original_response: response#, backtrace: e.backtrace
+        if ENV['DEBUG'] == 'true'
+          ap error_parser_exception: e, original_response: response, backtrace: e.backtrace
+        else
+          ap error_parser_exception: e, original_response: response
+        end
         
         @expiry = false
         @can_retry = false
@@ -161,8 +171,14 @@ module Radiator
       
       case @error['code']
       when -32003
+        any_of = [
+          'Internal Error"',
+          '_api_plugin not enabled.'
+        ]
+        
         can_retry = error_match?('Unable to acquire database lock')
-        can_retry = if !can_retry && error_match?('Internal Error"')
+        
+        if !can_retry && error_match?(any_of)
           can_retry = true
           @node_degraded = true
         else
@@ -177,18 +193,24 @@ module Radiator
       can_retry
     end
     
-    def error_match?(match)
-      case match
-      when String
-        @error['message'] && @error['message'].include?(match)
-      when Array
-        if @error['message']
-          match.map { |m| @error['message'].include?(m) }.include? true
-        else
-          false
+    def error_match?(matches)
+      matches = [matches].flatten
+      
+      any = matches.map do |match|
+        case match
+        when String
+          @error['message'] && @error['message'].include?(match)
+        when Array
+          if @error['message']
+            match.map { |m| m.include?(match) }.include? true
+          else
+            false
+          end
+        else; false
         end
-      else; false
       end
+      
+      any.include?(true)
     end
     
     def to_s

data/lib/radiator/transaction.rb

@@ -172,7 +172,8 @@ module Radiator
 
         @api.get_block(block_number) do |block, error|
           if !!error
-            raise TransactionError, "Unable to prepare transaction.", error
+            ap error if ENV['DEBUG'] == 'true'
+            raise TransactionError, "Unable to prepare transaction: #{error.message || 'Unknown cause.'}"
           end
 
           if !!block && !!block.previous

data/lib/radiator/version.rb

@@ -1,4 +1,4 @@
 module Radiator
-  VERSION = '0.4.0pre3'
+  VERSION = '0.4.0pre4'
   AGENT_ID = "radiator/#{VERSION}"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: radiator
 version: !ruby/object:Gem::Version
-  version: 0.4.0pre3
+  version: 0.4.0pre4
 platform: ruby
 authors:
 - Anthony Martin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-04-15 00:00:00.000000000 Z
+date: 2018-04-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler