radiant-shop-extension 0.9.3 → 0.10.0

data/spec/lib/shop/tags/responses_spec.rb

@@ -0,0 +1,129 @@
+require 'spec/spec_helper'
+
+describe Shop::Tags::Responses do
+  
+  dataset :forms, :pages
+  
+  it 'should describe these tags' do
+    Shop::Tags::Responses.tags.sort.should == [
+      'response:checkout',
+      'response:checkout:payment',
+      'response:checkout:payment:if_success',
+      'response:checkout:payment:unless_success'
+    ].sort
+  end
+  
+  context 'responses' do
+    
+    before :each do
+      login_as :customer
+      @order = shop_orders(:several_items)
+      
+      mock_page_with_request_and_data
+      mock_response
+      
+      mock.instance_of(ActiveMerchant::Billing::CreditCard).valid? { true }
+      mock_valid_form_checkout_request
+      @checkout = FormCheckout.new(@form, @page)
+    end
+    
+    describe '<r:response:checkout>' do
+      context 'checkout exists' do
+        before :each do
+          @response.result[:results][:checkout] = @checkout.create
+        end
+        it 'should expand' do
+          tag = %{<r:response:checkout>success</r:response:checkout>}
+          exp = %{success}
+          
+          pages(:home).should render(tag).as(exp)
+        end
+      end
+      context 'checkout does not exist' do
+        it 'should not expand' do
+          tag = %{<r:response:checkout>failure</r:response:checkout>}
+          exp = %{}
+        
+          pages(:home).should render(tag).as(exp)
+        end
+      end
+    end
+    
+    describe '<r:response:payment>' do
+      before :each do
+        @response.result[:results][:checkout] = @checkout.create
+      end
+      context 'payment success' do
+        it 'should expand' do
+          tag = %{<r:response:checkout:payment>success</r:response:checkout:payment>}
+          exp = %{success}
+        
+          pages(:home).should render(tag).as(exp)
+        end
+      end
+      context 'payment failure' do
+        before :each do
+          @response.result[:results][:checkout][:payment] = false
+        end
+        it 'should expand' do
+          tag = %{<r:response:checkout:payment>success</r:response:checkout:payment>}
+          exp = %{success}
+          
+          pages(:home).should render(tag).as(exp)
+        end
+      end
+    end
+    
+    describe '<r:response:payment:if_success>' do
+      before :each do
+        @response.result[:results][:checkout] = @checkout.create
+      end
+      context 'payment success' do
+        it 'should expand' do
+          tag = %{<r:response:checkout:payment:if_success>success</r:response:checkout:payment:if_success>}
+          exp = %{success}
+          
+          pages(:home).should render(tag).as(exp)
+        end
+      end
+      context 'payment failure' do
+        before :each do
+          @response.result[:results][:checkout][:payment] = false
+        end
+        it 'should not expand' do
+          tag = %{<r:response:checkout:payment:if_success>failure</r:response:checkout:payment:if_success>}
+          exp = %{}
+          
+          pages(:home).should render(tag).as(exp)
+        end
+      end
+    end
+    
+    describe '<r:response:payment:unless_success>' do
+      before :each do
+        @response.result[:results][:checkout] = @checkout.create
+      end
+      context 'payment failure' do
+        before :each do
+          @response.result[:results][:checkout][:payment] = false
+        end
+        it 'should expand' do
+          tag = %{<r:response:checkout:payment:unless_success>success</r:response:checkout:payment:unless_success>}
+          exp = %{success}
+          
+          pages(:home).should render(tag).as(exp)
+        end
+      end
+      context 'payment success' do
+        it 'should not expand' do
+          tag = %{<r:response:checkout:payment:unless_success>failure</r:response:checkout:payment:unless_success>}
+          exp = %{}
+          
+          pages(:home).should render(tag).as(exp)
+        end
+      end
+    end
+    
+  end
+
+end

data/spec/models/form_checkout_spec.rb

@@ -5,372 +5,306 @@ describe FormCheckout do
   dataset :shop_orders, :pages, :forms, :shop_addresses
   
   before :each do
-    @form = forms(:checkout)
-    @page = pages(:home)
-    @order = shop_orders(:one_item)
-    
-    @data     = { }
-    @request  = {
-      :session => {
-        :shop_order => @order.id
-      }
-    }
-
-    stub(@page).data    { @data }
-    stub(@page).request { @request }
-  end
-  
-  describe '#initialize' do
-    it 'should assign the instance variables' do
-      
-    end
+    mock_page_with_request_and_data
   end
-  
   describe '#create' do
     context 'addresses' do
-      context 'address configured' do
+      
+      context 'sending ids with user logged in' do
         before :each do
-          @form[:config] = {
-            :checkout   => {
-              :address  => {
-                :enabled => true
-              }
-            }
-          }
+          login_as :customer # Will have existing addresses due to several_items
+          @order = shop_orders(:one_item)
+          mock_valid_form_checkout_request
         end
-        context 'sending ids' do
-          context 'both billing and shipping' do
-            it 'should assign that address to the order billing and shipping' do
-              @data = { 
-                'billing'   => { 'id' => shop_addresses(:billing).id },
-                'shipping'  => { 'id' => shop_addresses(:shipping).id }
-              }
+        
+        context 'both billing and shipping' do
+          it 'should assign that address to the order billing and shipping' do
+            @data[:billing]   = { :id => shop_orders(:several_items).billing.id }
+            @data[:shipping]  = { :id => shop_orders(:several_items).shipping.id }
+            
+            @checkout = FormCheckout.new(@form, @page)
+            result = @checkout.create
             
-              @checkout = FormCheckout.new(@form, @page)
-              @checkout.create
+            shop_orders(:one_item).billing.should  === shop_addresses(:billing)
+            shop_orders(:one_item).shipping.should === shop_addresses(:shipping)
             
-              shop_orders(:one_item).billing.should  === shop_addresses(:billing)
-              shop_orders(:one_item).shipping.should === shop_addresses(:shipping)
-            end
+            result[:billing].should  === true
+            result[:shipping].should === true
           end
-          context 'just billing' do
-            it 'should assign shipping to be billing' do
-              @data = {
-                'billing' => { 'id' => shop_addresses(:billing).id }
-              }
+        end
+        
+        context 'just billing' do
+          it 'should assign shipping to be billing' do
+            # Set the order to have no shipping address
+            @data[:shipping] = {}
+            
+            @checkout = FormCheckout.new(@form, @page)
+            result = @checkout.create
             
-              @checkout = FormCheckout.new(@form, @page)
-              @checkout.create
+            shop_orders(:one_item).billing.should  === shop_addresses(:billing)
+            shop_orders(:one_item).shipping.should === shop_addresses(:billing)
             
-              shop_orders(:one_item).billing.should  === shop_addresses(:billing)
-              shop_orders(:one_item).shipping.should === shop_addresses(:billing)
-            end
+            result[:billing].should  === true
+            result[:shipping].should === true
           end
         end
+      end
       
-        context 'existing addresses' do
-          it 'should keep them assigned and update them' do
-            shop_orders(:one_item).update_attributes({ 
-              :billing_id   => shop_addresses(:billing).id,
-              :shipping_id  => shop_addresses(:shipping).id,
-            })
-          
-            @data = {
-              'billing'   => { 'name' => 'new billing' },
-              'shipping'  => { 'name' => 'new shipping' }
-            }
-          
+      context 'sending ids without customer logged in' do
+        before :each do
+          @order = shop_orders(:one_item)
+          mock_valid_form_checkout_request
+        end
+        context 'both billing and shipping' do
+          it 'it should not assign those addresses' do
             @checkout = FormCheckout.new(@form, @page)
-            @checkout.create
-          
-            shop_orders(:one_item).billing.should === shop_addresses(:billing)
-            shop_addresses(:billing).name.should  === 'new billing'
-            shop_orders(:one_item).shipping.should=== shop_addresses(:shipping)
-            shop_addresses(:shipping).name.should === 'new shipping'
+            result = @checkout.create
+            
+            shop_orders(:one_item).billing.should  be_nil
+            shop_orders(:one_item).shipping.should be_nil
+            
+            result[:billing].should  === false
+            result[:shipping].should === false
           end
         end
+      end
       
-        context 'new addresses' do
-          context 'both billing and shipping sent' do
-            it 'should create new addresses' do
-              @data = {
-                'billing'   => { 'name' => 'b_n', 'email' => 'b_e', 'street' => 'b_s', 'city' => 'b_c', 'state' => 'b_s', 'country' => 'b_c', 'postcode' => 'b_p' },
-                'shipping'  => { 'name' => 's_n', 'email' => 's_e', 'street' => 's_s', 'city' => 's_c', 'state' => 's_s', 'country' => 's_c', 'postcode' => 's_p' }
-              }
-          
-              @checkout = FormCheckout.new(@form, @page)
-              @checkout.create
+      context 'sending ids as a bad customer' do
+        before :each do
+          login_as :bad_customer
+          @order = shop_orders(:one_item)
+          mock_valid_form_checkout_request
+        end
+        it 'should not assign those addresses' do
+          @checkout = FormCheckout.new(@form, @page)
+          result = @checkout.create
           
-              shop_orders(:one_item).billing.name.should  === 'b_n'
-              shop_orders(:one_item).shipping.name.should === 's_n'
-            end
-          end
-          context 'only billing sent' do
-            it 'should copy billing to shipping' do
-              @data = {
-                'billing'   => { 'name' => 'b_n', 'email' => 'b_e', 'street' => 'b_s', 'city' => 'b_c', 'state' => 'b_s', 'country' => 'b_c', 'postcode' => 'b_p' }
-              }
+          shop_orders(:one_item).billing.should  be_nil
+          shop_orders(:one_item).shipping.should be_nil
           
-              @checkout = FormCheckout.new(@form, @page)
-              @checkout.create
+          result[:billing].should  === false
+          result[:shipping].should === false
+        end
+      end
+      
+      context 'updating existing addresses' do
+        before :each do
+          login_as :customer
+          @order = shop_orders(:several_items)
+          mock_valid_form_checkout_request
+        end
+        it 'should keep them assigned and update them' do
+          @data[:billing]   = { :name => 'new billing' }
+          @data[:shipping]  = { :name => 'new shipping' }
           
-              shop_orders(:one_item).billing.name.should  === 'b_n'
-              shop_orders(:one_item).shipping.should === shop_orders(:one_item).billing
-            end
-          end
-          context 'billing sent with same shipping' do
-            it 'should copy billing to shipping' do
-              @data = {
-                'billing'   => { 'id' => shop_addresses(:billing).id, 'name' => 'b_n', 'email' => 'b_e', 'street' => 'b_s', 'city' => 'b_c', 'state' => 'b_s', 'country' => 'b_c', 'postcode' => 'b_p' },
-                'shipping'  => { 'id' => shop_addresses(:billing).id, 'name' => 'b_n', 'email' => 'b_e', 'street' => 'b_s', 'city' => 'b_c', 'state' => 'b_s', 'country' => 'b_c', 'postcode' => 'b_p' }
-              }
+          @checkout = FormCheckout.new(@form, @page)
+          result = @checkout.create
           
-              @checkout = FormCheckout.new(@form, @page)
-              @checkout.create
+          shop_addresses(:billing).name.should  === 'new billing'
+          shop_addresses(:shipping).name.should === 'new shipping'
           
-              shop_orders(:one_item).billing.name.should  === 'b_n'
-              shop_orders(:one_item).shipping.should === shop_orders(:one_item).billing
-            end
-          end
+          result[:billing].should  === true
+          result[:shipping].should === true
         end
-      
-        context 'result string' do
-          context 'success' do
-            it 'should return a success string' do
-              @data = {
-                'billing'   => { 'name' => 'b_n', 'email' => 'b_e', 'street' => 'b_s', 'city' => 'b_c', 'state' => 'b_s', 'country' => 'b_c', 'postcode' => 'b_p' },
-                'shipping'  => { 'name' => 's_n', 'email' => 's_e', 'street' => 's_s', 'city' => 's_c', 'state' => 's_s', 'country' => 's_c', 'postcode' => 's_p' }
-              }
+      end
+          
+      context 'new addresses' do
+        before :each do
+          login_as :customer
+          @order = shop_orders(:one_item)
+          mock_valid_form_checkout_request
           
-              @checkout = FormCheckout.new(@form, @page)
-              result = @checkout.create
+          @data[:billing][:id]  = nil
+          @data[:shipping][:id] = nil
+        end
+        
+        context 'both billing and shipping sent' do
+          it 'should create new addresses' do            
+            @checkout = FormCheckout.new(@form, @page)
+            result = @checkout.create
+            
+            shop_orders(:one_item).billing.name.should  === @data[:billing][:name]
+            shop_orders(:one_item).shipping.name.should === @data[:shipping][:name]
             
-              result[:billing][:name].should === 'b_n'
-              result[:shipping][:name].should === 's_n'
-            end
+            result[:billing].should  === true
+            result[:shipping].should === true
           end
-          context 'failure' do
-            it 'should set false to the nil billing' do
-              @data = {
-                'shipping'  => { 'name' => 's_n', 'email' => 's_e', 'street' => 's_s', 'city' => 's_c', 'state' => 's_s', 'country' => 's_c', 'postcode' => 's_p' }
-              }
+        end
+        
+        context 'only billing sent' do
+          it 'should copy billing to shipping' do
+            @data[:shipping] = {}
+            
+            @checkout = FormCheckout.new(@form, @page)
+            result = @checkout.create
             
-              @checkout = FormCheckout.new(@form, @page)
-              result = @checkout.create
+            shop_orders(:one_item).billing.name.should  === @data[:billing][:name]
+            shop_orders(:one_item).shipping.name.should === @data[:billing][:name]
             
-              result[:billing].should === false
-              result[:shipping].should_not === false
-            end
-            it 'should set billing to the nil shipping' do
-              @data = {
-                'billing'   => { 'name' => 'b_n', 'email' => 'b_e', 'street' => 'b_s', 'city' => 'b_c', 'state' => 'b_s', 'country' => 'b_c', 'postcode' => 'b_p' }
-              }
+            result[:billing].should  === true
+            result[:shipping].should === true
+          end
+        end
+        
+        context 'billing sent with same shipping' do
+          it 'should copy billing to shipping' do
+            @data[:shipping] = @data[:billing]
             
-              @checkout = FormCheckout.new(@form, @page)
-              result = @checkout.create
+            @checkout = FormCheckout.new(@form, @page)
+            result = @checkout.create
             
-              result[:billing].should_not === false
-              result[:shipping].should === result[:billing]
-            end
-            it 'should set false to the nil objects' do
-              @checkout = FormCheckout.new(@form, @page)
-              result = @checkout.create
+            shop_orders(:one_item).shipping.should      === shop_orders(:one_item).billing
             
-              result[:billing].should === false
-              result[:shipping].should === false
-            end
+            result[:billing].should  === true
+            result[:shipping].should === true
           end
         end
       end
-      
-      context 'not configured' do
+    end
+    
+    context 'gateway' do
+        context 'configured correctly' do
         before :each do
-          @form[:config] = {
-            :checkout   => {
-              :address  => {
-                :enabled => true
-              }
-            }
-          }
+          login_as :customer
+          @order = shop_orders(:one_item)
+          
+          mock_valid_form_checkout_request
+        end
+        
+        it 'should assign ActiveMerchant to testing mode' do
+          @checkout = FormCheckout.new(@form, @page)
+          @checkout.create
+          
+          ActiveMerchant::Billing::Base.mode.should === :test
+        end
+        
+        it 'should return true for payment results' do
+          mock.instance_of(ActiveMerchant::Billing::CreditCard).valid? { true }
+          @checkout = FormCheckout.new(@form, @page)
+          result = @checkout.create
+          
+          result[:gateway].should === true
+          result[:card].should    === true
+          result[:payment].should === true
         end
-        it 'should not call on the Address methods' do
-          @addresses = ShopAddress.all
-                    
+        
+        it 'should assign a payment object' do
+          mock.instance_of(ActiveMerchant::Billing::CreditCard).valid? { true }
           @checkout = FormCheckout.new(@form, @page)
           result = @checkout.create
           
-          ShopAddress.all.should === @addresses
+          @order.payment.card_number.should === "XXXX-XXXX-XXXX-1"
+          @order.payment.card_type.should   === @data[:card][:type]
+          @order.payment.amount.should      === @order.price
         end
       end
-    end
-    
-    context 'gateway' do
-      context 'merchant' do
-        context 'configured' do
-          before :each do
-            @form[:config] = {
-              :checkout   => {
-                :test     => true,
-                :gateway  => {
-                  :name   => 'PayWay',
-                  :credentials=> {
-                    :username => 'abcdefgh',
-                    :password => '12345678',
-                    :pem      => 'README',
-                    :merchant => 'test'
-                  }
-                }
-              }
-            }
-            @data = {
-              'card' => { }
-            }
+      
+      context 'configured incorrectly' do
+        before :each do
+          login_as :customer
+          @order = shop_orders(:one_item)
+          
+          mock_valid_form_checkout_request
+        end
+        context 'no gateway' do
+          it 'should return gateway false' do
+            mock.instance_of(ActiveMerchant::Billing::CreditCard).valid? { true }
+            @form[:extensions][:checkout][:gateway] = nil
+            
+            @checkout = FormCheckout.new(@form, @page)
+            result = @checkout.create
             
-            @gateway = Object.new
-            @purchase = Object.new
-            stub(@purchase).success? { true }
-            stub(@purchase).message { 'success' }
+            result[:gateway].should === false
+            result[:card].should    === false
+            result[:payment].should === false
             
-            mock(ActiveMerchant::Billing::PayWayGateway).new(@form[:config][:checkout][:gateway][:credentials]) { @gateway }
-            stub(@gateway).purchase(1000, nil, { :order_id => @order.id}) { @purchase }
+            @order.payment.should be_nil
           end
-          it 'should assign ActiveMerchant to testing mode' do        
-            @checkout = FormCheckout.new(@form, @page)
-            @checkout.create
+        end
         
-            ActiveMerchant::Billing::Base.mode.should === :test
-          end
-          
-          it 'should return gateway true' do
+        context 'no card' do
+          it 'should return card and payment false' do
+            mock.instance_of(ActiveMerchant::Billing::CreditCard).valid? { true }
+            @data[:card] = nil
+            
             @checkout = FormCheckout.new(@form, @page)
             result = @checkout.create
             
             result[:gateway].should === true
+            result[:card].should    === false
+            result[:payment].should === false
+            
+            @order.payment.should be_nil
           end
         end
         
-        context 'not configured' do
-          before :each do
-            @form[:config] = {
-              :checkout   => {
-                :test     => true
-              }
-            }
-          end
-          
-          it 'should not call PayWayGateway' do
-            dont_allow(ActiveMerchant::Billing::PayWayGateway).new
+        context 'invalid card' do
+          it 'should return card and payment false' do
+            mock.instance_of(ActiveMerchant::Billing::CreditCard).valid? { false }
             
-            @checkout = FormCheckout.new(@form, @page)
-            @checkout.create
-          end
-          
-          it 'should return gateway false' do
             @checkout = FormCheckout.new(@form, @page)
             result = @checkout.create
             
-            result[:gateway].should === false
+            result[:gateway].should === true
+            result[:card].should    === false
+            result[:payment].should === false
+            
+            @order.payment.should be_nil
           end
         end
       end
+    end
+    
+    context 'mail' do
+      before :each do
+        mock.instance_of(ActiveMerchant::Billing::CreditCard).valid? { true }
+      end
       
-      context 'card without test' do
+      context 'mail configured' do
         before :each do
-          @form[:config] = {
-            :checkout   => {
-              :gateway  => {
-                :name   => 'PayWay',
-                :credentials => {}
-              }
-            }
-          }
-          @data = {
-            'card' => { 
-              'number'        => 1234123412341234,
-              'name'          => 'Mr. Joe Bloggs',
-              'verification'  => 123,
-              'month'         => 1,
-              'year'          => 2009,
-              'type'          => 'visa'
-            }
-          }
+          login_as :customer
+          @order = shop_orders(:one_item)
           
-          @gateway = Object.new
-          @purchase = Object.new
-          stub(@purchase).success? { true }
-          stub(@purchase).message { 'success' }
-          mock(ActiveMerchant::Billing::PayWayGateway).new(@form[:config][:checkout][:gateway][:credentials]) { @gateway }
-          stub(@gateway).purchase(@order.price * 100, anything, { :order_id => @order.id }) { @purchase }
+          mock_valid_form_checkout_request
         end
-        context 'configured' do
-          before :each do
-            @card = Object.new
-            stub(@card).valid? { true }
-            
-            mock(ActiveMerchant::Billing::CreditCard).new({
-              :number             => 1234123412341234,
-              :month              => 1,
-              :year               => 2009,
-              :first_name         => 'Mr. Joe',
-              :last_name          => 'Bloggs',
-              :verification_value => 123,
-              :type               => 'visa'
-            }) { @card }
-          end
-          context 'should return card details' do
-            context 'valid' do
-              it 'should return valid' do
-                stub(@card).valid? { true }
-                
-                @checkout = FormCheckout.new(@form, @page)
-                result = @checkout.create
-                
-                result[:card][:valid].should === true
-                result[:payment][:success].should == true
-                result[:payment][:message].should == 'success'
-              end
-              it 'should set the order as paid' do              
-                stub(@card).valid? { true }
-                
-                @checkout = FormCheckout.new(@form, @page)
-                result = @checkout.create
-                
-                shop_orders(:one_item).paid?.should === true
-              end
-            end
-            context 'invalid' do
-              it 'should return invalid' do
-                stub(@card).valid? { false }
-                
-                @checkout = FormCheckout.new(@form, @page)
-                result = @checkout.create
-                
-                result[:card][:valid].should === false
-              end
-            end
-          end
-          it 'should return relevant details' do
-            stub(@card).valid? { true }
-            
+        context 'payment successful' do
+          it 'should configure mail to be sent' do
             @checkout = FormCheckout.new(@form, @page)
-            result = @checkout.create
+            @checkout.create
             
-            result[:card].should == {
-              :valid  => true
-            }
+            @form[:extensions][:mail][:to].should         === shop_addresses(:billing).email
+            @form[:extensions][:mail][:recipient].should  === shop_addresses(:billing).email
+            @form[:extensions][:mail][:subject].should    === @form[:extensions][:checkout][:mail][:subject]
+            @form[:extensions][:mail][:bcc].should        === @form[:extensions][:checkout][:mail][:bcc]
           end
-          it 'should not return sensitive details' do
-            stub(@card).valid? { true }
-            
+        end
+        
+        context 'payment unsuccesful' do
+          it 'should not configure mail to be sent' do
             @checkout = FormCheckout.new(@form, @page)
-            result = @checkout.create
+            stub(@checkout).success? { false }
+            @checkout.create
             
-            result[:card][:number].should === nil
-            result[:card][:verification].should === nil
+            @form[:extensions][:mail].should be_nil
           end
         end
       end
       
+      context 'mail not configured' do
+        before :each do
+          login_as :customer
+          @order = shop_orders(:one_item)
+          
+          mock_valid_form_checkout_request
+          @form[:extensions][:checkout][:mail] = nil
+        end
+        it 'should not configure mail to be sent' do
+          @checkout = FormCheckout.new(@form, @page)
+          result = @checkout.create
+          
+          @form[:extensions][:mail].should be_nil
+        end
+      end
     end
   end
 end