radiant-reader-extension 0.9.2

data/spec/controllers/readers_controller_spec.rb

@@ -0,0 +1,193 @@
+require File.dirname(__FILE__) + '/../spec_helper'
+
+describe ReadersController do
+  dataset :readers, :messages
+  
+  before do
+    controller.stub!(:request).and_return(request)
+    Page.current_site = sites(:test) if defined? Site
+    request.env["HTTP_REFERER"] = 'http://test.host/referer!'
+    Radiant::Config['reader.allow_registration?'] = true
+  end
+    
+  describe "with a get to new" do
+    it "should render the registration screen" do
+      get :new
+      response.should be_success
+      response.should render_template("new")
+    end
+    
+    it "should generate a secret email field name" do
+      
+    end
+  end
+  
+  describe "with a registration" do
+    before do
+      session[:email_field] = @email_field = 'randomstring'
+      post :create, :reader => {:name => "registering user", :password => "password", :password_confirmation => "password"}, :randomstring => 'registrant@spanner.org'
+      @reader = Reader.find_by_name('registering user')
+    end
+    
+    it "should create a new reader" do
+      @reader.should_not be_nil
+    end
+
+    it "should set the current reader" do
+      controller.send(:current_reader).should == @reader
+    end
+
+    it "should have deobfuscated the email field" do
+      @reader.email.should == 'registrant@spanner.org'
+    end
+
+    it "should have defaulted to email address as login" do
+      @reader.login.should == @reader.email
+    end
+    
+    if defined? Site
+      it "should have assigned the new reader to the current site" do
+        @reader.site.should == sites(:test)
+      end
+    end
+
+    it "should redirect to the please-activate page" do
+      response.should be_redirect
+      response.should redirect_to(reader_activation_url)
+    end
+    
+    describe "with the trap field filled in" do
+      before do
+        session[:email_field] = @email_field = 'randomstring'
+        post :create, :reader => {:name => "bot user", :email => 'registrant@spanner.org'}, :password => "password", :password_confirmation => "password"
+        @reader = Reader.find_by_name('bot user')
+      end
+      it "should not create the reader" do
+        @reader.should be_nil
+      end
+      it "should re-render the form" do
+        response.should be_success
+        response.should render_template('new')
+      end
+      it "should flash a notice" do
+        flash[:error].should_not be_nil
+      end
+    end
+  end
+  
+  describe "to the browser" do
+    describe "who has logged in" do
+      before do
+        activate_authlogic
+        rsession = ReaderSession.create!(readers(:normal))
+        # controller.stub!(:current_reader_session).and_return(rsession)
+      end
+  
+      it "should consent to show another reader page" do 
+        get :show, :id => reader_id(:visible)
+        response.should be_success
+      end
+      
+      it "should not show the edit page for another reader" do 
+        get :edit, :id => reader_id(:visible)
+        response.should be_success        
+        flash[:error].should =~ /not allowed/
+      end
+
+      it "should not remove this reader" do 
+        delete :destroy, :id => reader_id(:normal)
+        response.should be_redirect
+        response.should redirect_to(admin_readers_url)
+        Reader.find(reader_id(:normal)).should_not be_nil
+      end
+
+      it "should not remove another reader" do 
+        delete :destroy, :id => reader_id(:visible)
+        response.should be_redirect
+        response.should redirect_to(admin_readers_url)
+        Reader.find(reader_id(:visible)).should_not be_nil
+      end
+    end
+
+    describe "who has not logged in" do
+      before do
+        logout_reader
+      end
+  
+      it "should not show a reader page" do 
+        get :show, :id => reader_id(:visible)
+        response.should be_redirect
+        response.should redirect_to(reader_login_url)
+      end
+    end
+  end
+    
+  describe "with an update request" do
+    before do
+      login_as_reader(:normal)
+    end
+
+    describe "that includes the correct password" do
+      before do
+        put :update, {:id => reader_id(:normal), :reader => {:name => "New Name", :current_password => 'password'}}
+        @reader = readers(:normal)
+      end
+      
+      it "should update the reader" do 
+        @reader.name.should == 'New Name'
+      end
+
+      it "should redirect to the reader page" do 
+        response.should be_redirect
+        response.should redirect_to(reader_url(@reader))
+      end
+      
+    end
+
+    describe "that does not include the correct password" do
+      before do
+        put :update, {:id => reader_id(:normal), :reader => {:name => "New Name"}, :current_password => 'wrongo'}
+        @reader = readers(:normal)
+      end
+
+      it "should not update the reader" do 
+        @reader.name.should == 'Normal'
+      end
+
+      it "should re-render the edit form" do 
+        response.should be_success
+        response.should render_template("edit")
+      end
+    end
+
+    describe "that does not validate" do
+      before do
+        put :update, {:id => reader_id(:normal), :reader => {:login => "visible@spanner.org"}, :current_password => 'password'}
+        @reader = readers(:normal)
+      end
+
+      it "should not update the reader" do 
+        @reader.name.should == 'Normal'
+      end
+
+      it "should re-render the edit form" do 
+        response.should be_success
+        response.should render_template("edit")
+      end
+
+    end
+  end
+  
+  describe "when registration is not allowed" do
+    before do
+      Radiant::Config['reader.allow_registration?'] = false
+    end
+    
+    it "should not offer the registration form" do
+      get :new
+      response.should be_redirect
+      response.should redirect_to reader_login_url
+      flash[:error].should_not be_nil
+    end
+  end
+end

data/spec/datasets/messages_dataset.rb

@@ -0,0 +1,49 @@
+class MessagesDataset < Dataset::Base
+  datasets = [:readers, :users]
+  datasets << :reader_sites if defined? Site
+  uses *datasets
+
+  def load
+    create_message "Normal"
+    create_message "Filtered", :filter_id => 'Textile', :body => 'this is a *filtered* message'
+    create_message "Welcome", :filter_id => 'Textile', :body => 'Hi', :function_id => 'welcome'
+    create_message "Activation", :filter_id => 'Textile', :body => 'Hi?', :function_id => 'activation'
+    create_message "Invitation", :filter_id => 'Textile', :body => 'Hi!', :function_id => 'invitation'
+    create_message "Password", :filter_id => 'Textile', :body => 'Oh', :function_id => 'password_reset'
+    create_message "Taggy", :filter_id => 'Textile', :body => %{
+To <r:recipient:name />
+
+Ying Tong Iddle I Po.
+
+From <r:sender:name />
+    }
+  end
+  
+  helpers do
+    def create_message(subject, attributes={})
+      attributes = message_attributes(attributes.update(:subject => subject))
+      message = create_model Message, subject.symbolize, attributes
+      message.update_attribute(:created_by, users(:existing))
+    end
+    
+    def message_attributes(attributes={})
+      subject = attributes[:subject] || "Message"
+      symbol = subject.symbolize
+      attributes = { 
+        :subject => subject,
+        :body => "This is the #{subject} message"
+      }.merge(attributes)
+      attributes[:site] = sites(:test) if defined? Site
+      attributes
+    end
+    
+    def seem_to_send(message, reader)
+      message = messages(message) unless message.is_a?(Message)
+      reader = readers(reader) unless reader.is_a?(Reader)
+      sending = MessageReader.find_or_create_by_message_id_and_reader_id(message.id, reader.id)
+      sending.sent_at = 10.minutes.ago
+      sending.save
+    end
+  end
+ 
+end

data/spec/datasets/reader_layouts_dataset.rb

@@ -0,0 +1,26 @@
+class ReaderLayoutsDataset < Dataset::Base
+  uses :reader_sites if defined? Site
+  
+  def load
+    create_layout "Main"
+    create_layout "Other"
+    create_layout "email", :content => %{
+<html>
+  <head><title><r:title /></title></head>
+  <body>
+    <p>header</p>
+    <r:content />
+    <p>footer</p>
+  </body>
+<html>  
+    }
+  end
+  
+  helpers do
+    def create_layout(name, attributes={})
+      attributes[:site] ||= sites(:test) if Layout.reflect_on_association(:site)
+      create_model :layout, name.symbolize, attributes.update(:name => name)
+    end
+  end
+ 
+end

data/spec/datasets/reader_sites_dataset.rb

@@ -0,0 +1,10 @@
+class ReaderSitesDataset < Dataset::Base
+  uses :home_page
+  
+  def load
+    create_record Site, :mysite, :name => 'My Site', :domain => 'mysite.domain.com', :base_domain => 'mysite.domain.com', :position => 1, :homepage_id => page_id(:home)
+    create_record Site, :yoursite, :name => 'Your Site', :domain => '^yoursite', :base_domain => 'yoursite.test.com', :position => 2
+    create_record Site, :test, :name => 'Test host', :domain => '^test\.', :base_domain => 'test.host', :position => 6
+    Page.current_site = sites(:test) if defined? Site
+  end
+end

data/spec/datasets/readers_dataset.rb

@@ -0,0 +1,51 @@
+require "authlogic/test_case"
+
+class ReadersDataset < Dataset::Base
+  datasets = [:users]
+  datasets << :reader_sites if defined? Site
+  uses *datasets
+
+  def load
+    create_reader "Normal"
+    create_reader "Visible"
+    create_reader "User", :user_id => user_id(:existing)
+    create_reader "Inactive", :activated_at => nil
+  end
+  
+  helpers do
+    def create_reader(name, attributes={})
+      attributes = reader_attributes(attributes.update(:name => name))
+      reader = create_model Reader, name.symbolize, attributes
+    end
+    
+    def reader_attributes(attributes={})
+      name = attributes[:name] || "John Doe"
+      symbol = name.symbolize
+      attributes = { 
+        :name => name,
+        :email => "#{symbol}@spanner.org", 
+        :login => "#{symbol}@spanner.org",
+        :activated_at => Time.now - 1.week,
+        :password_salt => "golly",
+        :password => 'password',
+        :password_confirmation => 'password'
+      }.merge(attributes)
+      attributes[:site] = sites(:test) if defined? Site
+      attributes
+    end
+        
+    def login_as_reader(reader)
+      activate_authlogic
+      login_reader = reader.is_a?(Reader) ? reader : readers(reader)
+      ReaderSession.create(login_reader)
+      login_reader
+    end
+    
+    def logout_reader
+      if session = ReaderSession.find
+        session.destroy
+      end
+    end
+  end
+ 
+end

data/spec/lib/reader_admin_ui_spec.rb

@@ -0,0 +1,35 @@
+require File.dirname(__FILE__) + "/../spec_helper"
+
+describe "AdminUI extensions for readers" do
+  before :each do
+    @admin = Radiant::AdminUI.new
+    @admin.reader = Radiant::AdminUI.load_default_reader_regions
+  end
+
+  it "should be included into Radiant::AdminUI" do
+    Radiant::AdminUI.included_modules.should include(ReaderAdminUI)
+  end
+
+  it "should define a collection of Region Sets for readers" do
+    @admin.should respond_to('reader')
+    @admin.should respond_to('readers')
+    @admin.send('reader').should_not be_nil
+    @admin.send('reader').should be_kind_of(OpenStruct)
+  end
+
+  describe "should define default regions" do
+    %w{new edit remove index}.each do |action|
+      
+      describe "for '#{action}'" do
+        before do
+          @reader = @admin.reader
+          @reader.send(action).should_not be_nil
+        end
+              
+        it "as a RegionSet" do
+          @reader.send(action).should be_kind_of(Radiant::AdminUI::RegionSet)
+        end
+      end
+    end
+  end
+end

data/spec/lib/reader_site_spec.rb

@@ -0,0 +1,18 @@
+require File.dirname(__FILE__) + "/../spec_helper"
+
+if defined? Site
+  describe 'Reader-extended site' do
+    dataset :reader_layouts, :reader_sites
+    Radiant::Config['reader.layout'] = 'This one'
+
+    it "should have a reader_layout association" do
+      Site.reflect_on_association(:reader_layout).should_not be_nil
+    end
+    
+    it "should be able to set its own layout" do
+      site = sites(:mysite)
+      site.reader_layout = layouts(:other)
+      site.layout_for(:reader).should == 'Other'
+    end
+  end
+end

data/spec/matchers/reader_login_system_matcher.rb

@@ -0,0 +1,35 @@
+module Spec
+  module Rails
+    module Matchers
+      class ReaderLoginRequirement
+        def initialize(example)
+          @example = example
+        end
+
+        def matches?(proc)
+          proc.call
+          @response = @example.response
+          @was_redirect = @response.redirect?
+          @was_redirect_to_login = @response.redirect_url_match?("/readers/login")
+          @was_redirect && @was_redirect_to_login
+        end
+
+        def failure_message
+          if @was_redirect
+            "expected to redirect to /readers/login but redirected to #{@response.redirect_url}"
+          else
+            "expected to require reader login but did not redirect"
+          end
+        end
+
+        def negative_failure_message
+          "expected not to require reader login"
+        end
+      end
+
+      def require_reader_login
+        ReaderLoginRequirement.new(self)
+      end
+    end
+  end
+end

data/spec/models/message_spec.rb

@@ -0,0 +1,109 @@
+require File.dirname(__FILE__) + '/../spec_helper'
+
+describe Message do
+  dataset :messages
+  
+  before do
+
+  end
+  
+  describe "on validation" do
+    before do
+      @message = messages(:normal)
+      @message.should be_valid
+    end
+    
+    it "should require a subject" do
+      @message.subject = nil
+      @message.should_not be_valid
+      @message.errors.on(:subject).should_not be_empty
+    end
+    
+    it "should require a body" do
+      @message.body = ""
+      @message.should_not be_valid
+      @message.errors.on(:body).should_not be_empty
+    end
+  end
+  
+  describe "with a filter" do
+    it "should format itself" do
+      messages(:filtered).body.should == "this is a *filtered* message"
+      messages(:filtered).filtered_body.should == "<p>this is a <strong>filtered</strong> message</p>"
+    end
+  end
+  
+  describe "on preview" do
+    before do
+      @preview = messages(:taggy).preview
+    end
+
+    it "should render a fake sending" do
+      @preview.should be_kind_of(TMail::Mail)
+      @preview.from.should == [messages(:taggy).created_by.email]
+      @preview.subject.should == messages(:taggy).subject
+      @preview.body.should =~ /From #{messages(:taggy).created_by.name}/
+    end
+  end
+  
+  describe "with a reader association" do
+    before do
+      @message = messages(:normal)
+      @message.readers << readers(:normal)
+    end
+    
+    describe "but unsent" do
+      it "should know to whom it can belong" do
+        @message.possible_readers.count.should == Reader.active.count
+      end
+
+      it "should know to whom it does belong" do
+        @message.readers.include?(readers(:normal)).should be_true
+      end
+    
+      it "should report itself unsent to anyone" do
+        @message.delivered?.should be_false
+      end
+    
+      it "should report itself not sent to one of its readers" do
+        @message.delivered_to?(readers(:normal)).should be_false
+      end
+
+      it "should report itself not sent to an unrelated reader" do
+        @message.delivered_to?(readers(:visible)).should be_false
+      end
+    end
+
+    describe "already sent to one reader" do
+      before do
+        seem_to_send(messages(:normal), readers(:normal))
+        @message.readers << readers(:visible)
+      end
+      
+      it "should report itself delivered" do
+        @message.delivered?.should be_true
+      end
+    
+      it "should know to whom it has been sent" do
+        @message.recipients.should == [readers(:normal)]
+      end
+    
+      it "should know to whom it has yet to be sent" do
+        @message.undelivered_readers.should == Reader.active - @message.recipients
+      end
+    
+      it "should report itself delivered to that reader" do
+        @message.delivered_to?(readers(:normal)).should be_true
+      end
+
+      it "should report itself not yet sent to other readers" do
+        @message.readers.include?(readers(:visible)).should be_true
+        @message.delivered_to?(readers(:visible)).should be_false
+      end
+
+    end
+    
+    
+  end
+  
+end