radiant-forum-extension 1.2.1 → 2.0.0

data/spec/lib/commentable_model_spec.rb

@@ -0,0 +1,88 @@
+require File.dirname(__FILE__) + "/../spec_helper"
+
+describe 'Post-holder' do
+  dataset :forums
+  
+  before do
+    Radiant::Config['forum.paginate_posts?'] = true
+    @topic = topics(:empty)
+  end
+
+  describe "without replies" do
+    it "should announce posts but not replies" do
+      @topic.posts.count.should == 1
+      @topic.has_posts?.should be_true
+      @topic.has_replies?.should be_false
+    end
+  end
+  
+  describe "with replies" do
+    before do
+      60.times do |i|
+        @topic.posts.create!(:body => "test #{i}", :reader => readers(:normal), :created_at => (100-i).minutes.ago)
+      end
+      @topic.posts.create!(:body => "test by another", :reader => readers(:idle))
+      @topic.reload
+    end
+    
+    it "should have many posts" do
+      @topic.posts.count.should == 62
+    end
+
+    it "should report the number of replies to the original post" do
+      @topic.reply_count.should == 61
+      @topic.replies.length.should == @topic.reply_count
+    end
+
+    it "should report the number of readers taking part" do
+      calculated = @topic.posts.map(&:reader).uniq
+      Rails.logger.warn ">>"
+      @topic.voice_count.should == calculated.length
+      Rails.logger.warn "<<"
+    end
+
+    it "should report the number of readers replying" do
+      calculated = @topic.posts.map(&:reader).uniq - [@topic.posts.first.reader]
+      @topic.other_voice_count.should == calculated.length
+    end
+
+    it "should report the list of readers taking part" do
+      @topic.voices.length.should == 3
+      @topic.voices.include?(readers(:notable)).should be_true
+      @topic.voices.include?(readers(:normal)).should be_true
+      @topic.voices.include?(readers(:idle)).should be_true
+    end
+
+    it "should report the list of readers replying" do
+      @topic.other_voices.length.should == 2
+      @topic.other_voices.include?(readers(:notable)).should be_false
+      @topic.other_voices.include?(readers(:normal)).should be_true
+      @topic.other_voices.include?(readers(:idle)).should be_true
+    end
+
+    it "should paginate its posts" do
+      @topic.paged?.should be_true
+    end
+
+    it "should know on which page to find a given post" do
+      @topic.page_for(Post.find_by_body("test 16")).should == 1
+      @topic.page_for(Post.find_by_body("test 36")).should == 2
+      @topic.page_for(Post.find_by_body("test 56")).should == 3
+    end
+
+    it "should read config to find the number of posts per page" do
+      Radiant::Config['forum.posts_per_page'] = 15
+      @topic.page_for(Post.find_by_body("test 16")).should == 2
+      @topic.page_for(Post.find_by_body("test 36")).should == 3
+      @topic.page_for(Post.find_by_body("test 56")).should == 4
+    end
+
+    it "should know when it was last replied to" do
+      @topic.replied_at.should == @topic.posts.last.created_at
+    end
+
+    it "should know by whom it was last replied to" do
+      @topic.replied_by.should == readers(:idle)
+    end
+  end
+end

data/spec/lib/forum_page_spec.rb

@@ -1,46 +1,14 @@
 require File.dirname(__FILE__) + "/../spec_helper"
 
 describe 'Forum-extended page' do
-  dataset :posts
-  dataset :forum_pages
+  dataset :forums
   
   before do
     login_as_reader(:normal)
   end
-
-  it "should have a topic association" do
-    Page.reflect_on_association(:topic).should_not be_nil
-  end
- 
-  it "should create a new topic if it doesn't already have one" do
-    topic = pages(:ordinary).find_or_build_topic
-    topic.new_record?.should be_true
-  end
-
-  it "should not create a topic if it does already have one" do
-    topic = pages(:commentable).find_or_build_topic
-    topic.new_record?.should be_false
-    topic.should == topics(:comments)
-  end
-
-  it "should not create a topic if it isn't commentable" do
-    topic = pages(:uncommentable).find_or_build_topic
-    topic.should be_nil
-  end
-
-  it "should know whether it has posts or not" do
-    page = pages(:ordinary)
-    topic = page.find_or_build_topic
-    topic.name = "Foo"
-    topic.body = "Bar"
-    topic.save
-    page.has_posts?.should be_false
-    topic.posts.create(:body => 'foo')
-    pages(:ordinary).has_posts?.should be_true
-  end
   
   it "should normally be commentable" do
-    pages(:ordinary).locked?.should be_false
+    pages(:uncommented).locked?.should be_false
   end
   
   it "should be locked if marked not commentable" do

data/spec/lib/forum_site_spec.rb

@@ -1,10 +1,9 @@
 require File.dirname(__FILE__) + "/../spec_helper"
 
 if defined? Site
-  Radiant::Config['reader.layout'] = 'This one'
-
   describe 'Forum site' do
-    dataset :forum_layouts, :forum_sites
+    dataset :forums, :forum_sites
+    # Radiant::Config['reader.layout'] = 'Reader'
     
     it "should have a forums association" do
       Site.reflect_on_association(:forums).should_not be_nil

data/spec/lib/forum_tags_spec.rb

@@ -0,0 +1,35 @@
+require File.dirname(__FILE__) + '/../spec_helper'
+
+describe "Forum Tags" do
+  dataset :forums
+
+  let(:page){ pages(:commentable) }
+
+  describe "r:forum:topic tags" do
+    let(:topic){ topics(:older) }
+    let(:sticky){ topics(:sticky) }
+    let(:on_date){ I18n.l(topic.created_at, :format => :standard) }
+    let(:sticky_date){ I18n.l(sticky.created_at, :format => :standard) }
+    
+    subject { page }
+    it { should render(%{<r:forum:topic id="#{topic.id}"><r:forum:topic:name /></r:forum:topic>}).as(topic.name) }
+    it { should render(%{<r:forum:topic id="#{topic.id}"><r:forum:topic:body /></r:forum:topic>}).as(topic.posts.first.body_html) }
+    it { should render(%{<r:forum:topic id="#{topic.id}"><r:forum:topic:author /></r:forum:topic>}).as("Normal") }
+    it { should render(%{<r:forum:topic id="#{topic.id}"><r:forum:topic:date /></r:forum:topic>}).as(on_date) }
+    it { should render(%{<r:forum:topic id="#{topic.id}"><r:forum:topic:url /></r:forum:topic>}).as("/forum/forums/#{topic.forum.id}/topics/#{topic.id}") }
+    it { should render(%{<r:forum:topic id="#{topic.id}"><r:forum:topic:context /></r:forum:topic>}).as(%{Started by <a href="/readers/#{reader_id(:normal)}">Normal</a> #{on_date}}) }
+    it { should render(%{<r:forum:topic id="#{topic.id}"><r:forum:topic:body /></r:forum:topic>}).as("<p>original topic message</p>") }
+    it { should render(%{<r:forum:topic id="#{topic.id}"><r:forum:topic:link /></r:forum:topic>}).as(%{<a href="/forum/forums/#{topic.forum.id}/topics/#{topic.id}">#{topic.name}</a>}) }
+    it { should render(%{<r:forum:topic id="#{topic.id}"><r:forum:topic:summary /></r:forum:topic>}).as(%{<li><a href="/forum/forums/#{topic.forum.id}/topics/#{topic.id}">#{topic.name}</a><br />Started by <a href="/readers/#{reader_id(:normal)}">Normal</a> #{on_date}</li>}) }
+    it { should render(%{<r:forum:topic id="#{sticky.id}"><r:forum:topic:summary /></r:forum:topic>}).as(%{<li><a href="/forum/forums/#{sticky.forum.id}/topics/#{sticky.id}">#{sticky.name}</a><br />Started by <a href="/readers/#{reader_id(:normal)}">Normal</a> #{sticky_date}</li>}) }
+  end
+
+  describe "r:forum:post tags" do
+    let(:post){ posts(:second) }
+    let(:comment){ posts(:comment) }
+    subject { page }
+    it { should render(%{<r:forum:post id="#{post.id}"><r:forum:post:name /></r:forum:post>}).as(post.topic.name) }
+    it { should render(%{<r:forum:post id="#{comment.id}"><r:forum:post:name /></r:forum:post>}).as(comment.page.title) }
+  end
+
+end

data/spec/models/forum_spec.rb

@@ -1,7 +1,7 @@
 require File.dirname(__FILE__) + '/../spec_helper'
 
 describe Forum do
-  dataset :topics
+  dataset :forums
   
   before do
     @site = Page.current_site = sites(:test) if defined? Site
@@ -15,34 +15,45 @@ describe Forum do
     @forum.errors.on(:name).should_not be_empty
   end
   
-  it "should list its topics in date order" do
-    @forum.topics.first.should == topics(:newer)
+  describe "topics.bydate" do
+    it "should list its topics in descending date order" do
+      forums(:public).topics.bydate.first.should == topics(:newer)
+      forums(:private).topics.bydate.first.should == topics(:private)
+    end
   end
   
-  it "should list its topics with the sticky first" do
-    forums(:private).topics.first.should == topics(:sticky)
+  describe "topics.stickyfirst" do
+    it "should list its topics with the sticky first" do
+      forums(:private).topics.stickyfirst.first.should == topics(:sticky)
+    end
   end
   
-  it "should report itself visible" do
-    forums(:public).visible_to?(@reader).should be_true
-    forums(:public).visible_to?(nil).should be_true
-  end
+  describe "when the forum is public" do
+    before do
+      Radiant::Config['forum.public?'] = true
+    end
 
-  describe ".find_or_create_comments_forum" do
+    it "should be visible to a reader" do
+      forums(:public).visible_to?(@reader).should be_true
+    end
     
-    it "should return the existing comments forum when there is one" do
-      @forum = Forum.find_or_create_comments_forum
-      @forum.should == forums(:comments)
+    it "should be visible when there is no reader" do
+      forums(:public).visible_to?(nil).should be_true
+    end
+  end
+
+  describe "when the whole forum is private" do
+    before do
+      Radiant::Config['forum.public?'] = false
     end
 
-    it "should create a comments forum if there is none" do
-      forums(:comments).delete
-      Forum.should_receive(:find_by_for_comments)
-      @forum = Forum.find_or_create_comments_forum
-      @forum.for_comments.should be_true
-      @forum.name.should == 'Page Comments'
-      @forum.created_at.should be_close(Time.now, 5.seconds)
+    it "should be visible to a reader" do
+      forums(:public).visible_to?(@reader).should be_true
     end
     
+    it "should not be visible when there is no reader" do
+      forums(:public).visible_to?(nil).should be_false
+    end
   end
+
 end

data/spec/models/post_spec.rb

@@ -1,49 +1,47 @@
 require File.dirname(__FILE__) + '/../spec_helper'
 
 describe Post do
-  dataset :posts
-  dataset :forum_readers
+  dataset :forums
   
   before do
-    @site = Page.current_site = sites(:test) if defined? Site
-    @reader = Reader.current = readers(:normal)
+    @site = Page.current_site = sites(:test) if Page.respond_to? :current_site
   end
   
   describe "on creation" do
-  
-    it "should require a topic" do
-      post = Post.new(:body => 'hullabaloo')
-      post.should_not be_valid
-    end
-    
     it "should require body text" do
-      post = topics(:older).posts.build(:body => nil)
+      post = topics(:older).posts.build(:body => nil, :reader => readers(:normal))
       post.should_not be_valid
+      post.errors.on(:body).should_not be_nil
     end
 
-    it "should get a reader automatically" do
+    it "should require a reader" do
       post = topics(:older).posts.build(:body => 'authorless')
-      post.should be_valid
-      post.reader.should == @reader
+      post.should_not be_valid
+      post.errors.on(:reader).should_not be_nil
     end
     
-    it "should update topic reply data" do
-      post = topics(:older).posts.create!(:body => 'hullabaloo')
-      topic = Topic.find(topic_id(:older))
-      topic.last_post.should == post
-      topic.replied_by.should == @reader
-      topic.replied_at.should be_close(Time.now, 5.seconds)
+    describe "when added to a topic" do
+      before do
+        Rails.logger.warn ">>"
+        post = topics(:older).posts.create!(:body => 'newly added', :reader => readers(:idle))
+      end
+      
+      it "should update topic reply data" do
+        topic = Topic.find(topic_id(:older))
+        topic.replied_by.should == readers(:idle)
+        topic.replied_at.should be_close(Time.now, 10.seconds)
+      end
     end
   end
 
   describe "during the editable period" do
     before do
       Radiant::Config['forum.editable_period'] = 15
-      @post = topics(:older).posts.create!(:body => 'foo')
+      @post = topics(:older).posts.create!(:body => 'foo', :reader => readers(:normal))
     end
 
     it "should be editable by its author" do 
-      @post.editable_by?(@post.reader).should be_true
+      @post.editable_by?(readers(:normal)).should be_true
     end
 
     it "should not be editable by anyone else" do 
@@ -54,38 +52,41 @@ describe Post do
   describe "after the editable period" do
     before do
       Radiant::Config['forum.editable_period'] = 15
-      @post = topics(:older).posts.create!(:body => 'foo')
-      @post.created_at = Time.now - 16.minutes
+      @post = topics(:older).posts.create!(:body => 'foo', :reader => readers(:normal), :created_at => Time.now - 16.minutes)
     end
     
-    it "should no longer be editable by its author" do 
+    it "should not be editable by its author" do 
       @post.editable_by?(@post.reader).should be_false
     end
+
+    it "should not be editable by anyone else" do 
+      @post.editable_by?(readers(:idle)).should be_false
+    end
   end
 
   describe "on removal" do
+    before do
+      @last = topics(:older).posts.last
+      @post = topics(:older).posts.create!(:body => 'uh oh', :reader => readers(:idle))
+    end
     it "should revert topic reply data" do
-      topicbefore = topics(:older)
-      last = topicbefore.last_post
-      post = topicbefore.posts.create!(:body => 'uh oh')
-
-      post.destroy
-      topicafter = Topic.find(topic_id(:older))
-      topicafter.last_post.should == last
-      topicafter.replied_by.should == last.reader
-      topicafter.replied_at.should == last.created_at
+      @post.destroy
+      topic = Topic.find(topic_id(:older))
+      topic.replied_by.should == @last.reader
+      topic.replied_at.should be_close(@last.created_at, 1.second)
     end
   end
   
   it "should report on which page of its topic it can be found" do
+    Radiant::Config['forum.paginate_posts?'] = true
     Radiant::Config['forum.posts_per_page'] = 25
-    firstpost = topics(:older).posts.create!(:body => 'foo')
+    firstpost = topics(:older).posts.create!(:body => 'foo', :reader => readers(:normal))
     55.times do |i| 
-      topics(:older).posts.create!(:body => 'rhubarb') 
+      topics(:older).posts.create!(:body => 'rhubarb', :reader => readers(:normal))
     end
-    lastpost = topics(:older).posts.create!(:body => 'bar')
-    firstpost.topic_page.should == 1
-    lastpost.topic_page.should == 3
+    lastpost = topics(:older).posts.create!(:body => 'bar', :reader => readers(:idle))
+    firstpost.page_when_paginated.should == 1
+    lastpost.page_when_paginated.should == 3
   end
 
 end

data/spec/models/topic_spec.rb

@@ -1,26 +1,29 @@
 require File.dirname(__FILE__) + '/../spec_helper'
 
 describe Topic do
-  dataset :topics
+  dataset :forums
 
-  before do
-    @site = Page.current_site = sites(:test) if defined? Site
-    @reader = Reader.current = readers(:normal)
-  end
-  
   describe "on creation" do
     before do
-      @topic = Topic.create!(:name => 'testing', :body => 'this is the first post body but validation requires it', :forum => forums(:public))
+      @post = Post.create!(
+        :body => "first post body", 
+        :reader_id => reader_id(:normal),
+        :topic_attributes => {
+          :name => 'testing',
+          :forum_id => forum_id(:public)
+        }
+      )
+      @topic = @post.topic
     end
     
     it "should set default values" do
       @topic.sticky?.should be_false
       @topic.locked?.should be_false
-      @topic.replied_by.should be_nil
-      @topic.replied_at.should be_close(@topic.created_at, 1.minute)
+      @topic.replied_by.should == readers(:normal)
+      @topic.replied_at.should be_close(Time.now, 1.minute)
     end
 
-    [:name, :forum].each do |field|
+    [:name].each do |field|
       it "should require a #{field}" do
         @topic.send("#{field}=".intern, nil)
         @topic.should_not be_valid
@@ -28,78 +31,33 @@ describe Topic do
       end
     end
     
-    it "should get a reader automatically" do
-      @topic.reader.should == @reader
-    end
-    
-    it "should get a first post automatically" do
-      @topic.first_post.should_not be_nil
-      @topic.first_post.body.should == 'this is the first post body but validation requires it'
-    end
-
-    it "should report itself visible" do
-      @topic.visible_to?(@reader).should be_true
-      @topic.visible_to?(nil).should be_true
-    end
-
-  end
-  
-  describe "with posts" do
-    dataset :posts
-
-    before do
-      @topic = topics(:older)
-      60.times do |i|
-        @topic.posts.create!(:body => "test #{i}", :created_at => (100-i).minutes.ago)
+    describe "when the whole forum is public" do
+      before do
+        Radiant::Config['forum.public?'] = true
       end
-      @topic.posts.create!(:body => "test by another", :reader => readers(:idle))
-      @topic.reload
-    end
 
-    it "should paginate posts" do
-      @topic.posts_count.should == 64
-      @topic.paged?.should be_true
-    end
-
-    it "should know on which page to find a given post" do
-      @topic.page_for(Post.find_by_body("test 15")).should == 1
-      @topic.page_for(Post.find_by_body("test 35")).should == 2
-      @topic.page_for(Post.find_by_body("test 55")).should == 3
-    end
-
-    it "should read config to find the number of posts per page" do
-      Radiant::Config['forum.posts_per_page'] = 15
-      @topic.page_for(Post.find_by_body("test 15")).should == 2
-      @topic.page_for(Post.find_by_body("test 35")).should == 3
-      @topic.page_for(Post.find_by_body("test 55")).should == 4
-    end
+      it "should be visible to a reader" do
+        @topic.visible_to?(@reader).should be_true
+      end
 
-    it "should know who last replied to it" do
-      @topic.replied_by.should == readers(:idle)
+      it "should be visible when there is no reader" do
+        @topic.visible_to?(nil).should be_true
+      end
     end
 
-    describe "when moved to another forum" do
+    describe "when the whole forum is private" do
       before do
-        @oldcount = @topic.forum.posts_count
-        newforum = forums(:private)
-        @newcount = newforum.posts_count
-        @topic.forum = newforum
-        @topic.save!
+        Radiant::Config['forum.public?'] = false
       end
 
-      it "should move its posts too" do
-        t = Topic.find(@topic.id)
-        t.posts.each do |p|
-          p.forum_id.should == forum_id(:private)
-        end
+      it "should be visible to a reader" do
+        @topic.visible_to?(readers(:idle)).should be_true
       end
 
-      it "should revise counter caches" do
-        ff = Forum.find(forum_id(:public))
-        tf = Forum.find(forum_id(:private))
-        ff.posts_count.should < @oldcount
-        tf.posts_count.should > @newcount
+      it "should not be visible when there is no reader" do
+        @topic.visible_to?(nil).should be_false
       end
     end
   end
+  
 end