radiant-banner_rotator-extension 1.0.0

data/spec/controllers/admin_banners_controller_spec.rb

@@ -0,0 +1,231 @@
+require File.dirname(__FILE__) + '/../spec_helper'
+require_dependency 'admin/banners_controller'
+class Admin::BannersController < Admin::ResourceController; def rescue_action(e); raise e; end end
+
+describe Admin::BannersController do
+  # Uses Admin::ResourceController, built into Radiant
+  dataset :users, :banners
+
+  before :each do
+    @banner = banners(:first)
+    @count = Banner.count
+    login_as(:admin)
+  end
+
+  it "should require login" do
+    logout
+    lambda { get :index }.should                require_login
+    lambda { get :show, :id => 1 }.should       require_login
+    lambda { get :new }.should                  require_login
+    lambda { post :create}.should               require_login
+    lambda { get :edit, :id => 1 }.should       require_login
+    lambda { put :update, :id => 1 }.should     require_login
+    lambda { get :remove, :id => 1 }.should     require_login
+    lambda { delete :destroy, :id => 1 }.should require_login
+    lambda { post :deactivate, :id => 1 }.should require_login
+  end
+  
+  it "'create' should add 1 banner and redirect to index" do
+    post :create, :banner => min_valid_banner_params
+    Banner.count.should == @count + 1
+    response.should be_redirect
+    response.should redirect_to(admin_banners_path)
+  end
+
+  it "'update' should redirect to index" do
+    put :update, :id => @banner.id
+    Banner.count.should == @count
+    response.should be_redirect
+    response.should redirect_to(admin_banners_path)
+  end
+  
+  it "'deactivate' should remove all banner placements and redirect to index" do
+    @banner.active?.should be_true
+    post :deactivate, :id => @banner.id
+    @banner.inactive?.should be_true
+    Banner.count.should == @count
+    response.should be_redirect
+    response.should redirect_to(admin_banners_path)
+    # flash notices are largely deprecated in as of 0.9
+    # flash[:notice].should include("Banner \"#{@banner.name}\" has been deactivated.") 
+  end
+  
+  it "'delete' should remove 1 banner and redirect to index" do
+    delete :destroy, :id => @banner.id
+    Banner.count.should == @count - 1
+    response.should be_redirect
+    response.should redirect_to(admin_banners_path)
+    # flash notices are largely deprecated in as of 0.9
+    # flash[:notice].should include("Banner has been deleted.")
+  end
+  
+  describe "protected banners" do
+
+    def protected_banner_behavior_on_deactivate
+      response.should be_redirect
+      response.should redirect_to(admin_banners_path)
+      flash[:error].should == @banner.cannot_be_deactivated_msg
+      @banner.active?.should be_true
+      @banner.protected?.should be_true
+    end
+    
+    def protected_banner_behavior_on_remove
+      response.should be_redirect
+      response.should redirect_to(admin_banners_path)
+      flash[:error].should == @banner.cannot_be_removed_msg
+      Banner.count.should == @count
+    end
+    
+    def protected_from_removal_tests
+      get :remove, :id => @banner.id
+      protected_banner_behavior_on_remove
+      delete :destroy, :id => @banner.id
+      protected_banner_behavior_on_remove
+    end
+    
+    def protected_from_deactivation_tests
+      get :deactivate, :id => @banner.id
+      protected_banner_behavior_on_deactivate
+      post :deactivate, :id => @banner.id
+      protected_banner_behavior_on_deactivate
+    end
+
+    it "should protect banners with 'protected' in the banner name from removal" do
+      @banner = banners(:protected)
+      protected_from_removal_tests
+    end
+    
+    it "should protect banners with 'protected' in the banner name from deactivation" do
+      @banner = banners(:protected)
+      protected_from_deactivation_tests
+    end
+
+    it "should protect banners named in Radiant::Config['admin.protected_banners'] from removal" do
+      @banner = banners(:child_2_1)
+      Radiant::Config['admin.protected_banners'] = @banner.name
+      protected_from_removal_tests
+    end
+    
+    it "should protect banners named in Radiant::Config['admin.protected_banners'] from deactivation" do
+      @banner = banners(:child_2_1)
+      Radiant::Config['admin.protected_banners'] = @banner.name
+      protected_from_deactivation_tests
+    end
+  
+  end
+
+  [:admin, :designer].each do |user|
+    describe "#{user} user" do
+      before :each do
+        @banner = Banner.find(:first)
+        login_as user
+      end
+
+      def redirects_to_index
+        response.should be_redirect
+        response.should redirect_to(admin_banners_url)
+      end
+
+      it 'should have access to the index action' do
+        get :index
+        response.should be_success
+      end
+      
+      it 'should have access to the show action' do
+        get :show, :id => @banner.id
+        response.should be_redirect
+        response.should redirect_to(edit_admin_banner_url(@banner))
+      end
+      
+      it 'should have access to the new action' do
+        get :new
+        response.should be_success
+      end
+      
+      it 'should have access to the create action' do
+        post :create, :banner => min_valid_banner_params
+        redirects_to_index
+      end
+      
+      it 'should have access to the edit action' do
+        get :edit, :id => 1
+        response.should be_success
+      end
+      
+      it 'should have access to the update action' do
+        put :update, :id => 1
+        redirects_to_index
+      end
+      
+      it "should have access to the remove action" do
+        get :remove, :id => 1
+        response.should be_success
+      end
+      
+      it 'should have access to the destroy action' do
+        delete :destroy, :id => 1
+        redirects_to_index
+      end
+      
+      it 'should have access to the deactivate action' do
+        post :deactivate, :id => 1
+        redirects_to_index
+      end
+    end
+  end
+  
+  [:existing, :non_admin].each do |user|
+    describe "#{user} user" do
+      before :each do
+        login_as user
+      end
+  
+      def redirects_to_pages
+        response.should be_redirect
+        response.should redirect_to(admin_pages_path)
+        flash[:error].should == 'You must have designer privileges to perform this action.'
+      end
+  
+      it 'should not have access to the index action' do
+        get :index
+      end
+      
+      it 'should not have access to the show action' do
+        get :show, :id => 1
+      end
+      
+      it 'should not have access to the new action' do
+        get :new
+      end
+      
+      it 'should not have access to the create action' do
+        post :create
+      end
+      
+      it 'should not have access to the edit action' do
+        get :edit, :id => 1
+      end
+      
+      it 'should not have access to the update action' do
+        put :update, :id => 1
+      end
+  
+      it 'should not have access to the remove action' do
+        put :remove, :id => 1
+      end
+      
+      it 'should not have access to the destroy action' do
+        delete :destroy, :id => 1
+      end
+      
+      it 'should not have access to the deactivate action' do
+        post :deactivate, :id => 1
+      end
+      
+      after :each do
+        redirects_to_pages
+      end
+    end
+  end
+
+end

data/spec/datasets/banners_dataset.rb

@@ -0,0 +1,26 @@
+class BannersDataset < Dataset::Base
+  uses :pages
+
+  def load
+    create_model Banner, :first, :id => 1, :name => "First", :background_image => "test.jpg", :foreground_image => 'front.jpg', :link_target => "_blank", :link_url => "/en/", :image_style => "text-align:right"
+    create_model Banner, :protected, :id => 2, :name => "First_protected", :background_image => "test.jpg", :foreground_image => 'front.jpg', :link_target => "_blank", :link_url => "/en/protected/", :image_style => "text-align:right"
+    create_model BannerPlacement, :first, :page_id => page_id(:home), :banner_id => banner_id(:first), :weight => 5
+    create_model BannerPlacement, :protected, :page_id => page_id(:home), :banner_id => banner_id(:protected), :weight => 5
+    Page.update_all({:show_banner => !  Page.columns_hash['show_banner'].default }, {:id => page_id(:radius)})
+    create_model Banner, :child_2_1, :name => "Child-2 first", :background_image => "test.jpg"
+    create_model BannerPlacement, :child_2_1, :page_id => page_id(:child_2), :banner_id => banner_id(:child_2_1), :weight => 1
+    create_model Banner, :child_2_2, :name => "Child-2 second", :background_image => "test.jpg"
+    create_model BannerPlacement, :child_2_2, :page_id => page_id(:child_2), :banner_id => banner_id(:child_2_2), :weight => 1  
+    create_model Banner, :blank, min_valid_banner_params
+    create_model BannerPlacement, :blank, :page_id => page_id(:another), :banner_id => banner_id(:blank), :weight => 1   
+  end
+  
+  helpers do
+    def min_valid_banner_params
+      { :name => 'New Banner',
+        :background_image => 'pic.png'
+      }  
+    end
+  end
+  
+end

data/spec/helpers/admin/banners_helper_spec.rb

@@ -0,0 +1,9 @@
+require File.dirname(__FILE__) + '/../../spec_helper'
+
+describe Admin::BannersHelper do
+  dataset :home_page
+  
+  it "should create options for the placements select box from existing pages" do
+    helper.pages_for_select.should == [["Home", page_id(:home)]]
+  end
+end

data/spec/models/banner_placement_spec.rb

@@ -0,0 +1,44 @@
+require File.dirname(__FILE__) + '/../spec_helper'
+
+describe BannerPlacement do
+
+  dataset :banners
+  
+  before(:each) do
+    @placement  = banner_placements(:first)
+  end
+
+  it "should require a page" do
+    @placement.page_id = nil
+    @placement.should_not be_valid
+    @placement.should have(1).error_on(:page_id)
+  end
+  
+  it "should require a banner" do
+    @placement.banner_id = nil
+    @placement.should_not be_valid
+    @placement.should have(1).error_on(:banner_id)
+  end
+  
+  it "should require a weight" do
+    @placement.weight = nil
+    @placement.should_not be_valid
+    @placement.should have(1).error_on(:weight)
+  end
+  
+  it "should require weight to be a number" do
+    @placement.weight = 'foo'
+    @placement.should_not be_valid
+    @placement.should have(1).error_on(:weight)
+  end
+  
+  it "should be unique to a given page and banner" do
+    @placement.page_id = page_id(:home)
+    @placement.banner_id = banner_id(:protected)
+    @placement.should_not be_valid
+  end
+  
+  it "should be valid with required parameters" do
+    @placement.should be_valid
+  end
+end

data/spec/models/banner_spec.rb

@@ -0,0 +1,47 @@
+require File.dirname(__FILE__) + '/../spec_helper'
+
+describe Banner do
+
+  dataset :banners
+
+  before(:each) do
+    @banner = banners(:first)
+  end
+
+  it "should require a name" do
+    @banner.name = nil
+    @banner.should_not be_valid
+    @banner.should have(1).error_on(:name)
+  end
+
+  it "should require a background image" do
+    @banner.background_image = nil
+    @banner.should_not be_valid
+    @banner.should have(1).error_on(:background_image)
+  end
+
+  it "should be valid with required parameters" do
+    @banner.should be_valid
+  end
+  
+  describe "with page placements" do
+    before(:each) do
+      @banner.placements = [{'page_id' => '1', 'weight' => '10'}, {'page_id' => '2', 'weight' => '5'}]
+      @banner.save.should be_true
+    end
+    it "should save associated page placements" do
+      @banner.active?.should be_true
+      @banner.inactive?.should be_false
+      @banner.should have(2).banner_placements
+      @banner.placements.should be_all{|p| p.valid? }
+    end
+    it "should remove all page placements" do
+      @banner.remove_all_placements!
+      @banner.save.should be_true
+      @banner.active?.should be_false
+      @banner.inactive?.should be_true
+      @banner.should have(0).banner_placements
+    end
+  end
+
+end

data/spec/models/page_extensions_spec.rb

@@ -0,0 +1,25 @@
+require File.dirname(__FILE__) + '/../spec_helper'
+
+describe "BannerRotator::PageExtensions" do
+  dataset :pages, :banners
+  
+  it "should have some banner and banner placements" do
+    pages(:home).should respond_to(:banners)
+    pages(:home).should respond_to(:banner_placements)
+    pages(:home).should have(2).banners
+  end
+  
+  it "should select a banner" do
+    [ banners(:first), banners(:protected) ].should include(pages(:home).select_banner)
+  end
+  
+  it "should inherit banners from its ancestors" do
+    pages(:article).banner_placements.should == pages(:home).banner_placements
+    [ banners(:first), banners(:protected) ].should include(pages(:article).select_banner)
+  end
+  
+  it "should not delete its parent's banner placements when destroyed" do
+    pages(:home).should == pages(:radius).parent
+    lambda { pages(:radius).destroy }.should_not change(BannerPlacement, :count)
+  end
+end

data/spec/models/tags_spec.rb

@@ -0,0 +1,69 @@
+require File.dirname(__FILE__) + '/../spec_helper'
+
+describe "BannerRotator::Tags" do
+  dataset :pages, :banners
+  
+  describe "<r:banner> defaults and updating show_banner attribute" do
+    if Page.columns_hash['show_banner'].default == true
+      it "should show a banner if show_banner is true (default)" do
+        pages(:home).should render('<r:banner>true</r:banner>').as('true')
+      end
+    
+      it "should not show a banner if show_banner is false" do
+        pages(:radius).should render('<r:banner>true</r:banner>').as('')
+      end
+    else
+      it "should not show a banner if show_banner is false (default)" do
+        pages(:home).should render('<r:banner>true</r:banner>').as('')
+      end
+    
+      it "should show a banner if show_banner is true" do
+        pages(:radius).should render('<r:banner>true</r:banner>').as('true')
+      end
+    end
+  end
+
+  describe "<r:banner> selection and inheritance" do
+    before :each do
+      Page.update_all({:show_banner => true })
+      banners(:protected).remove_all_placements!  #deal with only 1 active banner for predictable results
+    end
+
+    it "should select a random banner from the associated banners" do
+      pages(:child_2).should render('<r:banner:name />').matching(/^Child\-2 (first|second)$/)
+    end
+
+    it "should inherit a banner placement from an ancestor" do
+      pages(:child).should render('<r:banner:name />').as('First')
+    end
+  end
+  
+  describe "banner attributes, if_ and unless_ tags" do
+    before :each do
+      Page.update_all({:show_banner => true })
+      banners(:protected).remove_all_placements!  #deal with only 1 active banner for predictable results
+    end
+    %w{name background_image foreground_image link_url link_target image_style}.each do |att|
+      describe "<r:banner:#{att}>" do
+        it "should render the '#{att}' attribute of the selected banner" do
+          pages(:home).should render("<r:banner:#{att} />").as(pages(:home).banners[0][att])
+        end
+      end
+      describe "<r:banner:if_#{att}>" do
+        it "should expand the tag contents if the '#{att}' attribute of the selected banner is not blank" do
+          pages(:home).should render("<r:banner:if_#{att}>Content</r:banner:if_#{att}>").as("Content")
+        end
+      end
+      describe "<r:banner:unless_#{att}>" do
+        it "should expand the tag contents if the '#{att}' attribute of the selected banner is blank" do
+          if pages(:another).banners[0][att].blank?
+            pages(:another).should render("<r:banner:unless_#{att}>Content</r:banner:unless_#{att}>").as("Content")
+          else
+            pages(:another).should render("<r:banner:unless_#{att}>Content</r:banner:unless_#{att}>").as("")
+          end
+        end
+      end      
+    end
+  end
+
+end