radar-app 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3fb6b20d6df8f4cc3b56d91408d22aae3e84128b
-  data.tar.gz: 33a551fca948d6c5892308c9aa314a06baa632e2
+  metadata.gz: 87275c99ccf595f790ed41ea17368244a0ecf547
+  data.tar.gz: d8e60964e55ec23b1781890268d3c4144d793613
 SHA512:
-  metadata.gz: f2845a1c8fb8eaf8741ecdcbff2c7e2dbc83f648697d4091f0940ec2acca0f3240698fe8490176b3061a8bba6bf591219166fc2cddab3239c257e11e48ba0f93
-  data.tar.gz: f1313c072a94e6b88328503cfbd6729026801de924c0bced71e9f6015d09c195885b090e7f075266378dec9a9926621004a2de231c6e8e58bffbc282d9c1a660
+  metadata.gz: 4a966936887953e9172fb1de38a3d093060eebf0556846142287e23f73ee519898314b71606f26828f3f72c594e7bb708b868a9956dcfa711e61f18267363b17
+  data.tar.gz: 03f11106ab18446b278d671bfea31322cb0747094e9fdc3c30d50694c8263938fbf26ced0a5515671efcaad9ecce00b0fbaa67ffb40ea9bad30208f38a1dc60f

data/lib/radar/app.rb

@@ -7,6 +7,7 @@ require 'radar/app/analyzer_controller'
 require 'radar/app/server'
 require 'radar/app/bootstrap'
 require 'radar/app/analyzer'
+require 'radar/app/processor_factory'
 
 require 'radar-api'
 require 'connection_pool'

data/lib/radar/app/processor_factory.rb

@@ -0,0 +1,16 @@
+require 'thrift/exceptions'
+
+module Radar
+  module App
+    module ProcessorFactory
+      def self.create_processor(superclass)
+        Class.new(superclass) do
+          def write_error(err, oprot, name, seqid)
+            super
+            raise if err.type == Thrift::ApplicationException::INTERNAL_ERROR
+          end
+        end
+      end
+    end
+  end
+end

data/lib/radar/app/server.rb

@@ -8,7 +8,7 @@ module Radar
       
       def start
         handler = Radar::App::AnalyzerController.new
-        processor = Radar::API::AnalyzerController::Processor.new(handler)
+        processor = ProcessorFactory.create_processor(Radar::API::AnalyzerController::Processor.new(handler))
         transport = Thrift::ServerSocket.new(port)
         server = Thrift::NonblockingServer.new(processor, transport, Thrift::FramedTransportFactory.new)
         logger.info { "Starting app on port #{port}..." }

data/lib/radar/app/version.rb

@@ -1,5 +1,5 @@
 module Radar
   module App
-    VERSION = "0.1.2"
+    VERSION = "0.1.3"
   end
 end

data/spec/lib/radar/app/processor_factory_spec.rb

@@ -0,0 +1,51 @@
+require 'radar/app/processor_factory'
+
+describe Radar::App::ProcessorFactory do
+
+  let(:parent_processor_class) do
+    Class.new do
+      attr_reader :write_error_called
+
+      def process_an_error
+        begin
+          raise 'an error'
+        rescue => e
+          x = Thrift::ApplicationException.new(Thrift::ApplicationException::INTERNAL_ERROR, 'Internal error')
+          write_error(x, nil, nil, nil)
+        end
+      end
+
+      def process_unknown_method
+        x = Thrift::ApplicationException.new(Thrift::ApplicationException::UNKNOWN_METHOD, 'Unknown function')
+        write_error(x, nil, nil, nil)
+      end
+
+      def write_error(err, oprot, name, seqid)
+        @write_error_called = true
+      end
+
+    end
+  end
+
+  describe '#create_processor' do
+    describe 'it creates a processor that' do
+      let(:processor) { Radar::App::ProcessorFactory.create_processor(parent_processor_class).new }
+      it 'raises the exception on error' do
+        expect { processor.process_an_error }.to raise_error 'an error'
+      end
+      it 'calls #write_error from super' do
+        begin
+          processor.process_an_error
+        rescue => e
+          # not testing exception
+        end
+        expect(processor.write_error_called).to eq true
+      end
+      context 'when err is not INTERNAL_ERROR' do
+        it 'does not raise any exception' do
+          expect { processor.process_unknown_method }.not_to raise_error
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: radar-app
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Leonardo Mendonca
@@ -176,6 +176,7 @@ files:
 - lib/radar/app/core_ext.rb
 - lib/radar/app/core_ext/date.rb
 - lib/radar/app/logger.rb
+- lib/radar/app/processor_factory.rb
 - lib/radar/app/runner.rb
 - lib/radar/app/server.rb
 - lib/radar/app/session.rb
@@ -190,6 +191,7 @@ files:
 - spec/gen-rb/example_constants.rb
 - spec/gen-rb/example_types.rb
 - spec/lib/radar/app/analyzer_spec.rb
+- spec/lib/radar/app/processor_factory_spec.rb
 - spec/lib/radar/app/tasks/generate_spec.rb
 - spec/lib/thrift/builder_spec.rb
 - templates/.webhook
@@ -218,7 +220,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.5
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: radar-app generator
@@ -227,5 +229,6 @@ test_files:
 - spec/gen-rb/example_constants.rb
 - spec/gen-rb/example_types.rb
 - spec/lib/radar/app/analyzer_spec.rb
+- spec/lib/radar/app/processor_factory_spec.rb
 - spec/lib/radar/app/tasks/generate_spec.rb
 - spec/lib/thrift/builder_spec.rb