rad_core 0.0.13

data/spec/controller/controller_helper_spec/views/HelperMethodSpec/action.erb

@@ -0,0 +1 @@
+<%= some_controller_method %>

data/spec/controller/controller_helper_spec/views/HelperSpec/action.erb

@@ -0,0 +1 @@
+<%= wiget %>

data/spec/controller/controller_helper_spec.rb

@@ -0,0 +1,53 @@
+require "controller/spec_helper"
+
+describe "AbstractController" do
+  with_environment
+  with_abstract_controller_spec
+  with_view_path "#{spec_dir}/views"
+  
+  before :all do
+    AbstractController = Rad::AbstractController  
+  end
+  
+  after :all do
+    remove_constants %w(
+      SomeHelperSpec
+      HelperSpec
+      HelperMethodSpec
+      AbstractController
+    )
+  end
+  
+  it "helper_method" do
+    class ::HelperMethodSpec
+      inherit AbstractController
+      
+      def some_controller_method
+        "some controller value (rendered in cotext of #{self.class})"
+      end
+      helper_method :some_controller_method
+      
+      def action; end
+    end
+        
+    ccall(HelperMethodSpec, :action).should == "some controller value (rendered in cotext of HelperMethodSpec)"
+  end
+  
+  it "helper" do
+    module ::SomeHelperSpec
+      def wiget
+        "some wighet (rendered in context of #{self.class.name})"
+      end
+    end
+    
+    class ::HelperSpec
+      inherit AbstractController
+      
+      helper SomeHelperSpec
+      
+      def action; end
+    end
+    
+    ccall(HelperSpec, :action).should == "some wighet (rendered in context of HelperSpec::HelperSpecControllerContext)"
+  end  
+end

data/spec/controller/controller_render_spec/views/AlreadyRenderedSpec/action.erb

@@ -0,0 +1 @@
+content

data/spec/controller/controller_render_spec/views/AlreadyRenderedSpec/custom_template.erb

@@ -0,0 +1 @@
+custom content

data/spec/controller/controller_render_spec/views/AnotherActionSpec/another_action.erb

@@ -0,0 +1 @@
+another action (action_name: <%= action_name %>)

data/spec/controller/controller_render_spec/views/AnotherLayout/action.erb

@@ -0,0 +1 @@
+action

data/spec/controller/controller_render_spec/views/ForbidPartialAsActionSpec/_action.erb

@@ -0,0 +1 @@
+partial content

data/spec/controller/controller_render_spec/views/FormatSpec/action.html.erb

@@ -0,0 +1 @@
+html format

data/spec/controller/controller_render_spec/views/FormatSpec/action.js.erb

@@ -0,0 +1 @@
+js format

data/spec/controller/controller_render_spec/views/LayoutFiltersSpec/action_with_layout.erb

@@ -0,0 +1 @@
+content

data/spec/controller/controller_render_spec/views/LayoutFiltersSpec/action_without_layout.erb

@@ -0,0 +1 @@
+content

data/spec/controller/controller_render_spec/views/LayoutSpec/action.erb

@@ -0,0 +1 @@
+content

data/spec/controller/controller_render_spec/views/MultipleActions/actions.haml

@@ -0,0 +1,7 @@
+- case action_name
+- when :increase
+	plus
+- when :decrease
+	minus
+- else
+	- must_be.never_called

data/spec/controller/controller_render_spec/views/layouts/admin.erb

@@ -0,0 +1 @@
+Admin layout, <%= yield %>

data/spec/controller/controller_render_spec/views/layouts/app.html.erb

@@ -0,0 +1 @@
+Layout html, <%= yield %>

data/spec/controller/controller_render_spec/views/layouts/app.js.erb

@@ -0,0 +1 @@
+Layout js, <%= yield %>

data/spec/controller/controller_render_spec/views/rem ExplicitRenderSpec/action.erb

@@ -0,0 +1 @@
+action

data/spec/controller/controller_render_spec/views/rem ExplicitRenderSpec/another_action.erb

@@ -0,0 +1 @@
+another action

data/spec/controller/controller_render_spec/views/some_template.erb

@@ -0,0 +1 @@
+some template

data/spec/controller/controller_render_spec/views/standalone.html.erb

@@ -0,0 +1 @@
+standalone usage, <%= a %>

data/spec/controller/controller_render_spec.rb

@@ -0,0 +1,217 @@
+require "controller/spec_helper"
+
+describe "Controller render" do
+  with_environment
+  with_abstract_controller_spec
+  with_view_path "#{spec_dir}/views"
+  
+  before :all do
+    AbstractController = Rad::AbstractController
+  end
+  
+  after :all do
+    remove_constants %w(
+      LayoutFiltersSpec
+      LayoutSpec
+      AnotherLayout
+      ExplicitRenderSpec
+      RenderInsideOfControllerSpec
+      ForbidPartialAsActionSpec
+      FormatSpec
+      AlreadyRenderedSpec
+      SpecialFormatSpec
+      AnotherActionSpec
+      InlineRenderSpec
+      AbstractController
+      InlineWithLayoutSpec
+      MultipleActions
+    )
+  end
+    
+  describe 'layout' do  
+    it "should use :except and :only in layout" do
+      class ::LayoutFiltersSpec
+        inherit AbstractController
+        layout '/layouts/app', only: :action_with_layout
+        
+        def action_with_layout; end
+        def action_without_layout; end
+      end
+      
+      ccall(LayoutFiltersSpec, :action_with_layout, format: 'html').should == "Layout html, content"  
+      ccall(LayoutFiltersSpec, :action_without_layout).should == "content"
+    end
+    
+    it "should apply formats to layout" do
+      class LayoutSpec
+        inherit AbstractController
+        layout '/layouts/app'
+      
+        def action; end      
+      end
+    
+      ccall(LayoutSpec, :action, format: 'html').should == "Layout html, content"  
+      ccall(LayoutSpec, :action, format: 'js').should == "Layout js, content"
+    end  
+      
+    it "should take layout: false or layout: '/another_layout'" do
+      class AnotherLayout
+        inherit AbstractController
+        layout '/layout/app'
+        
+        def action; end
+        
+        def without_layout
+          render action: :action, layout: false
+        end
+        
+        def another_layout
+          render action: :action, layout: '/layouts/admin'
+        end        
+      end
+      
+      ccall(AnotherLayout, :without_layout).should == "action"
+      ccall(AnotherLayout, :another_layout).should == "Admin layout, action"
+    end
+      
+    
+    it "should take into account :layout when rendering template" do
+      class ::ExplicitRenderSpec
+        inherit AbstractController
+        layout '/layouts/app'
+        
+        def with_layout
+          render '/some_template'
+        end
+        
+        def without_layout
+          render '/some_template', layout: false
+        end
+      end
+      
+      ccall(ExplicitRenderSpec, :with_layout, format: 'html').should == "Layout html, some template"
+      ccall(ExplicitRenderSpec, :without_layout, format: 'html').should == "some template"
+    end    
+  end
+  
+  it "should render template inside of controller" do
+    class ::RenderInsideOfControllerSpec
+      inherit AbstractController
+
+      def some_action
+        render '/some_template'
+      end    
+    end
+
+    ccall(RenderInsideOfControllerSpec, 'some_action').should == "some template"
+  end
+  
+  it "should not allow to render partials as actions" do
+    class ::ForbidPartialAsActionSpec
+      inherit AbstractController
+      def action; end
+    end
+
+    lambda{ccall ForbidPartialAsActionSpec, :action}.should raise_error(/No template/)
+  end
+  
+  it "should render view with right format" do
+    class FormatSpec
+      inherit AbstractController
+      def action; end
+    end
+
+    ccall(FormatSpec, :action, format: 'html').should == "html format"    
+    ccall(FormatSpec, :action, format: 'js').should == "js format"
+  end
+  
+  it "should be able to use Template.render for different purposes (mail for example)" do
+    Rad::Template.render("/standalone", locals: {a: 'a'}).should == 'standalone usage, a'
+  end
+  
+  it "should not rener if already rendered in controller" do
+    class ::AlreadyRenderedSpec
+      inherit AbstractController
+
+      def action
+        render '/AlreadyRenderedSpec/custom_template'
+      end
+    end
+
+    ccall(AlreadyRenderedSpec, :action).should == 'custom content'
+  end
+  
+  it "should handle serialization obj ('xml', 'json')" do
+    class ::SpecialFormatSpec
+      inherit AbstractController
+      
+      def json_action
+        render json: {a: "b"}
+      end
+      
+      def xml_action
+        render xml: {a: "b"}
+      end
+    end
+    
+    ccall(SpecialFormatSpec, :json_action, format: 'json').should == %({"a":"b"})      
+    ccall(SpecialFormatSpec, :xml_action, format: 'xml').should =~ /<a>b<\/a>/      
+    -> {
+      ccall(SpecialFormatSpec, :json_action, format: 'xml')
+    }.should raise_error(/responing with 'json' to the 'xml'/)
+  end
+  
+  it "should render another action via action: :action_name" do
+    class ::AnotherActionSpec
+      inherit AbstractController
+  
+      def another_action; end
+      
+      def action          
+        render action: :another_action
+      end
+    end
+    
+    ccall(AnotherActionSpec, :action).should == "another action (action_name: another_action)"
+  end
+    
+  it "should take :inline option" do
+    class ::InlineRenderSpec
+      inherit AbstractController
+      
+      def action
+        render inline: "content"
+      end
+    end
+    
+    ccall(InlineRenderSpec, :action).should == "content"
+  end
+  
+  it ":inline option should render without layout" do
+    class ::InlineWithLayoutSpec
+      inherit AbstractController
+      
+      layout '/layouts/app'
+      
+      def action
+        render inline: "content"
+      end
+    end
+    
+    ccall(InlineWithLayoutSpec, :action).should == "content"
+  end
+  
+  it "should render correct action inside of special 'actions.xxx' template file" do
+    class ::MultipleActions
+      inherit AbstractController
+      
+      def increase; end
+      def decrease; end
+      def action_without_template; end
+    end
+    
+    ccall(MultipleActions, :increase).should == "plus\n"
+    ccall(MultipleActions, :decrease).should == "minus\n"
+    ccall(MultipleActions, :action_without_template).should == ""
+  end
+end

data/spec/controller/error_handling_spec/views/diferrent_error_handling_spec/a.erb

@@ -0,0 +1 @@
+a

data/spec/controller/error_handling_spec/views/diferrent_error_handling_spec/b.erb

@@ -0,0 +1 @@
+b

data/spec/controller/error_handling_spec/views/diferrent_error_handling_spec/c.erb

@@ -0,0 +1 @@
+<% raise 'error in template' %>

data/spec/controller/error_handling_spec.rb

@@ -0,0 +1,117 @@
+require "controller/spec_helper"
+
+describe "Error handling" do
+  with_environment
+  with_view_path "#{spec_dir}/views"
+  
+  before :all do    
+    AbstractController = Rad::AbstractController    
+    
+    rad.before :environment do
+      rad.config.test_error_template = rad.config.development_error_template!
+    end
+  
+    rad.after :environment do
+      rad.conveyors.web do |web|
+        web.use Rad::Processors::ControllerErrorHandling
+        web.use Rad::Processors::ControllerCaller
+      end 
+    end
+  end
+  
+  after :all do
+    remove_constants %w(
+      DisplayErrorWithFormat
+      DiferrentErrorHandlingSpec
+      AbstractController
+      ErrorInRedirectSpec
+    )
+  end
+  
+  it "should correctly display error messages in :development (with correct format)" do
+    class ::DisplayErrorWithFormat
+      inherit AbstractController
+      
+      def method
+        raise params.error 
+      end
+    end
+    
+    config.environment = :development
+    silence_logger!
+    
+    error = StandardError.new('some error')
+    
+    ccall(
+      DisplayErrorWithFormat, :method, 
+      {error: error, format: 'html'}
+    ).should =~ /html.+some error/m
+    
+    ccall(
+      DisplayErrorWithFormat, :method,
+      {error: error, format: 'js'}
+    ).should =~ /some error/
+    
+    ccall(
+      DisplayErrorWithFormat, :method,
+      {error: error, format: :non_existing_mime}
+    ).should =~ /some error/
+  end
+  
+  it "should catch errors with redirect (from error)" do
+    # if response.headers['Location'] has been set before redirect, it'll do redirect 
+    # after error will be catched and no error message will be displayed
+    
+    class ::ErrorInRedirectSpec
+      inherit AbstractController
+
+      def a
+        response.headers['Location'] = '/'
+        raise 'some error'
+      end        
+    end
+    
+    config.environment = :development
+    silence_logger!
+    
+    ccall(ErrorInRedirectSpec, :a, format: 'html')
+    response.headers['Location'].should be_nil
+  end
+    
+  describe "should be different in :test, :development and :production" do
+    before :all do
+      class ::DiferrentErrorHandlingSpec
+        inherit AbstractController
+  
+        def a; end  
+        def b
+          raise 'some error'
+        end  
+        def c; end
+      end
+    end
+    
+    it "in :production errors shouldn't be shown to user"
+    
+    it "in development errors should be catched" do
+      config.environment = :development
+      silence_logger!
+      
+      # with view
+      ccall(DiferrentErrorHandlingSpec, :a).should == 'a'
+      %w(html js).each do |format|  
+        ccall(DiferrentErrorHandlingSpec, :b, format: format).should =~ /some error/     
+        ccall(DiferrentErrorHandlingSpec, :c, format: format).should =~ /error in template/
+      end
+    end
+  
+    it "should not catch errors in :test environment" do
+      config.environment = :test
+    
+      # with render
+      ccall(DiferrentErrorHandlingSpec, :a).should == 'a'    
+      lambda{ccall(DiferrentErrorHandlingSpec, :b)}.should raise_error(/some error/)
+      lambda{ccall(DiferrentErrorHandlingSpec, :c)}.should raise_error(/error in template/)
+    end
+  end
+end

data/spec/controller/http_controller_spec.rb

@@ -0,0 +1,130 @@
+require "controller/spec_helper"
+
+describe "HttpController" do
+  with_environment
+  with_http
+  
+  before :all do
+    HttpController = Rad::HttpController
+    
+    rad.after :environment do
+      rad.conveyors.web do |web|
+        web.use Rad::Processors::HttpWriter
+        web.use Rad::Processors::ControllerCaller
+      end
+    end
+  end
+  
+  after :all do
+    remove_constants %w(
+      HttpController
+      ContentTypeSpec
+      StatusSpec
+      StatusShortcutsSpec
+      LocationSpec
+      RequestMethod
+      ForbidGetSpec
+    )
+  end
+    
+  describe 'render' do
+    it "should take :content_type option" do
+      class ::ContentTypeSpec
+        inherit HttpController
+        
+        def action
+          render inline: "some content", content_type: Mime.js
+        end
+      end
+      
+      wcall(ContentTypeSpec, :action)
+      response.content_type.should == "application/javascript"
+    end
+    
+    it "should take :status option" do
+      class ::StatusSpec
+        inherit HttpController
+        
+        def action
+          render inline: "some content", status: 220
+        end
+      end
+      
+      wcall(StatusSpec, :action)
+      response.status.should == 220
+    end
+    
+    it "should take shortcuts to status codes" do
+      class ::StatusShortcutsSpec
+        inherit HttpController
+        
+        def ok
+          render :ok
+        end
+        
+        def failed
+          render :failed
+        end
+      end
+      
+      wcall(StatusShortcutsSpec, :ok)
+      response.status.should == 200
+      
+      wcall(StatusShortcutsSpec, :failed)
+      response.status.should == 500
+    end
+
+    it "should take :location option" do
+      class ::LocationSpec
+        inherit HttpController
+        
+        def action
+          render location: "/"
+        end                
+      end
+      
+      # mock
+      class ::LocationSpec
+        def redirect_to location
+          self.class.location = location
+        end
+        
+        class << self
+          attr_accessor :location
+        end        
+      end
+      
+      wcall(LocationSpec, :action, format: 'html')
+      LocationSpec.location.should == '/'
+    end
+  end    
+  
+  it "should specify request method" do
+    class ::RequestMethod
+      inherit HttpController
+      def action
+        workspace.request.post?.should == true
+      end
+    end
+    
+    workspace, params = {env: {'REQUEST_METHOD' => 'POST'}}, {}    
+    wcall(RequestMethod, :action, workspace, params)
+  end
+  
+  it "should protect methods from GET request" do
+    class ::ForbidGetSpec
+      inherit HttpController
+      allow_get_for :get_action
+      
+      def get_action; end
+      def post_action; end
+    end
+    
+    workspace = {env: {'REQUEST_METHOD' => 'GET'}}
+    
+    wcall(ForbidGetSpec, :get_action, workspace, {})
+    lambda{
+      wcall(ForbidGetSpec, :post_action, workspace, {})
+    }.should raise_error(/not allowed/)
+  end
+end

data/spec/controller/spec_helper.rb

@@ -0,0 +1,19 @@
+require 'rspec_ext'
+
+require 'rad/controller'
+require 'rad/controller/http_controller'
+require 'rad/http'
+
+require 'rad/spec'
+
+rspec do
+  def self.with_abstract_controller_spec
+    before :all do
+      rad.after :environment do
+        rad.conveyors.web do |web|
+          web.use Rad::Processors::ControllerCaller
+        end
+      end
+    end
+  end
+end