ractor-rails-shim 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 515076a823c0767ce28d1bf35545a6ced10f2ef1f628f8e263cde654b58fb899
-  data.tar.gz: df743b8da60645f80569b646301d7d0fd5c197756ffb928921144f7fac161c5e
+  metadata.gz: 49ca69607b89c8817a961657ddccd6a3c1a3e87084ef0ec34090b91bce396b22
+  data.tar.gz: cc35444b2078ea06545412a8c6e0d44dd03d2e07c3c2fd99f7a9e930a6fb897e
 SHA512:
-  metadata.gz: c4c6fc83fc7fc61a0fecf603e26e2031d2876f20222c29717cc267fc99acfd7ed4e3e05cd98995099a62807bc37e37f34635c676c334caf2c99cc8d4acc50c0d
-  data.tar.gz: 53bb7cf546753b3bc7c6dc7313dc9b0bbf86b616f1e8f7fc1f0f45d0428988efeee0308bf93c7cf127e9219ebcd747f76340a86b750853a5fad81eaae5da4a0e
+  metadata.gz: 88badfc12887a028b39500559256df576e7317e2dbb9f9e4ee170f116279724a07aef6d3ab4a2bae848c12e04bbc56eb6ffc5c487a54f400aa60ff8b8ef3b0fe
+  data.tar.gz: 95751eb76405f35d3fa1b2f53c89f2d459af19e7503156597d282f23a3c7da2ac71d6836dc54d80c7991b1e623d66c30fd72e67001530d4636fc7846177ed89d

data/CHANGELOG.md

@@ -11,6 +11,20 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Improved the published gem summary and description (gemspec). Metadata-only
   release — no code changes.
 
+## [0.2.2]
+
+### Fixed
+- **Multi-threaded worker race in `WorkerApp#setup_once!` (kino `:ractor`,
+  `-wN -tM` with M > 1).** All threads inside a worker Ractor share
+  `Ractor.current`, so the previous `Ractor.current[:rrs_worker_ready]` guard
+  let multiple threads race through `rebind_constants` +
+  `init_worker_ar_connections!`, producing
+  `ActiveRecord::ConnectionNotEstablished` on the very first request. Setup is
+  now serialized with a per-Ractor `Thread::Mutex`, and `rebind_constants`
+  re-fetches each namespace parent so concurrent setup cannot clobber a module
+  out from under another thread. `kino :ractor (-w5 -t5)` now serves all
+  endpoints with 0 failures.
+
 ### Added — ActiveRecord query-path ractor-safety (Blocker 1 deep work)
 - `RactorRailsShim.worker_ar_init(app)` — a shareable Rack middleware that
   calls `init_worker_ar_connections!` on each worker's first request. Kino's
@@ -47,7 +61,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   `TYPE_MAP` (Procs) and `QUOTED_*` `Concurrent::Map` quoting caches.
   These are intrinsically unshareable and require upstream Rails changes
   (shareable callables instead of Procs; per-Ractor quoting caches). See
-  `NEXT_STEPS.md` "The wall — deep AR ractor-unsafety".
+  the "deep AR ractor-unsafety" wall in the project notes.
 
 ## [0.2.0] - 2026-07-09
 

data/lib/ractor_rails_shim/patches/activerecord.rb

@@ -2,7 +2,7 @@
 
 # Patch ActiveRecord's connection handler to work in per-Ractor mode.
 #
-# Blocker 1 (from NEXT_STEPS.md):
+# Blocker 1:
 #   ActiveRecord::Base.connection_pool calls
 #   default_connection_handler.retrieve_connection_pool(...)
 #   at connection_handling.rb:346. The default_connection_handler
@@ -229,7 +229,14 @@ module RactorRailsShim
       return unless defined?(::ActiveRecord::Base)
 
       key = :active_record_connection_handler
-      existing = ActiveSupport::IsolatedExecutionState[key]
+      # Store the handler in Ractor-local storage (Ractor.current), NOT in
+      # ActiveSupport::IsolatedExecutionState. IES is per-THREAD (it is a
+      # Thread.attr_accessor), so a value set on the init thread is invisible
+      # to the other worker threads in the same worker Ractor ->
+      # ConnectionNotEstablished ("No connection handler for Ractor X").
+      # Ractor.current storage is per-Ractor and shared by every thread of the
+      # worker, so connection_handler resolves the same handler for all threads.
+      existing = Ractor.current[key]
       return if existing
 
       # Establish a fresh, per-Ractor connection handler + pool from the
@@ -256,7 +263,7 @@ module RactorRailsShim
           end
         end
 
-        ActiveSupport::IsolatedExecutionState[key] = handler
+        Ractor.current[key] = handler
       end
     end
 
@@ -320,6 +327,35 @@ module RactorRailsShim
       _share_relation_delegate_caches! if Ractor.main?
     end
 
+    # ActiveModel::AttributeMethods::ClassMethods#attribute_method_patterns_cache
+    # stores a mutable Concurrent::Map in a CLASS instance variable
+    # (@attribute_method_patterns_cache). That ivar is unshareable, so reading
+    # it from a worker Ractor raises Ractor::IsolationError ("can not get
+    # unshareable values from instance variables of classes/modules from
+    # non-main Ractors") — hit on the write path via redirect_to @post ->
+    # respond_to? -> matched_attribute_method -> attribute_method_patterns_cache.
+    #
+    # Unlike @relation_delegate_cache (populated once, freezable), this map is
+    # mutated lazily per method_name (compute_if_absent) during request handling,
+    # so it cannot be frozen. Instead route it through Ractor-local storage:
+    # each Ractor gets its own Concurrent::Map, shared by all of its threads.
+    # The cache content is deterministic (a pure function of the class's
+    # attribute_method_patterns), so per-Ractor recomputation is correct.
+    def _install_active_model_attribute_method_patterns_patch
+      return if @am_amp_patched
+      @am_amp_patched = true
+      _register_patch :active_model_attribute_method_patterns, "8.1"
+      return unless defined?(::ActiveModel::AttributeMethods)
+
+      mod = ::ActiveModel::AttributeMethods::ClassMethods
+      mod.module_eval do
+        def attribute_method_patterns_cache
+          store = Ractor.current[:__am_attribute_method_patterns_cache__] ||= {}
+          store[object_id] ||= Concurrent::Map.new(initial_capacity: 4)
+        end
+      end
+    end
+
     # Make every loaded AR model class's @relation_delegate_cache shareable.
     # Idempotent; must run in the main Ractor after eager_load so that all
     # model classes (and their caches) exist.
@@ -1310,6 +1346,19 @@ module RactorRailsShim
         def default_connection_handler=(val)
           ActiveSupport::IsolatedExecutionState[#{dch_key_str}] = val
         end
+        # Route the per-Ractor handler through Ractor-local storage. IES is
+        # per-thread, so a handler stored on the init thread is invisible to the
+        # worker's other threads; Ractor.current is per-Ractor and shared by all
+        # threads of the worker. Falls back to IES (legacy) then
+        # default_connection_handler (main Ractor only).
+        def connection_handler
+          v = Ractor.current[:active_record_connection_handler]
+          return v unless v.nil?
+          ActiveSupport::IsolatedExecutionState[:active_record_connection_handler] || default_connection_handler
+        end
+        def connection_handler=(handler)
+          Ractor.current[:active_record_connection_handler] = handler
+        end
       RUBY
 
       # Also ensure connection_handler (which Rails already routes through IES

data/lib/ractor_rails_shim/patches/core.rb

@@ -377,6 +377,7 @@ module RactorRailsShim
       _install_activerecord_primary_key_patch
       _install_activerecord_query_constraints_patch
       _install_activerecord_relation_delegate_cache_patch
+      _install_active_model_attribute_method_patterns_patch
       _install_activerecord_model_classes_patch
       _install_active_model_naming_patch
       _install_active_record_core_patch
@@ -781,10 +782,18 @@ module RactorRailsShim
     private
 
     def setup_once!
-      return if Ractor.current[:rrs_worker_ready]
-      rebind_constants
-      RactorRailsShim.init_worker_ar_connections! if defined?(RactorRailsShim)
-      Ractor.current[:rrs_worker_ready] = true
+      # All threads inside a worker Ractor share Ractor.current, so a single
+      # per-Ractor mutex serializes the one-time init across the worker's
+      # threads. (The mutex is created under ||= which is racy under extreme
+      # contention, but both init steps below are themselves idempotent, so a
+      # rare double-init is harmless.)
+      m = Ractor.current[:rrs_worker_mutex] ||= Thread::Mutex.new
+      m.synchronize do
+        return if Ractor.current[:rrs_worker_ready]
+        rebind_constants
+        RactorRailsShim.init_worker_ar_connections! if defined?(RactorRailsShim)
+        Ractor.current[:rrs_worker_ready] = true
+      end
     end
 
     def rebind_constants
@@ -792,6 +801,9 @@ module RactorRailsShim
         parent = Object
         parts = cpath.split("::")
         parts[0...-1].each do |p|
+          # Re-fetch the parent each iteration so concurrent setup (multiple
+          # threads racing through setup_once! on the same worker) cannot
+          # clobber a namespace module out from under us.
           parent = if parent.const_defined?(p, false)
                      parent.const_get(p, false)
                    else

data/lib/ractor_rails_shim/patches/kaminari.rb

@@ -3,7 +3,7 @@
 # Patch Kaminari::config to not read the @_config class ivar from a worker
 # Ractor.
 #
-# Blocker 2 (from NEXT_STEPS.md):
+# Blocker 2:
 #   Kaminari.config reads @_config directly at kaminari/config.rb:14:
 #     def self.config; @_config ||= Kaminari::Configuration.new end
 #   Not mattr_accessor-backed, so the shim's mattr rewrite doesn't catch it.

data/lib/ractor_rails_shim/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RactorRailsShim
-  VERSION = "0.2.1"
+  VERSION = "0.2.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ractor-rails-shim
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - dev
@@ -106,7 +106,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.10
+rubygems_version: 4.0.16
 specification_version: 4
 summary: Make Rails apps Ractor-safe so they can run in Ractor mode (e.g. under the
   kino web server).