ractor-pool 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b97336e3bda02791d66cbef83761b58ff599afca2e58698bd79e7aa5bdedc497
-  data.tar.gz: 77b0ff65e53978436edc7701c204415709092f96a71f1c834e7ce719c75fc3d4
+  metadata.gz: 13aa15dab296025cc8fa8348a4477bd8afd2db09b24ea4e13c43a17cca976cd2
+  data.tar.gz: b99432e86a0e93b69aa84867b869a0502469b402a297698599175442987cc23f
 SHA512:
-  metadata.gz: acdd99e1c5c20f0d628353abe9682a9283c1d60d5b5f1247d366c08e91db3dc19e62797a8d3347fd49c8498e1896e57711637a0cea3c05359f4aa300f3f73eee
-  data.tar.gz: 5cf2b4e221ec273c5ed038c256d36e4b29f58619eee6d7412e68d498288e593373a874118b6b4f58e83c8a20009c800e3000d5aa31dc88cc7b6fc5ed277c33ed
+  metadata.gz: 8f85b3c281484b9daf22e6e0fe2c195ca4a5a67640e3913d70f93cd109c022e3138cbae924477de09e2400c552b9b4c19eb386cf9b5b3479ec6bf60e382cbb4d
+  data.tar.gz: 6101a788de91cbe8f681cfa3c3c05556154061f0f96910e2474c1b083b5c283455d2ee1c525d30f8e73785148ad6392dbf1464f578cdb8b07670718b911bfba5

data/.buildkite/pipeline.yml

@@ -6,6 +6,7 @@ steps:
       - bundle exec rake
 
   - label: ":ruby: Ruby head"
+    soft_fail: true
     image: "rubylang/ruby:master-dev"
     commands:
       - apt-get update && apt-get install -y libyaml-dev

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 ## [Unreleased]
 
+## [0.3.1] - 2026-05-12
+
+- Fix `result_port` race condition in single-worker shutdown
+
 ## [0.3.0] - 2026-05-08
 
 - Replace state atom with separate `@in_flight` and `@shutdown` atoms

data/lib/ractor-pool/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class RactorPool
-  VERSION = "0.3.0"
+  VERSION = "0.3.1"
 end

data/lib/ractor-pool.rb

@@ -35,7 +35,7 @@ Warning.ignore(/Ractor API is experimental/, __FILE__)
 #
 #   p counter.value #=> 10
 #
-# @see https://docs.ruby-lang.org/en/master/ractor_md.html Ractor Guide
+# @see https://docs.ruby-lang.org/en/master/language/ractor_md.html Ractor Guide
 # @see https://docs.ruby-lang.org/en/master/Ractor.html Ractor API
 # @see https://docs.ruby-lang.org/en/master/Ractor/Port.html Ractor::Port API
 # @see https://github.com/joshuay03/atomic-ruby atomic-ruby gem
@@ -62,8 +62,8 @@ class RactorPool
   # @rbs @error_port: Ractor::Port?
   # @rbs @coordinator: Ractor?
   # @rbs @workers: Array[Ractor]
-  # @rbs @error_collector: Thread?
   # @rbs @collector: Thread?
+  # @rbs @error_collector: Thread?
 
   # Creates a new RactorPool with the specified number of workers.
   #
@@ -107,8 +107,8 @@ class RactorPool
     @error_port  = Ractor::Port.new unless on_error
     @coordinator = start_coordinator if size > 1
     @workers = start_workers
-    @error_collector = start_error_collector
     @collector = start_collector
+    @error_collector = start_error_collector
   end
 
   # Queues a work item to be processed by an available worker.
@@ -170,10 +170,15 @@ class RactorPool
 
     Thread.pass until @in_flight.value.zero?
 
-    @coordinator&.send(SHUTDOWN, move: true) ||
-      (@workers.first.send(SHUTDOWN, move: true) && @result_port&.send(SHUTDOWN, move: true))
-    @workers.each(&:join)
-    @coordinator&.join
+    if @coordinator
+      @coordinator.send(SHUTDOWN, move: true)
+      @workers.each(&:join)
+      @coordinator.join
+    else
+      @workers.first.send(SHUTDOWN, move: true)
+      @workers.each(&:join)
+      @result_port&.send(SHUTDOWN, move: true)
+    end
     @error_port&.send(SHUTDOWN, move: true)
     @error_collector&.join
     @collector&.join
@@ -261,39 +266,39 @@ class RactorPool
   end
 
   # @rbs () -> Thread?
-  def start_error_collector
-    return if @on_error
+  def start_collector
+    return unless @result_handler
 
-    thread_name = String.new("#{self.class.name} error collector thread")
+    thread_name = String.new("#{self.class.name} collector thread")
     thread_name << " for #{@name}" if @name
 
-    Thread.new(@error_port, thread_name) do |error_port, name|
+    Thread.new(@result_port, @result_handler, thread_name) do |result_port, result_handler, name|
       Thread.current.name = name
 
       loop do
-        message = error_port.receive
-        break if message == SHUTDOWN
+        result = result_port.receive
+        break if result == SHUTDOWN
 
-        warn message
+        result_handler.call(result)
       end
     end
   end
 
   # @rbs () -> Thread?
-  def start_collector
-    return unless @result_handler
+  def start_error_collector
+    return if @on_error
 
-    thread_name = String.new("#{self.class.name} collector thread")
+    thread_name = String.new("#{self.class.name} error collector thread")
     thread_name << " for #{@name}" if @name
 
-    Thread.new(@result_port, @result_handler, thread_name) do |result_port, result_handler, name|
+    Thread.new(@error_port, thread_name) do |error_port, name|
       Thread.current.name = name
 
       loop do
-        result = result_port.receive
-        break if result == SHUTDOWN
+        message = error_port.receive
+        break if message == SHUTDOWN
 
-        result_handler.call(result)
+        warn message
       end
     end
   end

data/sig/generated/ractor-pool.rbs

@@ -29,7 +29,7 @@
 #
 #   p counter.value #=> 10
 #
-# @see https://docs.ruby-lang.org/en/master/ractor_md.html Ractor Guide
+# @see https://docs.ruby-lang.org/en/master/language/ractor_md.html Ractor Guide
 # @see https://docs.ruby-lang.org/en/master/Ractor.html Ractor API
 # @see https://docs.ruby-lang.org/en/master/Ractor/Port.html Ractor::Port API
 # @see https://github.com/joshuay03/atomic-ruby atomic-ruby gem
@@ -44,10 +44,10 @@ class RactorPool
 
   SHUTDOWN: ::Symbol
 
-  @collector: Thread?
-
   @error_collector: Thread?
 
+  @collector: Thread?
+
   @workers: Array[Ractor]
 
   @coordinator: Ractor?
@@ -137,8 +137,8 @@ class RactorPool
   def start_workers: () -> Array[Ractor]
 
   # @rbs () -> Thread?
-  def start_error_collector: () -> Thread?
+  def start_collector: () -> Thread?
 
   # @rbs () -> Thread?
-  def start_collector: () -> Thread?
+  def start_error_collector: () -> Thread?
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ractor-pool
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Joshua Young
@@ -73,7 +73,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.6
+rubygems_version: 4.0.10
 specification_version: 4
 summary: A thread-safe, lock-free pool of Ractor workers with a coordinator pattern
   for distributing work