rackamole 0.2.2 → 0.2.3

data/HISTORY

@@ -14,4 +14,9 @@
   
 0.2.2
 * NOTICE: Wrong docs and wrong configuration for mongo store initialization
-  * Corrected docs and validation for mongo store init - changed :database to :db_name
+  * Corrected docs and validation for mongo store init - changed :database to :db_name
+  
+0.2.3
+* Bug fixes
+  * Fixed issue where session or param key falls under the format a.b.c which causes 
+    validation problems in mongoDB. Thanks Rafael!

data/lib/rackamole.rb

@@ -1,7 +1,7 @@
 module Rackamole
 
   # :stopdoc:
-  VERSION = '0.2.2'
+  VERSION = '0.2.3'
   LIBPATH = ::File.expand_path(::File.dirname(__FILE__)) + ::File::SEPARATOR
   PATH = ::File.dirname(LIBPATH) + ::File::SEPARATOR
   # :startdoc:

data/lib/rackamole/store/mongo_db.rb

@@ -162,11 +162,23 @@ module Rackamole
           }
           
           args.each do |k,v|
-            row[min_field(k)] = v if v
+            row[min_field(k)] = check_hash( v ) if v
           end
           logs.save( row )
         end
         
+        # Check for invalid key format - ie something that will choke mongo
+        # case a.b.c => a_b_c
+        def ensure_valid_key( key )
+          key.to_s.index( /\./ ) ? key.to_s.gsub( /\./, '_' ) : key
+        end
+        
+        # Check 
+        def check_hash( value )
+          return value unless value.is_a?( Hash )
+          value.keys.inject({}){ |h,k| h[ensure_valid_key(k)] = value[k];h }
+        end
+        
         # For storage reason minify the json to save space...
         def min_field( field )
           field_map[field] || field

data/spec/rackamole/store/mongo_db_spec.rb

@@ -34,9 +34,9 @@ describe Rackamole::Store::MongoDb do
       @args[:session]      = { :fred => 10.to_json }
       @args[:created_at]   = @now.utc
     end
-    
+        
     it "should mole a context based feature correctly" do
-      @store.mole( @args )      
+      @store.mole( @args )
       @store.features.count.should == 1
       @store.logs.count.should     == 1
       
@@ -75,6 +75,18 @@ describe Rackamole::Store::MongoDb do
       user['did'].should == '20091127'
     end
     
+    it "should convert a.b.c session keys correctly" do
+      @args[:session] = { 'a.b.c' => 10 }
+      
+      @store.mole( @args )
+      @store.features.count.should == 1
+      @store.logs.count.should     == 1
+
+      log = @store.logs.find_one()
+      log.should_not        be_nil
+      log['ses'].should     == { 'a_b_c' => 10 }      
+    end
+    
     it "should mole a rails feature correctly" do
       @args[:path]       = '/fred/blee/duh'
       @args[:route_info] = { :controller => 'fred', :action => 'blee', :id => 'duh' }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: rackamole
 version: !ruby/object:Gem::Version 
-  version: 0.2.2
+  version: 0.2.3
 platform: ruby
 authors: 
 - Fernand Galiana
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-01-07 00:00:00 -07:00
+date: 2010-01-08 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency