rack_respond_to_malformed_formats 0.0.3 → 0.0.4

data/lib/rack/respond_to_malformed_formats.rb

@@ -5,7 +5,7 @@ require "yaml"
 
 module Rack
   class RespondToMalformedFormats
-    VERSION = "0.0.2"
+    VERSION = "0.0.4"
 
     def initialize(app, options = {})
       @app = app
@@ -41,6 +41,7 @@ module Rack
     end
 
     def parse_json(body)
+      return false if body.nil? || body.to_s.empty?
       JSON.parse(body)
       false
     rescue JSON::ParserError => e

data/rack_respond_to_malformed_formats.gemspec

@@ -3,7 +3,7 @@ $:.push File.expand_path("../lib", __FILE__)
 
 Gem::Specification.new do |s|
   s.name        = "rack_respond_to_malformed_formats"
-  s.version     = "0.0.3"
+  s.version     = "0.0.4"
   s.platform    = Gem::Platform::RUBY
   s.authors     = ["Case Commons, LLC"]
   s.email       = ["casecommons-dev@googlegroups.com"]

data/spec/respond_to_malformed_formats_spec.rb

@@ -45,6 +45,32 @@ describe Rack::RespondToMalformedFormats do
       end
     end
 
+    context "and it is nil" do
+      it "should not break" do
+        test_input = nil
+        app = lambda { |env| [200, {"Content-Type" => "application/json"}, response_for_env(env)] }
+        request = Rack::MockRequest.env_for("/", :params => "", "CONTENT_TYPE" => "application/json", :input => test_input)
+        response = wrapped_app(app).call(request)
+
+        response[0].should == 200
+        response[1]["Content-Type"].should == "application/json"
+        read(response.last).should == 'Got: '
+      end
+    end
+
+    context "and it is blank" do
+      it "should not break" do
+        test_input = ''
+        app = lambda { |env| [200, {"Content-Type" => "application/json"}, response_for_env(env)] }
+        request = Rack::MockRequest.env_for("/", :params => "", "CONTENT_TYPE" => "application/json", :input => test_input)
+        response = wrapped_app(app).call(request)
+
+        response[0].should == 200
+        response[1]["Content-Type"].should == "application/json"
+        read(response.last).should == 'Got: '
+      end
+    end
+
     context "and it is invalid" do
       it "should return a 400 with a message" do
         test_input = '{"foo":'
@@ -71,6 +97,32 @@ describe Rack::RespondToMalformedFormats do
       end
     end
 
+    context "and it is nil" do
+      it "should not break" do
+        test_input = nil
+        app = lambda { |env| [200, {"Content-Type" => "application/xml"}, response_for_env(env)] }
+        request = Rack::MockRequest.env_for("/", :params => "", "CONTENT_TYPE" => "application/json", :input => test_input)
+        response = wrapped_app(app).call(request)
+
+        response[0].should == 200
+        response[1]["Content-Type"].should == "application/xml"
+        read(response.last).should == 'Got: '
+      end
+    end
+
+    context "and it is blank" do
+      it "should not break" do
+        test_input = ''
+        app = lambda { |env| [200, {"Content-Type" => "application/xml"}, response_for_env(env)] }
+        request = Rack::MockRequest.env_for("/", :params => "", "CONTENT_TYPE" => "application/xml", :input => test_input)
+        response = wrapped_app(app).call(request)
+
+        response[0].should == 200
+        response[1]["Content-Type"].should == "application/xml"
+        read(response.last).should == 'Got: '
+      end
+    end
+
     context "and it is invalid" do
       it "should return a 400 with a message" do
         test_input = '<ml><foo>bar'
@@ -97,6 +149,32 @@ describe Rack::RespondToMalformedFormats do
       end
     end
 
+    context "and it is nil" do
+      it "should not break" do
+        test_input = nil
+        app = lambda { |env| [200, {"Content-Type" => "application/yaml"}, response_for_env(env)] }
+        request = Rack::MockRequest.env_for("/", :params => "", "CONTENT_TYPE" => "application/json", :input => test_input)
+        response = wrapped_app(app).call(request)
+
+        response[0].should == 200
+        response[1]["Content-Type"].should == "application/yaml"
+        read(response.last).should == 'Got: '
+      end
+    end
+
+    context "and it is blank" do
+      it "should not break" do
+        test_input = ''
+        app = lambda { |env| [200, {"Content-Type" => "application/yaml"}, response_for_env(env)] }
+        request = Rack::MockRequest.env_for("/", :params => "", "CONTENT_TYPE" => "application/yaml", :input => test_input)
+        response = wrapped_app(app).call(request)
+
+        response[0].should == 200
+        response[1]["Content-Type"].should == "application/yaml"
+        read(response.last).should == 'Got: '
+      end
+    end
+
     context "and it is invalid" do
       it "should return a 400 with a message" do
         test_input = "--- what:\nawagasd"

metadata

@@ -1,8 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: rack_respond_to_malformed_formats
 version: !ruby/object:Gem::Version 
-  prerelease: 
-  version: 0.0.3
+  hash: 23
+  prerelease: false
+  segments: 
+  - 0
+  - 0
+  - 4
+  version: 0.0.4
 platform: ruby
 authors: 
 - Case Commons, LLC
@@ -10,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-04-01 00:00:00 -04:00
+date: 2011-06-08 00:00:00 -04:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -21,6 +26,11 @@ dependencies:
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 15
+        segments: 
+        - 1
+        - 4
+        - 4
         version: 1.4.4
   type: :runtime
   version_requirements: *id001
@@ -58,17 +68,23 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
+      - 0
       version: "0"
 required_rubygems_version: !ruby/object:Gem::Requirement 
   none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
+      - 0
       version: "0"
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.5.2
+rubygems_version: 1.3.7
 signing_key: 
 specification_version: 3
 summary: Intercept malformed XML and JSON requests and return XML and JSON 400 responses not HTML 500