rack 2.2.6.2 → 3.0.4.1

Sign up to get free protection for your applications and to get access to all the features.

Potentially problematic release.


This version of rack might be problematic. Click here for more details.

Files changed (87) hide show
  1. checksums.yaml +4 -4
  2. data/CHANGELOG.md +192 -79
  3. data/CONTRIBUTING.md +53 -47
  4. data/MIT-LICENSE +1 -1
  5. data/README.md +293 -0
  6. data/SPEC.rdoc +183 -131
  7. data/lib/rack/auth/abstract/handler.rb +3 -1
  8. data/lib/rack/auth/abstract/request.rb +3 -1
  9. data/lib/rack/auth/basic.rb +0 -2
  10. data/lib/rack/auth/digest/md5.rb +1 -131
  11. data/lib/rack/auth/digest/nonce.rb +1 -54
  12. data/lib/rack/auth/digest/params.rb +1 -54
  13. data/lib/rack/auth/digest/request.rb +1 -43
  14. data/lib/rack/auth/digest.rb +256 -0
  15. data/lib/rack/body_proxy.rb +3 -1
  16. data/lib/rack/builder.rb +83 -63
  17. data/lib/rack/cascade.rb +2 -0
  18. data/lib/rack/chunked.rb +16 -13
  19. data/lib/rack/common_logger.rb +23 -18
  20. data/lib/rack/conditional_get.rb +18 -15
  21. data/lib/rack/constants.rb +64 -0
  22. data/lib/rack/content_length.rb +12 -16
  23. data/lib/rack/content_type.rb +8 -5
  24. data/lib/rack/deflater.rb +40 -26
  25. data/lib/rack/directory.rb +9 -3
  26. data/lib/rack/etag.rb +14 -23
  27. data/lib/rack/events.rb +4 -0
  28. data/lib/rack/file.rb +2 -0
  29. data/lib/rack/files.rb +15 -17
  30. data/lib/rack/head.rb +9 -8
  31. data/lib/rack/headers.rb +154 -0
  32. data/lib/rack/lint.rb +783 -682
  33. data/lib/rack/lock.rb +2 -5
  34. data/lib/rack/logger.rb +2 -0
  35. data/lib/rack/media_type.rb +1 -1
  36. data/lib/rack/method_override.rb +5 -1
  37. data/lib/rack/mime.rb +8 -0
  38. data/lib/rack/mock.rb +1 -271
  39. data/lib/rack/mock_request.rb +166 -0
  40. data/lib/rack/mock_response.rb +126 -0
  41. data/lib/rack/multipart/generator.rb +7 -5
  42. data/lib/rack/multipart/parser.rb +118 -61
  43. data/lib/rack/multipart/uploaded_file.rb +4 -0
  44. data/lib/rack/multipart.rb +20 -40
  45. data/lib/rack/null_logger.rb +9 -0
  46. data/lib/rack/query_parser.rb +76 -44
  47. data/lib/rack/recursive.rb +2 -0
  48. data/lib/rack/reloader.rb +0 -2
  49. data/lib/rack/request.rb +213 -106
  50. data/lib/rack/response.rb +136 -61
  51. data/lib/rack/rewindable_input.rb +24 -5
  52. data/lib/rack/runtime.rb +7 -6
  53. data/lib/rack/sendfile.rb +30 -25
  54. data/lib/rack/show_exceptions.rb +15 -2
  55. data/lib/rack/show_status.rb +17 -7
  56. data/lib/rack/static.rb +8 -8
  57. data/lib/rack/tempfile_reaper.rb +15 -4
  58. data/lib/rack/urlmap.rb +3 -1
  59. data/lib/rack/utils.rb +202 -176
  60. data/lib/rack/version.rb +9 -4
  61. data/lib/rack.rb +5 -76
  62. metadata +14 -34
  63. data/README.rdoc +0 -306
  64. data/Rakefile +0 -130
  65. data/bin/rackup +0 -5
  66. data/contrib/rack.png +0 -0
  67. data/contrib/rack.svg +0 -150
  68. data/contrib/rack_logo.svg +0 -164
  69. data/contrib/rdoc.css +0 -412
  70. data/example/lobster.ru +0 -6
  71. data/example/protectedlobster.rb +0 -16
  72. data/example/protectedlobster.ru +0 -10
  73. data/lib/rack/core_ext/regexp.rb +0 -14
  74. data/lib/rack/handler/cgi.rb +0 -59
  75. data/lib/rack/handler/fastcgi.rb +0 -100
  76. data/lib/rack/handler/lsws.rb +0 -61
  77. data/lib/rack/handler/scgi.rb +0 -71
  78. data/lib/rack/handler/thin.rb +0 -36
  79. data/lib/rack/handler/webrick.rb +0 -129
  80. data/lib/rack/handler.rb +0 -104
  81. data/lib/rack/lobster.rb +0 -70
  82. data/lib/rack/server.rb +0 -466
  83. data/lib/rack/session/abstract/id.rb +0 -523
  84. data/lib/rack/session/cookie.rb +0 -203
  85. data/lib/rack/session/memcache.rb +0 -10
  86. data/lib/rack/session/pool.rb +0 -85
  87. data/rack.gemspec +0 -46
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: 58f641d1882668bf5e150710676e3067def0089d87706cf4b233b11eb5e36cc7
4
- data.tar.gz: 1ea7a963d41498945e0377b9637ca37df23c9fa41139e83517b37de512be41d7
3
+ metadata.gz: 966e37b13d3b25138d48a0a120a35b23f8821c95e55ae1132208dbf6e4d01f3e
4
+ data.tar.gz: 849cf474ff1e7d79f4d1bc6a7b6396c174c21f6f2c5100d7b63030e9cc3fd808
5
5
  SHA512:
6
- metadata.gz: cafc52d78b4b998df9a973915ccd925de929d9b3b263369c76d3c3efb46d636752dd7260947507c3b4a5a51bab628c007567ef5e5b0759b8b59753ecab93c0f3
7
- data.tar.gz: c161e73e76fea22a0ef5b4c53c747a63591975c417e426697694d399f204806e6e39ff45e382f7f1938b3c8add90f4492c0c5d754d57685cfc12b486b8ef897f
6
+ metadata.gz: 781ff34ba58e47c262f239af6d76b697a2d6df26329b21e5d055609c95b2855f13a9355d470c85f0055b6ff135edebdf83dba845452645a7a2965443b49bca8f
7
+ data.tar.gz: 8a56368346afee246702533dfed7b444d2fab999bcc4d405484cb3af0b8e674ffa35509ddd402ed73b7a36bc9f9bb99dd09e2c31dafcb170c4cdbc63a095bd21
data/CHANGELOG.md CHANGED
@@ -2,25 +2,128 @@
2
2
 
3
3
  All notable changes to this project will be documented in this file. For info on how to format all future additions to this file please reference [Keep A Changelog](https://keepachangelog.com/en/1.0.0/).
4
4
 
5
- ## [2.2.6.2] - 2022-01-17
6
-
7
- - [CVE-2022-44570] Fix ReDoS in Rack::Utils.get_byte_ranges
8
-
9
- ## [2.2.6.1] - 2022-01-17
5
+ ## [3.0.4.1] - 2023-01-17
10
6
 
11
7
  - [CVE-2022-44571] Fix ReDoS vulnerability in multipart parser
8
+ - [CVE-2022-44570] Fix ReDoS in Rack::Utils.get_byte_ranges
12
9
  - [CVE-2022-44572] Forbid control characters in attributes (also ReDoS)
13
10
 
14
- ## [2.2.6] - 2022-01-17
11
+ ## [3.0.4] - 2022-01-17
15
12
 
16
- - Extend `Rack::MethodOverride` to handle `QueryParser::ParamsTooDeepError` error. ([#2011](https://github.com/rack/rack/pull/2011), [@byroot](https://github.com/byroot))
13
+ - `Rack::Request#POST` should consistently raise errors. Cache errors that occur when invoking `Rack::Request#POST` so they can be raised again later. ([#2010](https://github.com/rack/rack/pull/2010), [@ioquatix])
14
+ - Fix `Rack::Lint` error message for `HTTP_CONTENT_TYPE` and `HTTP_CONTENT_LENGTH`. ([#2007](https://github.com/rack/rack/pull/2007), [@byroot](https://github.com/byroot))
15
+ - Extend `Rack::MethodOverride` to handle `QueryParser::ParamsTooDeepError` error. ([#2006](https://github.com/rack/rack/pull/2006), [@byroot](https://github.com/byroot))
17
16
 
18
- ## [2.2.5] - 2022-12-27
17
+ ## [3.0.3] - 2022-12-27
19
18
 
20
19
  ### Fixed
21
20
 
22
21
  - `Rack::URLMap` uses non-deprecated form of `Regexp.new`. ([#1998](https://github.com/rack/rack/pull/1998), [@weizheheng](https://github.com/weizheheng))
23
22
 
23
+ ## [3.0.2] - 2022-12-05
24
+
25
+ ### Fixed
26
+
27
+ - `Utils.build_nested_query` URL-encodes nested field names including the square brackets.
28
+ - Allow `Rack::Response` to pass through streaming bodies. ([#1993](https://github.com/rack/rack/pull/1993), [@ioquatix])
29
+
30
+ ## [3.0.1] - 2022-11-18
31
+
32
+ ### Fixed
33
+
34
+ - `MethodOverride` does not look for an override if a request does not include form/parseable data.
35
+ - `Rack::Lint::Wrapper` correctly handles `respond_to?` with `to_ary`, `each`, `call` and `to_path`, forwarding to the body. ([#1981](https://github.com/rack/rack/pull/1981), [@ioquatix])
36
+
37
+ ## [3.0.0] - 2022-09-06
38
+
39
+ - No changes
40
+
41
+ ## [3.0.0.rc1] - 2022-09-04
42
+
43
+ ### SPEC Changes
44
+
45
+ - Stream argument must implement `<<` https://github.com/rack/rack/pull/1959
46
+ - `close` may be called on `rack.input` https://github.com/rack/rack/pull/1956
47
+ - `rack.response_finished` may be used for executing code after the response has been finished https://github.com/rack/rack/pull/1952
48
+
49
+ ## [3.0.0.beta1] - 2022-08-08
50
+
51
+ ### Security
52
+
53
+ - Do not use semicolon as GET parameter separator. ([#1733](https://github.com/rack/rack/pull/1733), [@jeremyevans])
54
+
55
+ ### SPEC Changes
56
+
57
+ - Response array must now be non-frozen.
58
+ - Response `status` must now be an integer greater than or equal to 100.
59
+ - Response `headers` must now be an unfrozen hash.
60
+ - Response header keys can no longer include uppercase characters.
61
+ - Response header values can be an `Array` to handle multiple values (and no longer supports `\n` encoded headers).
62
+ - Response body can now respond to `#call` (streaming body) instead of `#each` (enumerable body), for the equivalent of response hijacking in previous versions.
63
+ - Middleware must no longer call `#each` on the body, but they can call `#to_ary` on the body if it responds to `#to_ary`.
64
+ - `rack.input` is no longer required to be rewindable.
65
+ - `rack.multithread`/`rack.multiprocess`/`rack.run_once`/`rack.version` are no longer required environment keys.
66
+ - `SERVER_PROTOCOL` is now a required environment key, matching the HTTP protocol used in the request.
67
+ - `rack.hijack?` (partial hijack) and `rack.hijack` (full hijack) are now independently optional.
68
+ - `rack.hijack_io` has been removed completely.
69
+ - `rack.response_finished` is an optional environment key which contains an array of callable objects that must accept `#call(env, status, headers, error)` and are invoked after the response is finished (either successfully or unsuccessfully).
70
+ - It is okay to call `#close` on `rack.input` to indicate that you no longer need or care about the input.
71
+ - The stream argument supplied to the streaming body and hijack must support `#<<` for writing output.
72
+
73
+ ### Removed
74
+
75
+ - Remove `rack.multithread`/`rack.multiprocess`/`rack.run_once`. These variables generally come too late to be useful. ([#1720](https://github.com/rack/rack/pull/1720), [@ioquatix], [@jeremyevans]))
76
+ - Remove deprecated Rack::Request::SCHEME_WHITELIST. ([@jeremyevans])
77
+ - Remove internal cookie deletion using pattern matching, there are very few practical cases where it would be useful and browsers handle it correctly without us doing anything special. ([#1844](https://github.com/rack/rack/pull/1844), [@ioquatix])
78
+ - Remove `rack.version` as it comes too late to be useful. ([#1938](https://github.com/rack/rack/pull/1938), [@ioquatix])
79
+ - Extract `rackup` command, `Rack::Server`, `Rack::Handler` and related code into a separate gem. ([#1937](https://github.com/rack/rack/pull/1937), [@ioquatix])
80
+
81
+ ### Added
82
+
83
+ - `Rack::Headers` added to support lower-case header keys. ([@jeremyevans])
84
+ - `Rack::Utils#set_cookie_header` now supports `escape_key: false` to avoid key escaping. ([@jeremyevans])
85
+ - `Rack::RewindableInput` supports size. ([@ahorek](https://github.com/ahorek))
86
+ - `Rack::RewindableInput::Middleware` added for making `rack.input` rewindable. ([@jeremyevans])
87
+ - The RFC 7239 Forwarded header is now supported and considered by default when looking for information on forwarding, falling back to the X-Forwarded-* headers. `Rack::Request.forwarded_priority` accessor has been added for configuring the priority of which header to check. ([#1423](https://github.com/rack/rack/issues/1423), [@jeremyevans])
88
+ - Allow response headers to contain array of values. ([#1598](https://github.com/rack/rack/issues/1598), [@ioquatix])
89
+ - Support callable body for explicit streaming support and clarify streaming response body behaviour. ([#1745](https://github.com/rack/rack/pull/1745), [@ioquatix], [#1748](https://github.com/rack/rack/pull/1748), [@wjordan])
90
+ - Allow `Rack::Builder#run` to take a block instead of an argument. ([#1942](https://github.com/rack/rack/pull/1942), [@ioquatix])
91
+ - Add `rack.response_finished` to `Rack::Lint`. ([#1802](https://github.com/rack/rack/pull/1802), [@BlakeWilliams], [#1952](https://github.com/rack/rack/pull/1952), [@ioquatix])
92
+ - The stream argument must implement `#<<`. ([#1959](https://github.com/rack/rack/pull/1959), [@ioquatix])
93
+
94
+ ### Changed
95
+
96
+ - BREAKING CHANGE: Require `status` to be an Integer. ([#1662](https://github.com/rack/rack/pull/1662), [@olleolleolle](https://github.com/olleolleolle))
97
+ - BREAKING CHANGE: Query parsing now treats parameters without `=` as having the empty string value instead of nil value, to conform to the URL spec. ([#1696](https://github.com/rack/rack/issues/1696), [@jeremyevans])
98
+ - Relax validations around `Rack::Request#host` and `Rack::Request#hostname`. ([#1606](https://github.com/rack/rack/issues/1606), [@pvande](https://github.com/pvande))
99
+ - Removed antiquated handlers: FCGI, LSWS, SCGI, Thin. ([#1658](https://github.com/rack/rack/pull/1658), [@ioquatix])
100
+ - Removed options from `Rack::Builder.parse_file` and `Rack::Builder.load_file`. ([#1663](https://github.com/rack/rack/pull/1663), [@ioquatix])
101
+ - `Rack::HTTP_VERSION` has been removed and the `HTTP_VERSION` env setting is no longer set in the CGI and Webrick handlers. ([#970](https://github.com/rack/rack/issues/970), [@jeremyevans])
102
+ - `Rack::Request#[]` and `#[]=` now warn even in non-verbose mode. ([#1277](https://github.com/rack/rack/issues/1277), [@jeremyevans])
103
+ - Decrease default allowed parameter recursion level from 100 to 32. ([#1640](https://github.com/rack/rack/issues/1640), [@jeremyevans])
104
+ - Attempting to parse a multipart response with an empty body now raises Rack::Multipart::EmptyContentError. ([#1603](https://github.com/rack/rack/issues/1603), [@jeremyevans])
105
+ - `Rack::Utils.secure_compare` uses OpenSSL's faster implementation if available. ([#1711](https://github.com/rack/rack/pull/1711), [@bdewater](https://github.com/bdewater))
106
+ - `Rack::Request#POST` now caches an empty hash if input content type is not parseable. ([#749](https://github.com/rack/rack/pull/749), [@jeremyevans])
107
+ - BREAKING CHANGE: Updated `trusted_proxy?` to match full 127.0.0.0/8 network. ([#1781](https://github.com/rack/rack/pull/1781), [@snbloch](https://github.com/snbloch))
108
+ - Explicitly deprecate `Rack::File` which was an alias for `Rack::Files`. ([#1811](https://github.com/rack/rack/pull/1720), [@ioquatix]).
109
+ - Moved `Rack::Session` into [separate gem](https://github.com/rack/rack-session). ([#1805](https://github.com/rack/rack/pull/1805), [@ioquatix])
110
+ - `rackup -D` option to daemonizes no longer changes the working directory to the root. ([#1813](https://github.com/rack/rack/pull/1813), [@jeremyevans])
111
+ - The `x-forwarded-proto` header is now considered before the `x-forwarded-scheme` header for determining the forwarded protocol. `Rack::Request.x_forwarded_proto_priority` accessor has been added for configuring the priority of which header to check. ([#1809](https://github.com/rack/rack/issues/1809), [@jeremyevans])
112
+ - `Rack::Request.forwarded_authority` (and methods that call it, such as `host`) now returns the last authority in the forwarded header, instead of the first, as earlier forwarded authorities can be forged by clients. This restores the Rack 2.1 behavior. ([#1829](https://github.com/rack/rack/issues/1809), [@jeremyevans])
113
+ - Use lower case cookie attributes when creating cookies, and fold cookie attributes to lower case when reading cookies (specifically impacting `secure` and `httponly` attributes). ([#1849](https://github.com/rack/rack/pull/1849), [@ioquatix])
114
+ - The response array must now be mutable (non-frozen) so middleware can modify it without allocating a new Array,therefore reducing object allocations. ([#1887](https://github.com/rack/rack/pull/1887), [#1927](https://github.com/rack/rack/pull/1927), [@amatsuda], [@ioquatix])
115
+ - `rack.hijack?` (partial hijack) and `rack.hijack` (full hijack) are now independently optional. `rack.hijack_io` is no longer required/specified. ([#1939](https://github.com/rack/rack/pull/1939), [@ioquatix])
116
+ - Allow calling close on `rack.input`. ([#1956](https://github.com/rack/rack/pull/1956), [@ioquatix])
117
+
118
+ ### Fixed
119
+
120
+ - Make Rack::MockResponse handle non-hash headers. ([#1629](https://github.com/rack/rack/issues/1629), [@jeremyevans])
121
+ - TempfileReaper now deletes temp files if application raises an exception. ([#1679](https://github.com/rack/rack/issues/1679), [@jeremyevans])
122
+ - Handle cookies with values that end in '=' ([#1645](https://github.com/rack/rack/pull/1645), [@lukaso](https://github.com/lukaso))
123
+ - Make `Rack::NullLogger` respond to `#fatal!` [@jeremyevans])
124
+ - Fix multipart filename generation for filenames that contain spaces. Encode spaces as "%20" instead of "+" which will be decoded properly by the multipart parser. ([#1736](https://github.com/rack/rack/pull/1645), [@muirdm](https://github.com/muirdm))
125
+ - `Rack::Request#scheme` returns `ws` or `wss` when one of the `X-Forwarded-Scheme` / `X-Forwarded-Proto` headers is set to `ws` or `wss`, respectively. ([#1730](https://github.com/rack/rack/issues/1730), [@erwanst](https://github.com/erwanst))
126
+
24
127
  ## [2.2.4] - 2022-06-30
25
128
 
26
129
  - Better support for lower case headers in `Rack::ETag` middleware. ([#1919](https://github.com/rack/rack/pull/1919), [@ioquatix](https://github.com/ioquatix))
@@ -28,23 +131,21 @@ All notable changes to this project will be documented in this file. For info on
28
131
 
29
132
  ## [2.2.3.1] - 2022-05-27
30
133
 
31
- ### Security
32
-
33
134
  - [CVE-2022-30123] Fix shell escaping issue in Common Logger
34
135
  - [CVE-2022-30122] Restrict parsing of broken MIME attachments
35
136
 
36
- ## [2.2.3] - 2020-02-11
137
+ ## [2.2.3] - 2020-06-15
37
138
 
38
139
  ### Security
39
140
 
40
- - [CVE-2020-8184] Only decode cookie values
141
+ - [[CVE-2020-8184](https://nvd.nist.gov/vuln/detail/CVE-2020-8184)] Do not allow percent-encoded cookie name to override existing cookie names. BREAKING CHANGE: Accessing cookie names that require URL encoding with decoded name no longer works. ([@fletchto99](https://github.com/fletchto99))
41
142
 
42
143
  ## [2.2.2] - 2020-02-11
43
144
 
44
145
  ### Fixed
45
146
 
46
- - Fix incorrect `Rack::Request#host` value. ([#1591](https://github.com/rack/rack/pull/1591), [@ioquatix](https://github.com/ioquatix))
47
- - Revert `Rack::Handler::Thin` implementation. ([#1583](https://github.com/rack/rack/pull/1583), [@jeremyevans](https://github.com/jeremyevans))
147
+ - Fix incorrect `Rack::Request#host` value. ([#1591](https://github.com/rack/rack/pull/1591), [@ioquatix])
148
+ - Revert `Rack::Handler::Thin` implementation. ([#1583](https://github.com/rack/rack/pull/1583), [@jeremyevans])
48
149
  - Double assignment is still needed to prevent an "unused variable" warning. ([#1589](https://github.com/rack/rack/pull/1589), [@kamipo](https://github.com/kamipo))
49
150
  - Fix to handle same_site option for session pool. ([#1587](https://github.com/rack/rack/pull/1587), [@kamipo](https://github.com/kamipo))
50
151
 
@@ -52,105 +153,111 @@ All notable changes to this project will be documented in this file. For info on
52
153
 
53
154
  ### Fixed
54
155
 
55
- - Rework `Rack::Request#ip` to handle empty `forwarded_for`. ([#1577](https://github.com/rack/rack/pull/1577), [@ioquatix](https://github.com/ioquatix))
156
+ - Rework `Rack::Request#ip` to handle empty `forwarded_for`. ([#1577](https://github.com/rack/rack/pull/1577), [@ioquatix])
56
157
 
57
158
  ## [2.2.0] - 2020-02-08
58
159
 
59
160
  ### SPEC Changes
60
161
 
61
- - `rack.session` request environment entry must respond to `to_hash` and return unfrozen Hash. ([@jeremyevans](https://github.com/jeremyevans))
62
- - Request environment cannot be frozen. ([@jeremyevans](https://github.com/jeremyevans))
63
- - CGI values in the request environment with non-ASCII characters must use ASCII-8BIT encoding. ([@jeremyevans](https://github.com/jeremyevans))
64
- - Improve SPEC/lint relating to SERVER_NAME, SERVER_PORT and HTTP_HOST. ([#1561](https://github.com/rack/rack/pull/1561), [@ioquatix](https://github.com/ioquatix))
162
+ - `rack.session` request environment entry must respond to `to_hash` and return unfrozen Hash. ([@jeremyevans])
163
+ - Request environment cannot be frozen. ([@jeremyevans])
164
+ - CGI values in the request environment with non-ASCII characters must use ASCII-8BIT encoding. ([@jeremyevans])
165
+ - Improve SPEC/lint relating to SERVER_NAME, SERVER_PORT and HTTP_HOST. ([#1561](https://github.com/rack/rack/pull/1561), [@ioquatix])
65
166
 
66
167
  ### Added
67
168
 
68
- - `rackup` supports multiple `-r` options and will require all arguments. ([@jeremyevans](https://github.com/jeremyevans))
169
+ - `rackup` supports multiple `-r` options and will require all arguments. ([@jeremyevans])
69
170
  - `Server` supports an array of paths to require for the `:require` option. ([@khotta](https://github.com/khotta))
70
171
  - `Files` supports multipart range requests. ([@fatkodima](https://github.com/fatkodima))
71
- - `Multipart::UploadedFile` supports an IO-like object instead of using the filesystem, using `:filename` and `:io` options. ([@jeremyevans](https://github.com/jeremyevans))
72
- - `Multipart::UploadedFile` supports keyword arguments `:path`, `:content_type`, and `:binary` in addition to positional arguments. ([@jeremyevans](https://github.com/jeremyevans))
73
- - `Static` supports a `:cascade` option for calling the app if there is no matching file. ([@jeremyevans](https://github.com/jeremyevans))
74
- - `Session::Abstract::SessionHash#dig`. ([@jeremyevans](https://github.com/jeremyevans))
75
- - `Response.[]` and `MockResponse.[]` for creating instances using status, headers, and body. ([@ioquatix](https://github.com/ioquatix))
76
- - Convenient cache and content type methods for `Rack::Response`. ([#1555](https://github.com/rack/rack/pull/1555), [@ioquatix](https://github.com/ioquatix))
172
+ - `Multipart::UploadedFile` supports an IO-like object instead of using the filesystem, using `:filename` and `:io` options. ([@jeremyevans])
173
+ - `Multipart::UploadedFile` supports keyword arguments `:path`, `:content_type`, and `:binary` in addition to positional arguments. ([@jeremyevans])
174
+ - `Static` supports a `:cascade` option for calling the app if there is no matching file. ([@jeremyevans])
175
+ - `Session::Abstract::SessionHash#dig`. ([@jeremyevans])
176
+ - `Response.[]` and `MockResponse.[]` for creating instances using status, headers, and body. ([@ioquatix])
177
+ - Convenient cache and content type methods for `Rack::Response`. ([#1555](https://github.com/rack/rack/pull/1555), [@ioquatix])
77
178
 
78
179
  ### Changed
79
180
 
80
- - `Request#params` no longer rescues EOFError. ([@jeremyevans](https://github.com/jeremyevans))
81
- - `Directory` uses a streaming approach, significantly improving time to first byte for large directories. ([@jeremyevans](https://github.com/jeremyevans))
82
- - `Directory` no longer includes a Parent directory link in the root directory index. ([@jeremyevans](https://github.com/jeremyevans))
83
- - `QueryParser#parse_nested_query` uses original backtrace when reraising exception with new class. ([@jeremyevans](https://github.com/jeremyevans))
84
- - `ConditionalGet` follows RFC 7232 precedence if both If-None-Match and If-Modified-Since headers are provided. ([@jeremyevans](https://github.com/jeremyevans))
181
+ - `Request#params` no longer rescues EOFError. ([@jeremyevans])
182
+ - `Directory` uses a streaming approach, significantly improving time to first byte for large directories. ([@jeremyevans])
183
+ - `Directory` no longer includes a Parent directory link in the root directory index. ([@jeremyevans])
184
+ - `QueryParser#parse_nested_query` uses original backtrace when reraising exception with new class. ([@jeremyevans])
185
+ - `ConditionalGet` follows RFC 7232 precedence if both If-None-Match and If-Modified-Since headers are provided. ([@jeremyevans])
85
186
  - `.ru` files supports the `frozen-string-literal` magic comment. ([@eregon](https://github.com/eregon))
86
- - Rely on autoload to load constants instead of requiring internal files, make sure to require 'rack' and not just 'rack/...'. ([@jeremyevans](https://github.com/jeremyevans))
87
- - `Etag` will continue sending ETag even if the response should not be cached. ([@henm](https://github.com/henm))
187
+ - Rely on autoload to load constants instead of requiring internal files, make sure to require 'rack' and not just 'rack/...'. ([@jeremyevans])
188
+ - BREAKING CHANGE: `Etag` will continue sending ETag even if the response should not be cached. Streaming no longer works without a workaround, see [#1619](https://github.com/rack/rack/issues/1619#issuecomment-848460528). ([@henm](https://github.com/henm))
88
189
  - `Request#host_with_port` no longer includes a colon for a missing or empty port. ([@AlexWayfer](https://github.com/AlexWayfer))
89
- - All handlers uses keywords arguments instead of an options hash argument. ([@ioquatix](https://github.com/ioquatix))
90
- - `Files` handling of range requests no longer return a body that supports `to_path`, to ensure range requests are handled correctly. ([@jeremyevans](https://github.com/jeremyevans))
91
- - `Multipart::Generator` only includes `Content-Length` for files with paths, and `Content-Disposition` `filename` if the `UploadedFile` instance has one. ([@jeremyevans](https://github.com/jeremyevans))
92
- - `Request#ssl?` is true for the `wss` scheme (secure websockets). ([@jeremyevans](https://github.com/jeremyevans))
93
- - `Rack::HeaderHash` is memoized by default. ([#1549](https://github.com/rack/rack/pull/1549), [@ioquatix](https://github.com/ioquatix))
190
+ - All handlers uses keywords arguments instead of an options hash argument. ([@ioquatix])
191
+ - `Files` handling of range requests no longer return a body that supports `to_path`, to ensure range requests are handled correctly. ([@jeremyevans])
192
+ - `Multipart::Generator` only includes `Content-Length` for files with paths, and `Content-Disposition` `filename` if the `UploadedFile` instance has one. ([@jeremyevans])
193
+ - `Request#ssl?` is true for the `wss` scheme (secure websockets). ([@jeremyevans])
194
+ - `Rack::HeaderHash` is memoized by default. ([#1549](https://github.com/rack/rack/pull/1549), [@ioquatix])
94
195
  - `Rack::Directory` allow directory traversal inside root directory. ([#1417](https://github.com/rack/rack/pull/1417), [@ThomasSevestre](https://github.com/ThomasSevestre))
95
- - Sort encodings by server preference. ([#1184](https://github.com/rack/rack/pull/1184), [@ioquatix](https://github.com/ioquatix), [@wjordan](https://github.com/wjordan))
96
- - Rework host/hostname/authority implementation in `Rack::Request`. `#host` and `#host_with_port` have been changed to correctly return IPv6 addresses formatted with square brackets, as defined by [RFC3986](https://tools.ietf.org/html/rfc3986#section-3.2.2). ([#1561](https://github.com/rack/rack/pull/1561), [@ioquatix](https://github.com/ioquatix))
97
- - `Rack::Builder` parsing options on first `#\` line is deprecated. ([#1574](https://github.com/rack/rack/pull/1574), [@ioquatix](https://github.com/ioquatix))
196
+ - Sort encodings by server preference. ([#1184](https://github.com/rack/rack/pull/1184), [@ioquatix], [@wjordan](https://github.com/wjordan))
197
+ - Rework host/hostname/authority implementation in `Rack::Request`. `#host` and `#host_with_port` have been changed to correctly return IPv6 addresses formatted with square brackets, as defined by [RFC3986](https://tools.ietf.org/html/rfc3986#section-3.2.2). ([#1561](https://github.com/rack/rack/pull/1561), [@ioquatix])
198
+ - `Rack::Builder` parsing options on first `#\` line is deprecated. ([#1574](https://github.com/rack/rack/pull/1574), [@ioquatix])
98
199
 
99
200
  ### Removed
100
201
 
101
- - `Directory#path` as it was not used and always returned nil. ([@jeremyevans](https://github.com/jeremyevans))
102
- - `BodyProxy#each` as it was only needed to work around a bug in Ruby <1.9.3. ([@jeremyevans](https://github.com/jeremyevans))
202
+ - `Directory#path` as it was not used and always returned nil. ([@jeremyevans])
203
+ - `BodyProxy#each` as it was only needed to work around a bug in Ruby <1.9.3. ([@jeremyevans])
103
204
  - `URLMap::INFINITY` and `URLMap::NEGATIVE_INFINITY`, in favor of `Float::INFINITY`. ([@ch1c0t](https://github.com/ch1c0t))
104
205
  - Deprecation of `Rack::File`. It will be deprecated again in rack 2.2 or 3.0. ([@rafaelfranca](https://github.com/rafaelfranca))
105
- - Support for Ruby 2.2 as it is well past EOL. ([@ioquatix](https://github.com/ioquatix))
106
- - Remove `Rack::Files#response_body` as the implementation was broken. ([#1153](https://github.com/rack/rack/pull/1153), [@ioquatix](https://github.com/ioquatix))
107
- - Remove `SERVER_ADDR` which was never part of the original SPEC. ([#1573](https://github.com/rack/rack/pull/1573), [@ioquatix](https://github.com/ioquatix))
206
+ - Support for Ruby 2.2 as it is well past EOL. ([@ioquatix])
207
+ - Remove `Rack::Files#response_body` as the implementation was broken. ([#1153](https://github.com/rack/rack/pull/1153), [@ioquatix])
208
+ - Remove `SERVER_ADDR` which was never part of the original SPEC. ([#1573](https://github.com/rack/rack/pull/1573), [@ioquatix])
108
209
 
109
210
  ### Fixed
110
211
 
111
- - `Directory` correctly handles root paths containing glob metacharacters. ([@jeremyevans](https://github.com/jeremyevans))
112
- - `Cascade` uses a new response object for each call if initialized with no apps. ([@jeremyevans](https://github.com/jeremyevans))
113
- - `BodyProxy` correctly delegates keyword arguments to the body object on Ruby 2.7+. ([@jeremyevans](https://github.com/jeremyevans))
114
- - `BodyProxy#method` correctly handles methods delegated to the body object. ([@jeremyevans](https://github.com/jeremyevans))
212
+ - `Directory` correctly handles root paths containing glob metacharacters. ([@jeremyevans])
213
+ - `Cascade` uses a new response object for each call if initialized with no apps. ([@jeremyevans])
214
+ - `BodyProxy` correctly delegates keyword arguments to the body object on Ruby 2.7+. ([@jeremyevans])
215
+ - `BodyProxy#method` correctly handles methods delegated to the body object. ([@jeremyevans])
115
216
  - `Request#host` and `Request#host_with_port` handle IPv6 addresses correctly. ([@AlexWayfer](https://github.com/AlexWayfer))
116
- - `Lint` checks when response hijacking that `rack.hijack` is called with a valid object. ([@jeremyevans](https://github.com/jeremyevans))
117
- - `Response#write` correctly updates `Content-Length` if initialized with a body. ([@jeremyevans](https://github.com/jeremyevans))
217
+ - `Lint` checks when response hijacking that `rack.hijack` is called with a valid object. ([@jeremyevans])
218
+ - `Response#write` correctly updates `Content-Length` if initialized with a body. ([@jeremyevans])
118
219
  - `CommonLogger` includes `SCRIPT_NAME` when logging. ([@Erol](https://github.com/Erol))
119
- - `Utils.parse_nested_query` correctly handles empty queries, using an empty instance of the params class instead of a hash. ([@jeremyevans](https://github.com/jeremyevans))
220
+ - `Utils.parse_nested_query` correctly handles empty queries, using an empty instance of the params class instead of a hash. ([@jeremyevans])
120
221
  - `Directory` correctly escapes paths in links. ([@yous](https://github.com/yous))
121
- - `Request#delete_cookie` and related `Utils` methods handle `:domain` and `:path` options in same call. ([@jeremyevans](https://github.com/jeremyevans))
122
- - `Request#delete_cookie` and related `Utils` methods do an exact match on `:domain` and `:path` options. ([@jeremyevans](https://github.com/jeremyevans))
222
+ - `Request#delete_cookie` and related `Utils` methods handle `:domain` and `:path` options in same call. ([@jeremyevans])
223
+ - `Request#delete_cookie` and related `Utils` methods do an exact match on `:domain` and `:path` options. ([@jeremyevans])
123
224
  - `Static` no longer adds headers when a gzipped file request has a 304 response. ([@chooh](https://github.com/chooh))
124
- - `ContentLength` sets `Content-Length` response header even for bodies not responding to `to_ary`. ([@jeremyevans](https://github.com/jeremyevans))
125
- - Thin handler supports options passed directly to `Thin::Controllers::Controller`. ([@jeremyevans](https://github.com/jeremyevans))
126
- - WEBrick handler no longer ignores `:BindAddress` option. ([@jeremyevans](https://github.com/jeremyevans))
127
- - `ShowExceptions` handles invalid POST data. ([@jeremyevans](https://github.com/jeremyevans))
128
- - Basic authentication requires a password, even if the password is empty. ([@jeremyevans](https://github.com/jeremyevans))
129
- - `Lint` checks response is array with 3 elements, per SPEC. ([@jeremyevans](https://github.com/jeremyevans))
225
+ - `ContentLength` sets `Content-Length` response header even for bodies not responding to `to_ary`. ([@jeremyevans])
226
+ - Thin handler supports options passed directly to `Thin::Controllers::Controller`. ([@jeremyevans])
227
+ - WEBrick handler no longer ignores `:BindAddress` option. ([@jeremyevans])
228
+ - `ShowExceptions` handles invalid POST data. ([@jeremyevans])
229
+ - Basic authentication requires a password, even if the password is empty. ([@jeremyevans])
230
+ - `Lint` checks response is array with 3 elements, per SPEC. ([@jeremyevans])
130
231
  - Support for using `:SSLEnable` option when using WEBrick handler. (Gregor Melhorn)
131
- - Close response body after buffering it when buffering. ([@ioquatix](https://github.com/ioquatix))
232
+ - Close response body after buffering it when buffering. ([@ioquatix])
132
233
  - Only accept `;` as delimiter when parsing cookies. ([@mrageh](https://github.com/mrageh))
133
- - `Utils::HeaderHash#clear` clears the name mapping as well. ([@raxoft](https://github.com/raxoft))
134
- - Support for passing `nil` `Rack::Files.new`, which notably fixes Rails' current `ActiveStorage::FileServer` implementation. ([@ioquatix](https://github.com/ioquatix))
234
+ - `Utils::HeaderHash#clear` clears the name mapping as well. ([@raxoft](https://github.com/raxoft))
235
+ - Support for passing `nil` `Rack::Files.new`, which notably fixes Rails' current `ActiveStorage::FileServer` implementation. ([@ioquatix])
135
236
 
136
237
  ### Documentation
137
238
 
138
239
  - CHANGELOG updates. ([@aupajo](https://github.com/aupajo))
139
240
  - Added [CONTRIBUTING](CONTRIBUTING.md). ([@dblock](https://github.com/dblock))
140
241
 
242
+ ## [2.0.9] - 2020-02-08
243
+
244
+ - Handle case where session id key is requested but missing ([@jeremyevans])
245
+ - Restore support for code relying on `SessionId#to_s`. ([@jeremyevans])
246
+ - Add support for `SameSite=None` cookie value. ([@hennikul](https://github.com/hennikul))
247
+
141
248
  ## [2.1.2] - 2020-01-27
142
249
 
143
250
  - Fix multipart parser for some files to prevent denial of service ([@aiomaster](https://github.com/aiomaster))
144
251
  - Fix `Rack::Builder#use` with keyword arguments ([@kamipo](https://github.com/kamipo))
145
- - Skip deflating in Rack::Deflater if Content-Length is 0 ([@jeremyevans](https://github.com/jeremyevans))
252
+ - Skip deflating in Rack::Deflater if Content-Length is 0 ([@jeremyevans])
146
253
  - Remove `SessionHash#transform_keys`, no longer needed ([@pavel](https://github.com/pavel))
147
254
  - Add to_hash to wrap Hash and Session classes ([@oleh-demyanyuk](https://github.com/oleh-demyanyuk))
148
- - Handle case where session id key is requested but missing ([@jeremyevans](https://github.com/jeremyevans))
255
+ - Handle case where session id key is requested but missing ([@jeremyevans])
149
256
 
150
257
  ## [2.1.1] - 2020-01-12
151
258
 
152
- - Remove `Rack::Chunked` from `Rack::Server` default middleware. ([#1475](https://github.com/rack/rack/pull/1475), [@ioquatix](https://github.com/ioquatix))
153
- - Restore support for code relying on `SessionId#to_s`. ([@jeremyevans](https://github.com/jeremyevans))
259
+ - Remove `Rack::Chunked` from `Rack::Server` default middleware. ([#1475](https://github.com/rack/rack/pull/1475), [@ioquatix])
260
+ - Restore support for code relying on `SessionId#to_s`. ([@jeremyevans])
154
261
 
155
262
  ## [2.1.0] - 2020-01-10
156
263
 
@@ -167,13 +274,13 @@ All notable changes to this project will be documented in this file. For info on
167
274
  - Add boot-time profiling capabilities to `rackup`. ([@tenderlove](https://github.com/tenderlove))
168
275
  - Add multi mapping support for `X-Accel-Mappings` header. ([@yoshuki](https://github.com/yoshuki))
169
276
  - Add `sync: false` option to `Rack::Deflater`. (Eric Wong)
170
- - Add `Builder#freeze_app` to freeze application and all middleware instances. ([@jeremyevans](https://github.com/jeremyevans))
277
+ - Add `Builder#freeze_app` to freeze application and all middleware instances. ([@jeremyevans])
171
278
  - Add API to extract cookies from `Rack::MockResponse`. ([@petercline](https://github.com/petercline))
172
279
 
173
280
  ### Changed
174
281
 
175
- - Don't propagate nil values from middleware. ([@ioquatix](https://github.com/ioquatix))
176
- - Lazily initialize the response body and only buffer it if required. ([@ioquatix](https://github.com/ioquatix))
282
+ - Don't propagate nil values from middleware. ([@ioquatix])
283
+ - Lazily initialize the response body and only buffer it if required. ([@ioquatix])
177
284
  - Fix deflater zlib buffer errors on empty body part. ([@felixbuenemann](https://github.com/felixbuenemann))
178
285
  - Set `X-Accel-Redirect` to percent-encoded path. ([@diskkid](https://github.com/diskkid))
179
286
  - Remove unnecessary buffer growing when parsing multipart. ([@tainoe](https://github.com/tainoe))
@@ -186,15 +293,15 @@ All notable changes to this project will be documented in this file. For info on
186
293
  - Make `Utils.status_code` raise an error when the status symbol is invalid instead of `500`. ([@adambutler](https://github.com/adambutler))
187
294
  - Rename `Request::SCHEME_WHITELIST` to `Request::ALLOWED_SCHEMES`.
188
295
  - Make `Multipart::Parser.get_filename` accept files with `+` in their name. ([@lucaskanashiro](https://github.com/lucaskanashiro))
189
- - Add Falcon to the default handler fallbacks. ([@ioquatix](https://github.com/ioquatix))
296
+ - Add Falcon to the default handler fallbacks. ([@ioquatix])
190
297
  - Update codebase to avoid string mutations in preparation for `frozen_string_literals`. ([@pat](https://github.com/pat))
191
298
  - Change `MockRequest#env_for` to rely on the input optionally responding to `#size` instead of `#length`. ([@janko](https://github.com/janko))
192
- - Rename `Rack::File` -> `Rack::Files` and add deprecation notice. ([@postmodern](https://github.com/postmodern)).
193
- - Prefer Base64 “strict encoding” for Base64 cookies. ([@ioquatix](https://github.com/ioquatix))
299
+ - Rename `Rack::File` -> `Rack::Files` and add deprecation notice. ([@postmodern](https://github.com/postmodern))
300
+ - Prefer Base64 “strict encoding” for Base64 cookies. ([@ioquatix])
194
301
 
195
302
  ### Removed
196
303
 
197
- - Remove `to_ary` from Response ([@tenderlove](https://github.com/tenderlove))
304
+ - BREAKING CHANGE: Remove `to_ary` from Response ([@tenderlove](https://github.com/tenderlove))
198
305
  - Deprecate `Rack::Session::Memcache` in favor of `Rack::Session::Dalli` from dalli gem ([@fatkodima](https://github.com/fatkodima))
199
306
 
200
307
  ### Fixed
@@ -275,7 +382,7 @@ All notable changes to this project will be documented in this file. For info on
275
382
  ### Added
276
383
 
277
384
  - Allow `Session::Abstract::SessionHash#fetch` to accept a block with a default value. ([@yannvanhalewyn](https://github.com/yannvanhalewyn))
278
- - Add `Builder#freeze_app` to freeze application and all middleware. ([@jeremyevans](https://github.com/jeremyevans))
385
+ - Add `Builder#freeze_app` to freeze application and all middleware. ([@jeremyevans])
279
386
 
280
387
  ### Changed
281
388
 
@@ -287,9 +394,9 @@ All notable changes to this project will be documented in this file. For info on
287
394
  ### Fixed
288
395
 
289
396
  - Handle `NULL` bytes in multipart filenames. ([@casperisfine](https://github.com/casperisfine))
290
- - Remove warnings due to miscapitalized global. ([@ioquatix](https://github.com/ioquatix))
397
+ - Remove warnings due to miscapitalized global. ([@ioquatix])
291
398
  - Prevent exceptions caused by a race condition on multi-threaded servers. ([@sophiedeziel](https://github.com/sophiedeziel))
292
- - Add RDoc as an explicit depencency for `doc` group. ([@tonytonyjan](https://github.com/tonytonyjan))
399
+ - Add RDoc as an explicit dependency for `doc` group. ([@tonytonyjan](https://github.com/tonytonyjan))
293
400
  - Record errors originating from `Multipart::Parser` in the `MethodOverride` middleware instead of letting them bubble up. ([@carlzulauf](https://github.com/carlzulauf))
294
401
  - Remove remaining use of removed `Utils#bytesize` method from the `File` middleware. ([@brauliomartinezlm](https://github.com/brauliomartinezlm))
295
402
 
@@ -607,7 +714,7 @@ Items below this line are from the previously maintained HISTORY.md and NEWS.md
607
714
  - Moved Auth::OpenID to rack-contrib.
608
715
  - SPEC change that relaxes Lint slightly to allow subclasses of the
609
716
  required types
610
- - SPEC change to document rack.input binary mode in greator detail
717
+ - SPEC change to document rack.input binary mode in greater detail
611
718
  - SPEC define optional rack.logger specification
612
719
  - File servers support X-Cascade header
613
720
  - Imported Config middleware
@@ -725,3 +832,9 @@ Items below this line are from the previously maintained HISTORY.md and NEWS.md
725
832
  - Removed Rails adapter, was too alpha.
726
833
 
727
834
  ## [0.1] 2007-03-03
835
+
836
+ [@ioquatix]: https://github.com/ioquatix "Samuel Williams"
837
+ [@jeremyevans]: https://github.com/jeremyevans "Jeremy Evans"
838
+ [@amatsuda]: https://github.com/amatsuda "Akira Matsuda"
839
+ [@wjordan]: https://github.com/wjordan "Will Jordan"
840
+ [@BlakeWilliams]: https://github.com/BlakeWilliams "Blake Williams"
data/CONTRIBUTING.md CHANGED
@@ -1,29 +1,33 @@
1
- Contributing to Rack
2
- =====================
1
+ # Contributing to Rack
3
2
 
4
- Rack is work of [hundreds of contributors](https://github.com/rack/rack/graphs/contributors). You're encouraged to submit [pull requests](https://github.com/rack/rack/pulls), [propose features and discuss issues](https://github.com/rack/rack/issues). When in doubt, post to the [rack-devel](http://groups.google.com/group/rack-devel) mailing list.
3
+ Rack is work of [hundreds of
4
+ contributors](https://github.com/rack/rack/graphs/contributors). You're
5
+ encouraged to submit [pull requests](https://github.com/rack/rack/pulls) and
6
+ [propose features and discuss issues](https://github.com/rack/rack/issues).
5
7
 
6
- #### Fork the Project
8
+ ## Fork the Project
7
9
 
8
- Fork the [project on Github](https://github.com/rack/rack) and check out your copy.
10
+ Fork the [project on GitHub](https://github.com/rack/rack) and check out your
11
+ copy.
9
12
 
10
13
  ```
11
- git clone https://github.com/contributor/rack.git
14
+ git clone https://github.com/(your-github-username)/rack.git
12
15
  cd rack
13
16
  git remote add upstream https://github.com/rack/rack.git
14
17
  ```
15
18
 
16
- #### Create a Topic Branch
19
+ ## Create a Topic Branch
17
20
 
18
- Make sure your fork is up-to-date and create a topic branch for your feature or bug fix.
21
+ Make sure your fork is up-to-date and create a topic branch for your feature or
22
+ bug fix.
19
23
 
20
24
  ```
21
- git checkout master
22
- git pull upstream master
25
+ git checkout main
26
+ git pull upstream main
23
27
  git checkout -b my-feature-branch
24
28
  ```
25
29
 
26
- #### Bundle Install and Quick Test
30
+ ## Bundle Install and Quick Test
27
31
 
28
32
  Ensure that you can build the project and run quick tests.
29
33
 
@@ -32,7 +36,7 @@ bundle install --without extra
32
36
  bundle exec rake test
33
37
  ```
34
38
 
35
- #### Running All Tests
39
+ ## Running All Tests
36
40
 
37
41
  Install all dependencies.
38
42
 
@@ -46,39 +50,33 @@ Run all tests.
46
50
  rake test
47
51
  ```
48
52
 
49
- The test suite has no dependencies outside of the core Ruby installation and bacon.
53
+ ## Write Tests
50
54
 
51
- Some tests will be skipped if a dependency is not found.
55
+ Try to write a test that reproduces the problem you're trying to fix or
56
+ describes a feature that you want to build.
52
57
 
53
- To run the test suite completely, you need:
58
+ We definitely appreciate pull requests that highlight or reproduce a problem,
59
+ even without a fix.
54
60
 
55
- * fcgi
56
- * dalli
57
- * thin
58
-
59
- To test Memcache sessions, you need memcached (will be run on port 11211) and dalli installed.
60
-
61
- #### Write Tests
62
-
63
- Try to write a test that reproduces the problem you're trying to fix or describes a feature that you want to build.
64
-
65
- We definitely appreciate pull requests that highlight or reproduce a problem, even without a fix.
66
-
67
- #### Write Code
61
+ ## Write Code
68
62
 
69
63
  Implement your feature or bug fix.
70
64
 
71
- Make sure that `bundle exec rake fulltest` completes without errors.
65
+ Make sure that all tests pass:
66
+
67
+ ```
68
+ bundle exec rake test
69
+ ```
72
70
 
73
- #### Write Documentation
71
+ ## Write Documentation
74
72
 
75
- Document any external behavior in the [README](README.rdoc).
73
+ Document any external behavior in the [README](README.md).
76
74
 
77
- #### Update Changelog
75
+ ## Update Changelog
78
76
 
79
77
  Add a line to [CHANGELOG](CHANGELOG.md).
80
78
 
81
- #### Commit Changes
79
+ ## Commit Changes
82
80
 
83
81
  Make sure git knows your name and email address:
84
82
 
@@ -87,34 +85,37 @@ git config --global user.name "Your Name"
87
85
  git config --global user.email "contributor@example.com"
88
86
  ```
89
87
 
90
- Writing good commit logs is important. A commit log should describe what changed and why.
88
+ Writing good commit logs is important. A commit log should describe what changed
89
+ and why.
91
90
 
92
91
  ```
93
92
  git add ...
94
93
  git commit
95
94
  ```
96
95
 
97
- #### Push
96
+ ## Push
98
97
 
99
98
  ```
100
99
  git push origin my-feature-branch
101
100
  ```
102
101
 
103
- #### Make a Pull Request
102
+ ## Make a Pull Request
104
103
 
105
- Go to https://github.com/contributor/rack and select your feature branch. Click the 'Pull Request' button and fill out the form. Pull requests are usually reviewed within a few days.
104
+ Go to your fork of rack on GitHub and select your feature branch. Click the
105
+ 'Pull Request' button and fill out the form. Pull requests are usually
106
+ reviewed within a few days.
106
107
 
107
- #### Rebase
108
+ ## Rebase
108
109
 
109
- If you've been working on a change for a while, rebase with upstream/master.
110
+ If you've been working on a change for a while, rebase with upstream/main.
110
111
 
111
112
  ```
112
113
  git fetch upstream
113
- git rebase upstream/master
114
+ git rebase upstream/main
114
115
  git push origin my-feature-branch -f
115
116
  ```
116
117
 
117
- #### Make Required Changes
118
+ ## Make Required Changes
118
119
 
119
120
  Amend your previous commit and force push the changes.
120
121
 
@@ -123,14 +124,19 @@ git commit --amend
123
124
  git push origin my-feature-branch -f
124
125
  ```
125
126
 
126
- #### Check on Your Pull Request
127
+ ## Check on Your Pull Request
127
128
 
128
- Go back to your pull request after a few minutes and see whether it passed muster with Travis-CI. Everything should look green, otherwise fix issues and amend your commit as described above.
129
+ Go back to your pull request after a few minutes and see whether it passed
130
+ tests with GitHub Actions. Everything should look green, otherwise fix issues and
131
+ amend your commit as described above.
129
132
 
130
- #### Be Patient
133
+ ## Be Patient
131
134
 
132
- It's likely that your change will not be merged and that the nitpicky maintainers will ask you to do more, or fix seemingly benign problems. Hang on there!
135
+ It's likely that your change will not be merged and that the nitpicky
136
+ maintainers will ask you to do more, or fix seemingly benign problems. Hang in
137
+ there!
133
138
 
134
- #### Thank You
139
+ ## Thank You
135
140
 
136
- Please do know that we really appreciate and value your time and work. We love you, really.
141
+ Please do know that we really appreciate and value your time and work. We love
142
+ you, really.
data/MIT-LICENSE CHANGED
@@ -1,6 +1,6 @@
1
1
  The MIT License (MIT)
2
2
 
3
- Copyright (C) 2007-2019 Leah Neukirchen <http://leahneukirchen.org/infopage.html>
3
+ Copyright (C) 2007-2021 Leah Neukirchen <http://leahneukirchen.org/infopage.html>
4
4
 
5
5
  Permission is hereby granted, free of charge, to any person obtaining a copy
6
6
  of this software and associated documentation files (the "Software"), to