rack 2.2.10 → 3.0.0
Sign up to get free protection for your applications and to get access to all the features.
Potentially problematic release.
This version of rack might be problematic. Click here for more details.
- checksums.yaml +4 -4
- data/CHANGELOG.md +152 -100
- data/CONTRIBUTING.md +53 -47
- data/MIT-LICENSE +1 -1
- data/README.md +293 -0
- data/SPEC.rdoc +174 -126
- data/lib/rack/auth/abstract/handler.rb +3 -1
- data/lib/rack/auth/abstract/request.rb +3 -1
- data/lib/rack/auth/basic.rb +2 -1
- data/lib/rack/auth/digest/md5.rb +1 -131
- data/lib/rack/auth/digest/nonce.rb +1 -53
- data/lib/rack/auth/digest/params.rb +1 -54
- data/lib/rack/auth/digest/request.rb +1 -43
- data/lib/rack/auth/digest.rb +256 -0
- data/lib/rack/body_proxy.rb +3 -1
- data/lib/rack/builder.rb +60 -42
- data/lib/rack/cascade.rb +2 -0
- data/lib/rack/chunked.rb +16 -13
- data/lib/rack/common_logger.rb +23 -18
- data/lib/rack/conditional_get.rb +18 -15
- data/lib/rack/constants.rb +63 -0
- data/lib/rack/content_length.rb +12 -16
- data/lib/rack/content_type.rb +8 -5
- data/lib/rack/deflater.rb +40 -26
- data/lib/rack/directory.rb +9 -3
- data/lib/rack/etag.rb +14 -23
- data/lib/rack/events.rb +4 -0
- data/lib/rack/file.rb +2 -0
- data/lib/rack/files.rb +15 -17
- data/lib/rack/head.rb +9 -8
- data/lib/rack/headers.rb +154 -0
- data/lib/rack/lint.rb +754 -648
- data/lib/rack/lock.rb +2 -5
- data/lib/rack/logger.rb +2 -0
- data/lib/rack/media_type.rb +4 -9
- data/lib/rack/method_override.rb +5 -1
- data/lib/rack/mime.rb +8 -0
- data/lib/rack/mock.rb +1 -271
- data/lib/rack/mock_request.rb +166 -0
- data/lib/rack/mock_response.rb +126 -0
- data/lib/rack/multipart/generator.rb +7 -5
- data/lib/rack/multipart/parser.rb +123 -85
- data/lib/rack/multipart/uploaded_file.rb +4 -0
- data/lib/rack/multipart.rb +20 -40
- data/lib/rack/null_logger.rb +9 -0
- data/lib/rack/query_parser.rb +76 -44
- data/lib/rack/recursive.rb +2 -0
- data/lib/rack/reloader.rb +0 -2
- data/lib/rack/request.rb +189 -91
- data/lib/rack/response.rb +131 -61
- data/lib/rack/rewindable_input.rb +24 -5
- data/lib/rack/runtime.rb +7 -6
- data/lib/rack/sendfile.rb +30 -25
- data/lib/rack/show_exceptions.rb +15 -2
- data/lib/rack/show_status.rb +17 -7
- data/lib/rack/static.rb +8 -8
- data/lib/rack/tempfile_reaper.rb +15 -4
- data/lib/rack/urlmap.rb +4 -2
- data/lib/rack/utils.rb +212 -202
- data/lib/rack/version.rb +9 -4
- data/lib/rack.rb +5 -76
- metadata +15 -35
- data/README.rdoc +0 -320
- data/Rakefile +0 -130
- data/bin/rackup +0 -5
- data/contrib/rack.png +0 -0
- data/contrib/rack.svg +0 -150
- data/contrib/rack_logo.svg +0 -164
- data/contrib/rdoc.css +0 -412
- data/example/lobster.ru +0 -6
- data/example/protectedlobster.rb +0 -16
- data/example/protectedlobster.ru +0 -10
- data/lib/rack/core_ext/regexp.rb +0 -14
- data/lib/rack/handler/cgi.rb +0 -59
- data/lib/rack/handler/fastcgi.rb +0 -100
- data/lib/rack/handler/lsws.rb +0 -61
- data/lib/rack/handler/scgi.rb +0 -71
- data/lib/rack/handler/thin.rb +0 -36
- data/lib/rack/handler/webrick.rb +0 -129
- data/lib/rack/handler.rb +0 -104
- data/lib/rack/lobster.rb +0 -70
- data/lib/rack/server.rb +0 -466
- data/lib/rack/session/abstract/id.rb +0 -523
- data/lib/rack/session/cookie.rb +0 -203
- data/lib/rack/session/memcache.rb +0 -10
- data/lib/rack/session/pool.rb +0 -85
- data/rack.gemspec +0 -46
checksums.yaml
CHANGED
@@ -1,7 +1,7 @@
|
|
1
1
|
---
|
2
2
|
SHA256:
|
3
|
-
metadata.gz:
|
4
|
-
data.tar.gz:
|
3
|
+
metadata.gz: c02c25dfc02deefcbf95de53b538f14db0fa0a4c06d73755ce68062959cfd74f
|
4
|
+
data.tar.gz: e333965aa9cc102988178745dea18821e05b19f49a0d0fc7d5b7fc266f40d20e
|
5
5
|
SHA512:
|
6
|
-
metadata.gz:
|
7
|
-
data.tar.gz:
|
6
|
+
metadata.gz: f99ef35191516b033f16271abae7a3b5acce3d774c761c41ce0d1f29aa10b4e3e4c530a2495a7ad5bfed10073f19a7c87cec7b526bc33c57e2ff8623e528ea24
|
7
|
+
data.tar.gz: e498a5646da200b21ce1ce48893f5c59de580bddf1f33f8c85c3a344afb6ae37979259564b38bce50f6d699fcd574b8bcd08eb4e277d0926bcfcfc6762886909
|
data/CHANGELOG.md
CHANGED
@@ -2,53 +2,95 @@
|
|
2
2
|
|
3
3
|
All notable changes to this project will be documented in this file. For info on how to format all future additions to this file please reference [Keep A Changelog](https://keepachangelog.com/en/1.0.0/).
|
4
4
|
|
5
|
-
##
|
5
|
+
## [3.0.0] - 2022-09-06
|
6
6
|
|
7
|
-
|
7
|
+
- No changes
|
8
8
|
|
9
|
-
|
9
|
+
## [3.0.0.rc1] - 2022-09-04
|
10
10
|
|
11
|
-
|
12
|
-
|
13
|
-
- Return empty when parsing a multi-part POST with only one end delimiter. ([#2104](https://github.com/rack/rack/pull/2104), [@alpaca-tc])
|
14
|
-
|
15
|
-
## [2.2.8] - 2023-07-31
|
16
|
-
|
17
|
-
- Regenerate SPEC ([#2102](https://github.com/rack/rack/pull/2102), [@skipkayhil](https://github.com/skipkayhil))
|
18
|
-
- Limit file extension length of multipart tempfiles ([#2015](https://github.com/rack/rack/pull/2015), [@dentarg](https://github.com/dentarg))
|
19
|
-
- Fix "undefined method DelegateClass for Rack::Session::Cookie:Class" ([#2092](https://github.com/rack/rack/pull/2092), [@onigra](https://github.com/onigra) [@dchandekstark](https://github.com/dchandekstark))
|
20
|
-
|
21
|
-
## [2.2.7] - 2023-03-13
|
11
|
+
### SPEC Changes
|
22
12
|
|
23
|
-
-
|
24
|
-
-
|
13
|
+
- Stream argument must implement `<<` https://github.com/rack/rack/pull/1959
|
14
|
+
- `close` may be called on `rack.input` https://github.com/rack/rack/pull/1956
|
15
|
+
- `rack.response_finished` may be used for executing code after the response has been finished https://github.com/rack/rack/pull/1952
|
25
16
|
|
26
|
-
## [
|
17
|
+
## [3.0.0.beta1] - 2022-08-08
|
27
18
|
|
28
|
-
|
19
|
+
### Security
|
29
20
|
|
30
|
-
|
21
|
+
- Do not use semicolon as GET parameter separator. ([#1733](https://github.com/rack/rack/pull/1733), [@jeremyevans])
|
31
22
|
|
32
|
-
|
23
|
+
### SPEC Changes
|
33
24
|
|
34
|
-
|
25
|
+
- Response array must now be non-frozen.
|
26
|
+
- Response `status` must now be an integer greater than or equal to 100.
|
27
|
+
- Response `headers` must now be an unfrozen hash.
|
28
|
+
- Response header keys can no longer include uppercase characters.
|
29
|
+
- Response header values can be an `Array` to handle multiple values (and no longer supports `\n` encoded headers).
|
30
|
+
- Response body can now respond to `#call` (streaming body) instead of `#each` (enumerable body), for the equivalent of response hijacking in previous versions.
|
31
|
+
- Middleware must no longer call `#each` on the body, but they can call `#to_ary` on the body if it responds to `#to_ary`.
|
32
|
+
- `rack.input` is no longer required to be rewindable.
|
33
|
+
- `rack.multithread`/`rack.multiprocess`/`rack.run_once`/`rack.version` are no longer required environment keys.
|
34
|
+
- `SERVER_PROTOCOL` is now a required environment key, matching the HTTP protocol used in the request.
|
35
|
+
- `rack.hijack?` (partial hijack) and `rack.hijack` (full hijack) are now independently optional.
|
36
|
+
- `rack.hijack_io` has been removed completely.
|
37
|
+
- `rack.response_finished` is an optional environment key which contains an array of callable objects that must accept `#call(env, status, headers, error)` and are invoked after the response is finished (either successfully or unsucessfully).
|
38
|
+
- It is okay to call `#close` on `rack.input` to indicate that you no longer need or care about the input.
|
39
|
+
- The stream argument supplied to the streaming body and hijack must support `#<<` for writing output.
|
35
40
|
|
36
|
-
|
41
|
+
### Removed
|
37
42
|
|
38
|
-
|
43
|
+
- Remove `rack.multithread`/`rack.multiprocess`/`rack.run_once`. These variables generally come too late to be useful. ([#1720](https://github.com/rack/rack/pull/1720), [@ioquatix], [@jeremyevans]))
|
44
|
+
- Remove deprecated Rack::Request::SCHEME_WHITELIST. ([@jeremyevans])
|
45
|
+
- Remove internal cookie deletion using pattern matching, there are very few practical cases where it would be useful and browsers handle it correctly without us doing anything special. ([#1844](https://github.com/rack/rack/pull/1844), [@ioquatix])
|
46
|
+
- Remove `rack.version` as it comes too late to be useful. ([#1938](https://github.com/rack/rack/pull/1938), [@ioquatix])
|
47
|
+
- Extract `rackup` command, `Rack::Server`, `Rack::Handler` and related code into a separate gem. ([#1937](https://github.com/rack/rack/pull/1937), [@ioquatix])
|
39
48
|
|
40
|
-
|
41
|
-
- [CVE-2022-44572] Forbid control characters in attributes (also ReDoS)
|
49
|
+
### Added
|
42
50
|
|
43
|
-
|
51
|
+
- `Rack::Headers` added to support lower-case header keys. ([@jeremyevans])
|
52
|
+
- `Rack::Utils#set_cookie_header` now supports `escape_key: false` to avoid key escaping. ([@jeremyevans])
|
53
|
+
- `Rack::RewindableInput` supports size. ([@ahorek](https://github.com/ahorek))
|
54
|
+
- `Rack::RewindableInput::Middleware` added for making `rack.input` rewindable. ([@jeremyevans])
|
55
|
+
- The RFC 7239 Forwarded header is now supported and considered by default when looking for information on forwarding, falling back to the X-Forwarded-* headers. `Rack::Request.forwarded_priority` accessor has been added for configuring the priority of which header to check. ([#1423](https://github.com/rack/rack/issues/1423), [@jeremyevans])
|
56
|
+
- Allow response headers to contain array of values. ([#1598](https://github.com/rack/rack/issues/1598), [@ioquatix])
|
57
|
+
- Support callable body for explicit streaming support and clarify streaming response body behaviour. ([#1745](https://github.com/rack/rack/pull/1745), [@ioquatix], [#1748](https://github.com/rack/rack/pull/1748), [@wjordan])
|
58
|
+
- Allow `Rack::Builder#run` to take a block instead of an argument. ([#1942](https://github.com/rack/rack/pull/1942), [@ioquatix])
|
59
|
+
- Add `rack.response_finished` to `Rack::Lint`. ([#1802](https://github.com/rack/rack/pull/1802), [@BlakeWilliams], [#1952](https://github.com/rack/rack/pull/1952), [@ioquatix])
|
60
|
+
- The stream argument must implement `#<<`. ([#1959](https://github.com/rack/rack/pull/1959), [@ioquatix])
|
44
61
|
|
45
|
-
|
62
|
+
### Changed
|
46
63
|
|
47
|
-
|
64
|
+
- BREAKING CHANGE: Require `status` to be an Integer. ([#1662](https://github.com/rack/rack/pull/1662), [@olleolleolle](https://github.com/olleolleolle))
|
65
|
+
- BREAKING CHANGE: Query parsing now treats parameters without `=` as having the empty string value instead of nil value, to conform to the URL spec. ([#1696](https://github.com/rack/rack/issues/1696), [@jeremyevans])
|
66
|
+
- Relax validations around `Rack::Request#host` and `Rack::Request#hostname`. ([#1606](https://github.com/rack/rack/issues/1606), [@pvande](https://github.com/pvande))
|
67
|
+
- Removed antiquated handlers: FCGI, LSWS, SCGI, Thin. ([#1658](https://github.com/rack/rack/pull/1658), [@ioquatix])
|
68
|
+
- Removed options from `Rack::Builder.parse_file` and `Rack::Builder.load_file`. ([#1663](https://github.com/rack/rack/pull/1663), [@ioquatix])
|
69
|
+
- `Rack::HTTP_VERSION` has been removed and the `HTTP_VERSION` env setting is no longer set in the CGI and Webrick handlers. ([#970](https://github.com/rack/rack/issues/970), [@jeremyevans])
|
70
|
+
- `Rack::Request#[]` and `#[]=` now warn even in non-verbose mode. ([#1277](https://github.com/rack/rack/issues/1277), [@jeremyevans])
|
71
|
+
- Decrease default allowed parameter recursion level from 100 to 32. ([#1640](https://github.com/rack/rack/issues/1640), [@jeremyevans])
|
72
|
+
- Attempting to parse a multipart response with an empty body now raises Rack::Multipart::EmptyContentError. ([#1603](https://github.com/rack/rack/issues/1603), [@jeremyevans])
|
73
|
+
- `Rack::Utils.secure_compare` uses OpenSSL's faster implementation if available. ([#1711](https://github.com/rack/rack/pull/1711), [@bdewater](https://github.com/bdewater))
|
74
|
+
- `Rack::Request#POST` now caches an empty hash if input content type is not parseable. ([#749](https://github.com/rack/rack/pull/749), [@jeremyevans])
|
75
|
+
- BREAKING CHANGE: Updated `trusted_proxy?` to match full 127.0.0.0/8 network. ([#1781](https://github.com/rack/rack/pull/1781), [@snbloch](https://github.com/snbloch))
|
76
|
+
- Explicitly deprecate `Rack::File` which was an alias for `Rack::Files`. ([#1811](https://github.com/rack/rack/pull/1720), [@ioquatix]).
|
77
|
+
- Moved `Rack::Session` into [separate gem](https://github.com/rack/rack-session). ([#1805](https://github.com/rack/rack/pull/1805), [@ioquatix])
|
78
|
+
- `rackup -D` option to daemonizes no longer changes the working directory to the root. ([#1813](https://github.com/rack/rack/pull/1813), [@jeremyevans])
|
79
|
+
- The `x-forwarded-proto` header is now considered before the `x-forwarded-scheme` header for determining the forwarded protocol. `Rack::Request.x_forwarded_proto_priority` accessor has been added for configuring the priority of which header to check. ([#1809](https://github.com/rack/rack/issues/1809), [@jeremyevans])
|
80
|
+
- `Rack::Request.forwarded_authority` (and methods that call it, such as `host`) now returns the last authority in the forwarded header, instead of the first, as earlier forwarded authorities can be forged by clients. This restores the Rack 2.1 behavior. ([#1829](https://github.com/rack/rack/issues/1809), [@jeremyevans])
|
81
|
+
- Use lower case cookie attributes when creating cookies, and fold cookie attributes to lower case when reading cookies (specifically impacting `secure` and `httponly` attributes). ([#1849](https://github.com/rack/rack/pull/1849), [@ioquatix])
|
82
|
+
- The response array must now be mutable (non-frozen) so middleware can modify it without allocating a new Array,therefore reducing object allocations. ([#1887](https://github.com/rack/rack/pull/1887), [#1927](https://github.com/rack/rack/pull/1927), [@amatsuda], [@ioquatix])
|
83
|
+
- `rack.hijack?` (partial hijack) and `rack.hijack` (full hijack) are now independently optional. `rack.hijack_io` is no longer required/specified. ([#1939](https://github.com/rack/rack/pull/1939), [@ioquatix])
|
84
|
+
- Allow calling close on `rack.input`. ([#1956](https://github.com/rack/rack/pull/1956), [@ioquatix])
|
48
85
|
|
49
86
|
### Fixed
|
50
87
|
|
51
|
-
-
|
88
|
+
- Make Rack::MockResponse handle non-hash headers. ([#1629](https://github.com/rack/rack/issues/1629), [@jeremyevans])
|
89
|
+
- TempfileReaper now deletes temp files if application raises an exception. ([#1679](https://github.com/rack/rack/issues/1679), [@jeremyevans])
|
90
|
+
- Handle cookies with values that end in '=' ([#1645](https://github.com/rack/rack/pull/1645), [@lukaso](https://github.com/lukaso))
|
91
|
+
- Make `Rack::NullLogger` respond to `#fatal!` [@jeremyevans])
|
92
|
+
- Fix multipart filename generation for filenames that contain spaces. Encode spaces as "%20" instead of "+" which will be decoded properly by the multipart parser. ([#1736](https://github.com/rack/rack/pull/1645), [@muirdm](https://github.com/muirdm))
|
93
|
+
- `Rack::Request#scheme` returns `ws` or `wss` when one of the `X-Forwarded-Scheme` / `X-Forwarded-Proto` headers is set to `ws` or `wss`, respectively. ([#1730](https://github.com/rack/rack/issues/1730), [@erwanst](https://github.com/erwanst))
|
52
94
|
|
53
95
|
## [2.2.4] - 2022-06-30
|
54
96
|
|
@@ -57,23 +99,21 @@ All notable changes to this project will be documented in this file. For info on
|
|
57
99
|
|
58
100
|
## [2.2.3.1] - 2022-05-27
|
59
101
|
|
60
|
-
### Security
|
61
|
-
|
62
102
|
- [CVE-2022-30123] Fix shell escaping issue in Common Logger
|
63
103
|
- [CVE-2022-30122] Restrict parsing of broken MIME attachments
|
64
104
|
|
65
|
-
## [2.2.3] - 2020-
|
105
|
+
## [2.2.3] - 2020-06-15
|
66
106
|
|
67
107
|
### Security
|
68
108
|
|
69
|
-
- [CVE-2020-8184]
|
109
|
+
- [[CVE-2020-8184](https://nvd.nist.gov/vuln/detail/CVE-2020-8184)] Do not allow percent-encoded cookie name to override existing cookie names. BREAKING CHANGE: Accessing cookie names that require URL encoding with decoded name no longer works. ([@fletchto99](https://github.com/fletchto99))
|
70
110
|
|
71
111
|
## [2.2.2] - 2020-02-11
|
72
112
|
|
73
113
|
### Fixed
|
74
114
|
|
75
|
-
- Fix incorrect `Rack::Request#host` value. ([#1591](https://github.com/rack/rack/pull/1591), [@ioquatix]
|
76
|
-
- Revert `Rack::Handler::Thin` implementation. ([#1583](https://github.com/rack/rack/pull/1583), [@jeremyevans]
|
115
|
+
- Fix incorrect `Rack::Request#host` value. ([#1591](https://github.com/rack/rack/pull/1591), [@ioquatix])
|
116
|
+
- Revert `Rack::Handler::Thin` implementation. ([#1583](https://github.com/rack/rack/pull/1583), [@jeremyevans])
|
77
117
|
- Double assignment is still needed to prevent an "unused variable" warning. ([#1589](https://github.com/rack/rack/pull/1589), [@kamipo](https://github.com/kamipo))
|
78
118
|
- Fix to handle same_site option for session pool. ([#1587](https://github.com/rack/rack/pull/1587), [@kamipo](https://github.com/kamipo))
|
79
119
|
|
@@ -81,105 +121,111 @@ All notable changes to this project will be documented in this file. For info on
|
|
81
121
|
|
82
122
|
### Fixed
|
83
123
|
|
84
|
-
- Rework `Rack::Request#ip` to handle empty `forwarded_for`. ([#1577](https://github.com/rack/rack/pull/1577), [@ioquatix]
|
124
|
+
- Rework `Rack::Request#ip` to handle empty `forwarded_for`. ([#1577](https://github.com/rack/rack/pull/1577), [@ioquatix])
|
85
125
|
|
86
126
|
## [2.2.0] - 2020-02-08
|
87
127
|
|
88
128
|
### SPEC Changes
|
89
129
|
|
90
|
-
- `rack.session` request environment entry must respond to `to_hash` and return unfrozen Hash. ([@jeremyevans]
|
91
|
-
- Request environment cannot be frozen. ([@jeremyevans]
|
92
|
-
- CGI values in the request environment with non-ASCII characters must use ASCII-8BIT encoding. ([@jeremyevans]
|
93
|
-
- Improve SPEC/lint relating to SERVER_NAME, SERVER_PORT and HTTP_HOST. ([#1561](https://github.com/rack/rack/pull/1561), [@ioquatix]
|
130
|
+
- `rack.session` request environment entry must respond to `to_hash` and return unfrozen Hash. ([@jeremyevans])
|
131
|
+
- Request environment cannot be frozen. ([@jeremyevans])
|
132
|
+
- CGI values in the request environment with non-ASCII characters must use ASCII-8BIT encoding. ([@jeremyevans])
|
133
|
+
- Improve SPEC/lint relating to SERVER_NAME, SERVER_PORT and HTTP_HOST. ([#1561](https://github.com/rack/rack/pull/1561), [@ioquatix])
|
94
134
|
|
95
135
|
### Added
|
96
136
|
|
97
|
-
- `rackup` supports multiple `-r` options and will require all arguments. ([@jeremyevans]
|
137
|
+
- `rackup` supports multiple `-r` options and will require all arguments. ([@jeremyevans])
|
98
138
|
- `Server` supports an array of paths to require for the `:require` option. ([@khotta](https://github.com/khotta))
|
99
139
|
- `Files` supports multipart range requests. ([@fatkodima](https://github.com/fatkodima))
|
100
|
-
- `Multipart::UploadedFile` supports an IO-like object instead of using the filesystem, using `:filename` and `:io` options. ([@jeremyevans]
|
101
|
-
- `Multipart::UploadedFile` supports keyword arguments `:path`, `:content_type`, and `:binary` in addition to positional arguments. ([@jeremyevans]
|
102
|
-
- `Static` supports a `:cascade` option for calling the app if there is no matching file. ([@jeremyevans]
|
103
|
-
- `Session::Abstract::SessionHash#dig`. ([@jeremyevans]
|
104
|
-
- `Response.[]` and `MockResponse.[]` for creating instances using status, headers, and body. ([@ioquatix]
|
105
|
-
- Convenient cache and content type methods for `Rack::Response`. ([#1555](https://github.com/rack/rack/pull/1555), [@ioquatix]
|
140
|
+
- `Multipart::UploadedFile` supports an IO-like object instead of using the filesystem, using `:filename` and `:io` options. ([@jeremyevans])
|
141
|
+
- `Multipart::UploadedFile` supports keyword arguments `:path`, `:content_type`, and `:binary` in addition to positional arguments. ([@jeremyevans])
|
142
|
+
- `Static` supports a `:cascade` option for calling the app if there is no matching file. ([@jeremyevans])
|
143
|
+
- `Session::Abstract::SessionHash#dig`. ([@jeremyevans])
|
144
|
+
- `Response.[]` and `MockResponse.[]` for creating instances using status, headers, and body. ([@ioquatix])
|
145
|
+
- Convenient cache and content type methods for `Rack::Response`. ([#1555](https://github.com/rack/rack/pull/1555), [@ioquatix])
|
106
146
|
|
107
147
|
### Changed
|
108
148
|
|
109
|
-
- `Request#params` no longer rescues EOFError. ([@jeremyevans]
|
110
|
-
- `Directory` uses a streaming approach, significantly improving time to first byte for large directories. ([@jeremyevans]
|
111
|
-
- `Directory` no longer includes a Parent directory link in the root directory index. ([@jeremyevans]
|
112
|
-
- `QueryParser#parse_nested_query` uses original backtrace when reraising exception with new class. ([@jeremyevans]
|
113
|
-
- `ConditionalGet` follows RFC 7232 precedence if both If-None-Match and If-Modified-Since headers are provided. ([@jeremyevans]
|
149
|
+
- `Request#params` no longer rescues EOFError. ([@jeremyevans])
|
150
|
+
- `Directory` uses a streaming approach, significantly improving time to first byte for large directories. ([@jeremyevans])
|
151
|
+
- `Directory` no longer includes a Parent directory link in the root directory index. ([@jeremyevans])
|
152
|
+
- `QueryParser#parse_nested_query` uses original backtrace when reraising exception with new class. ([@jeremyevans])
|
153
|
+
- `ConditionalGet` follows RFC 7232 precedence if both If-None-Match and If-Modified-Since headers are provided. ([@jeremyevans])
|
114
154
|
- `.ru` files supports the `frozen-string-literal` magic comment. ([@eregon](https://github.com/eregon))
|
115
|
-
- Rely on autoload to load constants instead of requiring internal files, make sure to require 'rack' and not just 'rack/...'. ([@jeremyevans]
|
116
|
-
- `Etag` will continue sending ETag even if the response should not be cached. ([@henm](https://github.com/henm))
|
155
|
+
- Rely on autoload to load constants instead of requiring internal files, make sure to require 'rack' and not just 'rack/...'. ([@jeremyevans])
|
156
|
+
- BREAKING CHANGE: `Etag` will continue sending ETag even if the response should not be cached. Streaming no longer works without a workaround, see [#1619](https://github.com/rack/rack/issues/1619#issuecomment-848460528). ([@henm](https://github.com/henm))
|
117
157
|
- `Request#host_with_port` no longer includes a colon for a missing or empty port. ([@AlexWayfer](https://github.com/AlexWayfer))
|
118
|
-
- All handlers uses keywords arguments instead of an options hash argument. ([@ioquatix]
|
119
|
-
- `Files` handling of range requests no longer return a body that supports `to_path`, to ensure range requests are handled correctly. ([@jeremyevans]
|
120
|
-
- `Multipart::Generator` only includes `Content-Length` for files with paths, and `Content-Disposition` `filename` if the `UploadedFile` instance has one. ([@jeremyevans]
|
121
|
-
- `Request#ssl?` is true for the `wss` scheme (secure websockets). ([@jeremyevans]
|
122
|
-
- `Rack::HeaderHash` is memoized by default. ([#1549](https://github.com/rack/rack/pull/1549), [@ioquatix]
|
158
|
+
- All handlers uses keywords arguments instead of an options hash argument. ([@ioquatix])
|
159
|
+
- `Files` handling of range requests no longer return a body that supports `to_path`, to ensure range requests are handled correctly. ([@jeremyevans])
|
160
|
+
- `Multipart::Generator` only includes `Content-Length` for files with paths, and `Content-Disposition` `filename` if the `UploadedFile` instance has one. ([@jeremyevans])
|
161
|
+
- `Request#ssl?` is true for the `wss` scheme (secure websockets). ([@jeremyevans])
|
162
|
+
- `Rack::HeaderHash` is memoized by default. ([#1549](https://github.com/rack/rack/pull/1549), [@ioquatix])
|
123
163
|
- `Rack::Directory` allow directory traversal inside root directory. ([#1417](https://github.com/rack/rack/pull/1417), [@ThomasSevestre](https://github.com/ThomasSevestre))
|
124
|
-
- Sort encodings by server preference. ([#1184](https://github.com/rack/rack/pull/1184), [@ioquatix]
|
125
|
-
- Rework host/hostname/authority implementation in `Rack::Request`. `#host` and `#host_with_port` have been changed to correctly return IPv6 addresses formatted with square brackets, as defined by [RFC3986](https://tools.ietf.org/html/rfc3986#section-3.2.2). ([#1561](https://github.com/rack/rack/pull/1561), [@ioquatix]
|
126
|
-
- `Rack::Builder` parsing options on first `#\` line is deprecated. ([#1574](https://github.com/rack/rack/pull/1574), [@ioquatix]
|
164
|
+
- Sort encodings by server preference. ([#1184](https://github.com/rack/rack/pull/1184), [@ioquatix], [@wjordan](https://github.com/wjordan))
|
165
|
+
- Rework host/hostname/authority implementation in `Rack::Request`. `#host` and `#host_with_port` have been changed to correctly return IPv6 addresses formatted with square brackets, as defined by [RFC3986](https://tools.ietf.org/html/rfc3986#section-3.2.2). ([#1561](https://github.com/rack/rack/pull/1561), [@ioquatix])
|
166
|
+
- `Rack::Builder` parsing options on first `#\` line is deprecated. ([#1574](https://github.com/rack/rack/pull/1574), [@ioquatix])
|
127
167
|
|
128
168
|
### Removed
|
129
169
|
|
130
|
-
- `Directory#path` as it was not used and always returned nil. ([@jeremyevans]
|
131
|
-
- `BodyProxy#each` as it was only needed to work around a bug in Ruby <1.9.3. ([@jeremyevans]
|
170
|
+
- `Directory#path` as it was not used and always returned nil. ([@jeremyevans])
|
171
|
+
- `BodyProxy#each` as it was only needed to work around a bug in Ruby <1.9.3. ([@jeremyevans])
|
132
172
|
- `URLMap::INFINITY` and `URLMap::NEGATIVE_INFINITY`, in favor of `Float::INFINITY`. ([@ch1c0t](https://github.com/ch1c0t))
|
133
173
|
- Deprecation of `Rack::File`. It will be deprecated again in rack 2.2 or 3.0. ([@rafaelfranca](https://github.com/rafaelfranca))
|
134
|
-
- Support for Ruby 2.2 as it is well past EOL. ([@ioquatix]
|
135
|
-
- Remove `Rack::Files#response_body` as the implementation was broken. ([#1153](https://github.com/rack/rack/pull/1153), [@ioquatix]
|
136
|
-
- Remove `SERVER_ADDR` which was never part of the original SPEC. ([#1573](https://github.com/rack/rack/pull/1573), [@ioquatix]
|
174
|
+
- Support for Ruby 2.2 as it is well past EOL. ([@ioquatix])
|
175
|
+
- Remove `Rack::Files#response_body` as the implementation was broken. ([#1153](https://github.com/rack/rack/pull/1153), [@ioquatix])
|
176
|
+
- Remove `SERVER_ADDR` which was never part of the original SPEC. ([#1573](https://github.com/rack/rack/pull/1573), [@ioquatix])
|
137
177
|
|
138
178
|
### Fixed
|
139
179
|
|
140
|
-
- `Directory` correctly handles root paths containing glob metacharacters. ([@jeremyevans]
|
141
|
-
- `Cascade` uses a new response object for each call if initialized with no apps. ([@jeremyevans]
|
142
|
-
- `BodyProxy` correctly delegates keyword arguments to the body object on Ruby 2.7+. ([@jeremyevans]
|
143
|
-
- `BodyProxy#method` correctly handles methods delegated to the body object. ([@jeremyevans]
|
180
|
+
- `Directory` correctly handles root paths containing glob metacharacters. ([@jeremyevans])
|
181
|
+
- `Cascade` uses a new response object for each call if initialized with no apps. ([@jeremyevans])
|
182
|
+
- `BodyProxy` correctly delegates keyword arguments to the body object on Ruby 2.7+. ([@jeremyevans])
|
183
|
+
- `BodyProxy#method` correctly handles methods delegated to the body object. ([@jeremyevans])
|
144
184
|
- `Request#host` and `Request#host_with_port` handle IPv6 addresses correctly. ([@AlexWayfer](https://github.com/AlexWayfer))
|
145
|
-
- `Lint` checks when response hijacking that `rack.hijack` is called with a valid object. ([@jeremyevans]
|
146
|
-
- `Response#write` correctly updates `Content-Length` if initialized with a body. ([@jeremyevans]
|
185
|
+
- `Lint` checks when response hijacking that `rack.hijack` is called with a valid object. ([@jeremyevans])
|
186
|
+
- `Response#write` correctly updates `Content-Length` if initialized with a body. ([@jeremyevans])
|
147
187
|
- `CommonLogger` includes `SCRIPT_NAME` when logging. ([@Erol](https://github.com/Erol))
|
148
|
-
- `Utils.parse_nested_query` correctly handles empty queries, using an empty instance of the params class instead of a hash. ([@jeremyevans]
|
188
|
+
- `Utils.parse_nested_query` correctly handles empty queries, using an empty instance of the params class instead of a hash. ([@jeremyevans])
|
149
189
|
- `Directory` correctly escapes paths in links. ([@yous](https://github.com/yous))
|
150
|
-
- `Request#delete_cookie` and related `Utils` methods handle `:domain` and `:path` options in same call. ([@jeremyevans]
|
151
|
-
- `Request#delete_cookie` and related `Utils` methods do an exact match on `:domain` and `:path` options. ([@jeremyevans]
|
190
|
+
- `Request#delete_cookie` and related `Utils` methods handle `:domain` and `:path` options in same call. ([@jeremyevans])
|
191
|
+
- `Request#delete_cookie` and related `Utils` methods do an exact match on `:domain` and `:path` options. ([@jeremyevans])
|
152
192
|
- `Static` no longer adds headers when a gzipped file request has a 304 response. ([@chooh](https://github.com/chooh))
|
153
|
-
- `ContentLength` sets `Content-Length` response header even for bodies not responding to `to_ary`. ([@jeremyevans]
|
154
|
-
- Thin handler supports options passed directly to `Thin::Controllers::Controller`. ([@jeremyevans]
|
155
|
-
- WEBrick handler no longer ignores `:BindAddress` option. ([@jeremyevans]
|
156
|
-
- `ShowExceptions` handles invalid POST data. ([@jeremyevans]
|
157
|
-
- Basic authentication requires a password, even if the password is empty. ([@jeremyevans]
|
158
|
-
- `Lint` checks response is array with 3 elements, per SPEC. ([@jeremyevans]
|
193
|
+
- `ContentLength` sets `Content-Length` response header even for bodies not responding to `to_ary`. ([@jeremyevans])
|
194
|
+
- Thin handler supports options passed directly to `Thin::Controllers::Controller`. ([@jeremyevans])
|
195
|
+
- WEBrick handler no longer ignores `:BindAddress` option. ([@jeremyevans])
|
196
|
+
- `ShowExceptions` handles invalid POST data. ([@jeremyevans])
|
197
|
+
- Basic authentication requires a password, even if the password is empty. ([@jeremyevans])
|
198
|
+
- `Lint` checks response is array with 3 elements, per SPEC. ([@jeremyevans])
|
159
199
|
- Support for using `:SSLEnable` option when using WEBrick handler. (Gregor Melhorn)
|
160
|
-
- Close response body after buffering it when buffering. ([@ioquatix]
|
200
|
+
- Close response body after buffering it when buffering. ([@ioquatix])
|
161
201
|
- Only accept `;` as delimiter when parsing cookies. ([@mrageh](https://github.com/mrageh))
|
162
|
-
- `Utils::HeaderHash#clear` clears the name mapping as well. ([@raxoft](https://github.com/raxoft))
|
163
|
-
- Support for passing `nil` `Rack::Files.new`, which notably fixes Rails' current `ActiveStorage::FileServer` implementation. ([@ioquatix]
|
202
|
+
- `Utils::HeaderHash#clear` clears the name mapping as well. ([@raxoft](https://github.com/raxoft))
|
203
|
+
- Support for passing `nil` `Rack::Files.new`, which notably fixes Rails' current `ActiveStorage::FileServer` implementation. ([@ioquatix])
|
164
204
|
|
165
205
|
### Documentation
|
166
206
|
|
167
207
|
- CHANGELOG updates. ([@aupajo](https://github.com/aupajo))
|
168
208
|
- Added [CONTRIBUTING](CONTRIBUTING.md). ([@dblock](https://github.com/dblock))
|
169
209
|
|
210
|
+
## [2.0.9] - 2020-02-08
|
211
|
+
|
212
|
+
- Handle case where session id key is requested but missing ([@jeremyevans])
|
213
|
+
- Restore support for code relying on `SessionId#to_s`. ([@jeremyevans])
|
214
|
+
- Add support for `SameSite=None` cookie value. ([@hennikul](https://github.com/hennikul))
|
215
|
+
|
170
216
|
## [2.1.2] - 2020-01-27
|
171
217
|
|
172
218
|
- Fix multipart parser for some files to prevent denial of service ([@aiomaster](https://github.com/aiomaster))
|
173
219
|
- Fix `Rack::Builder#use` with keyword arguments ([@kamipo](https://github.com/kamipo))
|
174
|
-
- Skip deflating in Rack::Deflater if Content-Length is 0 ([@jeremyevans]
|
220
|
+
- Skip deflating in Rack::Deflater if Content-Length is 0 ([@jeremyevans])
|
175
221
|
- Remove `SessionHash#transform_keys`, no longer needed ([@pavel](https://github.com/pavel))
|
176
222
|
- Add to_hash to wrap Hash and Session classes ([@oleh-demyanyuk](https://github.com/oleh-demyanyuk))
|
177
|
-
- Handle case where session id key is requested but missing ([@jeremyevans]
|
223
|
+
- Handle case where session id key is requested but missing ([@jeremyevans])
|
178
224
|
|
179
225
|
## [2.1.1] - 2020-01-12
|
180
226
|
|
181
|
-
- Remove `Rack::Chunked` from `Rack::Server` default middleware. ([#1475](https://github.com/rack/rack/pull/1475), [@ioquatix]
|
182
|
-
- Restore support for code relying on `SessionId#to_s`. ([@jeremyevans]
|
227
|
+
- Remove `Rack::Chunked` from `Rack::Server` default middleware. ([#1475](https://github.com/rack/rack/pull/1475), [@ioquatix])
|
228
|
+
- Restore support for code relying on `SessionId#to_s`. ([@jeremyevans])
|
183
229
|
|
184
230
|
## [2.1.0] - 2020-01-10
|
185
231
|
|
@@ -196,13 +242,13 @@ All notable changes to this project will be documented in this file. For info on
|
|
196
242
|
- Add boot-time profiling capabilities to `rackup`. ([@tenderlove](https://github.com/tenderlove))
|
197
243
|
- Add multi mapping support for `X-Accel-Mappings` header. ([@yoshuki](https://github.com/yoshuki))
|
198
244
|
- Add `sync: false` option to `Rack::Deflater`. (Eric Wong)
|
199
|
-
- Add `Builder#freeze_app` to freeze application and all middleware instances. ([@jeremyevans]
|
245
|
+
- Add `Builder#freeze_app` to freeze application and all middleware instances. ([@jeremyevans])
|
200
246
|
- Add API to extract cookies from `Rack::MockResponse`. ([@petercline](https://github.com/petercline))
|
201
247
|
|
202
248
|
### Changed
|
203
249
|
|
204
|
-
- Don't propagate nil values from middleware. ([@ioquatix]
|
205
|
-
- Lazily initialize the response body and only buffer it if required. ([@ioquatix]
|
250
|
+
- Don't propagate nil values from middleware. ([@ioquatix])
|
251
|
+
- Lazily initialize the response body and only buffer it if required. ([@ioquatix])
|
206
252
|
- Fix deflater zlib buffer errors on empty body part. ([@felixbuenemann](https://github.com/felixbuenemann))
|
207
253
|
- Set `X-Accel-Redirect` to percent-encoded path. ([@diskkid](https://github.com/diskkid))
|
208
254
|
- Remove unnecessary buffer growing when parsing multipart. ([@tainoe](https://github.com/tainoe))
|
@@ -215,15 +261,15 @@ All notable changes to this project will be documented in this file. For info on
|
|
215
261
|
- Make `Utils.status_code` raise an error when the status symbol is invalid instead of `500`. ([@adambutler](https://github.com/adambutler))
|
216
262
|
- Rename `Request::SCHEME_WHITELIST` to `Request::ALLOWED_SCHEMES`.
|
217
263
|
- Make `Multipart::Parser.get_filename` accept files with `+` in their name. ([@lucaskanashiro](https://github.com/lucaskanashiro))
|
218
|
-
- Add Falcon to the default handler fallbacks. ([@ioquatix]
|
264
|
+
- Add Falcon to the default handler fallbacks. ([@ioquatix])
|
219
265
|
- Update codebase to avoid string mutations in preparation for `frozen_string_literals`. ([@pat](https://github.com/pat))
|
220
266
|
- Change `MockRequest#env_for` to rely on the input optionally responding to `#size` instead of `#length`. ([@janko](https://github.com/janko))
|
221
|
-
- Rename `Rack::File` -> `Rack::Files` and add deprecation notice. ([@postmodern](https://github.com/postmodern))
|
222
|
-
- Prefer Base64 “strict encoding” for Base64 cookies. ([@ioquatix]
|
267
|
+
- Rename `Rack::File` -> `Rack::Files` and add deprecation notice. ([@postmodern](https://github.com/postmodern))
|
268
|
+
- Prefer Base64 “strict encoding” for Base64 cookies. ([@ioquatix])
|
223
269
|
|
224
270
|
### Removed
|
225
271
|
|
226
|
-
- Remove `to_ary` from Response ([@tenderlove](https://github.com/tenderlove))
|
272
|
+
- BREAKING CHANGE: Remove `to_ary` from Response ([@tenderlove](https://github.com/tenderlove))
|
227
273
|
- Deprecate `Rack::Session::Memcache` in favor of `Rack::Session::Dalli` from dalli gem ([@fatkodima](https://github.com/fatkodima))
|
228
274
|
|
229
275
|
### Fixed
|
@@ -304,7 +350,7 @@ All notable changes to this project will be documented in this file. For info on
|
|
304
350
|
### Added
|
305
351
|
|
306
352
|
- Allow `Session::Abstract::SessionHash#fetch` to accept a block with a default value. ([@yannvanhalewyn](https://github.com/yannvanhalewyn))
|
307
|
-
- Add `Builder#freeze_app` to freeze application and all middleware. ([@jeremyevans]
|
353
|
+
- Add `Builder#freeze_app` to freeze application and all middleware. ([@jeremyevans])
|
308
354
|
|
309
355
|
### Changed
|
310
356
|
|
@@ -316,9 +362,9 @@ All notable changes to this project will be documented in this file. For info on
|
|
316
362
|
### Fixed
|
317
363
|
|
318
364
|
- Handle `NULL` bytes in multipart filenames. ([@casperisfine](https://github.com/casperisfine))
|
319
|
-
- Remove warnings due to miscapitalized global. ([@ioquatix]
|
365
|
+
- Remove warnings due to miscapitalized global. ([@ioquatix])
|
320
366
|
- Prevent exceptions caused by a race condition on multi-threaded servers. ([@sophiedeziel](https://github.com/sophiedeziel))
|
321
|
-
- Add RDoc as an explicit
|
367
|
+
- Add RDoc as an explicit dependency for `doc` group. ([@tonytonyjan](https://github.com/tonytonyjan))
|
322
368
|
- Record errors originating from `Multipart::Parser` in the `MethodOverride` middleware instead of letting them bubble up. ([@carlzulauf](https://github.com/carlzulauf))
|
323
369
|
- Remove remaining use of removed `Utils#bytesize` method from the `File` middleware. ([@brauliomartinezlm](https://github.com/brauliomartinezlm))
|
324
370
|
|
@@ -636,7 +682,7 @@ Items below this line are from the previously maintained HISTORY.md and NEWS.md
|
|
636
682
|
- Moved Auth::OpenID to rack-contrib.
|
637
683
|
- SPEC change that relaxes Lint slightly to allow subclasses of the
|
638
684
|
required types
|
639
|
-
- SPEC change to document rack.input binary mode in
|
685
|
+
- SPEC change to document rack.input binary mode in greater detail
|
640
686
|
- SPEC define optional rack.logger specification
|
641
687
|
- File servers support X-Cascade header
|
642
688
|
- Imported Config middleware
|
@@ -754,3 +800,9 @@ Items below this line are from the previously maintained HISTORY.md and NEWS.md
|
|
754
800
|
- Removed Rails adapter, was too alpha.
|
755
801
|
|
756
802
|
## [0.1] 2007-03-03
|
803
|
+
|
804
|
+
[@ioquatix]: https://github.com/ioquatix "Samuel Williams"
|
805
|
+
[@jeremyevans]: https://github.com/jeremyevans "Jeremy Evans"
|
806
|
+
[@amatsuda]: https://github.com/amatsuda "Akira Matsuda"
|
807
|
+
[@wjordan]: https://github.com/wjordan "Will Jordan"
|
808
|
+
[@BlakeWilliams]: https://github.com/BlakeWilliams "Blake Williams"
|
data/CONTRIBUTING.md
CHANGED
@@ -1,29 +1,33 @@
|
|
1
|
-
Contributing to Rack
|
2
|
-
=====================
|
1
|
+
# Contributing to Rack
|
3
2
|
|
4
|
-
Rack is work of [hundreds of
|
3
|
+
Rack is work of [hundreds of
|
4
|
+
contributors](https://github.com/rack/rack/graphs/contributors). You're
|
5
|
+
encouraged to submit [pull requests](https://github.com/rack/rack/pulls) and
|
6
|
+
[propose features and discuss issues](https://github.com/rack/rack/issues).
|
5
7
|
|
6
|
-
|
8
|
+
## Fork the Project
|
7
9
|
|
8
|
-
Fork the [project on
|
10
|
+
Fork the [project on GitHub](https://github.com/rack/rack) and check out your
|
11
|
+
copy.
|
9
12
|
|
10
13
|
```
|
11
|
-
git clone https://github.com/
|
14
|
+
git clone https://github.com/(your-github-username)/rack.git
|
12
15
|
cd rack
|
13
16
|
git remote add upstream https://github.com/rack/rack.git
|
14
17
|
```
|
15
18
|
|
16
|
-
|
19
|
+
## Create a Topic Branch
|
17
20
|
|
18
|
-
Make sure your fork is up-to-date and create a topic branch for your feature or
|
21
|
+
Make sure your fork is up-to-date and create a topic branch for your feature or
|
22
|
+
bug fix.
|
19
23
|
|
20
24
|
```
|
21
|
-
git checkout
|
22
|
-
git pull upstream
|
25
|
+
git checkout main
|
26
|
+
git pull upstream main
|
23
27
|
git checkout -b my-feature-branch
|
24
28
|
```
|
25
29
|
|
26
|
-
|
30
|
+
## Bundle Install and Quick Test
|
27
31
|
|
28
32
|
Ensure that you can build the project and run quick tests.
|
29
33
|
|
@@ -32,7 +36,7 @@ bundle install --without extra
|
|
32
36
|
bundle exec rake test
|
33
37
|
```
|
34
38
|
|
35
|
-
|
39
|
+
## Running All Tests
|
36
40
|
|
37
41
|
Install all dependencies.
|
38
42
|
|
@@ -46,39 +50,33 @@ Run all tests.
|
|
46
50
|
rake test
|
47
51
|
```
|
48
52
|
|
49
|
-
|
53
|
+
## Write Tests
|
50
54
|
|
51
|
-
|
55
|
+
Try to write a test that reproduces the problem you're trying to fix or
|
56
|
+
describes a feature that you want to build.
|
52
57
|
|
53
|
-
|
58
|
+
We definitely appreciate pull requests that highlight or reproduce a problem,
|
59
|
+
even without a fix.
|
54
60
|
|
55
|
-
|
56
|
-
* dalli
|
57
|
-
* thin
|
58
|
-
|
59
|
-
To test Memcache sessions, you need memcached (will be run on port 11211) and dalli installed.
|
60
|
-
|
61
|
-
#### Write Tests
|
62
|
-
|
63
|
-
Try to write a test that reproduces the problem you're trying to fix or describes a feature that you want to build.
|
64
|
-
|
65
|
-
We definitely appreciate pull requests that highlight or reproduce a problem, even without a fix.
|
66
|
-
|
67
|
-
#### Write Code
|
61
|
+
## Write Code
|
68
62
|
|
69
63
|
Implement your feature or bug fix.
|
70
64
|
|
71
|
-
Make sure that
|
65
|
+
Make sure that all tests pass:
|
66
|
+
|
67
|
+
```
|
68
|
+
bundle exec rake test
|
69
|
+
```
|
72
70
|
|
73
|
-
|
71
|
+
## Write Documentation
|
74
72
|
|
75
|
-
Document any external behavior in the [README](README.
|
73
|
+
Document any external behavior in the [README](README.md).
|
76
74
|
|
77
|
-
|
75
|
+
## Update Changelog
|
78
76
|
|
79
77
|
Add a line to [CHANGELOG](CHANGELOG.md).
|
80
78
|
|
81
|
-
|
79
|
+
## Commit Changes
|
82
80
|
|
83
81
|
Make sure git knows your name and email address:
|
84
82
|
|
@@ -87,34 +85,37 @@ git config --global user.name "Your Name"
|
|
87
85
|
git config --global user.email "contributor@example.com"
|
88
86
|
```
|
89
87
|
|
90
|
-
Writing good commit logs is important. A commit log should describe what changed
|
88
|
+
Writing good commit logs is important. A commit log should describe what changed
|
89
|
+
and why.
|
91
90
|
|
92
91
|
```
|
93
92
|
git add ...
|
94
93
|
git commit
|
95
94
|
```
|
96
95
|
|
97
|
-
|
96
|
+
## Push
|
98
97
|
|
99
98
|
```
|
100
99
|
git push origin my-feature-branch
|
101
100
|
```
|
102
101
|
|
103
|
-
|
102
|
+
## Make a Pull Request
|
104
103
|
|
105
|
-
Go to
|
104
|
+
Go to your fork of rack on GitHub and select your feature branch. Click the
|
105
|
+
'Pull Request' button and fill out the form. Pull requests are usually
|
106
|
+
reviewed within a few days.
|
106
107
|
|
107
|
-
|
108
|
+
## Rebase
|
108
109
|
|
109
|
-
If you've been working on a change for a while, rebase with upstream/
|
110
|
+
If you've been working on a change for a while, rebase with upstream/main.
|
110
111
|
|
111
112
|
```
|
112
113
|
git fetch upstream
|
113
|
-
git rebase upstream/
|
114
|
+
git rebase upstream/main
|
114
115
|
git push origin my-feature-branch -f
|
115
116
|
```
|
116
117
|
|
117
|
-
|
118
|
+
## Make Required Changes
|
118
119
|
|
119
120
|
Amend your previous commit and force push the changes.
|
120
121
|
|
@@ -123,14 +124,19 @@ git commit --amend
|
|
123
124
|
git push origin my-feature-branch -f
|
124
125
|
```
|
125
126
|
|
126
|
-
|
127
|
+
## Check on Your Pull Request
|
127
128
|
|
128
|
-
Go back to your pull request after a few minutes and see whether it passed
|
129
|
+
Go back to your pull request after a few minutes and see whether it passed
|
130
|
+
tests with GitHub Actions. Everything should look green, otherwise fix issues and
|
131
|
+
amend your commit as described above.
|
129
132
|
|
130
|
-
|
133
|
+
## Be Patient
|
131
134
|
|
132
|
-
It's likely that your change will not be merged and that the nitpicky
|
135
|
+
It's likely that your change will not be merged and that the nitpicky
|
136
|
+
maintainers will ask you to do more, or fix seemingly benign problems. Hang in
|
137
|
+
there!
|
133
138
|
|
134
|
-
|
139
|
+
## Thank You
|
135
140
|
|
136
|
-
Please do know that we really appreciate and value your time and work. We love
|
141
|
+
Please do know that we really appreciate and value your time and work. We love
|
142
|
+
you, really.
|
data/MIT-LICENSE
CHANGED
@@ -1,6 +1,6 @@
|
|
1
1
|
The MIT License (MIT)
|
2
2
|
|
3
|
-
Copyright (C) 2007-
|
3
|
+
Copyright (C) 2007-2021 Leah Neukirchen <http://leahneukirchen.org/infopage.html>
|
4
4
|
|
5
5
|
Permission is hereby granted, free of charge, to any person obtaining a copy
|
6
6
|
of this software and associated documentation files (the "Software"), to
|