rack 1.6.13 → 2.0.9

data/test/spec_version.rb

@@ -1,17 +1,11 @@
 # -*- encoding: utf-8 -*-
+require 'minitest/autorun'
 require 'rack'
 
 describe Rack do
   describe 'version' do
     it 'defaults to a hard-coded api version' do
-      Rack.version.should.equal("1.3")
-    end
-  end
-  describe 'release' do
-    it 'matches version in .gemspec' do
-      gemspec_path = File.join(File.dirname(File.expand_path(__FILE__)), '../rack.gemspec')
-      gemspec = Gem::Specification.load(gemspec_path)
-      Rack.release.split('.').take(2).should.equal gemspec.version.to_s.split('.').take(2)
+      Rack.version.must_equal "1.3"
     end
   end
 end

data/test/spec_webrick.rb

@@ -1,92 +1,108 @@
+require 'minitest/autorun'
 require 'rack/mock'
+require 'thread'
 require File.expand_path('../testrequest', __FILE__)
 
 Thread.abort_on_exception = true
 
 describe Rack::Handler::WEBrick do
-  extend TestRequest::Helpers
+  include TestRequest::Helpers
 
+  before do
   @server = WEBrick::HTTPServer.new(:Host => @host='127.0.0.1',
                                     :Port => @port=9202,
                                     :Logger => WEBrick::Log.new(nil, WEBrick::BasicLog::WARN),
                                     :AccessLog => [])
   @server.mount "/test", Rack::Handler::WEBrick,
     Rack::Lint.new(TestRequest.new)
-  Thread.new { @server.start }
+  @thread = Thread.new { @server.start }
   trap(:INT) { @server.shutdown }
+  @status_thread = Thread.new do
+    seconds = 10
+    wait_time = 0.1
+    until is_running? || seconds <= 0
+      seconds -= wait_time
+      sleep wait_time
+    end
+    raise "Server never reached status 'Running'" unless is_running?
+  end
+  end
 
-  should "respond" do
-    lambda {
-      GET("/test")
-    }.should.not.raise
+  def is_running?
+    @server.status == :Running
+  end
+
+  it "respond" do
+    GET("/test")
+    status.must_equal 200
   end
 
-  should "be a WEBrick" do
+  it "be a WEBrick" do
     GET("/test")
-    status.should.equal 200
-    response["SERVER_SOFTWARE"].should =~ /WEBrick/
-    response["HTTP_VERSION"].should.equal "HTTP/1.1"
-    response["SERVER_PROTOCOL"].should.equal "HTTP/1.1"
-    response["SERVER_PORT"].should.equal "9202"
-    response["SERVER_NAME"].should.equal "127.0.0.1"
+    status.must_equal 200
+    response["SERVER_SOFTWARE"].must_match(/WEBrick/)
+    response["HTTP_VERSION"].must_equal "HTTP/1.1"
+    response["SERVER_PROTOCOL"].must_equal "HTTP/1.1"
+    response["SERVER_PORT"].must_equal "9202"
+    response["SERVER_NAME"].must_equal "127.0.0.1"
   end
 
-  should "have rack headers" do
+  it "have rack headers" do
     GET("/test")
-    response["rack.version"].should.equal [1,3]
-    response["rack.multithread"].should.be.true
-    response["rack.multiprocess"].should.be.false
-    response["rack.run_once"].should.be.false
+    response["rack.version"].must_equal [1,3]
+    response["rack.multithread"].must_equal true
+    assert_equal false, response["rack.multiprocess"]
+    assert_equal false, response["rack.run_once"]
   end
 
-  should "have CGI headers on GET" do
+  it "have CGI headers on GET" do
     GET("/test")
-    response["REQUEST_METHOD"].should.equal "GET"
-    response["SCRIPT_NAME"].should.equal "/test"
-    response["REQUEST_PATH"].should.equal "/test"
-    response["PATH_INFO"].should.be.equal ""
-    response["QUERY_STRING"].should.equal ""
-    response["test.postdata"].should.equal ""
+    response["REQUEST_METHOD"].must_equal "GET"
+    response["SCRIPT_NAME"].must_equal "/test"
+    response["REQUEST_PATH"].must_equal "/test"
+    response["PATH_INFO"].must_equal ""
+    response["QUERY_STRING"].must_equal ""
+    response["test.postdata"].must_equal ""
 
     GET("/test/foo?quux=1")
-    response["REQUEST_METHOD"].should.equal "GET"
-    response["SCRIPT_NAME"].should.equal "/test"
-    response["REQUEST_PATH"].should.equal "/test/foo"
-    response["PATH_INFO"].should.equal "/foo"
-    response["QUERY_STRING"].should.equal "quux=1"
+    response["REQUEST_METHOD"].must_equal "GET"
+    response["SCRIPT_NAME"].must_equal "/test"
+    response["REQUEST_PATH"].must_equal "/test/foo"
+    response["PATH_INFO"].must_equal "/foo"
+    response["QUERY_STRING"].must_equal "quux=1"
 
     GET("/test/foo%25encoding?quux=1")
-    response["REQUEST_METHOD"].should.equal "GET"
-    response["SCRIPT_NAME"].should.equal "/test"
-    response["REQUEST_PATH"].should.equal "/test/foo%25encoding"
-    response["PATH_INFO"].should.equal "/foo%25encoding"
-    response["QUERY_STRING"].should.equal "quux=1"
+    response["REQUEST_METHOD"].must_equal "GET"
+    response["SCRIPT_NAME"].must_equal "/test"
+    response["REQUEST_PATH"].must_equal "/test/foo%25encoding"
+    response["PATH_INFO"].must_equal "/foo%25encoding"
+    response["QUERY_STRING"].must_equal "quux=1"
   end
 
-  should "have CGI headers on POST" do
+  it "have CGI headers on POST" do
     POST("/test", {"rack-form-data" => "23"}, {'X-test-header' => '42'})
-    status.should.equal 200
-    response["REQUEST_METHOD"].should.equal "POST"
-    response["SCRIPT_NAME"].should.equal "/test"
-    response["REQUEST_PATH"].should.equal "/test"
-    response["PATH_INFO"].should.equal ""
-    response["QUERY_STRING"].should.equal ""
-    response["HTTP_X_TEST_HEADER"].should.equal "42"
-    response["test.postdata"].should.equal "rack-form-data=23"
+    status.must_equal 200
+    response["REQUEST_METHOD"].must_equal "POST"
+    response["SCRIPT_NAME"].must_equal "/test"
+    response["REQUEST_PATH"].must_equal "/test"
+    response["PATH_INFO"].must_equal ""
+    response["QUERY_STRING"].must_equal ""
+    response["HTTP_X_TEST_HEADER"].must_equal "42"
+    response["test.postdata"].must_equal "rack-form-data=23"
   end
 
-  should "support HTTP auth" do
+  it "support HTTP auth" do
     GET("/test", {:user => "ruth", :passwd => "secret"})
-    response["HTTP_AUTHORIZATION"].should.equal "Basic cnV0aDpzZWNyZXQ="
+    response["HTTP_AUTHORIZATION"].must_equal "Basic cnV0aDpzZWNyZXQ="
   end
 
-  should "set status" do
+  it "set status" do
     GET("/test?secret")
-    status.should.equal 403
-    response["rack.url_scheme"].should.equal "http"
+    status.must_equal 403
+    response["rack.url_scheme"].must_equal "http"
   end
 
-  should "correctly set cookies" do
+  it "correctly set cookies" do
     @server.mount "/cookie-test", Rack::Handler::WEBrick,
     Rack::Lint.new(lambda { |req|
                      res = Rack::Response.new
@@ -97,14 +113,15 @@ describe Rack::Handler::WEBrick do
 
     Net::HTTP.start(@host, @port) { |http|
       res = http.get("/cookie-test")
-      res.code.to_i.should.equal 200
-      res.get_fields("set-cookie").should.equal ["one=1", "two=2"]
+      res.code.to_i.must_equal 200
+      res.get_fields("set-cookie").must_equal ["one=1", "two=2"]
     }
   end
 
-  should "provide a .run" do
-    block_ran = false
-    catch(:done) {
+  it "provide a .run" do
+    queue = Queue.new
+
+    t = Thread.new do
       Rack::Handler::WEBrick.run(lambda {},
                                  {
                                    :Host => '127.0.0.1',
@@ -112,16 +129,17 @@ describe Rack::Handler::WEBrick do
                                    :Logger => WEBrick::Log.new(nil, WEBrick::BasicLog::WARN),
                                    :AccessLog => []}) { |server|
         block_ran = true
-        server.should.be.kind_of WEBrick::HTTPServer
-        @s = server
-        throw :done
+        assert_kind_of WEBrick::HTTPServer, server
+        queue.push(server)
       }
-    }
-    block_ran.should.be.true
-    @s.shutdown
+    end
+
+    server = queue.pop
+    server.shutdown
+    t.join
   end
 
-  should "return repeated headers" do
+  it "return repeated headers" do
     @server.mount "/headers", Rack::Handler::WEBrick,
     Rack::Lint.new(lambda { |req|
         [
@@ -134,12 +152,12 @@ describe Rack::Handler::WEBrick do
 
     Net::HTTP.start(@host, @port) { |http|
       res = http.get("/headers")
-      res.code.to_i.should.equal 401
-      res["www-authenticate"].should.equal "Bar realm=X, Baz realm=Y"
+      res.code.to_i.must_equal 401
+      res["www-authenticate"].must_equal "Bar realm=X, Baz realm=Y"
     }
   end
 
-  should "support Rack partial hijack" do
+  it "support Rack partial hijack" do
     io_lambda = lambda{ |io|
       5.times do
         io.write "David\r\n"
@@ -151,18 +169,18 @@ describe Rack::Handler::WEBrick do
     Rack::Lint.new(lambda{ |req|
       [
         200,
-        {"rack.hijack" => io_lambda},
+        [ [ "rack.hijack", io_lambda ] ],
         [""]
       ]
     })
 
     Net::HTTP.start(@host, @port){ |http|
       res = http.get("/partial")
-      res.body.should.equal "David\r\nDavid\r\nDavid\r\nDavid\r\nDavid\r\n"
+      res.body.must_equal "David\r\nDavid\r\nDavid\r\nDavid\r\nDavid\r\n"
     }
   end
 
-  should "produce correct HTTP semantics with and without app chunking" do
+  it "produce correct HTTP semantics with and without app chunking" do
     @server.mount "/chunked", Rack::Handler::WEBrick,
     Rack::Lint.new(lambda{ |req|
       [
@@ -174,11 +192,15 @@ describe Rack::Handler::WEBrick do
 
     Net::HTTP.start(@host, @port){ |http|
       res = http.get("/chunked")
-      res["Transfer-Encoding"].should.equal "chunked"
-      res["Content-Length"].should.equal nil
-      res.body.should.equal "chunked"
+      res["Transfer-Encoding"].must_equal "chunked"
+      res["Content-Length"].must_be_nil
+      res.body.must_equal "chunked"
     }
   end
 
+  after do
+  @status_thread.join
   @server.shutdown
+  @thread.join
+  end
 end

data/test/static/foo.html

@@ -0,0 +1 @@
+foo.html!

data/test/testrequest.rb

@@ -12,7 +12,7 @@ class TestRequest
     # This may in the future want to replace with a dummy value instead.
     minienv.delete_if { |k,v| NOSERIALIZE.any? { |c| v.kind_of?(c) } }
     body = minienv.to_yaml
-    size = body.respond_to?(:bytesize) ? body.bytesize : body.size
+    size = body.bytesize
     [status, {"Content-Type" => "text/yaml", "Content-Length" => size.to_s}, [body]]
   end
 

data/test/unregistered_handler/rack/handler/unregistered.rb

@@ -4,4 +4,4 @@ module Rack
     class Unregistered
     end
   end
-end
+end

data/test/unregistered_handler/rack/handler/unregistered_long_one.rb

@@ -4,4 +4,4 @@ module Rack
     class UnregisteredLongOne
     end
   end
-end
+end

metadata

@@ -1,17 +1,31 @@
 --- !ruby/object:Gem::Specification
 name: rack
 version: !ruby/object:Gem::Version
-  version: 1.6.13
+  version: 2.0.9
 platform: ruby
 authors:
-- Christian Neukirchen
+- Leah Neukirchen
 autorequire: 
 bindir: bin
 cert_chain: []
 date: 2020-02-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: bacon
+  name: minitest
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '5.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '5.0'
+- !ruby/object:Gem::Dependency
+  name: minitest-sprint
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -45,19 +59,17 @@ description: |
   servers, web frameworks, and software in between (the so-called
   middleware) into a single method call.
 
-  Also see http://rack.github.io/.
-email: chneukirchen@gmail.com
+  Also see https://rack.github.io/.
+email: leah@vuxu.org
 executables:
 - rackup
 extensions: []
 extra_rdoc_files:
 - README.rdoc
-- KNOWN-ISSUES
 - HISTORY.md
 files:
 - COPYING
 - HISTORY.md
-- KNOWN-ISSUES
 - README.rdoc
 - Rakefile
 - SPEC
@@ -77,30 +89,25 @@ files:
 - lib/rack/auth/digest/nonce.rb
 - lib/rack/auth/digest/params.rb
 - lib/rack/auth/digest/request.rb
-- lib/rack/backports/uri/common_18.rb
-- lib/rack/backports/uri/common_192.rb
-- lib/rack/backports/uri/common_193.rb
 - lib/rack/body_proxy.rb
 - lib/rack/builder.rb
 - lib/rack/cascade.rb
 - lib/rack/chunked.rb
-- lib/rack/commonlogger.rb
-- lib/rack/conditionalget.rb
+- lib/rack/common_logger.rb
+- lib/rack/conditional_get.rb
 - lib/rack/config.rb
 - lib/rack/content_length.rb
 - lib/rack/content_type.rb
 - lib/rack/deflater.rb
 - lib/rack/directory.rb
 - lib/rack/etag.rb
+- lib/rack/events.rb
 - lib/rack/file.rb
 - lib/rack/handler.rb
 - lib/rack/handler/cgi.rb
-- lib/rack/handler/evented_mongrel.rb
 - lib/rack/handler/fastcgi.rb
 - lib/rack/handler/lsws.rb
-- lib/rack/handler/mongrel.rb
 - lib/rack/handler/scgi.rb
-- lib/rack/handler/swiftiplied_mongrel.rb
 - lib/rack/handler/thin.rb
 - lib/rack/handler/webrick.rb
 - lib/rack/head.rb
@@ -108,14 +115,16 @@ files:
 - lib/rack/lobster.rb
 - lib/rack/lock.rb
 - lib/rack/logger.rb
-- lib/rack/methodoverride.rb
+- lib/rack/media_type.rb
+- lib/rack/method_override.rb
 - lib/rack/mime.rb
 - lib/rack/mock.rb
 - lib/rack/multipart.rb
 - lib/rack/multipart/generator.rb
 - lib/rack/multipart/parser.rb
 - lib/rack/multipart/uploaded_file.rb
-- lib/rack/nulllogger.rb
+- lib/rack/null_logger.rb
+- lib/rack/query_parser.rb
 - lib/rack/recursive.rb
 - lib/rack/reloader.rb
 - lib/rack/request.rb
@@ -128,14 +137,14 @@ files:
 - lib/rack/session/cookie.rb
 - lib/rack/session/memcache.rb
 - lib/rack/session/pool.rb
-- lib/rack/showexceptions.rb
-- lib/rack/showstatus.rb
+- lib/rack/show_exceptions.rb
+- lib/rack/show_status.rb
 - lib/rack/static.rb
 - lib/rack/tempfile_reaper.rb
 - lib/rack/urlmap.rb
 - lib/rack/utils.rb
-- lib/rack/utils/okjson.rb
 - rack.gemspec
+- test/builder/an_underscore_app.rb
 - test/builder/anything.rb
 - test/builder/comment.ru
 - test/builder/end.ru
@@ -153,8 +162,10 @@ files:
 - test/cgi/test
 - test/cgi/test+directory/test+file
 - test/cgi/test.fcgi
+- test/cgi/test.gz
 - test/cgi/test.ru
 - test/gemloader.rb
+- test/helper.rb
 - test/multipart/bad_robots
 - test/multipart/binary
 - test/multipart/content_type_and_no_filename
@@ -163,10 +174,12 @@ files:
 - test/multipart/file1.txt
 - test/multipart/filename_and_modification_param
 - test/multipart/filename_and_no_name
+- test/multipart/filename_with_encoded_words
 - test/multipart/filename_with_escaped_quotes
 - test/multipart/filename_with_escaped_quotes_and_modification_param
 - test/multipart/filename_with_null_byte
 - test/multipart/filename_with_percent_escaped_quotes
+- test/multipart/filename_with_single_quote
 - test/multipart/filename_with_unescaped_percentages
 - test/multipart/filename_with_unescaped_percentages2
 - test/multipart/filename_with_unescaped_percentages3
@@ -176,9 +189,12 @@ files:
 - test/multipart/mixed_files
 - test/multipart/nested
 - test/multipart/none
+- test/multipart/quoted
+- test/multipart/rack-logo.png
 - test/multipart/semicolon
 - test/multipart/text
 - test/multipart/three_files_three_fields
+- test/multipart/unity3d_wwwform
 - test/multipart/webkit
 - test/rackup/config.ru
 - test/registering_handler/rack/handler/registering_myself.rb
@@ -189,14 +205,15 @@ files:
 - test/spec_cascade.rb
 - test/spec_cgi.rb
 - test/spec_chunked.rb
-- test/spec_commonlogger.rb
-- test/spec_conditionalget.rb
+- test/spec_common_logger.rb
+- test/spec_conditional_get.rb
 - test/spec_config.rb
 - test/spec_content_length.rb
 - test/spec_content_type.rb
 - test/spec_deflater.rb
 - test/spec_directory.rb
 - test/spec_etag.rb
+- test/spec_events.rb
 - test/spec_fastcgi.rb
 - test/spec_file.rb
 - test/spec_handler.rb
@@ -205,12 +222,12 @@ files:
 - test/spec_lobster.rb
 - test/spec_lock.rb
 - test/spec_logger.rb
-- test/spec_methodoverride.rb
+- test/spec_media_type.rb
+- test/spec_method_override.rb
 - test/spec_mime.rb
 - test/spec_mock.rb
-- test/spec_mongrel.rb
 - test/spec_multipart.rb
-- test/spec_nulllogger.rb
+- test/spec_null_logger.rb
 - test/spec_recursive.rb
 - test/spec_request.rb
 - test/spec_response.rb
@@ -219,12 +236,13 @@ files:
 - test/spec_sendfile.rb
 - test/spec_server.rb
 - test/spec_session_abstract_id.rb
+- test/spec_session_abstract_session_hash.rb
 - test/spec_session_cookie.rb
 - test/spec_session_memcache.rb
 - test/spec_session_persisted_secure_secure_session_hash.rb
 - test/spec_session_pool.rb
-- test/spec_showexceptions.rb
-- test/spec_showstatus.rb
+- test/spec_show_exceptions.rb
+- test/spec_show_status.rb
 - test/spec_static.rb
 - test/spec_tempfile_reaper.rb
 - test/spec_thin.rb
@@ -233,11 +251,12 @@ files:
 - test/spec_version.rb
 - test/spec_webrick.rb
 - test/static/another/index.html
+- test/static/foo.html
 - test/static/index.html
 - test/testrequest.rb
 - test/unregistered_handler/rack/handler/unregistered.rb
 - test/unregistered_handler/rack/handler/unregistered_long_one.rb
-homepage: http://rack.github.io/
+homepage: https://rack.github.io/
 licenses:
 - MIT
 metadata: {}
@@ -249,7 +268,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.2.2
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -265,45 +284,47 @@ test_files:
 - test/spec_deflater.rb
 - test/spec_static.rb
 - test/spec_session_cookie.rb
-- test/spec_commonlogger.rb
 - test/spec_session_pool.rb
-- test/spec_methodoverride.rb
 - test/spec_etag.rb
 - test/spec_version.rb
 - test/spec_handler.rb
 - test/spec_thin.rb
-- test/spec_showexceptions.rb
 - test/spec_session_abstract_id.rb
 - test/spec_mime.rb
 - test/spec_recursive.rb
+- test/spec_null_logger.rb
+- test/spec_media_type.rb
 - test/spec_cgi.rb
+- test/spec_method_override.rb
 - test/spec_content_type.rb
+- test/spec_session_abstract_session_hash.rb
 - test/spec_request.rb
-- test/spec_showstatus.rb
 - test/spec_chunked.rb
+- test/spec_show_exceptions.rb
 - test/spec_runtime.rb
 - test/spec_session_persisted_secure_secure_session_hash.rb
 - test/spec_fastcgi.rb
+- test/spec_common_logger.rb
 - test/spec_builder.rb
 - test/spec_config.rb
-- test/spec_mongrel.rb
 - test/spec_utils.rb
 - test/spec_sendfile.rb
 - test/spec_lobster.rb
 - test/spec_lint.rb
+- test/spec_conditional_get.rb
 - test/spec_tempfile_reaper.rb
 - test/spec_mock.rb
-- test/spec_conditionalget.rb
 - test/spec_server.rb
 - test/spec_directory.rb
 - test/spec_webrick.rb
 - test/spec_response.rb
 - test/spec_file.rb
+- test/spec_show_status.rb
 - test/spec_body_proxy.rb
 - test/spec_logger.rb
 - test/spec_auth_digest.rb
 - test/spec_urlmap.rb
-- test/spec_nulllogger.rb
+- test/spec_events.rb
 - test/spec_cascade.rb
 - test/spec_auth_basic.rb
 - test/spec_head.rb

data/KNOWN-ISSUES

@@ -1,44 +0,0 @@
-= Known issues with Rack and ECMA-262
-
-* Many users expect the escape() function defined in ECMA-262 to be compatible
-  with URI. Confusion is especially strong because the documentation for the
-  escape function includes a reference to the URI specifications. ECMA-262
-  escape is not however a URI escape function, it is a javascript escape
-  function, and is not fully compatible. Most notably, for characters outside of
-  the BMP. Users should use the more correct encodeURI functions.
-
-= Known issues with Rack and Web servers
-
-* Lighttpd sets wrong SCRIPT_NAME and PATH_INFO if you mount your
-  FastCGI app at "/".  This can be fixed by using this middleware:
-
-    class LighttpdScriptNameFix
-      def initialize(app)
-        @app = app
-      end
-
-      def call(env)
-        env["PATH_INFO"] = env["SCRIPT_NAME"].to_s + env["PATH_INFO"].to_s
-        env["SCRIPT_NAME"] = ""
-        @app.call(env)
-      end
-    end
-
-  Of course, use this only when your app runs at "/".
-
-  Since lighttpd 1.4.23, you also can use the "fix-root-scriptname" flag
-  in fastcgi.server.
-
-= Known conflicts regarding parameter parsing
-
- * Many users have differing opinions about parameter parsing. The current
-   parameter parsers in Rack are based on a combination of the HTTP and CGI
-   specs, and are intended to round-trip encoding and decoding. There are some
-   choices that may be viewed as deficiencies, specifically:
-    - Rack does not create implicit arrays for multiple instances of a parameter
-    - Rack returns nil when a value is not given
-    - Rack does not support multi-type keys in parameters
-   These issues or choices, will not be fixed before 2.0, if at all. They are
-   very major breaking changes. Users are free to write alternative parameter
-   parsers, and their own Request and Response wrappers. Moreover, users are
-   encouraged to do so.