rack 1.6.13 → 2.0.0.alpha

data/test/spec_show_exceptions.rb

@@ -0,0 +1,80 @@
+require 'minitest/autorun'
+require 'rack/show_exceptions'
+require 'rack/lint'
+require 'rack/mock'
+
+describe Rack::ShowExceptions do
+  def show_exceptions(app)
+    Rack::Lint.new Rack::ShowExceptions.new(app)
+  end
+
+  it "catches exceptions" do
+    res = nil
+
+    req = Rack::MockRequest.new(
+      show_exceptions(
+        lambda{|env| raise RuntimeError }
+    ))
+
+    res = req.get("/", "HTTP_ACCEPT" => "text/html")
+
+    res.must_be :server_error?
+    res.status.must_equal 500
+
+    assert_match(res, /RuntimeError/)
+    assert_match(res, /ShowExceptions/)
+  end
+
+  it "responds with HTML only to requests accepting HTML" do
+    res = nil
+
+    req = Rack::MockRequest.new(
+      show_exceptions(
+        lambda{|env| raise RuntimeError, "It was never supposed to work" }
+    ))
+
+    [
+      # Serve text/html when the client accepts text/html
+      ["text/html", ["/", {"HTTP_ACCEPT" => "text/html"}]],
+      ["text/html", ["/", {"HTTP_ACCEPT" => "*/*"}]],
+      # Serve text/plain when the client does not accept text/html
+      ["text/plain", ["/"]],
+      ["text/plain", ["/", {"HTTP_ACCEPT" => "application/json"}]]
+    ].each do |exmime, rargs|
+      res = req.get(*rargs)
+
+      res.must_be :server_error?
+      res.status.must_equal 500
+
+      res.content_type.must_equal exmime
+
+      res.body.must_include "RuntimeError"
+      res.body.must_include "It was never supposed to work"
+
+      if exmime == "text/html"
+        res.body.must_include '</html>'
+      else
+        res.body.wont_include '</html>'
+      end
+    end
+  end
+
+  it "handles exceptions without a backtrace" do
+    res = nil
+
+    req = Rack::MockRequest.new(
+      show_exceptions(
+        lambda{|env| raise RuntimeError, "", [] }
+      )
+    )
+
+    res = req.get("/", "HTTP_ACCEPT" => "text/html")
+
+    res.must_be :server_error?
+    res.status.must_equal 500
+
+    assert_match(res, /RuntimeError/)
+    assert_match(res, /ShowExceptions/)
+    assert_match(res, /unknown location/)
+  end
+end

data/test/{spec_showstatus.rb → spec_show_status.rb}

@@ -1,4 +1,5 @@
-require 'rack/showstatus'
+require 'minitest/autorun'
+require 'rack/show_status'
 require 'rack/lint'
 require 'rack/mock'
 require 'rack/utils'
@@ -7,23 +8,23 @@ describe Rack::ShowStatus do
   def show_status(app)
     Rack::Lint.new Rack::ShowStatus.new(app)
   end
-  
-  should "provide a default status message" do
+
+  it "provide a default status message" do
     req = Rack::MockRequest.new(
       show_status(lambda{|env|
         [404, {"Content-Type" => "text/plain", "Content-Length" => "0"}, []]
     }))
 
     res = req.get("/", :lint => true)
-    res.should.be.not_found
-    res.should.be.not.empty
+    res.must_be :not_found?
+    res.wont_be_empty
 
-    res["Content-Type"].should.equal("text/html")
-    res.should =~ /404/
-    res.should =~ /Not Found/
+    res["Content-Type"].must_equal "text/html"
+    assert_match(res, /404/)
+    assert_match(res, /Not Found/)
   end
 
-  should "let the app provide additional information" do
+  it "let the app provide additional information" do
     req = Rack::MockRequest.new(
       show_status(
         lambda{|env|
@@ -32,16 +33,16 @@ describe Rack::ShowStatus do
     }))
 
     res = req.get("/", :lint => true)
-    res.should.be.not_found
-    res.should.be.not.empty
+    res.must_be :not_found?
+    res.wont_be_empty
 
-    res["Content-Type"].should.equal("text/html")
-    res.should =~ /404/
-    res.should =~ /Not Found/
-    res.should =~ /too meta/
+    res["Content-Type"].must_equal "text/html"
+    assert_match(res, /404/)
+    assert_match(res, /Not Found/)
+    assert_match(res, /too meta/)
   end
 
-  should "escape error" do
+  it "escape error" do
     detail = "<script>alert('hi \"')</script>"
     req = Rack::MockRequest.new(
       show_status(
@@ -51,15 +52,15 @@ describe Rack::ShowStatus do
     }))
 
     res = req.get("/", :lint => true)
-    res.should.be.not.empty
+    res.wont_be_empty
 
-    res["Content-Type"].should.equal("text/html")
-    res.should =~ /500/
-    res.should.not.include detail
-    res.body.should.include Rack::Utils.escape_html(detail)
+    res["Content-Type"].must_equal "text/html"
+    assert_match(res, /500/)
+    res.wont_include detail
+    res.body.must_include Rack::Utils.escape_html(detail)
   end
 
-  should "not replace existing messages" do
+  it "not replace existing messages" do
     req = Rack::MockRequest.new(
       show_status(
         lambda{|env|
@@ -67,22 +68,22 @@ describe Rack::ShowStatus do
     }))
 
     res = req.get("/", :lint => true)
-    res.should.be.not_found
+    res.must_be :not_found?
 
-    res.body.should == "foo!"
+    res.body.must_equal "foo!"
   end
 
-  should "pass on original headers" do
+  it "pass on original headers" do
     headers = {"WWW-Authenticate" => "Basic blah"}
 
     req = Rack::MockRequest.new(
       show_status(lambda{|env| [401, headers, []] }))
     res = req.get("/", :lint => true)
 
-    res["WWW-Authenticate"].should.equal("Basic blah")
+    res["WWW-Authenticate"].must_equal "Basic blah"
   end
 
-  should "replace existing messages if there is detail" do
+  it "replace existing messages if there is detail" do
     req = Rack::MockRequest.new(
       show_status(
         lambda{|env|
@@ -91,13 +92,13 @@ describe Rack::ShowStatus do
     }))
 
     res = req.get("/", :lint => true)
-    res.should.be.not_found
-    res.should.be.not.empty
-
-    res["Content-Type"].should.equal("text/html")
-    res["Content-Length"].should.not.equal("4")
-    res.should =~ /404/
-    res.should =~ /too meta/
-    res.body.should.not =~ /foo/
+    res.must_be :not_found?
+    res.wont_be_empty
+
+    res["Content-Type"].must_equal "text/html"
+    res["Content-Length"].wont_equal "4"
+    assert_match(res, /404/)
+    assert_match(res, /too meta/)
+    res.body.wont_match(/foo/)
   end
 end

data/test/spec_static.rb

@@ -1,6 +1,9 @@
+require 'minitest/autorun'
 require 'rack/static'
 require 'rack/lint'
 require 'rack/mock'
+require 'zlib'
+require 'stringio'
 
 class DummyApp
   def call(env)
@@ -18,64 +21,101 @@ describe Rack::Static do
   OPTIONS = {:urls => ["/cgi"], :root => root}
   STATIC_OPTIONS = {:urls => [""], :root => "#{root}/static", :index => 'index.html'}
   HASH_OPTIONS = {:urls => {"/cgi/sekret" => 'cgi/test'}, :root => root}
+  HASH_ROOT_OPTIONS = {:urls => {"/" => "static/foo.html"}, :root => root}
+  GZIP_OPTIONS = {:urls => ["/cgi"], :root => root, :gzip=>true}
 
+  before do
   @request = Rack::MockRequest.new(static(DummyApp.new, OPTIONS))
   @static_request = Rack::MockRequest.new(static(DummyApp.new, STATIC_OPTIONS))
   @hash_request = Rack::MockRequest.new(static(DummyApp.new, HASH_OPTIONS))
+  @hash_root_request = Rack::MockRequest.new(static(DummyApp.new, HASH_ROOT_OPTIONS))
+  @gzip_request = Rack::MockRequest.new(static(DummyApp.new, GZIP_OPTIONS))
+  @header_request = Rack::MockRequest.new(static(DummyApp.new, HEADER_OPTIONS))
+  end
 
   it "serves files" do
     res = @request.get("/cgi/test")
-    res.should.be.ok
-    res.body.should =~ /ruby/
+    res.must_be :ok?
+    res.body.must_match(/ruby/)
   end
 
   it "404s if url root is known but it can't find the file" do
     res = @request.get("/cgi/foo")
-    res.should.be.not_found
+    res.must_be :not_found?
   end
 
   it "calls down the chain if url root is not known" do
     res = @request.get("/something/else")
-    res.should.be.ok
-    res.body.should == "Hello World"
+    res.must_be :ok?
+    res.body.must_equal "Hello World"
   end
 
   it "calls index file when requesting root in the given folder" do
     res = @static_request.get("/")
-    res.should.be.ok
-    res.body.should =~ /index!/
+    res.must_be :ok?
+    res.body.must_match(/index!/)
 
     res = @static_request.get("/other/")
-    res.should.be.not_found
+    res.must_be :not_found?
 
     res = @static_request.get("/another/")
-    res.should.be.ok
-    res.body.should =~ /another index!/
+    res.must_be :ok?
+    res.body.must_match(/another index!/)
   end
 
   it "doesn't call index file if :index option was omitted" do
     res = @request.get("/")
-    res.body.should == "Hello World"
+    res.body.must_equal "Hello World"
   end
 
   it "serves hidden files" do
     res = @hash_request.get("/cgi/sekret")
-    res.should.be.ok
-    res.body.should =~ /ruby/
+    res.must_be :ok?
+    res.body.must_match(/ruby/)
   end
 
   it "calls down the chain if the URI is not specified" do
     res = @hash_request.get("/something/else")
-    res.should.be.ok
-    res.body.should == "Hello World"
+    res.must_be :ok?
+    res.body.must_equal "Hello World"
+  end
+
+  it "allows the root URI to be configured via hash options" do
+    res = @hash_root_request.get("/")
+    res.must_be :ok?
+    res.body.must_match(/foo.html!/)
+  end
+
+  it "serves gzipped files if client accepts gzip encoding and gzip files are present" do
+    res = @gzip_request.get("/cgi/test", 'HTTP_ACCEPT_ENCODING'=>'deflate, gzip')
+    res.must_be :ok?
+    res.headers['Content-Encoding'].must_equal 'gzip'
+    res.headers['Content-Type'].must_equal 'text/plain'
+    Zlib::GzipReader.wrap(StringIO.new(res.body), &:read).must_match(/ruby/)
+  end
+
+  it "serves regular files if client accepts gzip encoding and gzip files are not present" do
+    res = @gzip_request.get("/cgi/rackup_stub.rb", 'HTTP_ACCEPT_ENCODING'=>'deflate, gzip')
+    res.must_be :ok?
+    res.headers['Content-Encoding'].must_equal nil
+    res.headers['Content-Type'].must_equal 'text/x-script.ruby'
+    res.body.must_match(/ruby/)
+  end
+
+  it "serves regular files if client does not accept gzip encoding" do
+    res = @gzip_request.get("/cgi/test")
+    res.must_be :ok?
+    res.headers['Content-Encoding'].must_equal nil
+    res.headers['Content-Type'].must_equal 'text/plain'
+    res.body.must_match(/ruby/)
   end
 
   it "supports serving fixed cache-control (legacy option)" do
     opts = OPTIONS.merge(:cache_control => 'public')
     request = Rack::MockRequest.new(static(DummyApp.new, opts))
     res = request.get("/cgi/test")
-    res.should.be.ok
-    res.headers['Cache-Control'].should == 'public'
+    res.must_be :ok?
+    res.headers['Cache-Control'].must_equal 'public'
   end
 
   HEADER_OPTIONS = {:urls => ["/cgi"], :root => root, :header_rules => [
@@ -86,47 +126,46 @@ describe Rack::Static do
     ['cgi/assets/javascripts', {'Cache-Control' => 'public, max-age=500'}],
     [/\.(css|erb)\z/, {'Cache-Control' => 'public, max-age=600'}]
   ]}
-  @header_request = Rack::MockRequest.new(static(DummyApp.new, HEADER_OPTIONS))
 
   it "supports header rule :all" do
     # Headers for all files via :all shortcut
     res = @header_request.get('/cgi/assets/index.html')
-    res.should.be.ok
-    res.headers['Cache-Control'].should == 'public, max-age=100'
+    res.must_be :ok?
+    res.headers['Cache-Control'].must_equal 'public, max-age=100'
   end
 
   it "supports header rule :fonts" do
     # Headers for web fonts via :fonts shortcut
     res = @header_request.get('/cgi/assets/fonts/font.eot')
-    res.should.be.ok
-    res.headers['Cache-Control'].should == 'public, max-age=200'
+    res.must_be :ok?
+    res.headers['Cache-Control'].must_equal 'public, max-age=200'
   end
 
   it "supports file extension header rules provided as an Array" do
     # Headers for file extensions via array
     res = @header_request.get('/cgi/assets/images/image.png')
-    res.should.be.ok
-    res.headers['Cache-Control'].should == 'public, max-age=300'
+    res.must_be :ok?
+    res.headers['Cache-Control'].must_equal 'public, max-age=300'
   end
 
   it "supports folder rules provided as a String" do
     # Headers for files in folder via string
     res = @header_request.get('/cgi/assets/folder/test.js')
-    res.should.be.ok
-    res.headers['Cache-Control'].should == 'public, max-age=400'
+    res.must_be :ok?
+    res.headers['Cache-Control'].must_equal 'public, max-age=400'
   end
 
   it "supports folder header rules provided as a String not starting with a slash" do
     res = @header_request.get('/cgi/assets/javascripts/app.js')
-    res.should.be.ok
-    res.headers['Cache-Control'].should == 'public, max-age=500'
+    res.must_be :ok?
+    res.headers['Cache-Control'].must_equal 'public, max-age=500'
   end
 
   it "supports flexible header rules provided as Regexp" do
     # Flexible Headers via Regexp
     res = @header_request.get('/cgi/assets/stylesheets/app.css')
-    res.should.be.ok
-    res.headers['Cache-Control'].should == 'public, max-age=600'
+    res.must_be :ok?
+    res.headers['Cache-Control'].must_equal 'public, max-age=600'
   end
 
   it "prioritizes header rules over fixed cache-control setting (legacy option)" do
@@ -138,8 +177,8 @@ describe Rack::Static do
 
     request = Rack::MockRequest.new(static(DummyApp.new, opts))
     res = request.get("/cgi/test")
-    res.should.be.ok
-    res.headers['Cache-Control'].should == 'public, max-age=42'
+    res.must_be :ok?
+    res.headers['Cache-Control'].must_equal 'public, max-age=42'
   end
 
 end

data/test/spec_tempfile_reaper.rb

@@ -1,3 +1,4 @@
+require 'minitest/autorun'
 require 'rack/tempfile_reaper'
 require 'rack/lint'
 require 'rack/mock'
@@ -23,33 +24,33 @@ describe Rack::TempfileReaper do
     Rack::Lint.new(Rack::TempfileReaper.new(app)).call(@env)
   end
 
-  should 'do nothing (i.e. not bomb out) without env[rack.tempfiles]' do
+  it 'do nothing (i.e. not bomb out) without env[rack.tempfiles]' do
     app = lambda { |_| [200, {}, ['Hello, World!']] }
     response = call(app)
     response[2].close
-    response[0].should.equal(200)
+    response[0].must_equal 200
   end
 
-  should 'close env[rack.tempfiles] when body is closed' do
+  it 'close env[rack.tempfiles] when body is closed' do
     tempfile1, tempfile2 = MockTempfile.new, MockTempfile.new
     @env['rack.tempfiles'] = [ tempfile1, tempfile2 ]
     app = lambda { |_| [200, {}, ['Hello, World!']] }
     call(app)[2].close
-    tempfile1.closed.should.equal true
-    tempfile2.closed.should.equal true
+    tempfile1.closed.must_equal true
+    tempfile2.closed.must_equal true
   end
 
-  should 'initialize env[rack.tempfiles] when not already present' do
+  it 'initialize env[rack.tempfiles] when not already present' do
     tempfile = MockTempfile.new
     app = lambda do |env|
       env['rack.tempfiles'] << tempfile
       [200, {}, ['Hello, World!']]
     end
     call(app)[2].close
-    tempfile.closed.should.equal true
+    tempfile.closed.must_equal true
   end
 
-  should 'append env[rack.tempfiles] when already present' do
+  it 'append env[rack.tempfiles] when already present' do
     tempfile1, tempfile2 = MockTempfile.new, MockTempfile.new
     @env['rack.tempfiles'] = [ tempfile1 ]
     app = lambda do |env|
@@ -57,7 +58,7 @@ describe Rack::TempfileReaper do
       [200, {}, ['Hello, World!']]
     end
     call(app)[2].close
-    tempfile1.closed.should.equal true
-    tempfile2.closed.should.equal true
+    tempfile1.closed.must_equal true
+    tempfile2.closed.must_equal true
   end
 end