rack-wwwhisper 1.1.6 → 1.1.7

data/lib/rack/wwwhisper.rb

@@ -110,12 +110,13 @@ class WWWhisper
 
     if auth_resp.code == '200'
       debug req, 'access granted'
-      env['REMOTE_USER'] = auth_resp['User']
+      user = auth_resp['User']
+      env['REMOTE_USER'] = user if user
       status, headers, body = dispatch(req)
       if should_inject_iframe(status, headers)
         body = inject_iframe(headers, body)
       end
-      headers['User'] = auth_resp['User']
+      headers['User'] = user if user
       [status, headers, body]
     else
       debug req, {

data/lib/rack/wwwhisper_version.rb

@@ -1,3 +1,3 @@
 module Rack
-  WWWHISPER_VERSION = '1.1.6'
+  WWWHISPER_VERSION = '1.1.7'
 end

data/test/test_wwwhisper.rb

@@ -68,6 +68,11 @@ class TestWWWhisper < Test::Unit::TestCase
     {:status => 200, :body => '', :headers => {'User' => TEST_USER}}
   end
 
+  def open_location_granted()()
+    # Open locations allow not authenticated access, 'User' can be not set
+    {:status => 200, :body => '', :headers => {}}
+  end
+
   def test_wwwhisper_url_required
     ENV.delete('WWWHISPER_URL')
     # Exception should not be raised during initialization, but during
@@ -88,7 +93,7 @@ class TestWWWhisper < Test::Unit::TestCase
     get path
     assert last_response.ok?
     assert_equal 'Hello World', last_response.body
-    assert_nil last_response['User']
+    assert !last_response.original_headers.has_key?('User')
   end
 
   def test_auth_query_path
@@ -108,6 +113,20 @@ class TestWWWhisper < Test::Unit::TestCase
     assert_requested :get, full_url(@wwwhisper.auth_query(path))
   end
 
+  def test_open_location_request_allowed
+    # Configure MockBackend to make sure REMOTE_USER is not set.
+    @wwwhisper = Rack::WWWhisper.new(MockBackend.new(nil))
+    path = '/foo/bar'
+    stub_request(:get, full_url(@wwwhisper.auth_query(path))).
+      to_return(open_location_granted())
+
+    get path
+    assert last_response.ok?
+    assert_equal 'Hello World', last_response.body
+    assert !last_response.original_headers.has_key?('User')
+    assert_requested :get, full_url(@wwwhisper.auth_query(path))
+  end
+
   def test_login_required
     path = '/foo/bar'
     stub_request(:get, full_url(@wwwhisper.auth_query(path))).

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rack-wwwhisper
 version: !ruby/object:Gem::Version
-  version: 1.1.6
+  version: 1.1.7
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-15 00:00:00.000000000 Z
+date: 2013-04-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -130,12 +130,18 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: 3214471811457318214
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: 3214471811457318214
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24