rack-webprofiler 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 96dfb4d501418608de8496058d100f1006e7f616
-  data.tar.gz: 4f0b768c2127d7106d9b22c23605f33e59e0915a
+  metadata.gz: fd396a0c74f2907da4a53e8ecd201d49b90cca65
+  data.tar.gz: f5f48a8a2545e4721ebed61e239dc645632525fc
 SHA512:
-  metadata.gz: 0f295760200944bd1e04c5de3aae9278f7ba853928125b9b3f3093df1d813252d3090fdd0e061c876deeaaf577e8604d56cfb41b3800065b117dd64c2cf7c0c3
-  data.tar.gz: f9c4d0d31334b356185c149dd071cbaf32ad707675b63811e2ab751d044a89489c00756faa267cad363445af6bde95975538d06b4ae259535ebb96222bf5faea
+  metadata.gz: 42a65d8ce8ab998d31d367ef4f66b9baa0ea85151c00b729104bf631b4c6c1211f309185c728db938fbf3e960244c9ff80d95a019d689ffeaee0c0b43687b6cc
+  data.tar.gz: dae12374c57ec4984b0744886681925e87e79a21f7f6dbd662c1188d52584cd2ecf28f09e687df1826df4d6e2bf8bf7bb172860738c271200f2aab3f3efb7a5a

data/CHANGELOG.md

@@ -11,6 +11,13 @@
   * Catch 500 or exceptions.
 
 
+## v0.1.2
+
+### Fixes
+
+  * Optimize the process of saving collected datas.
+  * Truncate table instead delete db file (#31).
+  * Small code cleanup.
 
 
 ## v0.1.1
@@ -34,7 +41,7 @@
 
 ### Fixes
 
- * Debug SQLite database stabilty by using a single thread.
+  * Debug SQLite database stabilty by using a single thread.
 
 
 ## v0.1.0.beta2

data/lib/rack/web_profiler/collectors/rack_collector.rb

@@ -12,20 +12,10 @@ ICON
 
     collect do |request, _response|
       store :rack_version, Rack.release
-      store :rack_env,     hash_stringify_values(request.env)
+      store :rack_env,     Rack::WebProfiler::Utils.hash_stringify_values(request.env)
     end
 
     template __FILE__, type: :DATA
-
-    class << self
-      def hash_stringify_values(hash)
-        return {} unless hash.kind_of?(Hash)
-        hash.collect do |k,v|
-          v = v.inspect unless v.kind_of?(String)
-          [k, v]
-        end
-      end
-    end
   end
 end
 

data/lib/rack/web_profiler/collectors/request_collector.rb

@@ -17,7 +17,7 @@ ICON
       store :request_cookies,   request.cookies
       store :request_get,       request.GET
       store :request_post,      request_post(request)
-      store :request_session,   hash_stringify_values(request.session)
+      store :request_session,   Rack::WebProfiler::Utils.hash_stringify_values(request.session)
       store :request_cookies,   request.cookies
       store :request_body,      request.body_string
       store :request_mediatype, request.media_type
@@ -44,11 +44,6 @@ ICON
       rescue Exception
         nil
       end
-
-      def hash_stringify_values(hash)
-        return {} unless hash.kind_of?(Hash)
-        hash.collect {|k,v| [k, v.to_s]}
-      end
     end
   end
 end

data/lib/rack/web_profiler/config.rb

@@ -1,4 +1,5 @@
 require "fileutils"
+require "tmpdir"
 
 module Rack
   # Config
@@ -11,6 +12,8 @@ module Rack
       Rack::WebProfiler::Collectors::RubyCollector,
       Rack::WebProfiler::Collectors::TimeCollector,
     ].freeze
+
+    # Initialize Config.
     def initialize
       @collectors = Rack::WebProfiler::Collectors.new
 

data/lib/rack/web_profiler/engine.rb

@@ -73,40 +73,40 @@ module Rack
         attr_reader :record
 
         def initialize(request, response)
-          @collectors = {}
-          @request    = request.clone.freeze
-          @response   = response.clone.freeze
-          @record     = nil
+          @record = new_record(request.clone.freeze, response.clone.freeze)
         end
 
         def save!
-          create_record!
-          save_collected_datas!
-
           @record.save({ transaction: true })
+        rescue => e
+          # @todo raise_if_debug WebProfiler::RuntimeError, "Error while processing to save datas", e.backtrace
         end
 
         private
 
-        def create_record!
-          @record ||= WebProfiler::Model::CollectionRecord.create({
-            url:           @request.url,
-            ip:            @request.ip,
-            http_method:   @request.request_method,
-            http_status:   @response.status,
-            content_type:  @response.content_type,
-            datas:         {},
+        def new_record(request, response)
+          WebProfiler::Model::CollectionRecord.new({
+            url:          request.url,
+            ip:           request.ip,
+            http_method:  request.request_method,
+            http_status:  response.status,
+            content_type: response.content_type,
+            datas:        collect_datas(request, response),
           })
         end
 
-        def save_collected_datas!
+        def collect_datas(request, response)
           datas = {}
 
           Rack::WebProfiler.config.collectors.all.each do |name, definition|
-            datas[name.to_sym] = definition.collect!(@request, @response).to_h
+            begin
+              datas[name.to_sym] = definition.collect!(request, response).to_h
+            rescue => e
+              # @todo raise_if_debug WebProfiler::RuntimeError, "Error while collecting datas of collector '#{name}'"
+            end
           end
 
-          @record.datas = datas
+          datas
         end
       end
     end

data/lib/rack/web_profiler/model.rb

@@ -22,9 +22,7 @@ module Rack
         def clean!
           return unless ::File.exist?(db_file_path)
 
-          ::File.delete(db_file_path)
-          @db = nil
-          @db_file_path = nil
+          CollectionRecord.truncate
         end
 
         private

data/lib/rack/web_profiler/utils.rb

@@ -0,0 +1,13 @@
+module Rack
+  class WebProfiler::Utils
+    class << self
+      def hash_stringify_values(hash)
+        return {} unless hash.kind_of?(Hash)
+        hash.collect do |k,v|
+          v = v.inspect unless v.kind_of?(String)
+          [k, v]
+        end
+      end
+    end
+  end
+end

data/lib/rack/web_profiler/version.rb

@@ -1,5 +1,5 @@
 module Rack
   class WebProfiler
-    VERSION = "0.1.1".freeze
+    VERSION = "0.1.2".freeze
   end
 end

data/lib/rack/web_profiler.rb

@@ -13,6 +13,7 @@ module Rack
     autoload :Response,   "rack/web_profiler/response"
     autoload :Request,    "rack/web_profiler/request"
     autoload :Router,     "rack/web_profiler/router"
+    autoload :Utils,      "rack/web_profiler/utils"
     autoload :View,       "rack/web_profiler/view"
 
     # Classes about Rouge gem customization.
@@ -20,6 +21,9 @@ module Rack
       autoload :HTMLFormatter, "rack/web_profiler/rouge/html_formatter"
     end
 
+    # Exceptions
+    class RuntimeError < ::RuntimeError; end
+
     # Env key constants.
     ENV_RUNTIME_START = "rack_webprofiler.runtime_start".freeze
     ENV_RUNTIME       = "rack_webprofiler.runtime".freeze

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rack-webprofiler
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Nicolas Brousse
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-22 00:00:00.000000000 Z
+date: 2017-04-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -168,6 +168,7 @@ files:
 - lib/rack/web_profiler/response.rb
 - lib/rack/web_profiler/rouge/html_formatter.rb
 - lib/rack/web_profiler/router.rb
+- lib/rack/web_profiler/utils.rb
 - lib/rack/web_profiler/version.rb
 - lib/rack/web_profiler/view.rb
 - lib/rack/webprofiler.rb