rack-tracker 1.0.2 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c743ccee29e6faa8c5d71c07d205f3ae15be5919
-  data.tar.gz: efa4ee308684aabf373fb85d37a43d13605d6620
+  metadata.gz: 7967cb6b637c7fbcbef964f3e12a198a3e18b4d3
+  data.tar.gz: 090e46d7451bf2d2d3a449b04a0162bf39e8fd6e
 SHA512:
-  metadata.gz: 579341d83332e1859080caf204e1ad92194c18e9e175194ca75701a23873dc4baa6e21fd97618d1b8d6bafdf70fdc3ee76c73fabbc2e62325c8824420ce4aa73
-  data.tar.gz: 2549534848b0a718337d61950f56b78e2def2c7e2d723f95dec60605bf868064b8ab15057e9d70f654f43acdadc44034d60ca8a02f6706af7be4c30c962c18d4
+  metadata.gz: 0da5aef1623fe668fd12b9c646cc80c262bbcd610bb6686af8fb01b0c201a722191020fa6b4a45ab22e9bf5f33561f7ece544bd9890b88b5f0c85552f0ba6319
+  data.tar.gz: 8ff3380ee3229d099f78eba30914e7cb67a991013810ab0209db287b3b119a93319966015c6cab06f94dd7e3ec1fe7492ab8763d51cf2302c06afd146a6a9ea0

data/CHANGELOG.md

@@ -1,8 +1,15 @@
+# 1.1.0
+
+  * [BREAKING] Google Tag Manager #59
+    * change `dataLayer.push` syntax from from `name: 'click', value: 'X'` to just `click: 'X'`
+    * this allows to specify a hash with multiple key-value pairs for one push event
+    * this will also correctly handle array values (see issue #57)
+  * setEmail event for criteo #51 (thx @florianeck)
+
 # 1.0.2
 
   * Back port deep_stringify_keys! from Rails 4 #55 (thx @jivagoalves)
   * Javascript escape implementation to prevent XSS #54 (thx @fabn)
-  * setEmail event for criteo #51 (thx @florianeck)
 
 # 1.0.1
 

data/README.md

@@ -246,7 +246,7 @@ To add events or variables to the dataLayer from the server side, just call the
 ```ruby
   def show
     tracker do |t|
-      t.google_tag_manager :push, { name: 'price', value: 'X' }
+      t.google_tag_manager :push, { price: 'X', another_variable: ['array', 'values'] }
     end
   end
 ```
@@ -378,6 +378,7 @@ end
 Other global criteo handler options are:
 * `set_customer_id: 'x'`
 * `set_site_type: 'd'` - possible values are `m` (mobile), `t` (tablet), `d` (desktop)
+* `set_email: 'email'`
 
 Option values can be either static or dynamic by providing a lambda being reevaluated for each request, e.g. `set_customer_id: lambda { |env| env['rack.session']['user_id'] }`
 
@@ -441,6 +442,7 @@ and the following variables:
 ```
 zx_category = 'Swimming';
 zx_amount = '3.50';
+```
 
 #### Conversion tracking
 

data/lib/rack/tracker/criteo/criteo.rb

@@ -4,7 +4,8 @@ class Rack::Tracker::Criteo <  Rack::Tracker::Handler
     # event name => event key name, e.g. { event: 'setSiteType', type: '' }
     set_site_type: :type,
     set_account: :account,
-    set_customer_id: :id
+    set_customer_id: :id,
+    set_email: :email
   }
 
   class Event < OpenStruct

data/lib/rack/tracker/google_tag_manager/google_tag_manager.rb

@@ -1,17 +1,8 @@
 class Rack::Tracker::GoogleTagManager < Rack::Tracker::Handler
 
   class Push < OpenStruct
-
     def write
-      "'#{event[:name]}': '#{event[:value]}'"
-    end
-
-    def event
-      attributes.stringify_values.compact
-    end
-
-    def attributes
-      to_h.slice(:name, :value)
+      to_h.to_json
     end
   end
 

data/lib/rack/tracker/google_tag_manager/template/google_tag_manager.erb

@@ -12,8 +12,8 @@ j=d.createElement(s),dl=l!='dataLayer'?'&l='+l:'';j.async=true;j.src=
 })(window,document,'script','dataLayer','<%= container %>');</script>
 
 <script>
-dataLayer.push({
+dataLayer.push(
   <%= events.map(&:write).join(', ') %>
-});
+);
 </script>
 <% end %>

data/lib/rack/tracker/version.rb

@@ -1,5 +1,5 @@
 module Rack
   class Tracker
-    VERSION = '1.0.2'
+    VERSION = '1.1.0'
   end
 end

data/spec/handler/google_tag_manager_spec.rb

@@ -18,15 +18,14 @@ RSpec.describe Rack::Tracker::GoogleTagManager do
       def env
         {'tracker' => {
           'google_tag_manager' => [
-            { 'class_name' => 'Push', 'name' => 'page', 'value' => 'Cart' },
-            { 'class_name' => 'Push', 'name' => 'price', 'value' => 50 }
+            { 'class_name' => 'Push', 'page' => 'Cart', 'price' => 50, 'content_ids' => ['sku_1', 'sku_2', 'sku_3'] }
           ]
         }}
       end
 
       subject { described_class.new(env, container: 'somebody').render }
       it "will show events" do
-        expect(subject).to match(%r{'page': 'Cart', 'price': '50'})
+        expect(subject).to match(%r{"page":"Cart","price":50,"content_ids":\["sku_1","sku_2","sku_3"\]})
       end
     end
   end

data/spec/integration/criteo_integration_spec.rb

@@ -6,7 +6,8 @@ RSpec.describe "Criteo Integration" do
       tracker.handler(:criteo, {
         set_account: '1234',
         set_customer_id: ->(env){ '4711' },
-        set_site_type: ->(env){ 'm' }
+        set_site_type: ->(env){ 'm' },
+        set_email: 'user@test.com'
       })
     end
     visit '/'
@@ -19,6 +20,7 @@ RSpec.describe "Criteo Integration" do
     expect(page.find("body")).to have_content "window.criteo_q.push({\"event\":\"setAccount\",\"account\":\"1234\"});"
     expect(page.find("body")).to have_content "window.criteo_q.push({\"event\":\"setSiteType\",\"type\":\"m\"});"
     expect(page.find("body")).to have_content "window.criteo_q.push({\"event\":\"setCustomerId\",\"id\":\"4711\"});"
+    expect(page.find("body")).to have_content "window.criteo_q.push({\"event\":\"setEmail\",\"email\":\"user@test.com\"});"
 
     # events
     expect(page.find("body")).to have_content "window.criteo_q.push({\"event\":\"viewItem\",\"item\":\"P001\"});"

data/spec/integration/google_tag_manager_integration_spec.rb

@@ -11,8 +11,8 @@ RSpec.describe "Google Tag Manager Integration" do
   subject { page }
 
   it "embeds the script tag with tracking event from the controller action" do
-    expect(page.find("body")).to have_content('GTM-ABCDEF')
-    expect(page.find("body")).to have_content('\'click\': \'X\', \'price\': \'10\'')
+    expect(page.find("body")).to have_content 'GTM-ABCDEF'
+    expect(page.find("body")).to have_content "dataLayer.push( {\"click\":\"X\",\"price\":10}, {\"transactionProducts\":[{\"sku\":\"DD44\",\"name\":\"T-shirt\"},{\"sku\":\"DD66\",\"name\":\"Jeans\"}]} );"
   end
 
-end
+end

data/spec/support/metal_controller.rb

@@ -42,8 +42,8 @@ class MetalController < ActionController::Metal
 
   def google_tag_manager
     tracker do |t|
-      t.google_tag_manager :push, { name: 'click', value: 'X' }
-      t.google_tag_manager :push, { name: 'price', value: '10' }
+      t.google_tag_manager :push, { click: 'X', price: 10 }
+      t.google_tag_manager :push, transactionProducts: [{ sku: 'DD44', name: 'T-shirt' }, { sku: 'DD66', name: 'Jeans' }]
     end
     render "metal/index"
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rack-tracker
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.1.0
 platform: ruby
 authors:
 - Lars Brillert
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-12 00:00:00.000000000 Z
+date: 2015-11-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack