rack-tracker 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7565da578c5c506a95014ea972db7008e870e034
-  data.tar.gz: 4a735adf525fe516133d7c807472cc338d8b106b
+  metadata.gz: 4f96283c0c0a98829afd90e11bbd5e79d7286f52
+  data.tar.gz: 5ad6fa93e9419ac106f7c53dc7b07afcab142db7
 SHA512:
-  metadata.gz: edae2548f40570b3068c4bcc9323fc869465add3be35d3fe856556a4702af888d1ebec860e9644e1df519b2bcc973d322accddb53bc23b5fc0712ef7d49d0930
-  data.tar.gz: cbfc180230a44535c9d40c48fe82c7f9e4300f68ece15849dacc5789f46f348ccf497da7eaba24173d5d3567247579153ef85b89cb95c206934a1ab53fa97423
+  metadata.gz: 4006a72b6a23f2af2d29446842a93f0f6fc7392f75d539bb8344ffad99e81f8405ae365927bbcc58a7cf4848c90cfcbe95264ef86f5de6214895723a5d886caa
+  data.tar.gz: 39be467029907b418117f7c8457b5268c1dbf0a8ea656bf346d5d8c92f9374c75745d2bdc74625c0c02316a1f7fc36ca1c3b3b0461476f7b2a3e2926bf45c3ff

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+# 1.0.1
+
+  * [BUGFIX] Fix for adjusted_bounce_rate_timeouts #49 (thx @fabn)
+  * [BUGFIX] Do not pass string in mastertag when should be json #47 (thx @berlintam)
+
 # 1.0.0
 
   * [BUGFIX] breaking API change: set zanox path extension #45 (thx @berlintam)

data/README.md

@@ -389,7 +389,7 @@ This is an example of a mastertag:
 ```
 def show
   tracker do |t|
-    t.zanox :mastertag, { id: "25GHTE9A07DF67DFG90T" }
+    t.zanox :mastertag, { id: "25GHTE9A07DF67DFG90T", category: 'Swimming', amount: '3.50' }
   end
 end
 ```
@@ -400,6 +400,11 @@ This will render to the follwing code in the JS:
 window._zx.push({"id": "25GHTE9A07DF67DFG90T"});
 ```
 
+and the following variables:
+```
+zx_category = 'Swimming';
+zx_amount = '3.50';
+
 #### Conversion tracking
 
 This is an example of a lead event:

data/lib/rack/tracker/google_analytics/template/google_analytics.erb

@@ -25,7 +25,7 @@
 <% end %>
 <% if options[:adjusted_bounce_rate_timeouts] %>
   <% options[:adjusted_bounce_rate_timeouts].each do |timeout| %>
-      setTimeout(ga('send', 'event', '<%= "#{timeout.to_s}_seconds" %>', 'read'),<%= timeout*1000 %>);
+      setTimeout(function() { ga('send', 'event', '<%= "#{timeout.to_s}_seconds" %>', 'read'); },<%= timeout*1000 %>);
   <% end %>
 <% end %>
 <% end %>

data/lib/rack/tracker/version.rb

@@ -1,5 +1,5 @@
 module Rack
   class Tracker
-    VERSION = '1.0.0'
+    VERSION = '1.0.1'
   end
 end

data/lib/rack/tracker/zanox/template/zanox.erb

@@ -1,20 +1,18 @@
 <% if mastertag %>
-
-<div class="zx_<%= mastertag.id %> zx_mediaslot">
-  <script type="text/javascript">
-    window._zx = window._zx || [];
-    window._zx.push({"id": "<%= mastertag.id %>"});
-    (function(d) {
-      var s = d.createElement("script"); s.async = true;
-      s.src = (d.location.protocol == "https:" ? "https:" : "http:") + "//static.zanox.com/scripts/zanox.js";
-      var a = d.getElementsByTagName("script")[0]; a.parentNode.insertBefore(s, a);
-    }(document));
-  </script>
-</div>
-
+  <div class="zx_<%= mastertag.id %> zx_mediaslot">
+    <script type="text/javascript">
+      window._zx = window._zx || [];
+      window._zx.push({"id": "<%= mastertag.id %>"});
+      (function(d) {
+        var s = d.createElement("script"); s.async = true;
+        s.src = (d.location.protocol == "https:" ? "https:" : "http:") + "//static.zanox.com/scripts/zanox.js";
+        var a = d.getElementsByTagName("script")[0]; a.parentNode.insertBefore(s, a);
+      }(document));
+        <%= mastertag.write %>
+    </script>
+  </div>
 <% end %>
 
-
 <% sale_events.each do |event| %>
 
   <script type="text/javascript" src="https://ad.zanox.com/pps/?<%= options[:account_id] %>&mode=[[1]]&<%= event.write %>">

data/lib/rack/tracker/zanox/zanox.rb

@@ -3,6 +3,12 @@ class Rack::Tracker::Zanox < Rack::Tracker::Handler
   # name of the handler
   # everything after is passed as options
   class Mastertag < OpenStruct
+
+    def write
+      to_h.except(:id).map do |k,v|
+        "var zx_#{k} = #{v.to_json};"
+      end.join("\n")
+    end
   end
 
   class Lead < OpenStruct

data/spec/handler/google_analytics_spec.rb

@@ -259,8 +259,8 @@ RSpec.describe Rack::Tracker::GoogleAnalytics do
     subject { described_class.new(env, tracker: 'afake', adjusted_bounce_rate_timeouts: [15, 30]).render }
 
     it "will add timeouts to push read events" do
-      expect(subject).to match(%r{ga\('send', 'event', '15_seconds', 'read'\)})
-      expect(subject).to match(%r{ga\('send', 'event', '30_seconds', 'read'\)})
+      expect(subject).to include %q{setTimeout(function() { ga('send', 'event', '15_seconds', 'read'); },15000)}
+      expect(subject).to include %q{setTimeout(function() { ga('send', 'event', '30_seconds', 'read'); },30000)}
     end
   end
 end

data/spec/handler/zanox_spec.rb

@@ -9,6 +9,15 @@ RSpec.describe Rack::Tracker::Zanox do
     end
   end
 
+  describe Rack::Tracker::Zanox::Mastertag do
+
+    subject { described_class.new(id: "25GHTE9A07DF67DFG90T", category: 'Swimming', amount: '3.50', products: [{amount: '5', currency: 'EUR'}, {amount: '6', currency: 'USD'}]) }
+
+    describe '#write' do
+      specify { expect(subject.write).to eq "var zx_category = \"Swimming\";\nvar zx_amount = \"3.50\";\nvar zx_products = [{\"amount\":\"5\",\"currency\":\"EUR\"},{\"amount\":\"6\",\"currency\":\"USD\"}];"}
+    end
+  end
+
   def env
     {}
   end
@@ -80,7 +89,10 @@ RSpec.describe Rack::Tracker::Zanox do
             [
               {
                 'id' => '12345678D2345',
-                'class_name' => 'Mastertag'
+                'class_name' => 'Mastertag',
+                'category' => 'Sewing',
+                'identifier' => '234',
+                'amount' => '5.90'
               }
             ]
           }
@@ -88,10 +100,12 @@ RSpec.describe Rack::Tracker::Zanox do
       }
 
       subject { described_class.new(env, options).render }
+
       let(:options) { { account_id: '123456H123456' } }
 
       it 'will display the correct tracking events' do
         expect(subject).to include 'window._zx.push({"id": "12345678D2345"});'
+        expect(subject).to include "var zx_category = \"Sewing\";\nvar zx_identifier = \"234\";\nvar zx_amount = \"5.90\";\n"
       end
     end
   end

data/spec/integration/zanox_integration_spec.rb

@@ -14,6 +14,7 @@ RSpec.describe "Zanox Integration" do
 
   it 'should include the mastertag event' do
     expect(page.find("body")).to have_content "window._zx.push({\"id\": \"blurg567\"});"
+    expect(page).to have_content "var zx_category = \"cake decorating\";\nvar zx_amount = \"5.90\";\n"
   end
 
   it 'should include the sale event' do

data/spec/support/metal_controller.rb

@@ -77,7 +77,7 @@ class MetalController < ActionController::Metal
 
   def zanox
     tracker do |t|
-      t.zanox :mastertag, { id: 'blurg567'}
+      t.zanox :mastertag, { id: 'blurg567', category: 'cake decorating', amount: '5.90'}
       t.zanox :sale, { customer_i_d: '123456', order_i_d: 'DEFC-4321', currency_symbol: 'EUR', total_price: '150.00' }
       t.zanox :lead, { customer_i_d: '654321' }
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rack-tracker
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Lars Brillert
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-20 00:00:00.000000000 Z
+date: 2015-08-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack