rack-tracer 0.4.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 86a3c63d2d6db8aec7973f1cb60369d557b6b9ab
-  data.tar.gz: 37bf5f4419bf129fe3209dd201569ff287d6fff5
+  metadata.gz: fcdf093205910aa4ebbf86106ae6929cb357dea6
+  data.tar.gz: 05b02d43b23d13608c6290dca697314c13a389fa
 SHA512:
-  metadata.gz: c08bb82015ccd64d96048f380736ee1d4b09014c17c83e03b72ff93be014efa5847dd2987dce4c339a0241db77f69dbe0f75dbe462a4db46facacb9b2cc7f423
-  data.tar.gz: 53de4aa41e736128324fe05050f71d0473e546313c4fdfabfc168cd82891db182faacb2aa0d581056bb7c5595b4b0b13c3e528813064f30dfa73ed13cd06f48a
+  metadata.gz: 4b6ca1127b3e86a814e99dd243c059ba282696dfa878e873c9930a43b036ec0f7ff23df63981248ce3cfacaa622d8ce2895aaaad38c75d3412ed3d9461fe0292
+  data.tar.gz: e04d7645b819e853ca9cde4b25dd2121aca8717ef20bc85a9457fb8a05f3724b16cd1987c558633bcea6275b54b3e356a2ec64f62e0aa714d867267b375f0704

data/README.md

@@ -23,9 +23,11 @@ You can access the created span using
 env['rack.span']
 ```
 
-You can also add a start span callback
+You can also add start and finish span callbacks
 ```ruby
-use Rack::Tracer, on_start_span: Proc.new {|span| do_something(span) }
+use Rack::Tracer,
+    on_start_span: ->(span) { Thread.current[:root_span] = span },
+    on_finish_span: ->(_span) { Thread.current[:root_span] = nil }
 ```
 
 ## Development
@@ -42,4 +44,3 @@ Bug reports and pull requests are welcome on GitHub at https://github.com/opentr
 ## License
 
 The gem is available as open source under the terms of the [MIT License](http://opensource.org/licenses/MIT).
-

data/lib/rack/tracer.rb

@@ -11,12 +11,14 @@ module Rack
     # @param tracer [OpenTracing::Tracer] A tracer to be used when start_span, and extract
     #        is called.
     # @param on_start_span [Proc, nil] A callback evaluated after a new span is created.
+    # @param on_finish_span [Proc, nil] A callback evaluated after a span is finished.
     # @param errors [Array<Class>] An array of error classes to be captured by the tracer
     #        as errors. Errors are **not** muted by the middleware, they're re-raised afterwards.
-    def initialize(app, tracer: OpenTracing.global_tracer, on_start_span: nil, trust_incoming_span: true, errors: [StandardError])
+    def initialize(app, tracer: OpenTracing.global_tracer, on_start_span: nil, on_finish_span: nil, trust_incoming_span: true, errors: [StandardError])
       @app = app
       @tracer = tracer
       @on_start_span = on_start_span
+      @on_finish_span = on_finish_span
       @trust_incoming_span = trust_incoming_span
       @errors = errors
     end
@@ -36,9 +38,7 @@ module Rack
         }
       )
 
-      if @on_start_span
-        @on_start_span.call(span)
-      end
+      @on_start_span.call(span) if @on_start_span
 
       env['rack.span'] = span
 
@@ -54,7 +54,11 @@ module Rack
       span.log(event: 'error', :'error.object' => e)
       raise
     ensure
-      span.finish
+      begin
+        span.finish
+      ensure
+        @on_finish_span.call(span) if @on_finish_span
+      end
     end
 
     private

data/rack-tracer.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'rack-tracer'
-  spec.version       = '0.4.0'
+  spec.version       = '0.5.0'
   spec.authors       = ['SaleMove TechMovers']
   spec.email         = ['techmovers@salemove.com']
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rack-tracer
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
 - SaleMove TechMovers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-05 00:00:00.000000000 Z
+date: 2018-04-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: opentracing