rack-test 0.8.2 → 0.8.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: e1ef918ca1ef466e983de48748ac507cde298bce
-  data.tar.gz: 5b51e1abc057e78f5e6a2c651c5b2f20ec1b6049
+SHA256:
+  metadata.gz: 98d93b9da867444521efc5c2d82d14b37c2b5743324865f96d2f6c0603ad8256
+  data.tar.gz: 3f78a90b58f6de6582088185f995195841995e9b2a0a9518a93ecee081eb8416
 SHA512:
-  metadata.gz: 70ee9fa76cb6d0174fb88169adc3a854aea6d86da94ee058cb64500ee881b9fcfd8e863f55557d286e6c4458ebc0e67189cbeb78cdab877e3d7b4c06d2e8251d
-  data.tar.gz: 116d2337e1daa6852b23172766817b5c17864ec95db124fb50b441a5ab65fd32d755b2605cfcbb4832fd8891d28c98e888389cd9b689b4308d08d2909ddb4b55
+  metadata.gz: 3bd23e7ffcfa4ab19ad2966f36bcab31f49f3ea7f819fb81f15ce874437d8c6b96c6844f40499512042166b007d940b819b44e8d978ba4001f77fe515225f529
+  data.tar.gz: 9d0479de503ae1a74f2aa9263b39dfdabf1745c17bed3fc18e6aaf757bf0b7428510f26a08c0021090ec98f8125eca74fb19e9f7f19eef41a94dd9847a441472

data/History.md

@@ -1,3 +1,14 @@
+## 0.8.3 / 2018-02-27
+
+* Bug fixes:
+  * Do not set Content-Type if params are explicitly set to nil
+    (Bartek Bułat #212). Fixes #200.
+  * Fix `UploadedFile#new` regression
+    (Per Lundberg #215)
+
+* Minor enhancements
+  * [CI] Test against Ruby 2.5 (Nicolas Leger #217)
+
 ## 0.8.2 / 2017-11-21
 
 * Bug fixes:

data/README.md

@@ -65,7 +65,7 @@ class HomepageTest < Test::Unit::TestCase
     assert last_response.ok?
     assert_equal last_response.body, 'All responses are OK'
   end
-  
+
   def post_with_json
     # No assertion in this, we just demonstrate how you can post a JSON-encoded string.
     # By default, Rack::Test will use HTTP form encoding if you pass in a Hash as the
@@ -134,6 +134,7 @@ Contributions are welcome. Please make sure to:
 
 ## Releasing
 
-* Ensure History.txt is up-to-date
+* Ensure `History.md` is up-to-date
 * Bump VERSION in lib/rack/test/version.rb
 * bundle exec thor :release
+* Updated the [GitHub releases page](https://github.com/rack-test/rack-test/releases)

data/lib/rack/test.rb

@@ -217,31 +217,31 @@ module Rack
         # Stringifying and upcasing methods has be commit upstream
         env['REQUEST_METHOD'] ||= env[:method] ? env[:method].to_s.upcase : 'GET'
 
-        if %w[GET DELETE].include?(env['REQUEST_METHOD'])
+        params = env.delete(:params) do {} end
+
+        if env['REQUEST_METHOD'] == 'GET'
           # merge :params with the query string
-          if params = env[:params]
+          if params
             params = parse_nested_query(params) if params.is_a?(String)
 
             uri.query = [uri.query, build_nested_query(params)].compact.reject { |v| v == '' }.join('&')
           end
         elsif !env.key?(:input)
-          env['CONTENT_TYPE'] ||= 'application/x-www-form-urlencoded'
+          env['CONTENT_TYPE'] ||= 'application/x-www-form-urlencoded' unless params.nil?
 
-          if env[:params].is_a?(Hash)
-            if data = build_multipart(env[:params])
+          if params.is_a?(Hash)
+            if data = build_multipart(params)
               env[:input] = data
               env['CONTENT_LENGTH'] ||= data.length.to_s
               env['CONTENT_TYPE'] = "multipart/form-data; boundary=#{MULTIPART_BOUNDARY}"
             else
-              env[:input] = params_to_string(env[:params])
+              env[:input] = params_to_string(params)
             end
           else
-            env[:input] = env[:params]
+            env[:input] = params
           end
         end
 
-        env.delete(:params)
-
         set_cookie(env.delete(:cookie), uri) if env.key?(:cookie)
 
         Rack::MockRequest.env_for(uri.to_s, env)

data/lib/rack/test/uploaded_file.rb

@@ -25,11 +25,11 @@ module Rack
       #   file.
       # @param content_type [String]
       # @param binary [Boolean] an optional flag that indicates whether the file should be open in binary mode or not.
-      # @param original_filename [String] an optional parameter that provides the original filename if `content` is an IO
-      #   object.
+      # @param original_filename [String] an optional parameter that provides the original filename if `content` is a StringIO
+      #   object. Not used for other kind of `content` objects.
       def initialize(content, content_type = 'text/plain', binary = false, original_filename: nil)
-        if content.respond_to?(:read) && (content.is_a?(IO) || content.is_a?(StringIO))
-          initialize_from_io(content, original_filename)
+        if original_filename
+          initialize_from_stringio(content, original_filename)
         else
           initialize_from_file_path(content)
         end
@@ -62,9 +62,9 @@ module Rack
 
       private
 
-      def initialize_from_io(io, original_filename)
-        @tempfile = io
-        @original_filename = original_filename || raise(ArgumentError, 'Missing `original_filename` for IO')
+      def initialize_from_stringio(stringio, original_filename)
+        @tempfile = stringio
+        @original_filename = original_filename || raise(ArgumentError, 'Missing `original_filename` for StringIO object')
       end
 
       def initialize_from_file_path(path)

data/lib/rack/test/version.rb

@@ -1,5 +1,5 @@
 module Rack
   module Test
-    VERSION = '0.8.2'.freeze
+    VERSION = '0.8.3'.freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rack-test
 version: !ruby/object:Gem::Version
-  version: 0.8.2
+  version: 0.8.3
 platform: ruby
 authors:
 - Bryan Helmkamp
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-11-21 00:00:00.000000000 Z
+date: 2018-02-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -181,7 +181,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Simple testing API built on Rack