rack-referral-tracking 0.0.4 → 0.0.5

data/README.md

@@ -1,5 +1,7 @@
 # Rack::Referral::Tracking
 
+[![Code Climate](https://codeclimate.com/github/craigkerstiens/rack-referral-tracking.png)](https://codeclimate.com/github/craigkerstiens/rack-referral-tracking)
+
 Rack middleware that detects requests from a referral and places some details
 about the referral in a user's cookies.
 

data/Rakefile

@@ -1 +1,11 @@
 require "bundler/gem_tasks"
+
+require "rake/testtask"
+
+Rake::TestTask.new do |t|
+  t.libs << 'lib/rack-referral-tracking'
+  t.test_files = FileList['spec/lib/**/*_spec.rb']
+  t.verbose = true
+end
+
+task :default => :test

data/lib/rack-referral-tracking/middleware.rb

@@ -1,3 +1,4 @@
+require 'cgi'
 require 'domainatrix'
 require 'fernet'
 require 'uri'
@@ -27,10 +28,10 @@ module Rack
           end
         end
 
-        Rack::Utils.set_cookie_header!(headers, "utm_campaign", :value => params['utm_campaign'], :domain => cookie_domain, :path => '/') if params.has_key? 'utm_campaign'
-        Rack::Utils.set_cookie_header!(headers, "utm_source", :value => params['utm_source'], :domain => cookie_domain, :path => '/') if params.has_key? 'utm_source'
-        Rack::Utils.set_cookie_header!(headers, "utm_medium", :value => params['utm_medium'], :domain => cookie_domain, :path => '/') if params.has_key? 'utm_medium'
-        Rack::Utils.set_cookie_header!(headers, "ref", :value => referer, :domain => cookie_domain, :path => '/') if referer
+        Rack::Utils.set_cookie_header!(headers, "utm_campaign", :value => params['utm_campaign'], :domain => cookie_domain, :path => '/', :httponly => true, :secure => true) if params.has_key? 'utm_campaign'
+        Rack::Utils.set_cookie_header!(headers, "utm_source", :value => params['utm_source'], :domain => cookie_domain, :path => '/', :httponly => true, :secure => true) if params.has_key? 'utm_source'
+        Rack::Utils.set_cookie_header!(headers, "utm_medium", :value => params['utm_medium'], :domain => cookie_domain, :path => '/', :httponly => true, :secure => true) if params.has_key? 'utm_medium'
+        Rack::Utils.set_cookie_header!(headers, "ref", :value => referer, :domain => cookie_domain, :path => '/', :httponly => true, :secure => true) if referer
 
         [status, headers, body]
       end

data/lib/rack-referral-tracking/version.rb

@@ -1,5 +1,5 @@
 module Rack
   module ReferralTracking
-    VERSION = '0.0.4'
+    VERSION = '0.0.5'
   end
 end

data/rack-referral-tracking.gemspec

@@ -19,5 +19,7 @@ Gem::Specification.new do |gem|
 
   gem.add_dependency 'domainatrix'
   gem.add_dependency 'fernet'
+  gem.add_dependency 'rack'
+  gem.add_development_dependency 'rack-test'
   gem.add_development_dependency 'rake'
 end

data/spec/lib/rack-referral-tracking/middleware_spec.rb

@@ -0,0 +1,52 @@
+require_relative '../../spec_helper'
+
+describe Rack::ReferralTracking::Middleware do
+  include Rack::Test::Methods
+
+  describe 'basic Rack compliance' do
+    let(:app) do
+      inner_app = lambda { |env|
+        [200, {'Content-Type' => 'text/plain'}, ["OK"]]
+      }
+      Rack::Lint.new(Rack::ReferralTracking::Middleware.new(inner_app))
+    end
+
+    it 'passes all Lint checks' do
+      env = Rack::MockRequest.env_for('/')
+      app.call(env)
+    end
+  end
+
+  describe 'with referral metadata' do
+    let(:app) do
+      inner_app = lambda { |env|
+        [200, {'Content-Type' => 'text/plain'}, ["OK"]]
+      }
+      Rack::ReferralTracking::Middleware.new(inner_app)
+    end
+
+    before { clear_cookies }
+
+    it 'stores utm_campaign in a cookie' do
+      get 'http://blog.example.com/?utm_campaign=launch'
+      get 'http://id.example.com/signup'
+
+      last_request.cookies.must_equal 'utm_campaign' => 'launch'
+    end
+
+    it 'stores utm_source in a cookie' do
+      get 'http://blog.example.com/?utm_source=twitter'
+      get 'http://id.example.com/signup'
+
+      last_request.cookies.must_equal 'utm_source' => 'twitter'
+    end
+
+    it 'stores utm_medium in a cookie' do
+      get 'http://blog.example.com/?utm_medium=email'
+      get 'http://id.example.com/signup'
+
+      last_request.cookies.must_equal 'utm_medium' => 'email'
+    end
+  end
+
+end

data/spec/spec_helper.rb

@@ -0,0 +1,9 @@
+ENV['REFERRAL_SECRET'] = '50mJn9wvwAXtQ28obpwxD7uMcqJRUquFz+GMRGDB4ZU='
+
+require 'minitest/autorun'
+require 'minitest/spec'
+
+require 'rack/mock'
+require 'rack/test'
+
+require 'rack-referral-tracking'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rack-referral-tracking
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
   prerelease: 
 platform: ruby
 authors:
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-24 00:00:00.000000000 Z
+date: 2014-01-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: domainatrix
@@ -44,6 +44,38 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rack
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rack-test
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -76,6 +108,8 @@ files:
 - lib/rack-referral-tracking/middleware.rb
 - lib/rack-referral-tracking/version.rb
 - rack-referral-tracking.gemspec
+- spec/lib/rack-referral-tracking/middleware_spec.rb
+- spec/spec_helper.rb
 homepage: https://github.com/craigkerstiens/rack-referral-tracking
 licenses: []
 post_install_message: 
@@ -100,4 +134,6 @@ rubygems_version: 1.8.25
 signing_key: 
 specification_version: 3
 summary: Remember a visitor's referrer across subdomains
-test_files: []
+test_files:
+- spec/lib/rack-referral-tracking/middleware_spec.rb
+- spec/spec_helper.rb