rack-raw-upload 1.0.3 → 1.0.4

data/README.md

@@ -19,18 +19,31 @@ Rack::RawUpload expects that requests will:
 
 ## Configuration
 
-The simpler case:
+### Bog-standard Rack app
 
+The simpler case. Add these lines in your `config.ru`, where appropriate:
+
+    require 'rack/raw_upload'
     use Rack::RawUpload
 
 If you want to limit the conversion to a few known paths, do:
 
+    require 'rack/raw_upload'
     use Rack::RawUpload, :paths => ['/upload/path', '/alternative/path.*']
 
 You can also make it so that the conversion only happens when explicitly required by the client using a header. This would be `X-File-Upload: true` to make the conversion regardless of the content type. A value of `X-File-Upload: smart` would ask for the normal detection to be performed. For this, use the following setting:
 
     use Rack::RawUpload, :explicit => true
 
+### Ruby on Rails
+
+Add this to your Gemfile
+
+    gem 'rack-raw-upload'
+
+and then add the middleware in application.rb
+
+    config.middleware.use 'Rack::RawUpload'
 
 ## More options
 
@@ -50,4 +63,6 @@ When present, Rack::RawUpload will assume that the header ***`X-Query-Params`***
 
 A blog post on HTML5 uploads, which are raw uploads, and can be greatly simplified with this middleware:
 
-* [http://blog.new-bamboo.co.uk/2010/7/30/html5-powered-ajax-file-uploads](http://blog.new-bamboo.co.uk/2010/7/30/html5-powered-ajax-file-uploads)
+* [http://blog.new-bamboo.co.uk/2010/7/30/html5-powered-ajax-file-uploads](http://blog.new-bamboo.co.uk/2010/7/30/html5-powered-ajax-file-uploads)
+
+This middleware should work with Ruby 1.8.7, 1.9.2, REE, Rubinius and JRuby. Tests for all these platforms are run on the wonderful [Travis-CI](http://travis-ci.org/) regularly, and the current status of these is: [![Build Status](http://travis-ci.org/newbamboo/rack-raw-upload.png)](http://travis-ci.org/newbamboo/rack-raw-upload)

data/lib/rack-raw-upload.rb

@@ -0,0 +1 @@
+require 'rack/raw_upload'

data/lib/rack/raw_upload.rb

@@ -1,7 +1,9 @@
+require 'tmpdir' # Needed in 1.8.7 to access Dir::tmpdir
+
 module Rack
   class RawUpload
 
-    VERSION = '1.0.3'
+    VERSION = '1.0.4'
 
     def initialize(app, opts = {})
       @app = app
@@ -80,7 +82,12 @@ module Rack
     end
     
     def content_type_of_raw_file?(content_type)
-      ! %w{application/x-www-form-urlencoded multipart/form-data}.include?(content_type)
+      case content_type
+      when %r{^application/x-www-form-urlencoded}, %r{^multipart/form-data}
+        false
+      else
+        true
+      end
     end
   end
 end

data/test/raw_upload_test.rb

@@ -1,7 +1,7 @@
 require 'rubygems'
 require 'rack/test'
 require 'shoulda'
-require 'rack/raw_upload'
+require 'rack-raw-upload'
 require 'json'
 
 class RawUploadTest < Test::Unit::TestCase
@@ -52,6 +52,13 @@ class RawUploadTest < Test::Unit::TestCase
       upload('CONTENT_TYPE' => 'multipart/form-data')
       assert_successful_non_upload
     end
+
+    # "stuff" should be something like "boundary=----WebKitFormBoundaryeKPeU4p65YgercgO",
+    # but if I do that here, Rack tries to be clever and the test breaks
+    should "not work with Content-Type 'multipart/form-data; stuff'" do
+      upload('CONTENT_TYPE' => 'multipart/form-data; stuff')
+      assert_successful_non_upload
+    end
     
     should "be forced to perform a file upload if `X-File-Upload: true`" do
       upload('CONTENT_TYPE' => 'multipart/form-data', 'HTTP_X_FILE_UPLOAD' => 'true')

metadata

@@ -1,12 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: rack-raw-upload
 version: !ruby/object:Gem::Version 
+  hash: 31
   prerelease: false
   segments: 
   - 1
   - 0
-  - 3
-  version: 1.0.3
+  - 4
+  version: 1.0.4
 platform: ruby
 authors: 
 - Pablo Brasero
@@ -14,16 +15,18 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-05-31 00:00:00 +01:00
+date: 2011-06-07 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: json
   prerelease: false
   requirement: &id001 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 3
         segments: 
         - 0
         version: "0"
@@ -33,9 +36,11 @@ dependencies:
   name: rake
   prerelease: false
   requirement: &id002 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 3
         segments: 
         - 0
         version: "0"
@@ -45,9 +50,11 @@ dependencies:
   name: rack-test
   prerelease: false
   requirement: &id003 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 3
         segments: 
         - 0
         version: "0"
@@ -57,9 +64,11 @@ dependencies:
   name: shoulda
   prerelease: false
   requirement: &id004 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 3
         segments: 
         - 0
         version: "0"
@@ -76,6 +85,7 @@ extra_rdoc_files:
 - README.md
 files: 
 - lib/rack/raw_upload.rb
+- lib/rack-raw-upload.rb
 - test/raw_upload_test.rb
 - LICENSE
 - README.md
@@ -93,23 +103,27 @@ rdoc_options:
 require_paths: 
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement 
+  none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      hash: 3
       segments: 
       - 0
       version: "0"
 required_rubygems_version: !ruby/object:Gem::Requirement 
+  none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      hash: 3
       segments: 
       - 0
       version: "0"
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.6
+rubygems_version: 1.3.7
 signing_key: 
 specification_version: 3
 summary: Rack Raw Upload middleware