rack-perftools_profiler 0.1.0 → 0.1.1

data/README.rdoc

@@ -32,15 +32,13 @@ For Rails 2, add the following to config/environment.rb
  require 'rack/perftools_profiler'
  config.middleware.use Rack::PerftoolsProfiler, :default_printer => 'gif'
 
-For Rails 3 (or any app using Bundler), add the following to your Gemfile
+For Rails 3, add the following to your Gemfile
 
- gem 'rack-perftools_profiler', '~> 0.1', :require => 'rack/perftools_profiler' 
+  gem 'rack-perftools_profiler', '~> 0.1', :require => 'rack/perftools_profiler'
 
-and make sure you pass the option
+and add the following to config/application.rb
 
-  :bundler => true
-
-when configuring the middleware.
+  config.middleware.use Rack::PerftoolsProfiler, :default_printer => 'gif', :bundler => true
 
 For Sinatra, call 'use' inside a configure block, like so:
 

data/VERSION

@@ -1 +1 @@
-0.1.0
+0.1.1

data/lib/rack/perftools_profiler/profiler.rb

@@ -77,10 +77,12 @@ module Rack::PerftoolsProfiler
         cmd = "pprof.rb #{args} #{PROFILING_DATA_FILE}"
         cmd = "bundle exec " + cmd if @bundler
         stdout, stderr, status = Dir.chdir(@gemfile_dir) { run(cmd) }
-        if(status == 0)
-          [printer, stdout]
-        else
+        if status!=0
           raise ProfilingError.new("Running the command '#{cmd}' exited with status #{status}", stderr)
+        elsif stdout.length == 0 && stderr.length > 0
+          raise ProfilingError.new("Running the command '#{cmd}' failed to generate a file", stderr)
+        else
+          [printer, stdout]
         end
       else
         [:none, nil]
@@ -90,7 +92,8 @@ module Rack::PerftoolsProfiler
     private
 
     def run(command)
-      out = err = pid = nil
+      out = err = ""
+      pid = nil
       status = Open4.popen4(command) do |pid, stdin, stdout, stderr|
         stdin.close
         pid = pid

data/test/rack-perftools-profiler_test.rb

@@ -405,7 +405,7 @@ class RackPerftoolsProfilerTest < Test::Unit::TestCase
 
     context "when in bundler mode" do
       
-      should "call pprof.rb using 'bundle' command if bunder is set" do
+      should "call pprof.rb using 'bundle' command if bundler is set" do
         status = stub_everything(:exitstatus => 0)
         profiled_app = Rack::PerftoolsProfiler.new(@app, :bundler => true)
         Open4.expects(:popen4).with(regexp_matches(/^bundle exec pprof\.rb/)).returns(status)

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 1
-  - 0
-  version: 0.1.0
+  - 1
+  version: 0.1.1
 platform: ruby
 authors: 
 - Ben Brinckerhoff
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-08-21 00:00:00 -06:00
+date: 2010-10-11 00:00:00 -06:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency