rack-parser 0.5.0 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2bfc0d8a49d8bbfbea8feb0f9760dd7ddc4ab9a4
-  data.tar.gz: b2012859f92dc0317ca7d3db060ed82aececaf31
+  metadata.gz: 3a7ddcfcf164a59f2e0a35d8dbc197e742c715db
+  data.tar.gz: cb8b0b947daa30f8ef17276d1d2f81a16897b907
 SHA512:
-  metadata.gz: dcbf8aad748d39e46dd18557c44184bd5500ca38d55420f5e30f16b6b8aabfbc4577ccae569658c4c269b74ed80d91d47dfc9c3b22c8926fde5c6ea88988a152
-  data.tar.gz: e73679c51a235e0983fdca3bbb9b2fded19ebb8d0ec62da4ae486d35340c702df403314f6bf7adaa219f36cbad1746397eba9158e8c19f299d1e3ca664552094
+  metadata.gz: b19155797c75b417c940feb83f10ff6384833215db9b010415e674aad87894f992d49aeb5440b45d4b03fc644493ee2a280f5825f7e2783f862228b94b2fff23
+  data.tar.gz: 8ad8459f09be43fc97dbd1b5baf382da16a2e1e94745bf011b5d258b1cf36dad111a5235ba81b2d20926826214e05b9e86489314bb907ccd0904c6aaa7fb9ba1

data/README.md

@@ -67,6 +67,9 @@ override the default response as well.
 
 If no content_type error handling response is present, it will return `400`
 
+Do note, the error handler rescues exceptions that are descents of `StandardError`. See
+http://www.mikeperham.com/2012/03/03/the-perils-of-rescue-exception/
+
 ### Regex Matching ###
 
 With version `0.4.0`, you can specify regex matches for the content
@@ -99,7 +102,7 @@ This project came to being because of:
 * [Moonsik Kang](https://github.com/deepblue) - skip rack parser for content types that are not explicitly set.
 * [Guillermo Iguaran](https://github.com/guilleiguaran) - Updating `multi_xml` version dependency for XML/YAML exploit
 * [Doug Orleans](https://github.com/dougo) - Handle only post-body parsing errors and let upstream errors propogate downstream
-* [Akshay Moghe](https://github.com/amoghe) - Make default error handler rack compliant by responding to #each
+* [Akshay Moghe](https://github.com/amoghe) - Make default error handler rack compliant by responding to #each and use StandardError
 
 ## Copyright
 

data/lib/rack/parser.rb

@@ -30,7 +30,7 @@ module Rack
       begin
         parsed = parser.last.call body
         env.update FORM_HASH => parsed, FORM_INPUT => env[POST_BODY]
-      rescue Exception => e
+      rescue StandardError => e
         warn! e, type
         handler   = handlers.detect { |content_type, _|  type.match(content_type) }
         handler ||= ['default', ERROR_HANDLER]

data/rack-parser.gemspec

@@ -3,7 +3,7 @@ $:.push File.expand_path("../lib", __FILE__)
 
 Gem::Specification.new do |s|
   s.name        = "rack-parser"
-  s.version     = "0.5.0"
+  s.version     = "0.6.0"
   s.authors     = ["Arthur Chiu"]
   s.email       = ["mr.arthur.chiu@gmail.com"]
   s.homepage    = "https://www.github.com/achiu/rack-parser"

data/spec/parser_spec.rb

@@ -43,7 +43,7 @@ describe Rack::Parser do
   end
 
   it "handles upstream errors" do
-    assert_raises Exception, 'error!' do
+    assert_raises StandardError, 'error!' do
       parser = proc { |data| JSON.parse data }
       stack Rack::Parser, :parsers => { %r{json} => parser }
       post '/error', '{}', { 'CONTENT_TYPE' => 'application/json' }
@@ -51,7 +51,7 @@ describe Rack::Parser do
   end
 
   it "returns a default error" do
-    parser  = proc { |data| raise Exception, 'wah wah' }
+    parser  = proc { |data| raise StandardError, 'wah wah' }
     stack Rack::Parser, :parsers  => { %r{json} => parser } 
     post '/post', '{}', { 'CONTENT_TYPE' => 'application/vnd.foo+json' }
 
@@ -59,7 +59,7 @@ describe Rack::Parser do
   end
 
   it "returns a custom error message" do
-    parser  = proc { |data| raise Exception, "wah wah" }
+    parser  = proc { |data| raise StandardError, "wah wah" }
     handler = proc { |err, type| [500, {}, "%s : %s"  % [type, err]] }
     stack Rack::Parser, :parsers  => { %r{json} => parser }, 
                         :handlers => { %r{json} => handler }

data/spec/spec_helper.rb

@@ -14,7 +14,7 @@ class ParserApp
       case request.path
       when '/'      then [200, 'Hello World']
       when '/post'  then [200, request.params.inspect]
-      when '/error' then raise(Exception, 'error!')
+      when '/error' then raise(StandardError, 'error!')
       else
         [404, 'Nothing']
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rack-parser
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
 platform: ruby
 authors:
 - Arthur Chiu